| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2017-01-12 | |||
| 08:49:56 | reedip | We have 4 cases basically | |
| 08:49:59 | reedip | Create | |
| 08:50:00 | reedip | Append | |
| 08:50:01 | reedip | Remove | |
| 08:50:03 | reedip | Overwrite | |
| 08:50:05 | ralonsoh | yes | |
| 08:50:07 | ralonsoh | I agree | |
| 08:50:18 | reedip | Create would be by --qos-policy | |
| 08:50:22 | ralonsoh | now append has a different action to overwrite | |
| 08:50:33 | reedip | ralonsoh : yup, it has a different action | |
| 08:50:34 | ralonsoh | action=effect | |
| 08:50:38 | ralonsoh | ok | |
| 08:50:48 | ralonsoh | i'll update my comment in the PS | |
| 08:50:53 | ralonsoh | thank you!! | |
| 08:51:03 | reedip | ralonsoh : ok , great :) | |
| 09:12:31 | reedip | ralonsoh : Hi . This Test Case failed in one of my patches | |
| 09:12:33 | reedip | https://review.openstack.org/#/c/352477/34/openstackclient/tests/unit/network/v2/test_network_qos_rule.py#656 | |
| 09:13:06 | reedip | ralonsoh : http://logs.openstack.org/67/419067/2/check/gate-python-openstackclient-python27-ubuntu-xenial/7a2f84a/console.html#_2017-01-12_05_58_52_977913 | |
| 09:13:49 | ralonsoh | reedip: i'm in a meeting. I'll take a look at this ASAP | |
| 09:14:00 | reedip | ralonsoh : Oh sorry , sure :) | |
| 11:42:23 | ralonsoh | reedip: uffff, I took me a bit of time. You found an error | |
| 11:42:36 | ralonsoh | reedip: in parse_args i make this check "if parsed_args.dscp_mark:" | |
| 11:42:48 | ralonsoh | reedip: and dscp_mark = 0 in this case | |
| 11:43:03 | ralonsoh | reedip: I'll fill this bug and I'll send the patch. Thanks!!! | |
| 11:49:03 | openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Network qos rule unit test broken https://review.openstack.org/419434 | |
| 11:50:31 | huanxuan | ralonsoh: er... I also found it just now... | |
| 11:55:41 | huanxuan | ralonsoh: To be fair... I will abandon my patch if you are working on it, sorry for the conflict... | |
| 12:06:58 | ralonsoh_ | huanxuan: no, please, continue with it | |
| 12:07:06 | ralonsoh_ | I'll review it | |
| 12:07:17 | ralonsoh_ | Add me as reviewer | |
| 12:08:06 | ralonsoh_ | Ok, I saw you abandon the patch | |
| 12:11:48 | huanxuan | ralonsoh_: Yes... really sorry about the conflict, I was just found the error but did not sure about it, you can commit your patch and fix it now, thank you! | |
| 12:23:21 | stevemar | huanxuan: ralonsoh_ sounds like you two found the gate bug :) | |
| 12:24:23 | ralonsoh_ | stevemar: I'm on it and adding new tests to check that | |
| 12:25:50 | huanxuan | stevemar: I cause a conflict... :( thank you alot ralonsoh_ | |
| 12:26:54 | huanxuan | stevemar: I think we may still have a gate bug | |
| 12:27:08 | huanxuan | http://logs.openstack.org/85/418685/3/check/gate-python-openstackclient-python35/fe25c5f/console.html#_2017-01-12_06_18_50_571756 | |
| 12:27:40 | huanxuan | stevemar: about auth_ref | |
| 12:28:28 | stevemar | huanxuan: yeah, i noticed that a few times now | |
| 12:29:41 | openstackgerrit | Huanxuan Ao proposed openstack/python-openstackclient: Fix gate broken by auth_ref in image unit test https://review.openstack.org/419445 | |
| 12:31:00 | huanxuan | stevemar: I try to specify a value for auth_ref, just like we did in other unit test, hopefully it works | |
| 12:31:00 | openstackgerrit | Xinhui Li proposed openstack/python-openstacksdk: Add workflow service (mistral) https://review.openstack.org/414919 | |
| 12:43:03 | dtroyer | OK, I am trying to understand what makes that test race like that… | |
| 12:43:10 | dtroyer | ooooooooohhhhhhhhhh... | |
| 12:43:22 | dtroyer | many class variables in that file | |
| 12:45:18 | dtroyer | are all of the failures in the same place? | |
| 12:47:23 | huanxuan | dtroyer: no, I saw two in network qos rule command, and one in image set command | |
| 12:50:19 | huanxuan | they are variable... | |
| 12:52:52 | stevemar | huanxuan: dtroyer at least unit test failures are more isolated than functional test failures :) | |
| 13:00:26 | RuiChen | we have an IRC meeting UTC 13:00 today? | |
| 13:00:44 | dtroyer | YES! thanks for the nudge… | |
| 13:01:11 | dtroyer | #openstack-meeting-3 now | |
| 13:01:22 | RuiChen | \o/, I join it right now | |
| 13:17:52 | openstackgerrit | Monty Taylor proposed openstack/os-client-config: Use upper-constraints for tox envs https://review.openstack.org/419273 | |
| 13:17:54 | openstackgerrit | Monty Taylor proposed openstack/os-client-config: Remove 3.4 from tox envlist https://review.openstack.org/419457 | |
| 13:23:40 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/python-openstackclient: Fix Network QoS rule CLI attrs parsing https://review.openstack.org/419461 | |
| 14:00:24 | stevemar | o/ | |
| 14:00:30 | huanxuan | stevemar: let's talk about the manage and unmanage | |
| 14:00:30 | RuiChen | hi | |
| 14:01:15 | stevemar | huanxuan: sure, looks like thingee (mike perez) had some comments in v | |
| 14:01:16 | stevemar | https://review.openstack.org/#/c/410008/ | |
| 14:01:18 | RuiChen | but some new commands which is added in newton can't use against Mitaka OpenStack, I mean, dtroyer | |
| 14:02:45 | huanxuan | stevemar: actually I don't know how to make sure the comment "do this automatically" | |
| 14:03:17 | huanxuan | stevemar: I don't know how to see the difference in this kind of volume between using --remote and not | |
| 14:04:02 | huanxuan | since there is not a volume create using --remote for me | |
| 14:04:24 | huanxuan | I cannot see any information about it | |
| 14:05:01 | stevemar | huanxuan: that's fine, i was hoping there was information about in the volume, but i guess not | |
| 14:05:15 | stevemar | huanxuan: i'm just concerned about mike's last comments | |
| 14:05:38 | stevemar | he really doesn't like the --remote option, sounds like he would have liked manage/unmanage commands | |
| 14:06:18 | dtroyer | I really don't like manage/unmanage, but don't understant the choice of —remote either | |
| 14:06:20 | huanxuan | stevemar: yes | |
| 14:06:42 | dtroyer | is 'set —manage | —unmanage' a thing here? | |
| 14:06:42 | stevemar | dtroyer: did we release those commands yet? | |
| 14:07:04 | dtroyer | stevemar: no idea…probably, this goes back to before the previous release or two | |
| 14:07:47 | dtroyer | if we make a change in direction, deprecating —remote is no big deal | |
| 14:08:17 | huanxuan | yes, we can make a change if necessary | |
| 14:08:21 | stevemar | grr, went into 3.6.0 and 3.5.0 | |
| 14:08:28 | dtroyer | my concern with manage/unamanage is that it is fairly meaningless without already knowing exactly what cinder defines it to mean, not something that can ge used elsewhere sicne no other API that I know of has this concenpt | |
| 14:08:31 | stevemar | thats true | |
| 14:08:51 | huanxuan | yeah | |
| 14:09:00 | dtroyer | those really are db-only operations | |
| 14:09:18 | dtroyer | if I wanted to be a jerk, I'd say they belong in cinder-manage :) | |
| 14:09:18 | RuiChen | sorry, I think make OSC version match openstack version make sense for downstream team, it's easier to pick right osc version for stable openstack , so what's your advise? dtroyer | |
| 14:09:50 | dtroyer | RuiChen: I'd like to finish the cinder thing first… | |
| 14:09:59 | stevemar | we can always deprecate the option or add a new manage command (the two options for creating can co-exist) | |
| 14:10:13 | stevemar | dtroyer: i think we're done | |
| 14:10:28 | RuiChen | sure, here you go, sorry | |
| 14:10:29 | dtroyer | right. this is a case where I do think we need to step back a bit and make sure we build the right UI | |
| 14:10:39 | dtroyer | ok, thanks guys | |
| 14:11:03 | huanxuan | RuiChen: thanks | |
| 14:11:10 | dtroyer | RuiChen: the current OSC will always have features that an older cloud can not use, but that does not make it unusable on older clouds | |
| 14:11:53 | stevemar | if someone comes up with a nice UI, they can build it. the two options can co-exist. just like git checkout -b new_branch; and git branch -d <new_branch> | |
| 14:11:55 | dtroyer | if that idea is a problem for your downstream, then it will always be a problem during every release | |
| 14:12:12 | huanxuan | stevemar: sounds good | |
| 14:13:02 | huanxuan | stevemar: so we are going to add manange and unmanage commands now, right? | |
| 14:13:12 | stevemar | huanxuan: not now, whenever :P | |
| 14:13:19 | dtroyer | the cases where matching stable OSC to a cloud release are usually due to distributions that can not co-install multiple python bits from different releases due to dependency conflicts | |
| 14:13:58 | huanxuan | stevemar: OK, get it! :) | |
| 14:14:53 | dtroyer | RuiChen: so what specifically is blocking your use of the current OSc releases? | |
| 14:16:52 | RuiChen | our user confused about why some osc commands raise error in stable openstack, they don't know openstack too much | |