| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2026-10-06 | |||
| 13:07:00 | opendevreview | ribaudr proposed openstack/nova master: Fix swap disk creation skipped on NFS during cold migration https://review.opendev.org/c/openstack/nova/+/1006036 | |
| 15:10:33 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron networks https://review.opendev.org/c/openstack/nova/+/928022 | |
| 15:12:20 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron subnets https://review.opendev.org/c/openstack/nova/+/962190 | |
| 15:12:51 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron subnets https://review.opendev.org/c/openstack/nova/+/962190 | |
| 15:13:11 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron extensions https://review.opendev.org/c/openstack/nova/+/962270 | |
| 15:13:21 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron extensions https://review.opendev.org/c/openstack/nova/+/962270 | |
| 15:15:43 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove version check for old libvirt/qemu https://review.opendev.org/c/openstack/nova/+/1008862 | |
| 15:16:00 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | |
| 15:18:48 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | |
| 15:20:26 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | |
| 15:22:17 | opendevreview | Takashi Kajinami proposed openstack/nova master: Bump MIN_{LIBVIRT,QEMU} for "Indri" https://review.opendev.org/c/openstack/nova/+/1008847 | |
| 15:22:17 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove version check for old libvirt/qemu https://review.opendev.org/c/openstack/nova/+/1008862 | |
| 15:22:18 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | |
| 15:25:21 | tkajinam | after 10+ years interacting with gerrit I eventually learned how that "copy" button next to the change title works... | |
| 15:25:47 | tkajinam | idk how many times I copy-pasted the title and link separately ... | |
| 15:25:55 | tkajinam | and manually ... | |
| 15:27:00 | opendevreview | Konrad Gube proposed openstack/nova master: Add assisted volume extend API. https://review.opendev.org/c/openstack/nova/+/1009077 | |
| 15:29:58 | sean-k-mooney | tkajinam: huh ya i have never uesed that | |
| 15:30:03 | sean-k-mooney | i guess that is useful | |
| 15:32:37 | tkajinam | especially when you put the link to etherpad :-) | |
| 15:33:12 | tkajinam | for ptg, review priority list, etc ... | |
| 15:44:39 | melwitt | good to know -- thanks for sharing. fwiw it might be a more recent feature in gerrit and it is not that you missed it for a long time :) | |
| 15:59:43 | opendevreview | Takashi Kajinami proposed openstack/nova master: Bump MIN_{LIBVIRT,QEMU} for "Indri" https://review.opendev.org/c/openstack/nova/+/1008847 | |
| 15:59:44 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove version check for old libvirt/qemu https://review.opendev.org/c/openstack/nova/+/1008862 | |
| 15:59:44 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | |
| 16:02:00 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | |
| 16:28:52 | opendevreview | Lajos Katona proposed openstack/nova master: Cfg: document devname reject in [pci]device_spec https://review.opendev.org/c/openstack/nova/+/1009083 | |
| 16:31:26 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Stop testing missing sev capability in libvirt < 10.0.0 https://review.opendev.org/c/openstack/nova/+/1009084 | |
| 16:39:51 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Create base class for domain capability feature https://review.opendev.org/c/openstack/nova/+/1009086 | |
| 16:41:16 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Create base class for domain capability feature https://review.opendev.org/c/openstack/nova/+/1009086 | |
| 17:52:23 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Create base class for domain capability feature https://review.opendev.org/c/openstack/nova/+/1009086 | |
| 18:08:44 | clif | sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/1005118 seems to be failing on nova-tox-py312-threading, but the test failures seem to hinge on nova/utils.py accessing executor._workers, which doesn't seem to exist which this patch doesn't change in any way afaict | |
| 18:09:41 | sean-k-mooney | hum that may be a issue with the version of oslo or rather futureist used on that stable branch | |
| 18:11:20 | clif | have you run into this before? | |
| 18:11:50 | sean-k-mooney | no | |
| 18:12:09 | sean-k-mooney | but i know that eariler in the eventlet removal process we did have some issue like that | |
| 18:12:20 | sean-k-mooney | where the executors ewre not as swapable as they shoudl have been | |
| 18:14:09 | sean-k-mooney | that does nto look liek thsoe failrue are related to your packt really | |
| 18:14:14 | sean-k-mooney | *patch | |
| 18:16:50 | clif | do we need to patch stable/2025.2 to change the version of oslo or futurist? or patch nova/utils.py to not refer to executor._workers? | |
| 18:18:13 | sean-k-mooney | well the larger problem is that code is refering to the greetheadpool executor | |
| 18:18:24 | sean-k-mooney | in the version of the job that does not use eventlet | |
| 18:18:35 | sean-k-mooney | so that is also incorrect | |
| 18:19:09 | clif | the code in nova/utils.py? | |
| 18:19:15 | sean-k-mooney | https://paste.opendev.org/show/bcyOL5SrnQtVCITo8DeV/ | |
| 18:19:20 | sean-k-mooney | that the traceback | |
| 18:19:29 | clif | right | |
| 18:20:26 | clif | you mentioned that the version of oslo or futurist might be an issue | |
| 18:20:33 | sean-k-mooney | so that is invoking cdoe that depens on using the treaded executor but tis callign it on a GreenThreadPoolExecutor | |
| 18:20:48 | sean-k-mooney | maybe but this looks more liek a test confiurtion issue | |
| 18:21:01 | sean-k-mooney | looking at master futureist it also does not provide _workers | |
| 18:21:06 | sean-k-mooney | so i dont think its a regresion | |
| 18:21:50 | clif | so you the the executor object would be a different type that does have _workers if the tests were configured correctly? | |
| 18:21:55 | clif | you think* | |
| 18:22:00 | sean-k-mooney | yes | |
| 18:22:07 | sean-k-mooney | the normal threadpool executor has that value | |
| 18:22:28 | sean-k-mooney | https://github.com/openstack/futurist/blob/master/futurist/_futures.py#L175 | |
| 18:22:49 | sean-k-mooney | and that is what we are expectign to use in that job but we are not for some reason | |
| 18:22:57 | clif | sounds reasonable | |
| 18:23:04 | clif | do you know how to fix the configuration | |
| 18:23:20 | sean-k-mooney | so you are mockign @mock.patch('nova.utils.spawn_on') | |
| 18:23:48 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/1005118/1/nova/tests/unit/compute/test_compute_mgr.py#518 | |
| 18:23:55 | sean-k-mooney | so im wondering if its related to that in some way | |
| 18:25:16 | sean-k-mooney | althouhg at least in the test that is failing its in a completely unrealted part of the code | |
| 18:25:42 | sean-k-mooney | ah found the bug https://review.opendev.org/c/openstack/nova/+/1005118/1/nova/compute/manager.py#674 | |
| 18:25:42 | clif | that's why I thought this change was indepedent of the failures | |
| 18:26:14 | sean-k-mooney | so you cant hardcode the executor type there | |
| 18:26:28 | clif | But that's what the line above it does? | |
| 18:26:39 | clif | line 671 also hardcodes a GreenThreadPoolExecutor | |
| 18:26:46 | clif | which exists prior to this change | |
| 18:27:09 | sean-k-mooney | yes but we have the power sysnt disbsle i think | |
| 18:27:28 | sean-k-mooney | so i dont think that executor is actully used in the tests | |
| 18:28:30 | sean-k-mooney | in newer verisons fo this patch on master for example | |
| 18:28:42 | sean-k-mooney | you were getting the executor form a util funciton that did the right thing | |
| 18:28:53 | sean-k-mooney | i.e. that checked if it shoudl be using real thread or not | |
| 18:29:14 | sean-k-mooney | in the backport your not doing that so eitehr we need to emulate that logic or backport hte helper funciton | |
| 18:30:00 | sean-k-mooney | this is the same line one release newer https://review.opendev.org/c/openstack/nova/+/1005115/1/nova/compute/manager.py#673 | |
| 18:30:13 | sean-k-mooney | your calling nova.utils.create_executor | |
| 18:30:59 | sean-k-mooney | so you coudl do a minimial backprot of just that one fuction in utils.py adn its assocated tets or backprot that as an addtional patch prior to this one | |
| 18:32:37 | sean-k-mooney | clif: its djust this https://github.com/openstack/nova/blob/stable/2026.1/nova/utils.py#L116-L121 | |
| 18:32:49 | clif | ahh I see ok | |
| 18:33:01 | sean-k-mooney | and this https://github.com/openstack/nova/blob/stable/2026.1/nova/utils.py#L1336-L1341 | |
| 18:33:15 | clif | yeah I can handle that | |
| 18:33:21 | sean-k-mooney | that was remvoed durign the hibiscus cycle after the chagne merged on master | |
| 18:52:48 | sean-k-mooney | clif: by the way when you fix this in your backport make sure to update the commit message to note the partical backport of those fucntiosn if you dont do it in a seperate commit | |
| 18:53:24 | clif | sure | |
| 18:53:32 | clif | do you prefer separate? | |
| 18:53:55 | sean-k-mooney | either is fine i would check the orginal commit that added the funciton | |
| 18:54:05 | sean-k-mooney | if that is a clean cherry pick then that is prefered | |
| 18:54:21 | sean-k-mooney | if not its ok ot pull it in just make note of the change id that orginally added them | |
| 18:54:23 | clif | gotcha | |
| 19:18:32 | opendevreview | Merged openstack/nova master: Replace deprecated sqlalchemy.orm.noload https://review.opendev.org/c/openstack/nova/+/1007632 | |
| 20:15:43 | opendevreview | Gabin Lanore proposed openstack/nova master: libvirt: stop the event dispatch loops on cleanup https://review.opendev.org/c/openstack/nova/+/1005022 | |
| 20:29:17 | opendevreview | Adam Harwell proposed openstack/nova master: Stop the service when its start fails https://review.opendev.org/c/openstack/nova/+/1009119 | |
| #openstack-nova - 2026-10-07 | |||
| 00:35:31 | opendevreview | Michael Sherman proposed openstack/nova master: ironic: Reproduce node leak after local delete https://review.opendev.org/c/openstack/nova/+/1008334 | |
| 00:43:12 | opendevreview | Michael Sherman proposed openstack/nova master: ironic: Reproduce node leak after failed build cleanup https://review.opendev.org/c/openstack/nova/+/1009134 | |
| 00:45:56 | opendevreview | Michael Sherman proposed openstack/nova master: ironic: Reproduce 409 on unprovision during deploy https://review.opendev.org/c/openstack/nova/+/1009135 | |
| 00:57:20 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Stop hanging the test if threadpool executor is stuck in cleanup https://review.opendev.org/c/openstack/nova/+/1006351 | |
| 01:47:53 | opendevreview | Takashi Kajinami proposed openstack/nova master: Bump MIN_{LIBVIRT,QEMU} for "Indri" https://review.opendev.org/c/openstack/nova/+/1008847 | |
| 01:48:06 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove version check for old libvirt/qemu https://review.opendev.org/c/openstack/nova/+/1008862 | |