| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2026-08-26 | |||
| 16:21:44 | melwitt | sean-k-mooney: do we need to bump nova too for nvme traits? I guess you said no it would not? | |
| 16:22:06 | sean-k-mooney | melwitt: nova will never report them so not a depency for it | |
| 16:22:17 | melwitt | oh I see, cool | |
| 16:22:36 | sean-k-mooney | cyborg need it for the constant adn placmenet so we can say 2026.2 will alwasy have them | |
| 16:22:58 | sean-k-mooney | techinally the standard traits can be newer if placment has a newer os-tratis installed | |
| 16:23:25 | melwitt | gotcha | |
| 16:23:27 | sean-k-mooney | that why it was working in ci we alwasy use whatever is allwoed by UC | |
| 16:24:08 | gibi | I stopping for today. o/ | |
| 16:24:21 | sean-k-mooney | o/ | |
| 16:24:33 | opendevreview | Clif Houck proposed openstack/nova master: perf(ironic): eliminate O(N²) ProviderTree deepcopy at startup https://review.opendev.org/c/openstack/nova/+/980676 | |
| 16:24:34 | opendevreview | Clif Houck proposed openstack/nova master: Parallelize per-node resource updates https://review.opendev.org/c/openstack/nova/+/980679 | |
| 16:24:43 | sean-k-mooney | ill be swaping to watcher review sortly too and tomorrow ill be mainly focusing on watcher and cyborg | |
| 16:57:24 | opendevreview | Clif Houck proposed openstack/nova master: Parallelize per-node resource updates https://review.opendev.org/c/openstack/nova/+/980679 | |
| 17:04:46 | opendevreview | Merged openstack/nova master: Switch Cyborg client from keystoneauth1 to openstacksdk https://review.opendev.org/c/openstack/nova/+/1002007 | |
| 17:30:48 | opendevreview | Merged openstack/nova master: libvirt: Launch security Intel TDX https://review.opendev.org/c/openstack/nova/+/999249 | |
| 17:31:02 | opendevreview | Merged openstack/nova master: doc: Add documentation for Intel TDX https://review.opendev.org/c/openstack/nova/+/1000081 | |
| 17:48:51 | opendevreview | melanie witt proposed openstack/nova master: Remove workaround for ServiceAuthTokenWrapper get_endpoint_data() https://review.opendev.org/c/openstack/nova/+/1002540 | |
| 17:52:10 | opendevreview | melanie witt proposed openstack/nova master: Remove workaround for ServiceAuthTokenWrapper get_endpoint_data() https://review.opendev.org/c/openstack/nova/+/1002540 | |
| 17:52:42 | melwitt | stephenfin, sean-k-mooney: seems to work fine ^ tested on my devstack | |
| 18:42:06 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Fix race between RPC method completion and task tracking updates https://review.opendev.org/c/openstack/nova/+/1002432 | |
| 19:29:31 | opendevreview | Merged openstack/placement master: bump min version of os-traits https://review.opendev.org/c/openstack/placement/+/1002526 | |
| 20:46:17 | opendevreview | melanie witt proposed openstack/nova master: tests: Functional reproducer for bug 2088831 https://review.opendev.org/c/openstack/nova/+/935565 | |
| 20:46:18 | opendevreview | melanie witt proposed openstack/nova master: Include image in unified limits quota check https://review.opendev.org/c/openstack/nova/+/1002553 | |
| 21:14:27 | opendevreview | Merged openstack/nova master: Stabilize TestSerialConsoleLiveMigrate https://review.opendev.org/c/openstack/nova/+/1002477 | |
| 21:14:39 | opendevreview | Merged openstack/nova master: Stabilize live migration tests https://review.opendev.org/c/openstack/nova/+/1002493 | |
| 21:14:54 | opendevreview | Merged openstack/nova master: Lock on DB url in functional test https://review.opendev.org/c/openstack/nova/+/1002529 | |
| 22:38:29 | opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Support cold migration with virtiofs shares https://review.opendev.org/c/openstack/nova/+/989633 | |
| 22:38:30 | opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Reconcile stale Manila share access rules https://review.opendev.org/c/openstack/nova/+/1001916 | |
| 22:59:42 | opendevreview | Merged openstack/nova master: libvirt: reject_mem_enc_instances https://review.opendev.org/c/openstack/nova/+/1000082 | |
| #openstack-nova - 2026-08-27 | |||
| 00:41:56 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Fix graceful shutdown functional unstable tests https://review.opendev.org/c/openstack/nova/+/1002223 | |
| 01:07:09 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add functional tests for TDX capability report https://review.opendev.org/c/openstack/nova/+/998525 | |
| 03:19:03 | opendevreview | Merged openstack/nova master: Stub kernel support check of AMD-SEV in tests https://review.opendev.org/c/openstack/nova/+/999780 | |
| 05:41:15 | opendevreview | Merged openstack/nova master: libvirt: Check only x86_64 arch for Intel TDX https://review.opendev.org/c/openstack/nova/+/1000805 | |
| 06:27:39 | opendevreview | Merged openstack/nova master: Remove unused default argument https://review.opendev.org/c/openstack/nova/+/922073 | |
| 07:51:29 | gibi | antia: TDX landed. Thanks for the contribution! | |
| 08:16:21 | gibi | a bunch of stabilization bug fix landed. I now took https://bugs.launchpad.net/nova/+bug/2165150 as the next to work on | |
| 08:16:33 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add functional tests for TDX capability report https://review.opendev.org/c/openstack/nova/+/998525 | |
| 08:30:47 | antia | gibi: Amazing! Thanks for all your effort on this | |
| 08:32:01 | gibi | now that both TDX and SNP is in the tree I will buy a slice of cake after lunch. It was a nice cooperation across timezones, companies, and even vendors. I would like to see more such feature development in the future in openstack | |
| 08:33:17 | gibi | thanks tkajinam antia sean-k-mooney gmaan bauzas and others in the background who are not on IRC to make it happen | |
| 09:48:38 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add functional tests for TDX capability report https://review.opendev.org/c/openstack/nova/+/998525 | |
| 12:16:27 | gmaan | \o/ | |
| 12:24:18 | gibi | I think I found a race that is not test only but a real race in the compute(s) https://bugs.launchpad.net/nova/+bug/2165318 | |
| 12:35:46 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Add event.set cleanup in test_graceful_shutdown https://review.opendev.org/c/openstack/nova/+/1002638 | |
| 12:38:35 | gmaan | gibi: ^^ followup for self.addCleanup event.set | |
| 12:40:05 | gibi | thanks | |
| 13:25:33 | opendevreview | Lajos Katona proposed openstack/nova master: libvirt: Preserve queue_size during live migration https://review.opendev.org/c/openstack/nova/+/995841 | |
| 13:52:26 | opendevreview | Merged openstack/nova master: Remove workaround for ServiceAuthTokenWrapper get_endpoint_data() https://review.opendev.org/c/openstack/nova/+/1002540 | |
| 14:29:09 | stephenfin | melwitt: I'd appreciate your eyes on https://review.opendev.org/c/openstack/nova/+/1002359 while you still have ksa know-how fresh in your head 🙏 | |
| 14:29:43 | melwitt | stephenfin: ah yes thanks for reminding. writing it down this time | |
| 14:49:37 | opendevreview | Stephen Finucane proposed openstack/nova master: conf: Deprecated http_retries options https://review.opendev.org/c/openstack/nova/+/1002657 | |
| 14:49:38 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: network: Simplify client creation https://review.opendev.org/c/openstack/nova/+/1002658 | |
| 15:10:20 | melwitt | gmaan: can I get a sanity check regarding a stable backport proposed? it would change a HTTP 403 to a HTTP 400. I believe this should be ok for stable bc it is remaining a 4xx status still, but wanted to check with you https://review.opendev.org/c/openstack/nova/+/996878 | |
| 15:11:23 | gmaan | melwitt: sure, will check after internal meeting. | |
| 15:11:51 | gmaan | melwitt: thanks for review on gate fixes, this one also ready https://review.opendev.org/c/openstack/nova/+/1002223 | |
| 15:12:06 | melwitt | cool thank you | |
| 15:12:31 | gmaan | melwitt: stephenfin and this one you had reviewed earlier, i need to rebase it due to code refactor on this https://review.opendev.org/c/openstack/nova/+/986477 | |
| 15:12:36 | melwitt | gmaan: thanks for the fixes! I'm very happy for the improvements. thanks I will review that one too | |
| 15:12:42 | gmaan | thanks | |
| 15:21:29 | melwitt | gmaan: regarding this review comment https://review.opendev.org/c/openstack/nova/+/1002223/comment/9997bc1c_41882d81/ doesn't that mean that the _wait_for_service_parameter will not actually wait at all? if the service reports "up" before the first heartbeat, wouldn't this _wait_for_service_parameter just return immediately seeing "up" and not actually wait? | |
| 15:23:01 | opendevreview | Stephen Finucane proposed openstack/nova master: conf: Deprecate http_retries options https://review.opendev.org/c/openstack/nova/+/1002657 | |
| 15:23:07 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: network: Simplify client creation https://review.opendev.org/c/openstack/nova/+/1002658 | |
| 15:23:33 | gmaan | melwitt: yes, it will immediately return as service is up. one issue i found where it was waiting was when we restart the service. in restart test failed as service did not came as 'up' just after restart | |
| 15:24:07 | gmaan | but yes, after service start, it will be up till first heartbeat is there or service_down_time elapsed | |
| 15:25:27 | melwitt | thanks | |
| 15:25:51 | melwitt | I wondered if it could somehow be a problem for the tests if it doesn't actually wait but I guess not | |
| 15:30:03 | stephenfin | melwitt: I agree that it would be good to document this. As noted on the review, my understanding is that it's okay to change an error response status code but not to add a new code | |
| 15:30:26 | stephenfin | hopefully I have that right | |
| 15:31:05 | melwitt | I think you are right | |
| 15:32:16 | melwitt | I had been thinking of something else where I wonder if it's not cool to go across code "levels" in certain directions. like it's cool to go from 500 => 400 but not to go from 400 => 500 | |
| 15:33:30 | melwitt | and going from a 4xx to a different 4xx stays within a level (in addition to being an error code that is already currently being returned) | |
| 15:58:40 | opendevreview | Clif Houck proposed openstack/nova master: perf(ironic): eliminate O(N²) ProviderTree deepcopy at startup https://review.opendev.org/c/openstack/nova/+/980676 | |
| 15:58:40 | opendevreview | Clif Houck proposed openstack/nova master: Parallelize per-node resource updates https://review.opendev.org/c/openstack/nova/+/980679 | |
| 16:13:47 | sean-k-mooney | we are alwasy allowed ot change a 500 to a 400 if it was previosly broken | |
| 16:14:10 | sean-k-mooney | 400->500 is just a bug | |
| 16:14:19 | sean-k-mooney | that we shoudl fix before intentully intoducing :) | |
| 16:14:57 | sean-k-mooney | https://docs.openstack.org/nova/latest/contributor/microversions.html#id2:~:text=Footnotes | |
| 16:15:34 | sean-k-mooney | ``` | |
| 16:15:36 | sean-k-mooney | When fixing 500 errors that previously caused stack traces, try to map the new error into the existing set of errors that API call could previously return (400 if nothing else is appropriate). Changing the set of allowed status codes from a request is changing the contract, and should be part of a microversion ``` | |
| 16:16:11 | sean-k-mooney | so 500 to any exisitng responce code is fine and 400, 403, 404 and 415 are alwasy allowed per footnote 2 | |
| 16:33:49 | gmaan | melwitt: on 403->400, yes it is all good to change it to existing code. if it is changing to same level but a new code then it is not backward compatible but it that changing code is existing one then it is ok. | |
| 16:42:06 | opendevreview | Merged openstack/nova master: ci: Remove GLANCE_STANDALONE https://review.opendev.org/c/openstack/nova/+/996322 | |
| 16:44:54 | melwitt | gmaan: awesome thanks | |
| 16:48:09 | melwitt | sean-k-mooney: yes I remember we can change from 5xx to any other error. but I was thinking about other "level" changes but there aren't really any good examples ... the example of 4xx => 5xx is obviously not ok | |
| 16:51:31 | sean-k-mooney | not without a microversion correct | |
| 16:51:47 | sean-k-mooney | but we shoudl not really return a 5xx in general | |
| 16:52:20 | melwitt | yeah, I think 5xx is never desired. that's if all other error handling falls through | |
| 16:52:22 | sean-k-mooney | at least not intentionally unless we are signaling a rate limiting issue or propagaging a 5xx we recived form a different service | |
| 16:52:43 | sean-k-mooney | well 500 is what you get when you hit an edge case we didng accoutn for right | |
| 16:53:49 | melwitt | generally I think so | |
| 17:28:02 | opendevreview | Merged openstack/nova master: libvirt: Drop redundant cast to str in python 3 https://review.opendev.org/c/openstack/nova/+/997810 | |
| 17:49:03 | opendevreview | Merged openstack/nova master: libvirt: Fail when file-backed memory is used with reservation https://review.opendev.org/c/openstack/nova/+/906161 | |
| 17:55:28 | opendevreview | Merged openstack/nova master: Fix race between RPC method completion and task tracking updates https://review.opendev.org/c/openstack/nova/+/1002432 | |
| 17:55:42 | opendevreview | Merged openstack/nova master: Add event.set cleanup in test_graceful_shutdown https://review.opendev.org/c/openstack/nova/+/1002638 | |
| 19:09:30 | gmaan | melwitt: replied to your question https://review.opendev.org/c/openstack/nova/+/1002223/comment/c5a84643_8a1c0fa7/ | |
| 19:09:55 | gmaan | sorry for being lazy to explain on why we need wait after start_compute. though it is only needed in _restart_compute and not in setUp | |
| 19:10:13 | gmaan | let me know if you prefer to remove it from setUp, i can respin it quickly | |
| 19:12:42 | gmaan | basically there is difference in service status until first heartbeat arrives for start fresh service vs restart existing service. where in former case, service initial status is 'up' and latter one is 'down'. once first heartbeat arrives it is as per the heartbeat and service_down_time | |
| 19:14:35 | melwitt | gmaan: haha thanks. yes that makes sense that it's necessary for the restart. I was confused by your last comment about tests failing without the wait because we were commenting at the setUp location in the code :) | |
| 19:15:20 | gmaan | yeah, i commented that in wrong place. let me remove it from setUp to avoid confusion in future | |