Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2026-08-25
13:55:40 sean-k-mooney so that why im qustioning using a 3.11 feature
13:55:52 stephenfin okay, backporting does change the equation. I wasn't aware of that
13:55:58 sean-k-mooney well we intned to backprot he prevsiou patch this wone was deabateable
13:57:58 sean-k-mooney we can modify it on backport if requried but ya the hope ofr the O(n2) patch at least was to backport to all stable branches
13:58:23 sean-k-mooney the parallisze i know operator will want it backported but im not sure it fully fits stabel policy
13:58:29 stephenfin okay, if that's the plan then yeah, we'd want to go back to just raising the first exception
13:58:31 sean-k-mooney so that patch may be propsoedn abut not mergd
13:59:23 sean-k-mooney *may be proposed but not merged
13:59:48 sean-k-mooney we can do both we could add a patch to swap to excption groups as a followup
14:00:02 stephenfin clif: ☝️ apologies for the slight waste of your time there 🙇
14:00:04 sean-k-mooney but if we can keep this 3.10 compatiable it woudl be nice
14:03:41 sean-k-mooney stephenfin: since your about https://review.opendev.org/c/openstack/nova/+/1002246 gibi puhsed htat to stablise a functional test mind taking a look
14:11:14 clif ok, yea I can revert the ExceptionGroup change
14:12:28 clif relatedly, some functional tests are failing on the parallel per-node resource update change, for instance: nova.tests.functional.libvirt.test_pci_in_placement.PlacementPCIInventoryReportingTests.test_device_reconfiguration_with_allocations_config_change_stop fails because the exception raised has changed
14:14:58 clif any advice on that?
14:19:22 clif well now that I think about it some the failures may be related to the exceptiongroup change
14:34:48 clif ah yea it was the exceptiongroup changing how exceptions got raised, makes sense
14:39:23 opendevreview Clif Houck proposed openstack/nova master: Parallelize per-node resource updates https://review.opendev.org/c/openstack/nova/+/980679
15:05:10 gmaan gibi: ack, will check
15:19:58 gibi gmaan: thanks
15:23:11 gmaan I saw this again, I think this hit twice, I will work on this today https://bugs.launchpad.net/nova/+bug/2164880
15:26:37 gibi gmaan: thanks
15:29:09 melwitt thank you gmaan for working on these
15:31:10 melwitt sean-k-mooney: gotcha, I see. yeah. really hope we can switch to sdk rather than add those one-off ... the patch is not too ugly (I hope!)
16:56:18 stephenfin melwitt: I'm +2 on https://review.opendev.org/c/openstack/nova/+/1002007 again. The ksa fix is also merged and should be released this week, so we could potentially remove that subclass next week. Just need sean-k-mooney to revisit that now (hint hint)
17:00:02 sean-k-mooney[m] cool we are at the park with frya ill be home in a bit and ill take a look then
17:22:59 melwitt stephenfin: super, thank you
17:28:58 opendevreview Stephen Finucane proposed openstack/nova master: cinder: Use keystoneauth1 Adapter for endpoint discovery https://review.opendev.org/c/openstack/nova/+/1002359
18:07:42 sean-k-mooney stephenfin: melwitt im pretty sure that https://review.opendev.org/c/openstack/nova/+/1002007/8/nova/accelerator/cyborg.py is incorrect
18:07:56 sean-k-mooney stephenfin: melwitt we do not use an admin client today to talk to cyrbog
18:08:04 sean-k-mooney wew shoudl in the future but we dont today
18:08:18 sean-k-mooney and that cached client is confging it ot an admin client
18:08:45 sean-k-mooney the cachign itself might makes sense in the future but not today when we alwasy need to use the users token
18:09:54 sean-k-mooney i think the problem is that this is folow the same pattern we use to tak to ironic and manilla but the cybrog interaction is not the same as the inronic interaction
18:09:55 melwitt sean-k-mooney: hm ok, so that should be admin=False. I had thought it was but that must have been an earlier iteration
18:10:43 sean-k-mooney ya which means we take the if brnach here https://review.opendev.org/c/openstack/nova/+/1002007/8/nova/utils.py#940
18:10:45 sean-k-mooney not the else
18:11:04 sean-k-mooney but if we take the if brnach we done need to chagne the signigure to pass in ksa_auth
18:12:06 sean-k-mooney if admin false branch already correctly constuct the service user token and uses the uers token form the context to constuct the sdk connection
18:12:23 melwitt argh dammit
18:13:01 melwitt sorry
18:13:42 sean-k-mooney on a side note i messed up my grub config on one of my dev hosts, i do not know the root password adn signle user mode didnt work so im not reinstalling an os
18:13:47 sean-k-mooney so its one of those days
18:14:15 melwitt I have been there
18:17:21 sean-k-mooney i didnt properly unstack and swift or rather the swift loopback volume we create in devstack is preventing the boot
18:18:12 sean-k-mooney melwitt: have you had a chance to check the auth change on a devstack by the way
18:19:41 melwitt sean-k-mooney: no, but cyborg-tempest-py3 was definitely showing when it fails
18:20:23 sean-k-mooney ack i was plannign to test it on the host im reinstalling before trying to test the nvme serise
18:23:01 melwitt ++
18:30:17 opendevreview Merged openstack/nova master: Stabilize TestInstanceNotificationSample.test_instance_action https://review.opendev.org/c/openstack/nova/+/1002246
18:32:06 sean-k-mooney melwitt: my main concern woudl be that all the attachment end up beign owned by nova instead of the end user
18:32:31 sean-k-mooney i.e. the client worked but the ownership was wrong
18:32:46 melwitt yeah, that is an important point
18:33:12 sean-k-mooney hence why i want to check it on a devstack si i can check the db to verify the ownership
18:36:35 melwitt yeah, you are right
19:06:52 opendevreview Ghanshyam Maan proposed openstack/nova master: Fix graceful shutdown functional unstable tests https://review.opendev.org/c/openstack/nova/+/1002223
20:11:16 opendevreview melanie witt proposed openstack/nova master: Switch Cyborg client from keystoneauth1 to openstacksdk https://review.opendev.org/c/openstack/nova/+/1002007
20:28:02 gmaan melwitt: gibi updated this, matching the service_down_time with what any test can take time to execute, also added the root cause of why service down is happening in between of tests in note/commit msg https://review.opendev.org/c/openstack/nova/+/1002223
20:52:42 opendevreview Merged openstack/nova master: Stabilize TestInstanceNotificationSampleWithMultipleCompute https://review.opendev.org/c/openstack/nova/+/1002281
21:29:04 opendevreview melanie witt proposed openstack/nova master: Switch Cyborg client from keystoneauth1 to openstacksdk https://review.opendev.org/c/openstack/nova/+/1002007
21:32:35 opendevreview melanie witt proposed openstack/nova master: Switch Cyborg client from keystoneauth1 to openstacksdk https://review.opendev.org/c/openstack/nova/+/1002007
22:26:03 melwitt sean-k-mooney: ok, I think https://review.opendev.org/c/openstack/nova/+/1002007 should be in the right state now. I'm leaving it in WIP mode while we test it more
23:47:46 melwitt sean-k-mooney: seems to work as intended on my devstack, created a server with the fake_driver device and the extended_accelerator_requests table has a record with project_id of the "demo" project I created the server with
#openstack-nova - 2026-08-26
00:20:12 opendevreview Ghanshyam Maan proposed openstack/nova master: Shutdown thread pool executors during graceful shutdown https://review.opendev.org/c/openstack/nova/+/1000211
00:21:58 gmaan gibi: dansmith ^^ updated the shutdown executors with wait=True
00:28:18 opendevreview Ghanshyam Maan proposed openstack/nova master: Add doc and release notes for the graceful shutdown task tracking https://review.opendev.org/c/openstack/nova/+/997141
00:31:08 opendevreview Ghanshyam Maan proposed openstack/nova master: Add doc and release notes for the graceful shutdown task tracking https://review.opendev.org/c/openstack/nova/+/997141
00:49:02 gmaan melwitt: gibi ^^ updated the doc change also
02:16:07 opendevreview Merged openstack/nova master: Bump python_version for mypy to 3.11 https://review.opendev.org/c/openstack/nova/+/1002290
02:54:27 opendevreview Merged openstack/nova master: Do not use format string in logs https://review.opendev.org/c/openstack/nova/+/987016
03:06:16 opendevreview Ghanshyam Maan proposed openstack/nova master: Fix race between RPC method completion and task tracking updates https://review.opendev.org/c/openstack/nova/+/1002432
04:33:58 opendevreview Goutham Pacha Ravi proposed openstack/nova master: Extract share management from ComputeManager https://review.opendev.org/c/openstack/nova/+/999349
04:33:59 opendevreview Goutham Pacha Ravi proposed openstack/nova master: Support cold migration with virtiofs shares https://review.opendev.org/c/openstack/nova/+/989633
04:33:59 opendevreview Goutham Pacha Ravi proposed openstack/nova master: Reconcile stale Manila share access rules https://review.opendev.org/c/openstack/nova/+/1001916
05:02:06 opendevreview Goutham Pacha Ravi proposed openstack/nova master: Reconcile stale Manila share access rules https://review.opendev.org/c/openstack/nova/+/1001916
05:48:33 opendevreview Goutham Pacha Ravi proposed openstack/nova master: Reconcile stale Manila share access rules https://review.opendev.org/c/openstack/nova/+/1001916
06:22:48 opendevreview Daniel Schulz proposed openstack/nova master: Prevent orphaned attachments when shelve is preempted by a delete https://review.opendev.org/c/openstack/nova/+/1002439
06:24:05 opendevreview Daniel Schulz proposed openstack/nova master: Prevent orphaned attachments when shelve is preempted by a delete https://review.opendev.org/c/openstack/nova/+/1002439
06:25:16 opendevreview Daniel Schulz proposed openstack/nova master: Prevent orphaned attachments by preemptive delete https://review.opendev.org/c/openstack/nova/+/1002439
07:03:47 opendevreview Merged openstack/nova master: Use service shutdown related config options in nova-graceful-shutdown https://review.opendev.org/c/openstack/nova/+/1001017
08:21:26 antia gibi: Is there anything to resolve, other than the gate errors, for the TDX series?
08:24:48 gibi antia: I'm not tracking anything else just the gate
08:25:01 gibi antia: if you have time contributing whitebox test for TDX would be nice
08:25:47 gibi also if you want you can write a blogpost somewhere about how to configured you HW and tested the series (or even about your overall contribution experience) and we will probably link to it in our doc :)
08:27:05 antia I already started on the whitebox testing, so I'll try to finish that :)
11:02:32 stephenfin sean-k-mooney: melwitt: Because we're doing some deeper diving on KSA at the moment... I've proposed https://review.opendev.org/c/openstack/nova/+/1002359. That is a small initial step that would allow us to move away from cinderclient in a future release. efried started the effort years ago but never closed it out. I'd appreciate your reviews if possible
11:03:11 sean-k-mooney stephenfin: i saw that in my notifications but didnt look so closely
11:03:30 sean-k-mooney i think some of the changes that melwitt has in the cybrog patch are still not required
11:03:45 sean-k-mooney i think it will now work
11:03:56 sean-k-mooney but im not sure why we need to pass in ksa_auth
11:04:15 sean-k-mooney stephenfin: do you know why https://review.opendev.org/c/openstack/nova/+/1002007/11/nova/utils.py is required
11:04:35 sean-k-mooney am i missing somthing in the admin false path?
11:05:26 sean-k-mooney its creating a service token and then usign the user token form the context to create the connections?
11:05:31 sean-k-mooney or is that wrong
11:06:38 sean-k-mooney was the previous admin=false path not passing a service token as well as the user token
11:06:45 stephenfin looking
11:15:22 sean-k-mooney stephenfin: ya thats the chnage
11:15:47 sean-k-mooney well
11:15:54 stephenfin sorry, wanted to double check stuff
11:16:01 stephenfin my understanding of those changes was that we needed to pre-build the auth plugin becuse one of the other services currently using SDK appear to be using service tokens

Earlier   Later