| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2026-08-14 | |||
| 12:09:45 | opendevreview | Pierre Libeau proposed openstack/nova master: libvirt: Render guest interface PCI address in config https://review.opendev.org/c/openstack/nova/+/1000962 | |
| 12:09:45 | opendevreview | Pierre Libeau proposed openstack/nova master: libvirt: Preserve vNIC guest PCI address on domain XML regeneration https://review.opendev.org/c/openstack/nova/+/1000963 | |
| 12:43:40 | plibeau | hi — opinions wanted on https://bugs.launchpad.net/nova/+bug/2163417 : vNIC guest PCI slots get reshuffled on hard reboot (multi-NIC appliances see port1/port2 swapped). nova never pins the VIF guest PCI address, libvirt renumbers from XML order; MAC is the only invariant. reproduced on clean master | |
| 12:45:19 | plibeau | I have a WIP opt-in (3 commits above) [libvirt] preserve_vif_pci_addresses re-pinning by MAC from old_guest (hard reboot/power_on/resume only). is that the right direction, or should the slot be persisted per-VIF? or is "use device role tagging" the intended answer? | |
| 12:47:34 | gibi | plibeau: I think we never promised the guest that the pci slot ordering is stable. Tagging devices are the way to map ports to devices afaik | |
| 12:53:59 | plibeau | yes and linux by default manage that correctly because it use mac address and not pci slot to manage NIC but it's not the case of some and specially appliance. What do you think to try to improve that for this type of use case? | |
| 12:56:21 | gibi | plibeau: I mean you can tag the nic and block devices in the nova api when add it to your server, then the VM can read the tagging from the metadata | |
| 12:56:28 | gibi | that should be OS independent | |
| 12:57:43 | amorin | yes, but some OS are not able to do that, the proposition from plibeau is to try to keep the order as much as possible to avoid order change when it's possible | |
| 13:01:26 | gibi | amorin: you mean there are OSes that are not able to read the metadata API? | |
| 13:01:47 | gibi | or read the metadat from the config drive? | |
| 13:02:00 | amorin | yup | |
| 13:02:10 | amorin | some of our customers complain about this | |
| 13:02:49 | gibi | is it possible that they could read but don't want to? Sorry I'm suspicious here as it is a very basic fuctionality to read a file from an attached disk or do http request | |
| 13:03:40 | amorin | I totally agree with you :) They usually rely on providers to give them images and they seems not able to do so in an easy way | |
| 13:03:54 | amorin | plibeau will have more info, I dont remember the name of the image? | |
| 13:05:11 | gibi | amorin: you can propose a feature (or ask this on the IRC meeting) to start providing a stable order of PCI devices to guests to get the oppinion of others but this was rejected before with the above argument | |
| 13:05:52 | plibeau | Fortinet is the name :) but not only and the customer can't fix also because it's appliance, he don't have root access on it | |
| 13:07:48 | gibi | can this be brougth up to Frotinet then? to integrate with cloud VMs by reading the metadata? :) | |
| 13:09:58 | gibi | I feel like either Fortinet supports to run in OpenStack or isn't :) | |
| 13:15:21 | plibeau | yes, fix on Fortinet side is a solution but we need to fix also probably other case. I think yes Fortinet is supported on openstack I see some documentation how to deploy it above openstack | |
| 13:38:29 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Unify the thread pool executors into a central factory https://review.opendev.org/c/openstack/nova/+/998571 | |
| 13:58:28 | gmaan | gibi: ^^ added the test coverage | |
| 13:59:31 | gibi | gmaan: thanks. I will check it soon | |
| 14:01:33 | gmaan | thanks | |
| 14:01:39 | gibi | +2 | |
| 14:01:42 | gibi | thanks | |
| 14:01:50 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Shutdown thread pool executors during graceful shutdown https://review.opendev.org/c/openstack/nova/+/1000211 | |
| 14:01:56 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Add doc and release notes for the graceful shutdown task tracking https://review.opendev.org/c/openstack/nova/+/997141 | |
| 14:15:18 | opendevreview | Tobias Urdin proposed openstack/nova master: Catch ValueError from from_image_ref in rescue https://review.opendev.org/c/openstack/nova/+/1000969 | |
| 14:48:47 | gmaan | gibi: and this is graceful shutdown part to shutdown executors which i separated from the original change https://review.opendev.org/c/openstack/nova/+/1000211 | |
| 14:59:06 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stabilize functional test for slow instance.save https://review.opendev.org/c/openstack/nova/+/999121 | |
| 14:59:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make functional-py313-threading voting https://review.opendev.org/c/openstack/nova/+/997216 | |
| 14:59:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix test_fill_vifs_migration under native threading https://review.opendev.org/c/openstack/nova/+/1000780 | |
| 14:59:08 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stabilize func test waiting for VM ERROR state https://review.opendev.org/c/openstack/nova/+/1000971 | |
| 15:00:11 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stabilize func test waiting for VM ERROR state https://review.opendev.org/c/openstack/nova/+/998822 | |
| 15:00:11 | opendevreview | Balazs Gibizer proposed openstack/nova master: Stabilize functional test for slow instance.save https://review.opendev.org/c/openstack/nova/+/999121 | |
| 15:00:12 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make functional-py313-threading voting https://review.opendev.org/c/openstack/nova/+/997216 | |
| 15:00:12 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix test_fill_vifs_migration under native threading https://review.opendev.org/c/openstack/nova/+/1000780 | |
| 15:05:08 | gibi | gmaan: thank for the suggestion in the stabilization series ^^ I applied it | |
| 15:05:25 | gmaan | gibi: ack will check today | |
| 15:49:48 | opendevreview | Pierre Libeau proposed openstack/nova master: libvirt: Add reproducer for unstable vNIC PCI addresses on hard reboot https://review.opendev.org/c/openstack/nova/+/1000961 | |
| 15:49:49 | opendevreview | Pierre Libeau proposed openstack/nova master: libvirt: Render guest interface PCI address in config https://review.opendev.org/c/openstack/nova/+/1000962 | |
| 15:49:49 | opendevreview | Pierre Libeau proposed openstack/nova master: libvirt: Preserve vNIC guest PCI address on domain XML regeneration https://review.opendev.org/c/openstack/nova/+/1000963 | |
| 16:31:20 | opendevreview | Merged openstack/os-traits master: Add HW_NVME capability traits https://review.opendev.org/c/openstack/os-traits/+/999921 | |
| 17:48:37 | opendevreview | Merged openstack/nova master: Task tracking mechanism for graceful shutdown https://review.opendev.org/c/openstack/nova/+/996299 | |
| 17:58:05 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Shutdown thread pool executors during graceful shutdown https://review.opendev.org/c/openstack/nova/+/1000211 | |
| 18:29:29 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Unify the thread pool executors into a central factory https://review.opendev.org/c/openstack/nova/+/998571 | |
| 18:30:15 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Shutdown thread pool executors during graceful shutdown https://review.opendev.org/c/openstack/nova/+/1000211 | |
| #openstack-nova - 2026-08-15 | |||
| 02:59:02 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Use devstack set service shutdown related config options https://review.opendev.org/c/openstack/nova/+/1001017 | |
| 03:19:25 | gmaan | it seems nova-grenade-multinode job is failing more frequently on test_shelve_unshelve_server, any known issue? i reported bug for that but did not debug it yet https://bugs.launchpad.net/nova/+bug/2163552 | |
| 23:50:00 | opendevreview | Merged openstack/nova master: Track and log the main RPC server in-progress task https://review.opendev.org/c/openstack/nova/+/996583 | |
| #openstack-nova - 2026-08-17 | |||
| 11:26:03 | opendevreview | chandan kumar proposed openstack/nova master: Report OWNER_NOVA trait on resource providers https://review.opendev.org/c/openstack/nova/+/994299 | |
| 11:34:02 | opendevreview | chandan kumar proposed openstack/nova master: Report OWNER_NOVA trait on resource providers https://review.opendev.org/c/openstack/nova/+/994299 | |
| 11:56:34 | opendevreview | Joan Gilabert proposed openstack/nova master: Add libvirt driver MDEV ARQ support for Cyborg https://review.opendev.org/c/openstack/nova/+/995840 | |
| 13:40:12 | opendevreview | Pierre Libeau proposed openstack/nova master: libvirt: Add reproducer for unstable vNIC PCI addresses on hard reboot https://review.opendev.org/c/openstack/nova/+/1000961 | |
| 13:40:12 | opendevreview | Pierre Libeau proposed openstack/nova master: libvirt: Render guest interface PCI address in config https://review.opendev.org/c/openstack/nova/+/1000962 | |
| 13:40:13 | opendevreview | Pierre Libeau proposed openstack/nova master: libvirt: Preserve vNIC guest PCI address on domain XML regeneration https://review.opendev.org/c/openstack/nova/+/1000963 | |
| 14:51:46 | melwitt | I saw that somebody posted a new comment on this bug https://bugs.launchpad.net/nova/+bug/2076614 saying they hit the problem while upgrading 2025.1 => 2026.1 ... there was a fix proposed but it's in merge conflict now and sean-k-mooney had a comment on it with some follow up steps, I wondered are those steps still valid now (> 1 year later) https://review.opendev.org/c/openstack/nova/+/948328 or is it that we just need to rebase the | |
| 14:51:46 | melwitt | patch? | |
| 14:54:36 | sean-k-mooney | melwitt: triging to remeber context | |
| 14:55:02 | sean-k-mooney | but reading my old comment i was just noting we could start droping older migrations in a followup for things older then caracal | |
| 14:55:27 | sean-k-mooney | i think as wriggen the archive/pruge woudl still be required before doign the online migrations | |
| 14:56:21 | sean-k-mooney | and it might still be worth addign an upgrade release note | |
| 14:56:30 | sean-k-mooney | but i think just rebaseing that commit would be fine | |
| 14:57:05 | sean-k-mooney | melwitt: i.e. if you wanted to progress that i would be ok wiht just resolving the merge conflict and proceeding with it | |
| 14:57:46 | sean-k-mooney | with that said this only affect upgrades form unsupproted releases to my knowldage | |
| 14:57:52 | sean-k-mooney | so it has not been a high priorty | |
| 14:58:29 | sean-k-mooney | oh ok the latest comment confirm its an issue for current release | |
| 14:58:35 | melwitt | sean-k-mooney: ok cool thank you. yeah ... it caught my eye bc they are upgrading _to_ a supported release though so it set off my alarm bells | |
| 14:58:36 | sean-k-mooney | when upgrading after caracal so ya | |
| 14:59:15 | sean-k-mooney | right it was the other way around its only an issue after caracal but also not sure why we dont see this grenade | |
| 15:01:45 | melwitt | it happens due to the "fake" marker instance for that fill_virtual_interface_list online migration right ... so the grenade test wouldn't have that old of a migration artifact in its database | |
| 15:02:27 | melwitt | it would have to be a long lived deployment that has been upgraded over the years, IIUC | |
| 15:11:46 | sean-k-mooney | i guess i tought that marker was adde by the older migration | |
| 15:11:48 | sean-k-mooney | but ok | |
| 15:14:06 | sean-k-mooney | its still a valid bug so it makes sesne to fix it on master in anycase | |
| 15:15:24 | melwitt | yes I think that is correct that the marker was added by the older migration (rocky => stein). I was trying to say that CI wouldn't show it bc CI would not ever have that old of a migration remnant in it | |
| 15:16:52 | melwitt | maybe i'm misunderstanding it, I guess you are saying the old migration still running today. I have to think about it more | |
| 15:17:45 | sean-k-mooney | i dont recall if alembic/sql aclahme in devstack is instcating the db directly from the model or if it apples the base schema and then runs the migrations | |
| 15:18:09 | sean-k-mooney | i thinink sqlalchemy-migrate may have done the latter | |
| 15:18:19 | sean-k-mooney | as i recall seeign devstack run migraitons locally in teh past | |
| 15:18:33 | sean-k-mooney | but i dont knwo if we skip that step in a normal install with alembic | |
| 15:18:39 | sean-k-mooney | and just create the db directly with the final state | |
| 15:19:04 | melwitt | ah ok I get what you mean | |
| 15:20:21 | sean-k-mooney | so we call migrtion.db_sync and pass the version wihc default to None | |
| 15:21:44 | sean-k-mooney | and that does an alembic upgrade https://opendev.org/openstack/nova/src/branch/master/nova/db/migration.py#L54-L94 | |
| 15:22:36 | sean-k-mooney | but we are not going to run the online data migration until the db is already at the latest revision | |
| 15:25:17 | sean-k-mooney | i guess if we have no cells at that point | |
| 15:25:19 | sean-k-mooney | https://opendev.org/openstack/nova/src/branch/master/nova/objects/virtual_interface.py#L186-L187 | |
| 15:25:24 | sean-k-mooney | we never enter that for loop | |
| 15:25:36 | sean-k-mooney | and if we never enter that loop we never set the fake marker instnace | |
| 15:25:47 | sean-k-mooney | https://opendev.org/openstack/nova/src/branch/master/nova/objects/virtual_interface.py#L284-L287 | |
| 15:26:44 | sean-k-mooney | so in a normal install you wont hit this problem, still not sure why greade wont | |
| 15:27:17 | sean-k-mooney | but proably not worth diging into | |
| 15:28:46 | melwitt | yeah :/ needs more brain power | |
| 15:31:26 | melwitt | unrelated to that, I just saw a new TestComputeGracefulShutdown func test failure in the openstack-tox-cover job https://16fdd6c48f9c26f8b19a-1184c5a69e25bd403bd8a2f61f3cbab7.ssl.cf2.rackcdn.com/openstack/424ac0a1e84d486eacd5fda46d788ab6/testr_results.html not sure if this is already represented in an open bug cc gmaan | |
| 15:38:08 | Uggla | Reminder: upstream meeting in ~20mn | |
| 15:52:15 | opendevreview | ribaudr proposed openstack/nova master: Add regression test for bug 2062523 https://review.opendev.org/c/openstack/nova/+/1001185 | |
| 15:52:15 | opendevreview | ribaudr proposed openstack/nova master: fix: preserve task_state during evacuation to prevent race https://review.opendev.org/c/openstack/nova/+/1001186 | |