| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2026-08-04 | |||
| 14:19:49 | sean-k-mooney | I found no unpatched access to /sys/module/kvm_amd/parameters/sev in the current checkout. | |
| 14:19:51 | sean-k-mooney | - nova/tests/fixtures/libvirt.py:2727 forces the SEV parameter to appear absent in LibvirtFixture. | |
| 14:19:53 | sean-k-mooney | - SEV-specific tests explicitly patch os.path.exists and open. | |
| 14:19:55 | sean-k-mooney | - SysFsPoisonFixture raises if a unit test actually opens an unmocked /sys path. | |
| 14:19:57 | sean-k-mooney | Validation: | |
| 14:19:59 | sean-k-mooney | - test_driver: 1,186 tests passed | |
| 14:20:01 | sean-k-mooney | - test_host: 127 tests passed | |
| 14:20:03 | sean-k-mooney | One unrelated potential typo exists: the fixture patches sev-es, while the production path is sev_es. | |
| 14:20:23 | sean-k-mooney | tkajinam: ^ | |
| 14:23:01 | sean-k-mooney | im checkign what that actully is now but also in an irc meeting | |
| 14:24:36 | sean-k-mooney | clif: just to confirm were the fialing teest sev specific or unrelated | |
| 14:24:59 | opendevreview | Dr. Jens Harbott proposed openstack/nova master: DNM: Test unit tests on kvm https://review.opendev.org/c/openstack/nova/+/999729 | |
| 14:25:43 | frickler | sean-k-mooney: one test was nova.tests.unit.virt.test_virt_drivers.LibvirtConnTestCase.test_unplug_vifs_with_destroy_vifs_true , doesn't look related to me | |
| 14:25:45 | sean-k-mooney | we may have mocked it in all the sev paths an missed it in the genric tests paths | |
| 14:25:54 | sean-k-mooney | ack | |
| 14:29:40 | opendevreview | Dr. Jens Harbott proposed openstack/nova master: DNM: Test unit tests on kvm https://review.opendev.org/c/openstack/nova/+/999729 | |
| 14:31:39 | clif | sean-k-mooney: every test failure I still have in traceback is failing due to the SEV exception | |
| 14:31:54 | clif | I can re-run and save all output | |
| 14:36:51 | clif | https://gist.github.com/ClifHouck/b7186501897e8276afcc9a7827e21789 here's a full traceback of one error | |
| 14:38:54 | clif | yep, I get 217 failures and they're all due to this SEV exception | |
| 14:41:42 | frickler | ok, my test triggers the same failures. maybe add that permanently at least as experimental or periodic job? | |
| 14:42:31 | frickler | https://zuul.opendev.org/t/openstack/build/1af158b6480d4783b0211c4f4d890fed | |
| 14:45:23 | tkajinam | ohhk let me check that | |
| 14:46:54 | sean-k-mooney | frickler: ok so its related to kvm? | |
| 14:48:01 | frickler | either that or it is the mad cpu and we only have that in vexxhost, not 100% sure yet | |
| 14:48:53 | clif | I assume this check is only triggered if an amd cpu is detected | |
| 14:49:43 | sean-k-mooney | clif: yes the exact check is complicated as we are also checking if libvirt has supprot too | |
| 14:50:11 | tkajinam | I suspect that there are something patched properly in the tests which eventually let the driver code to read that path | |
| 14:50:18 | tkajinam | I've not yet identified that yet though | |
| 14:52:29 | sean-k-mooney | File "/home/zuul/src/opendev.org/openstack/nova/nova/virt/libvirt/driver.py", line 7913, in _get_mem_encryption_config | |
| 14:52:31 | sean-k-mooney | if not self._host.supports_mem_encryption: | |
| 14:52:42 | sean-k-mooney | so that the trigger right | |
| 14:52:53 | sean-k-mooney | _get_guest_config | |
| 14:53:03 | sean-k-mooney | is calling _get_mem_encryption_config | |
| 14:53:16 | sean-k-mooney | whic eventully calls the sev check | |
| 14:53:24 | sean-k-mooney | but that happing alwasy now | |
| 14:54:04 | sean-k-mooney | so a way to fix this is in the libvirt fixutre alwasy mock _kernel_supports_amd_sev | |
| 14:54:14 | sean-k-mooney | and save it in self | |
| 14:54:26 | sean-k-mooney | then you can set the return value as needed in the sev tests | |
| 14:55:30 | sean-k-mooney | most unit test shoudl not get as far as calling _kernel_supports_amd_sev but if they do just returning False by defualt shoudl be fine | |
| 14:55:56 | sean-k-mooney | and you can either disbale the mockign with a class var or save the refence to the mock so you can modify it for the test that do | |
| 14:57:30 | sean-k-mooney | https://github.com/openstack/nova/blob/39dc667a1f9a7c12814f5892b900462560b1a229/nova/virt/libvirt/host.py#L2097 | |
| 14:57:35 | sean-k-mooney | i think that is the new call | |
| 14:57:43 | sean-k-mooney | added in https://github.com/openstack/nova/commit/7dd0d6106bdcf9babb81d7b55fd775b543a6e9ad | |
| 15:02:12 | sean-k-mooney | tkajinam: https://github.com/openstack/nova/commit/7dd0d6106bdcf9babb81d7b55fd775b543a6e9ad#diff-319aeacd4767563ecfa85b0690ccb4dfbdc9ce39173d08058f14cdce764c5040L2728-L2741 | |
| 15:02:32 | sean-k-mooney | so actully it this fixutre change i think | |
| 15:03:30 | sean-k-mooney | the libvirt fixure used ot alwasy mock the calls to read those files | |
| 15:04:47 | sean-k-mooney | self.useFixture(fixtures.MonkeyPatch('os.path.exists', fake_exists)) was overlly broad | |
| 15:05:01 | sean-k-mooney | but you can do a much more targeted mock in the same place | |
| 15:06:32 | sean-k-mooney | self.kernel_sev = self.useFixture(fixtures.MockPatch('nova.virt.libvirt.host.Host._kernel_supports_amd_sev', return_value=False).mock | |
| 15:30:44 | tkajinam | sean-k-mooney, I avoided that fixture in the base class so that I don't have to un-patch it later in test cases where these should be detected properly, but I may have to recheck that approach. | |
| 15:31:28 | tkajinam | but I have to revisit that approach, I agree | |
| 15:31:52 | sean-k-mooney | you wont need to unpatch it just modify the mock that is saved in self | |
| 15:32:13 | sean-k-mooney | but ya i get the intent of remvoign the broad mock | |
| 15:40:05 | tkajinam | yup | |
| 15:41:07 | tkajinam | I'm too tired to dig into it now but will take a further look tomorrow. | |
| 15:41:52 | tkajinam | I guess open is not triggered in intel machine with kvm due to absence of that path (and os.path.exists is not poison-pilled | |
| 16:10:10 | opendevreview | Joan Gilabert proposed openstack/nova master: Report OWNER_NOVA trait on resource providers https://review.opendev.org/c/openstack/nova/+/994299 | |
| 16:10:10 | opendevreview | Joan Gilabert proposed openstack/nova master: Add libvirt driver MDEV ARQ support for Cyborg https://review.opendev.org/c/openstack/nova/+/995840 | |
| 16:11:54 | opendevreview | Elod Illes proposed openstack/nova stable/2025.1: [stable-only] Set skip-level grenade as voting https://review.opendev.org/c/openstack/nova/+/999742 | |
| 16:58:06 | gmaan | gibi: did you see me reply on thread pool executor unifying idea, https://review.opendev.org/c/openstack/nova/+/998571/comment/23f68a57_21843d10 | |
| 16:58:31 | gmaan | i mentioned 3 options to unify those, if you can check and which one is more alligned with what you are thinking about iut | |
| 18:44:14 | opendevreview | Joan Gilabert proposed openstack/nova master: Report OWNER_NOVA trait on resource providers https://review.opendev.org/c/openstack/nova/+/994299 | |
| 18:44:14 | opendevreview | Joan Gilabert proposed openstack/nova master: Add libvirt driver MDEV ARQ support for Cyborg https://review.opendev.org/c/openstack/nova/+/995840 | |
| 19:48:53 | opendevreview | Sebastian Krott proposed openstack/nova master: conductor: Clean up port-bindings for live migrations https://review.opendev.org/c/openstack/nova/+/978121 | |
| 19:48:54 | opendevreview | Sebastian Krott proposed openstack/nova master: network: Add host filtering to `cleanup_instance_network_on_host` https://review.opendev.org/c/openstack/nova/+/978122 | |
| 21:37:14 | opendevreview | Merged openstack/nova master: Stabilize test_failed_count_with_anti_affinity_violation https://review.opendev.org/c/openstack/nova/+/998001 | |
| 21:39:24 | opendevreview | Merged openstack/nova master: (2/2)Stabilize test_create_images_negative_invalid_state https://review.opendev.org/c/openstack/nova/+/997719 | |
| 23:08:20 | opendevreview | Goutham Pacha Ravi proposed openstack/nova master: DNM: Add virtiofs share attachment CI jobs https://review.opendev.org/c/openstack/nova/+/999772 | |
| #openstack-nova - 2026-08-05 | |||
| 03:12:00 | opendevreview | Goutham Pacha Ravi proposed openstack/nova master: DNM: Add virtiofs share attachment CI jobs https://review.opendev.org/c/openstack/nova/+/999772 | |
| 03:12:30 | opendevreview | Goutham Pacha Ravi proposed openstack/nova master: DNM: Add virtiofs share attachment CI jobs https://review.opendev.org/c/openstack/nova/+/999772 | |
| 04:15:10 | opendevreview | Takashi Kajinami proposed openstack/nova master: Stub kernel support check of AMD-SEV in tests https://review.opendev.org/c/openstack/nova/+/999780 | |
| 04:16:00 | opendevreview | Dr. Jens Harbott proposed openstack/nova master: DNM: Test unit tests on kvm https://review.opendev.org/c/openstack/nova/+/999729 | |
| 04:26:32 | opendevreview | Takashi Kajinami proposed openstack/nova master: DNM: Test unit tests on kvm https://review.opendev.org/c/openstack/nova/+/999729 | |
| 04:55:43 | opendevreview | Goutham Pacha Ravi proposed openstack/nova master: DNM: Add virtiofs share attachment CI jobs https://review.opendev.org/c/openstack/nova/+/999772 | |
| 04:56:57 | opendevreview | Goutham Pacha Ravi proposed openstack/nova master: DNM: Add virtiofs share attachment CI jobs https://review.opendev.org/c/openstack/nova/+/999772 | |
| 06:18:29 | opendevreview | Takashi Kajinami proposed openstack/nova master: Stub kernel support check of AMD-SEV in tests https://review.opendev.org/c/openstack/nova/+/999780 | |
| 06:18:30 | opendevreview | Takashi Kajinami proposed openstack/nova master: DNM: Test unit tests on kvm https://review.opendev.org/c/openstack/nova/+/999729 | |
| 07:26:05 | opendevreview | Takashi Kajinami proposed openstack/nova master: Stub kernel support check of AMD-SEV in tests https://review.opendev.org/c/openstack/nova/+/999780 | |
| 07:26:06 | opendevreview | Takashi Kajinami proposed openstack/nova master: DNM: Test unit tests on kvm https://review.opendev.org/c/openstack/nova/+/999729 | |
| 07:32:44 | gibi | gmaan: re threadpool, not yet, I will try to get to it today but there are higher prio things in front of it at the moment | |
| 07:40:50 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: check tempest for instability https://review.opendev.org/c/openstack/nova/+/999378 | |
| 07:43:05 | bauzas | gibi: may I gently ask you for a short +W ? https://review.opendev.org/c/openstack/nova/+/999607 | |
| 07:44:56 | gibi | bauzas: done. Have you checked if a failing post copy live migration in this case leaves the instance on the source node in ACTIVE state and we leak nothing on the dest node? | |
| 07:45:36 | bauzas | gibi: at least I saw that by the tempest whitebox test, the instance is back to the source | |
| 07:45:47 | bauzas | https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/939498 | |
| 07:46:24 | gibi | OK, thanks | |
| 07:46:55 | bauzas | but I'll verify whether the instance is back ACTIVE for sure | |
| 07:51:29 | opendevreview | Kamil Sambor proposed openstack/nova master: libvirt: retry get_guest() on InstanceNotFound during post-copy VIF reattach https://review.opendev.org/c/openstack/nova/+/997380 | |
| 08:07:35 | mattcrees | Good morning! Would anyone be free to give me another review of my bugfix? https://review.opendev.org/c/openstack/nova/+/982660 | |
| 09:07:30 | opendevreview | Takashi Kajinami proposed openstack/nova master: Stub kernel support check of AMD-SEV in tests https://review.opendev.org/c/openstack/nova/+/999780 | |
| 09:07:30 | opendevreview | Takashi Kajinami proposed openstack/nova master: DNM: Test unit tests on kvm https://review.opendev.org/c/openstack/nova/+/999729 | |
| 09:33:40 | opendevreview | Takashi Kajinami proposed openstack/nova master: Stub kernel support check of AMD-SEV in tests https://review.opendev.org/c/openstack/nova/+/999780 | |
| 09:33:40 | opendevreview | Takashi Kajinami proposed openstack/nova master: DNM: Test unit tests on kvm https://review.opendev.org/c/openstack/nova/+/999729 | |
| 09:34:09 | tkajinam | hmm I was able to fix unit tests but am struggling to fix functional tests. I don't know why that patching of update_provider_tree is ignored ... | |
| 09:40:47 | opendevreview | Merged openstack/nova master: doc: Document postcopy incompatibility with vGPU live migration https://review.opendev.org/c/openstack/nova/+/999607 | |
| 11:06:54 | opendevreview | Merged openstack/osc-placement master: tox: Fix outdated functional test environments https://review.opendev.org/c/openstack/osc-placement/+/998825 | |
| 11:08:17 | opendevreview | Elod Illes proposed openstack/nova stable/2025.1: [stable-only] Set skip-level grenade as voting https://review.opendev.org/c/openstack/nova/+/999742 | |
| 11:14:48 | opendevreview | Merged openstack/osc-placement master: [tox] Use constraints for requirements in docs job https://review.opendev.org/c/openstack/osc-placement/+/998816 | |
| 11:16:38 | opendevreview | Merged openstack/osc-placement master: reno: Update master for unmaintained/2024.1 https://review.opendev.org/c/openstack/osc-placement/+/965495 | |