Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2026-06-23
16:55:32 opendevreview Takashi Kajinami proposed openstack/nova master: libvirt: Ignore SEV-ES when SEV-SNP is detected https://review.opendev.org/c/openstack/nova/+/994343
17:01:51 sean-k-mooney gmaan: oh cool
17:02:09 sean-k-mooney looks pretty mechnaical
17:02:45 sean-k-mooney while while somewhat tedious to review is at elast not overly compex
17:03:01 opendevreview Lajos Katona proposed openstack/nova master: Add regression test to repoduce bug 1854844 https://review.opendev.org/c/openstack/nova/+/991772
17:04:12 sean-k-mooney im slightly suprised the nova change depens on the placment one but i guess that is down to the fixture?
17:08:27 gmaan sean-k-mooney: I think yes, somewhere it was failing and I need to do placement one first
17:14:39 sean-k-mooney i am sumwhat suprised that we need to update teh gabit tests
17:15:11 sean-k-mooney specific for system scoped rp creation
17:15:41 sean-k-mooney given i was not expecting system scoped roels to really be valid based on https://github.com/openstack/placement/blob/master/placement/policies/resource_provider.py
17:16:37 sean-k-mooney given admin or service is "role:admin or role:service"
17:17:02 sean-k-mooney but i guess when scope enforcment is disabeld we are merging system and doamin roels into the set of token roles?
17:17:44 sean-k-mooney gmaan: basiclly im asking did we change the behvior or was gabbi just not emululatign this properly
17:18:21 sean-k-mooney for this change https://review.opendev.org/c/openstack/placement/+/987568/4/placement/tests/functional/gabbits/aggregate-legacy-rbac.yaml#55
17:19:00 gmaan sean-k-mooney: yes, it is same as nova test change. the update is to the tests which were testing scope disable and system_admin can do the things
17:20:09 gmaan sean-k-mooney: those are needed to create the resource for other tests like update test, for example $ENVIRON[[RP_UUID]
17:20:25 gmaan previously system_admin was allowed in those tests and it created the resouce
17:20:51 gmaan i thought of remove the legacy tests but till we have the legacy policy, we should keep them tested
17:23:31 gmaan Basically, it remove the scope disable tests and update a few that were dependent on the test resource creation by scope disable tests
17:36:25 opendevreview Takashi Kajinami proposed openstack/nova master: compute: Validate SEV/SEV-ES support at start up https://review.opendev.org/c/openstack/nova/+/994342
17:36:25 opendevreview Takashi Kajinami proposed openstack/nova master: libvirt: Ignore SEV-ES when SEV-SNP is detected https://review.opendev.org/c/openstack/nova/+/994343
17:36:26 opendevreview Takashi Kajinami proposed openstack/nova master: Fix wrong mock for properties https://review.opendev.org/c/openstack/nova/+/994505
17:36:26 opendevreview Takashi Kajinami proposed openstack/nova master: Drop dependency on [libvirt] num_memory_encrypted_guests https://review.opendev.org/c/openstack/nova/+/994506
18:37:01 opendevreview Sahana proposed openstack/nova master: compute: remove redundant exception args from LOG.exception calls https://review.opendev.org/c/openstack/nova/+/994522
18:57:19 opendevreview melanie witt proposed openstack/nova master: Add non-voting IPv6 ceph live migration job https://review.opendev.org/c/openstack/nova/+/984623
19:12:25 opendevreview melanie witt proposed openstack/nova master: Add non-voting IPv6 ceph live migration job https://review.opendev.org/c/openstack/nova/+/984623
19:31:08 gmaan frickler: melwitt this will fix the nova-ceph-multistore job on 2024.1, we cna see devstack-plugin-ceph-tempest-py3 passing there https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/994503
19:32:10 gmaan but it seems gate is broken for doc job there so I am leaving this until someonw fix the gate. cannot spend more time on those. That is one of the reason i try not to touch unmaintained branches as they need lot of gate fixes before one merge :)
19:32:56 gmaan CC: elodilles just to make you aware about ceph job fix
19:49:27 frickler gmaan: thanks, I can try to look at the docs issue. and yes I can understand your reluctance, thx for checking this anyhow
19:57:03 melwitt gmaan: ah makes sense
20:01:42 opendevreview Merged openstack/nova master: move compile earlier https://review.opendev.org/c/openstack/nova/+/950516
20:08:38 opendevreview melanie witt proposed openstack/nova master: Add non-voting IPv6 ceph live migration job https://review.opendev.org/c/openstack/nova/+/984623
20:12:19 erlon sean-k-mooney: hey Sean, can you take a look in the RBD fix we discuss the other day? See if thats how you wanted the regression tests, please let me know if I'm missing anything: https://review.opendev.org/c/openstack/nova/+/974032
20:14:22 sean-k-mooney erlon: yes i started lookign at that elaire today
20:14:30 sean-k-mooney i have the regression test open i na tab somewhere
20:16:21 sean-k-mooney erlon: lookign at ti brifly yes it looks more or less correct ill try and review it proeprly but probaly tomorrow
20:16:34 erlon nice, thanks
20:17:48 sean-k-mooney i see melwitt updated https://review.opendev.org/c/openstack/nova/+/984623/21 as well so we shoudl get som new reuslt of the ipv6 test in a few hours
20:19:35 melwitt yeah fingers crossed it doesn't run into another issue. this is the first time I try it with depends-on patches proposed to the proper repos. last fail was for database host using ipv4 address. I'll keep iterating on it
20:25:06 sean-k-mooney is there a reason you made the ipv6 connectivity opt in instead of opt out?
20:25:27 sean-k-mooney we often have ipv6 in the jobs
20:25:40 sean-k-mooney even if its not the ipv6 job
20:25:55 sean-k-mooney we just dont use those adress for the services by default
20:25:55 melwitt no reason other than to keep existing behavior the same
20:26:01 sean-k-mooney ack
20:26:17 sean-k-mooney im not sure which is the better default i just said i would ask
20:26:28 sean-k-mooney incasue it was because you hit a bug or something i was not aware of
20:26:59 melwitt oh yeah. not yet anyway haha
20:27:54 sean-k-mooney so if you respin you might want to mention ipv6 in the readme for that roles https://opendev.org/zuul/zuul-jobs/src/commit/6c0c643b8cffa1f61cf7af34f29d8a7e4d1bb114/roles/multi-node-bridge/README.rst
20:29:26 sean-k-mooney melwitt: they do not use molecule in that repo
20:29:32 sean-k-mooney but you may also want to exted https://opendev.org/zuul/zuul-jobs/src/commit/6c0c643b8cffa1f61cf7af34f29d8a7e4d1bb114/test-playbooks/multinode/multi-node-bridge.yaml
20:29:42 sean-k-mooney to test the ipv6 functionlatiy
20:30:02 sean-k-mooney but i dont really review code in that repo oftent so im not sure what the normal expecation are
20:30:06 melwitt good point, I didn't know about those
20:31:10 sean-k-mooney fungi and clarkb are inovled so i knwo there woudl be tests but i am not very familar with how they are setup but i guess this is just usign zuul to run the test playbooks directly
20:31:57 sean-k-mooney looks like tey are using tox and unittest to run them at a quick glance
20:32:26 sean-k-mooney although that may just be for the inline moduels
20:32:59 fungi yeah, clarkb can probably explain it better since he wrote a lot of it, but the idea initially was to have an abstract foundation for multi-node devstack jobs to build on
20:34:11 sean-k-mooney fungi: for the most part it works quite well. fungi context is melaine is adding supprot for multi node ipv6
20:34:23 fungi in particular, avoiding dependence on the network topology available to the test nodes themselves and setting up an encapsulated layer 2 network between them that would provide consistency
20:34:23 sean-k-mooney so we can test live mgiration with ipv6 ceph
20:35:13 fungi just to be clear, you want to tunnel v6 over the bridge (that shouldn't be a problem but maybe we baked in assumptions)
20:36:25 sean-k-mooney fungi: yep that the idea. melwitt has some devstack josb mostly workign with pre-playbooks in nova and is now tryign to do it properly in zuul-jobs and devstack
20:38:47 melwitt with barely any knowledge 😩 it just failed again. obviously I must have lost something while splitting out from the pre-playbooks into zuul-jobs. will have to figure this out
20:39:24 fungi right, afaik we didn't want that role to restrict what kind of traffic you can send over it, modulo obvious mtu adjustments
20:39:32 sean-k-mooney you may need to set bridge_configure_ipv6_address: true in the subnodes as well
20:39:50 sean-k-mooney https://review.opendev.org/c/openstack/nova/+/984623/21/.zuul.yaml#416
20:39:52 fungi also i think there may be some limitations or at least limitations carrying broadcast and multicast traffic on it
20:40:07 sean-k-mooney fungi: its using vxlan
20:40:08 fungi er, or at least inefficiencies
20:40:10 sean-k-mooney so it shoud be fine
20:40:21 sean-k-mooney ya its a partial mesh using ovs
20:40:44 sean-k-mooney so all multicast becoms bradcast which si copied intrenlly t o all spokes in the mesh
20:40:51 fungi i think vxlan relies on multicast groups underneath to carry broadcasts though? and our cloud providers don't let the multicast traffic through
20:40:57 sean-k-mooney so its a littele inefficnet but it shoudl work
20:41:02 fungi ah okay
20:41:06 sean-k-mooney fungi: not with ovs
20:41:11 sean-k-mooney but with linux bridge yes
20:41:17 sean-k-mooney ovs only supprot unicast tunnels
20:41:28 fungi you are far more familiar with all of this than i am
20:41:46 sean-k-mooney but that actully makes it more portable since you do not rely on the cloud provdier supproting multicast grouping at the fabic level
20:42:21 fungi all i can really say is afaik we didn't intentionally omit support for sending ipv6 packets over the bridge, so if it's not working i'd consider that a bug worth fixing
20:42:25 sean-k-mooney it comes form addign ovs-dpdk suppreot neutron/nova and maintianing it for years:)
20:42:43 melwitt sean-k-mooney: oh yeah, that makes sense. in pre, I was doing it for hosts: all but didn't put under both
20:43:39 fungi `hosts: all` should run the same task on every test node (but not the zuul executor, which needs `hosts: localhost` instead, not really relevant to this playbook anyway)
20:45:57 sean-k-mooney fungi: i have also impletend my own version fo the role 2 before although the most recent version i got ai to do :)
20:46:28 sean-k-mooney fungi: https://github.com/SeanMooney/ard/tree/master/ansible/roles/ard_multinode_bridge does basically the same thign but it uses linux bridge and gre tunnels to avoid installign ovs
20:46:57 sean-k-mooney i used to just use the zuul jobs one
20:48:19 sean-k-mooney im not entrily sure im happy with how the new version works but i was tryign to make it compatiabe with our operator based isntaller and i dint want to fight with its installation and management of ovs
20:49:54 sean-k-mooney that fact that ovs survies reboot makes the ovs based approch we use upstream less complex in many ways
20:56:19 sean-k-mooney my the way the mtu caluation does have to be adjuscted for ipv6 but the role aslready subtratc 70 bytes which si enough to have ipv6 geneve trafic go over the bridge
20:56:23 sean-k-mooney melwitt: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/multi-node-bridge/tasks/common.yaml#L103-L139
20:58:00 melwitt hm ok
20:59:17 sean-k-mooney techinaly the 70 bytes of overad is the bare minium for geneve to work over the bridge
20:59:25 sean-k-mooney and it shoudl work for neutron in general
20:59:57 clarkb its not geneve its vxlan iirc
21:00:02 clarkb and that is why there isn't ipv6
21:00:04 sean-k-mooney i use a 100 byte safty buffer in my verions
21:00:07 fungi sean-k-mooney: yeah, we originally used gre i believe, but it isn't allowed in all out providers

Earlier   Later