Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2026-04-16
13:42:40 sean-k-mooney im talkign about the ci jobs
13:43:07 dansmith gibi: sounds like this was an interesting diversion but that led to some understanding about why we're hitting this in tests only and that production should be good yeah?
13:43:14 sean-k-mooney and as i noted in the reivew tox installs a seperve version of tox in a venv and uses htat if the min veriosn is above our current one
13:43:50 sean-k-mooney s/our current one/ the one that is locally installed/
13:44:06 bauzas I'm doublechecking but I'm almost sure we have somewhere in our docs that says we should use tox 3.x
13:44:38 bauzas of course that's a legacy doc with 4.x but if that's on the nova doc, I'd want to be consistent
13:45:20 bauzas and again, the fact that we bump to 4.x is understandable but I just say we should say it way louder than just a file change to tox.ini
13:45:23 sean-k-mooney devstack does seam to insall na older version but i dont think that is what our tox jobs do but ill doubel check
13:46:04 bauzas thanks
13:46:16 sean-k-mooney https://opendev.org/zuul/zuul-jobs/commit/bda76ac8bb30bb8d8c24552194038db0ff5e6255
13:46:24 sean-k-mooney ok so it was pinend but that was removed a year ago
13:46:42 sean-k-mooney oh no 4 years ago https://opendev.org/zuul/zuul-jobs/commit/13925d1965aa5658304c9ca88fb0307d6cff2eff
13:46:46 bauzas again, I'm not opposed to the change, I just want us to be careful and explaining about the bump (a reno would be nice)
13:46:53 sean-k-mooney yep
13:46:58 sean-k-mooney i agree on the release note
13:47:26 stephenfin renos are for end-users/operators. This is developer-focused. I don't believe we should document this in release note
13:47:36 sean-k-mooney https://opendev.org/openstack/openstack-zuul-jobs/src/branch/master/zuul.d/jobs.yaml#L24
13:47:46 sean-k-mooney stephenfin: it has an implciation for packageser
13:48:04 sean-k-mooney so the other secion could be approrpate
13:48:08 stephenfin how?
13:48:20 sean-k-mooney i dont think it needs to be in upgrade
13:48:45 sean-k-mooney stephenfin: well i guess it depend on how they run unit test but your probly right that it does not actully
13:48:56 sean-k-mooney they are likely runing them directly
13:49:20 bauzas yeah, that's for an other section IMHO
13:49:23 sean-k-mooney sicne they woudl not want to use deps form pypi in the rpm/deb test execution
13:50:15 stephenfin yeah, I'd be shocked if they were running tox rather than stestr directly (if I recall correctly, RDO spec files were still using os-testr for at least some projects)
13:50:45 sean-k-mooney stephenfin: so you need tox 4.28.0 adn our ci is currently caped at 4.48
13:51:05 sean-k-mooney so we shoudl be testign with a version that suprot it today
13:54:37 stephenfin so do I need a release note? I don't think it makes sense but if it'll help smooth the path to getting this in I can do so
13:56:10 dansmith TBH, a reno for this seems odd to me
13:56:40 sean-k-mooney im ok without one but im fine if other wnat it
13:57:02 sean-k-mooney as you said its mainly a devleoper chnge so other is the only place that seam reasonable if we have one
13:57:15 bauzas okay, then if no reno, we should then mention that in our contrib docs
13:57:18 dansmith I don't see any other tox or unit test related stuff in our renos (from a dumb grep)
13:57:23 sean-k-mooney i just removed my +2 to allow htat converstaion to happen without it there
13:57:25 dansmith contributor docs makes a lot more sense
13:58:11 dansmith we have development-environment.rst which talks about pip installing tox, so that seems like an appropriate place
13:58:25 bauzas we have https://github.com/openstack/nova/blob/master/doc/source/contributor/development-environment.rst
13:58:32 bauzas ah jinxed
13:58:46 bauzas stephenfin: fancy amending this ?
13:58:52 sean-k-mooney stephenfin: the actual thing i think would be more imporant to fix is figure out why devstack is capped to 3.x when our tox jobs are not. and get those in sync so that folks that use tox provdied by there devstack install have somethign less old...
13:59:13 opendevreview Kamil Sambor proposed openstack/nova master: Enable threading mode for proxy services https://review.opendev.org/c/openstack/nova/+/976089
13:59:13 dansmith sean-k-mooney: might have been for grenade or testing older distros at some point
13:59:35 stephenfin sean-k-mooney: it's pinned for tempest. From my message earlier:
13:59:36 sean-k-mooney dansmith: ya i suspect its from when we supproted jammy
13:59:51 stephenfin 14:16 stephenfin That and tempest, which is relying on the shared venv thing that doesn't work in tox 4.x (I've been working on fixing that in the background) but this doesn't affect nova itself
13:59:57 sean-k-mooney stephenfin: oh because of the venv thing?
14:00:01 sean-k-mooney ok
14:00:01 stephenfin yeah
14:00:07 dansmith sean-k-mooney: I run 4.4 on jammy, but.. something earlier
14:00:33 stephenfin but that (a) is huge tech debt we really need to fix and (b) doesn't affect nova's use of tox
14:01:27 sean-k-mooney stephenfin: my new thoery is hte hardwrae where i sometimes(often) have the log setup time in tox is just cursed
14:02:27 gibi dansmith: > led to some understanding about why we're hitting this in tests only and that production should be good yeah? | yeah I think I see now why this cannot happen in production
14:02:28 sean-k-mooney nova full unit test sqiute shoudl not exectue in less time then buildign the venv to run it in... py3: OK (508.14=setup[284.11]+cmd[193.47,23.86,6.70] seconds)
14:02:47 dansmith gibi: ack, well, sorry for the goose chase, but I feel better :)
14:03:25 stephenfin bauzas: Can do. What will that look like? I'd rather not duplicate what's in tox.ini in our docs since they're liable to drift, so maybe I can just say you need at least tox 4.x available (since it'll bootstrap itself if it needs a newer version)?
14:03:30 gibi dansmith: don't feel bad about it. Your question actually lead to a deeper understanding of the situation
14:03:31 stephenfin s/will/should/
14:03:55 bauzas gibi: dansmith: I hadn't yet reviewed, but thanks for the discussion, I'll look at the patch
14:04:46 gibi dansmith: the next similar area I want to understand more is the CellDatabases fixture that implements some weird routing of DB connections via hooking into the target_cell call
14:05:03 bauzas stephenfin: there are two problems to solve here : 1/ documenting the fact that in Hibiscus, we bumped to 4.28.0 (should be easy addition to dev-env.rst), 2/ before merging the patch, making sure that we don't create devstack problems
14:05:18 dansmith gibi: ack, there are some acrobatics in there for sure
14:06:48 stephenfin (2) isn't an issue and will be confirmed by CI and the fact that other projects have already done see (e.g. ironic https://github.com/openstack/ironic/blob/master/tox.ini#L2)
14:07:22 stephenfin I can also walk through how tempest is (wrongly) using tox and why it depends on tox 3.x, but my WIP patches probably explain it better
14:08:10 stephenfin https://review.opendev.org/q/topic:%22rework-tempest-install%22+is:open
14:08:23 sean-k-mooney ~/repos/nova-2$ tox -e py3 -r
14:08:25 sean-k-mooney .tox create: /home/debian/repos/nova-2/.tox/.tox
14:08:27 sean-k-mooney .tox installdeps: tox >= 4.28.0
14:08:33 sean-k-mooney so that usign the tox provided by devstack
14:08:39 sean-k-mooney on stephenfin's patch
14:08:56 sean-k-mooney so the pone we have pinned it too has the supprot to bootstracp to the requried version if needed
14:09:10 sean-k-mooney im waiting for that to complete
14:12:20 bauzas there are a long list of projects that still have 3.18.0 as minimum https://codesearch.openstack.org/?q=minversion%20%3D&i=nope&literal=nope&files=tox.ini&excludeFiles=
14:12:41 bauzas again, I'm not opposed to the upgrade, I just want us to be careful
14:13:33 bauzas my life didn't change when I upgraded to 4.x apart the fact I stupidely forget every day that I need to add doubledashes on posargs :)
14:15:22 dansmith I've been using 4.x for a long time and I still do that :)
14:19:33 stephenfin bauzas: Hmm, this dev-env doc is pretty old 😅 It references RHEL 6 and easy_install 🙈
14:19:56 sean-k-mooney ya...
14:20:00 stephenfin I'm happy to rewrite it, but can I stick it in a follow-up since I suspect it'll need a few rounds of review
14:20:15 sean-k-mooney that compelte fien by the way py3: OK (478.49=setup[271.33]+cmd[181.72,18.91,6.54] seconds)
14:21:01 sean-k-mooney so the bootstrap and execution works end ot end with the tox provided by devstack
14:21:43 sean-k-mooney without impact the actul tox version that devstack provides
14:21:46 sean-k-mooney tox --version
14:21:48 sean-k-mooney 3.28.0 imported from /opt/stack/data/venv/lib/python3.13/site-packages/tox/__init__.py
14:34:27 stephenfin sean-k-mooney: the dev-env doc references fake compute. That's not a thing any more, right?
14:34:37 sean-k-mooney yes it is
14:34:51 sean-k-mooney we are using them to test teh eventlet removeal with rally
14:35:11 stephenfin Oh, okay. I thought the fake driver was only used for functional tests
14:35:24 sean-k-mooney nope it can be used as a "real" driver
14:35:48 sean-k-mooney typeicly without networkign but there is technially a fake neturon driver too
14:36:40 sean-k-mooney https://github.com/openstack/devstack/blob/master/lib/nova_plugins/hypervisor-fake still works more or less
14:41:29 stephenfin TIL
14:58:07 opendevreview Stephen Finucane proposed openstack/nova master: docs: Update development-environment guide https://review.opendev.org/c/openstack/nova/+/984956
14:58:13 stephenfin bauzas: sean-k-mooney: ^
14:58:31 stephenfin dansmith: you might tell me if the (minimal) macOS instructions are correct (I've no way to verify)
14:59:57 dansmith stephenfin: ack, joining a call but will look async
15:00:04 stephenfin ty 🙏
16:31:09 Uggla gibi, fyi regarding bug https://bugs.launchpad.net/nova/+bug/2145783 found in the spec : While it would possible to support defining different resource_class names for different VFs under the same parent PF, this is considered bad practice and unnecessary complexity. Such configuration will be rejected.
16:31:10 Uggla https://specs.openstack.org/openstack/nova-specs/specs/zed/approved/pci-device-tracking-in-placement.html
16:45:20 gibi Uggla: that sounds good at least it was outscope due to complexity not due to infeasibility

Earlier   Later