| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2026-03-09 | |||
| 17:28:13 | dansmith | ack Uggla let's punt, but I think this is a good one to track and nag people to look at as soon as H opens | |
| 17:29:24 | Uggla | dansmith 👍 | |
| 17:32:42 | stephenfin | sean-k-mooney: dansmith: if the question is about backporting migrations, if you're going back further than the release the last migration was added in, then you'll end up creating a branch https://alembic.sqlalchemy.org/en/latest/branches.html#working-with-branches | |
| 17:33:35 | dansmith | I don't want to backport this | |
| 17:33:51 | sean-k-mooney | stephenfin: it more how safe to we feel https://review.opendev.org/c/openstack/nova/+/958556 is and what its upgrade impact | |
| 17:33:54 | dansmith | I think sean-k-mooney's question was what happens if someone has manually done this or something | |
| 17:34:08 | sean-k-mooney | also that | |
| 17:34:40 | sean-k-mooney | the current patch does not have an upgrade release note and i suspect this will take some time to caluate the inde of there are a large number of rows | |
| 17:34:54 | dansmith | also true | |
| 17:34:56 | sean-k-mooney | i belive this will be appled as part of the db sync when we do the expand migritons | |
| 17:35:06 | dansmith | but if it's in the upgrade phase it should be pre-doable | |
| 17:35:11 | stephenfin | Well they're already out of support, but I believe you'll simply end up with a duplicate index with a different name | |
| 17:35:42 | stephenfin | it would be a 5 minute test if you'd a devstack to hand | |
| 17:35:49 | sean-k-mooney | stephenfin: basicly i was wondering if we fix this in master in 2026.2 | |
| 17:36:12 | sean-k-mooney | can operator "fix it themselve" by just creating the index on older rellease without breaking our upgrades | |
| 17:36:22 | sean-k-mooney | or will almebic be unhapply | |
| 17:36:39 | sean-k-mooney | if its just a duplcit index and it wont break future migration that proably ok | |
| 17:38:22 | sean-k-mooney | to be clear 2.264 sec to 0.006 sec for 500k rows is nice but for a perodic that runs every 5 minutes its not unworkable at 2.5seconds | |
| 17:38:32 | sean-k-mooney | defintly worth fixing on master however | |
| 17:38:50 | dansmith | I thought the claim was that this overwhelms conductors when you have a ton of nodes doing it | |
| 17:39:07 | dansmith | "NOTE: missing index for a query that gets regulary executed by every nova-compute node this can overwhelm the nova-conductor service in large scale deployments" | |
| 17:39:26 | dansmith | (from the etherpad, maybe should be copied into the bug) | |
| 17:39:26 | sean-k-mooney | oh its every 5 mintes per compute | |
| 17:39:30 | dansmith | yeah | |
| 17:39:44 | sean-k-mooney | ok that scaling diffently then i initally tought | |
| 17:39:59 | dansmith | and probably scales like n^2 almost because each compute doing it is scanning each other compute record that you ad | |
| 17:40:02 | dansmith | *add | |
| 17:40:04 | sean-k-mooney | although ya it makes sense this is per compute | |
| 17:41:04 | sean-k-mooney | we already have indexs on source_compute and dest_compute and source_node and dest node | |
| 17:41:07 | stephenfin | sean-k-mooney: I can't say, but we've never written our migrations on the assumption that the operator has manually hacked in their own migrations | |
| 17:41:20 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/958556/1/nova/db/main/models.py#895 | |
| 17:41:23 | stephenfin | so I'm not sure how this would be any different | |
| 17:41:52 | stephenfin | however, if they *had* done that, they can always dummy apply the migration using the stamp command | |
| 17:42:04 | sean-k-mooney | im actully surpised that a quey on teh subset is not coverd by htat | |
| 17:42:10 | stephenfin | https://alembic.sqlalchemy.org/en/latest/api/commands.html#alembic.command.stamp | |
| 17:42:45 | sean-k-mooney | stephenfin: well in the very old days we assumed the dba may create indexes ro set coalation types to optimise for there usecase | |
| 17:43:10 | sean-k-mooney | im not saying that a good thing just that it was a thing | |
| 17:43:31 | sean-k-mooney | the ops guided uses to have soem recomentions for adding indexes but that was eons ago | |
| 18:25:46 | dansmith | Uggla: the other volume bugs there are good things to fix, but I'm not sure in the best way.. I've left some comments | |
| 18:42:54 | opendevreview | Merged openstack/os-traits master: Remove MANIFEST.in https://review.opendev.org/c/openstack/os-traits/+/975992 | |
| 18:44:20 | opendevreview | Merged openstack/osc-placement master: Remove MANIFEST.in https://review.opendev.org/c/openstack/osc-placement/+/975984 | |
| #openstack-nova - 2026-03-10 | |||
| 07:25:33 | opendevreview | Max proposed openstack/nova master: fix: leftover volume_attachment on instance delete https://review.opendev.org/c/openstack/nova/+/934984 | |
| 08:00:17 | jkulik | gibi, when you find some time, could your provide feedback to https://review.opendev.org/c/openstack/nova-specs/+/975698 ? it's a proposal to fix the race-condition you mentioned in my recent volume-attachment changes | |
| 09:40:05 | opendevreview | Max proposed openstack/nova master: Add regression test for bug #2139135 https://review.opendev.org/c/openstack/nova/+/974831 | |
| 09:40:06 | opendevreview | Max proposed openstack/nova master: fix: delete attachments after rescheduling delete https://review.opendev.org/c/openstack/nova/+/974832 | |
| 09:52:32 | opendevreview | Max proposed openstack/nova master: db: add indexes for source/dest migrations https://review.opendev.org/c/openstack/nova/+/958556 | |
| 10:28:08 | opendevreview | Sylvain Bauza proposed openstack/nova master: Support multiple allocations for vGPUs https://review.opendev.org/c/openstack/nova/+/845757 | |
| 10:54:51 | opendevreview | Seyeong Kim proposed openstack/nova master: libvirt: Support boot_index for multiple block devices https://review.opendev.org/c/openstack/nova/+/963665 | |
| 14:20:09 | opendevreview | Ashish Gupta proposed openstack/nova master: Run functional test with threading mode https://review.opendev.org/c/openstack/nova/+/979850 | |
| 15:04:10 | opendevreview | Merged openstack/nova master: Add regression test for bug #2088066 https://review.opendev.org/c/openstack/nova/+/965927 | |
| 15:11:39 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.1: Add functional reproducer for bug 2125030 https://review.opendev.org/c/openstack/nova/+/979864 | |
| 15:11:40 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.1: Move cleanup of vTPM secret from driver to compute https://review.opendev.org/c/openstack/nova/+/979865 | |
| 15:11:41 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.1: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/979866 | |
| 15:25:32 | dansmith | Uggla: your -1 is still on here from Feb: https://review.opendev.org/c/openstack/nova/+/972045/2 | |
| 15:25:52 | dansmith | I guess because you -1'd this patch for the thing on the one below, and since this one didn't change it didn't reset | |
| 15:44:06 | bauzas | gibi: melwitt: just a note that I updated https://review.opendev.org/c/openstack/nova/+/845757 by adding the bug report in the reno file | |
| 15:44:18 | bauzas | (and thanks for your reviews <3 ) | |
| 15:53:04 | MaxLamprecht[m] | dansmith: thx for review of the attachment stuff. During debugging I found 2 more things that are really small and broken: https://review.opendev.org/c/openstack/nova/+/973103 and https://review.opendev.org/c/openstack/nova/+/975651 | |
| 16:01:47 | Uggla | dansmith yep unfortunately you are right. It has not change since that time. | |
| 16:04:26 | dansmith | MaxLamprecht[m]: I'm about to get on a couple _hours_ of calls but will look closer at the second in in a bit | |
| 16:05:56 | gibi | bauzas: +2 | |
| 16:06:05 | bauzas | <3 | |
| 16:11:03 | MaxLamprecht[m] | dansmith: thx :) | |
| 16:12:16 | gibi | I just caugth up on the nova meeting logs from yesterday (slow me). I see that the SEV refactor is on hold until branch is open. That is OK for me. | |
| 18:20:32 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron networks https://review.opendev.org/c/openstack/nova/+/928022 | |
| 18:20:32 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron subnets https://review.opendev.org/c/openstack/nova/+/962190 | |
| 18:20:33 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron extensions https://review.opendev.org/c/openstack/nova/+/962270 | |
| 18:20:33 | opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron floating IPs https://review.opendev.org/c/openstack/nova/+/962604 | |
| 19:25:15 | melwitt | bauzas: cool thanks I will check the update | |
| #openstack-nova - 2026-03-11 | |||
| 00:55:45 | opendevreview | Merged openstack/nova stable/2025.2: Add functional reproducer for bug 2125030 https://review.opendev.org/c/openstack/nova/+/979041 | |
| 04:44:06 | opendevreview | Merged openstack/nova master: Support multiple allocations for vGPUs https://review.opendev.org/c/openstack/nova/+/845757 | |
| 08:05:33 | nicolairuckel | melwitt: Should I just abandon this https://review.opendev.org/c/openstack/nova/+/979866 and create a new one with the correct cherry-picks? | |
| 09:16:46 | opendevreview | Max proposed openstack/nova master: fix: orphaned attachments during migration delete https://review.opendev.org/c/openstack/nova/+/972045 | |
| 09:29:35 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.1: Add functional reproducer for bug 2125030 https://review.opendev.org/c/openstack/nova/+/979864 | |
| 09:29:36 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.1: Move cleanup of vTPM secret from driver to compute https://review.opendev.org/c/openstack/nova/+/979865 | |
| 09:29:37 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.1: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/979866 | |
| 09:55:06 | nicolairuckel | The gate fails with an sqlalchemy error for me: https://b49a1a6bd7022e637e55-03d448e06513a4e4bb78797852449f92.ssl.cf1.rackcdn.com/openstack/cf4f116365064c10b0f3e76c6db33568/testr_results.html I vaguely remember people here talking about some sqlalchemy stuff. Was that related to that? | |
| 09:55:56 | nicolairuckel | I ran the same command (tox -epy312-threading -vv --skip-missing-interpreters=false) locally without any errors. | |
| 10:34:04 | gibi | nicolairuckel: am I blind or that job should not even run that test case due to the known issue https://github.com/openstack/nova/blob/master/threading_unit_test_excludes.txt#L38 | |
| 10:42:14 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add functional tests for NUMA aware vswitches https://review.opendev.org/c/openstack/nova/+/979999 | |
| 10:45:08 | nicolairuckel | gibi: That test doesn't seem to be excluded for 2025.2 though. | |
| 11:02:28 | opendevreview | Thibaut Démaret proposed openstack/nova master: libvirt: add disk rotation_rate support for local disks https://review.opendev.org/c/openstack/nova/+/979693 | |
| 11:09:36 | gibi | I will investigate | |
| 11:10:59 | nicolairuckel | https://github.com/openstack/nova/blob/stable/2025.2/threading_unit_test_excludes.txt | |
| 11:24:42 | elodilles | sorry, i did not see the discussion and rechecked it, but at least nova-tox-py312-threading has passed now o:) | |
| 11:25:36 | gibi | OK so https://review.opendev.org/c/openstack/nova/+/953475 is in 2025.2 so the job expected to run that branch | |
| 11:25:50 | gibi | I guess there was a fix on the exclude list that was not backported to 2025.2 | |
| 11:26:40 | nicolairuckel | and 2025.1 if I see that correctly | |
| 11:27:34 | gibi | yepp https://review.opendev.org/c/openstack/nova/+/961781 this is missing from stable. I will do the backports | |
| 11:27:41 | nicolairuckel | thank you | |
| 11:27:50 | gibi | thanks for notifying | |
| 11:28:25 | gibi | nicolairuckel: I don't think the job should run on 2025.1 | |
| 11:28:30 | gibi | but let me double check | |
| 11:28:33 | nicolairuckel | It's very self-serving for me. :D | |
| 11:29:42 | gibi | :) that is fine | |
| 11:29:51 | gibi | yeah it does not exists on 2025.1 | |
| 11:30:54 | opendevreview | Balazs Gibizer proposed openstack/nova stable/2025.2: [nova-tox-py312-threading]Ignore failing tests https://review.opendev.org/c/openstack/nova/+/980013 | |
| 11:31:03 | gibi | elodilles: ^^ | |
| 11:31:54 | elodilles | thanks, looking o/ | |
| 11:34:18 | elodilles | gibi: +2+W'd it | |