| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2026-03-04 | |||
| 15:46:51 | tkajinam | after it is merged into master | |
| 15:47:18 | tkajinam | so I don't think that needs to be blocked now | |
| 16:18:10 | nicolairuckel | oh | |
| 16:18:12 | nicolairuckel | sorry | |
| 16:18:16 | nicolairuckel | you're right | |
| 16:23:54 | nicolairuckel | dansmith: So should I backport that one first once it's merged? Then I'd do that, then the vTPM patch, and finally my NVRAM patch. | |
| 16:24:24 | dansmith | you can't have it go first without making conflicts.. you generally need to go in the order they appeared, | |
| 16:24:33 | dansmith | so stack them vTPM, NVRAM, test fix | |
| 16:24:58 | dansmith | they should all be on top of each other, they'll update in gerrit together and show as a sequence for proper merge dependencies | |
| 16:26:00 | nicolairuckel | got it | |
| 16:26:28 | tkajinam | dansmith, nicolairuckel I guess you don't need it for 2025.2, though. I think these all patches for firmware selection was merged bot after the fixes to preserve vTPM and NVRAM were merged | |
| 16:26:40 | tkajinam | but it needs to be double-checked. | |
| 16:26:57 | nicolairuckel | I think so too but I added it to my todo list to check it. | |
| 16:27:06 | dansmith | oh, could be | |
| 16:27:30 | tkajinam | I remember I had to resolve conflict caused by that preserve NVRAM patch | |
| 16:27:37 | dansmith | I actually backported the nvram fix to a much older version myself, and that test was failing (and I couldn't figure out why it wasn't failing on master) | |
| 16:27:50 | tkajinam | ok | |
| 16:30:31 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.2: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/978908 | |
| 18:28:11 | opendevreview | ribaudr proposed openstack/nova master: Fix NUMA cell sorting for non-PCI VMs with pack strategy https://review.opendev.org/c/openstack/nova/+/978954 | |
| 19:49:16 | opendevreview | Merged openstack/nova master: Migrate coverage configuration to pyproject https://review.opendev.org/c/openstack/nova/+/978737 | |
| 22:50:41 | opendevreview | melanie witt proposed openstack/nova master: Add nova-vtpm-live-migration job https://review.opendev.org/c/openstack/nova/+/978841 | |
| #openstack-nova - 2026-03-05 | |||
| 03:41:15 | manideep | #openstack-neutron | |
| 03:58:37 | opendevreview | Nope proposed openstack/nova master: scheduler: optional re-query on claim failure https://review.opendev.org/c/openstack/nova/+/977908 | |
| 08:41:14 | opendevreview | Dominik proposed openstack/nova master: Regression test for Placement allocations remaining during failed schedule https://review.opendev.org/c/openstack/nova/+/969251 | |
| 08:41:38 | opendevreview | Dominik proposed openstack/nova master: Remove Placement allocations in the broken build cleanup https://review.opendev.org/c/openstack/nova/+/968446 | |
| 10:36:52 | opendevreview | Dominik proposed openstack/nova master: Regression test for Placement allocations remaining during failed schedule https://review.opendev.org/c/openstack/nova/+/969251 | |
| 10:37:41 | opendevreview | Dominik proposed openstack/nova master: Remove Placement allocations in the broken build cleanup https://review.opendev.org/c/openstack/nova/+/968446 | |
| 10:38:15 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.2: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/978908 | |
| 13:04:12 | opendevreview | Dominik proposed openstack/nova master: NUMA Topology with Resource Providers: Scheduler changes https://review.opendev.org/c/openstack/nova/+/971176 | |
| 14:31:45 | opendevreview | ribaudr proposed openstack/nova master: Update compute rpc alias for Gazpacho https://review.opendev.org/c/openstack/nova/+/979008 | |
| 14:57:11 | opendevreview | ribaudr proposed openstack/nova master: Add service version for Gazpacho https://review.opendev.org/c/openstack/nova/+/979016 | |
| 15:19:49 | opendevreview | ribaudr proposed openstack/nova master: Add Gazpacho prelude section https://review.opendev.org/c/openstack/nova/+/979023 | |
| 15:35:24 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.2: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/978908 | |
| 15:54:39 | nicolairuckel | How much am I allowed to deviate from an original patch for a backport? I needed to make two small adjustments that were not part of the original patch but came from some earlier patches. | |
| 16:05:50 | dansmith | nicolairuckel: as little as possible | |
| 16:06:01 | dansmith | call out the fixes in the commit message | |
| 16:06:14 | elodilles | nicolairuckel: as little as possible o:) if the conflict is due to another bug is not backported, then the easiest is to backport that as well | |
| 16:06:15 | dansmith | if it's too invasive, that's grounds for saying "maybe this isn't suitable for backporting" | |
| 16:06:17 | elodilles | jinx | |
| 16:47:27 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Remove unnecessary type aliases, exceptions https://review.opendev.org/c/openstack/nova/+/738240 | |
| 16:47:28 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Use imports instead of type aliases https://review.opendev.org/c/openstack/nova/+/738018 | |
| 16:47:28 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Remove wrappers around ovo mixins https://review.opendev.org/c/openstack/nova/+/738019 | |
| 16:47:29 | opendevreview | Stephen Finucane proposed openstack/nova master: objects: Remove 'NovaObjectDictCompat' from 'Service' https://review.opendev.org/c/openstack/nova/+/835595 | |
| 16:54:53 | stephenfin | gmaan: sean-k-mooney: What do we want to do about the failures on https://review.opendev.org/c/openstack/python-novaclient/+/978254? | |
| 16:56:10 | stephenfin | nova docs state that nova only supports the 'default' quota class set and the JSON schemas now enforce this. However, based on that now-failing test, it looks like this wasn't enforced previously and non-'default' quota class sets were allowed even if they did nothing | |
| 16:56:41 | stephenfin | My guess is that we need to back out the schema restriction that prevents us using non-default values but I just wanted to check you were happy with me doing so | |
| 17:00:41 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Don't restrict return value of quota class set name https://review.opendev.org/c/openstack/nova/+/979031 | |
| 17:00:50 | stephenfin | gmaan: sean-k-mooney: ^ | |
| 17:02:28 | stephenfin | ah, tkajinam already beat me to it https://review.opendev.org/c/openstack/nova/+/978494 | |
| 17:10:31 | sean-k-mooney | im aware and i dont think that is the correct fix | |
| 17:11:27 | sean-k-mooney | its a workaorund but you were correct in restriting the resopcne schema, the supprot for classes other then defualt was an api exstion and it was removed in ocata | |
| 17:12:00 | sean-k-mooney | the respocne schdmea validation expsoed and input validate bug | |
| 17:13:28 | stephenfin | right, but restricting that would be an API change | |
| 17:13:34 | stephenfin | and therefore needs a microversion | |
| 17:13:35 | sean-k-mooney | the ablity to use this was remvovd with the ablity to confirue out of tree quota drivers | |
| 17:14:20 | stephenfin | right, but the API still works | |
| 17:14:35 | sean-k-mooney | it does not need a microverion if we retrun an existing error code that we allow in our api | |
| 17:14:37 | stephenfin | even if it does nothing | |
| 17:14:44 | sean-k-mooney | so no this does not need a microverison | |
| 17:15:55 | stephenfin | Assuming that's true, can we merge that patch then work on the request schema change? If we *do* allow that, I suspect we also want to go and delete all the non-default entries from the database too | |
| 17:16:40 | sean-k-mooney | yes | |
| 17:16:47 | sean-k-mooney | im not sure we want to clean up the db | |
| 17:17:24 | stephenfin | Looks like the quota class show API doesn't have any expected error codes :/ https://github.com/openstack/nova/blob/968965cc77c6932eb67cc36a539f108c73d50ea0/nova/api/openstack/compute/quota_classes.py#L89 | |
| 17:18:06 | sean-k-mooney | https://docs.openstack.org/nova/latest/contributor/microversions.html#id3 | |
| 17:18:19 | sean-k-mooney | """ | |
| 17:18:21 | sean-k-mooney | The exception to not needing a microversion when returning a previously unspecified error code is the 400, 403, 404 and 415 cases. This is considered OK to return even if previously unspecified in the code since it’s implied given keystone authentication can fail with a 403 and API validation can fail with a 400 for invalid json request body. Request to url/resource that | |
| 17:18:23 | sean-k-mooney | does not exist always fails with 404. Invalid content types are handled before API methods are called which results in a 415.""" | |
| 17:18:38 | sean-k-mooney | this should be a 400 | |
| 17:18:53 | stephenfin | there wasn't a previously unspecified error code though | |
| 17:19:00 | stephenfin | as in, we don't see HTTP 500 | |
| 17:19:12 | stephenfin | which I thought was the only case where a microversion wasn't needed | |
| 17:19:15 | sean-k-mooney | that isnt requried | |
| 17:19:27 | stephenfin | (that and returning HTTP 410 (Gone) where we could no longer support a service) | |
| 17:19:40 | sean-k-mooney | we have estiblishted several time sthat you shoudln not need ot opt into a bug fix | |
| 17:22:05 | sean-k-mooney | stephenfin: by the way if you read the comment thread https://review.opendev.org/c/openstack/nova/+/978494/comments/6ba93b6c_a0707c41 i said i was ok if we add a fixeme comment to adress this proplry later | |
| 17:22:35 | sean-k-mooney | i would also prefer if it was not closes-bug but related-bug | |
| 17:22:43 | sean-k-mooney | buecause it does not close it in my view | |
| 17:22:49 | sean-k-mooney | but i care about that less | |
| 17:27:15 | opendevreview | Stephen Finucane proposed openstack/nova master: WIP: api: Block non-default quota class sets https://review.opendev.org/c/openstack/nova/+/979033 | |
| 17:27:26 | stephenfin | sean-k-mooney: mock up of what I think you're after ☝️ | |
| 17:28:25 | sean-k-mooney | ya basiclly i was also debating if we woudl encoded it in the open api schema as well | |
| 17:28:45 | nicolairuckel | dansmith, elodilles: I'm not sure where exactly the changes came from though. One is this (https://opendev.org/openstack/nova/commit/650772d97efe98e578c18b8268b3bbed63ac4d18) and the other one removed a line so I can't just use git blame (or I just don't know how) | |
| 17:29:09 | sean-k-mooney | stephenfin: but something like that | |
| 17:29:56 | stephenfin | we don't currently have schemas for request parameters (only ironic does for now), but if we did then that should be added, yes | |
| 17:30:05 | stephenfin | *request path parameters | |
| 17:30:09 | sean-k-mooney | ah ok | |
| 17:30:17 | sean-k-mooney | then ya ignore that for now | |
| 17:34:02 | nicolairuckel | ah, this is the other one: https://opendev.org/openstack/nova/commit/880019baafe23f46e59dee7debadf49b9177dc70 | |
| 17:40:14 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.2: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/978908 | |
| 17:40:55 | opendevreview | Nicolai Ruckel proposed openstack/nova stable/2025.2: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/978908 | |
| 17:47:43 | nicolairuckel | I added my additional changes to the commit message. I'm not sure if it would make sense to backport those two patches as well. | |
| 17:47:55 | nicolairuckel | But I guess that can be discussed in the patch. :) | |
| 17:49:01 | sean-k-mooney | i commeted in the patch | |
| 17:49:25 | sean-k-mooney | you shoudl backport https://review.opendev.org/c/openstack/nova/+/961734/4 and the fix https://review.opendev.org/c/openstack/nova/+/962007 | |
| 17:51:21 | sean-k-mooney | at least that woudl be my inclination as i think we will want to backprot that to fix https://bugs.launchpad.net/nova/+bug/2125030 ingeneral | |
| 17:51:52 | sean-k-mooney | melwitt: is there a reason ^ has not been backported beyound time? | |
| 17:53:16 | melwitt | sean-k-mooney: no there is no reason and in fact I think it should be backported. there is also a func test patch that goes with it | |
| 17:53:38 | sean-k-mooney | yep nicolairuckel was pullingin part of the funtional test patch | |
| 17:53:39 | melwitt | I just didn't think of it at the time | |
| 17:53:59 | sean-k-mooney | to resolve a conflict in backing the fix for vtpm rebot | |