| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2026-02-04 | |||
| 10:27:40 | sean-k-mooney | bauzas ++ thanks once thats merged ill reply to mel's email to let folk know its safe to recheck | |
| 11:15:27 | opendevreview | Balazs Gibizer proposed openstack/nova master: Use an executor to delay STOPPED events https://review.opendev.org/c/openstack/nova/+/974445 | |
| 11:15:27 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove spawn_after https://review.opendev.org/c/openstack/nova/+/975396 | |
| 11:15:28 | opendevreview | Balazs Gibizer proposed openstack/nova master: Cleanup libvirt driver at service stop https://review.opendev.org/c/openstack/nova/+/975128 | |
| 11:15:28 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix full executor warning on noname executor https://review.opendev.org/c/openstack/nova/+/975172 | |
| 11:15:29 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | |
| 11:15:55 | gibi | bauzas: ^^ removed the print() call | |
| 12:32:46 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: Troubleshoot deadlocks in threading mode https://review.opendev.org/c/openstack/nova/+/975515 | |
| 13:27:51 | opendevreview | sean mooney proposed openstack/nova-specs master: add pci passthrough groups spec for 2026.2 https://review.opendev.org/c/openstack/nova-specs/+/975635 | |
| 13:36:42 | opendevreview | sean mooney proposed openstack/nova-specs master: add pci passthrough groups spec for 2026.2 https://review.opendev.org/c/openstack/nova-specs/+/975635 | |
| 16:04:08 | opendevreview | Max proposed openstack/nova master: fix: device_by_alias should respect config type https://review.opendev.org/c/openstack/nova/+/975651 | |
| 16:14:35 | sean-k-mooney | gibi: ya so that was the orginal comemnt on the delay behavior. which is being adressed by https://review.opendev.org/c/openstack/nova/+/974445/14 so ill review it properly after i grab somethign to drink but we can likely proceed. | |
| 16:14:58 | sean-k-mooney | note i need to recheck the gate fix again because it had a network timeout downloaing pip packages form teh mirror | |
| 16:39:58 | sean-k-mooney | gibi: i was thinking of https://review.opendev.org/c/openstack/nova/+/922497 and https://review.opendev.org/c/openstack/nova/+/905287/9 which on master is now https://github.com/openstack/nova/blob/master/nova/image/glance.py#L580-L586 so it looks like in threaded mode we jsut execute it inline and block on the upload | |
| 16:40:40 | sean-k-mooney | so unless we move snapshots to the long runting thread pool that will tie up an rpc thread for the entirty fo the galnce snapshot upload | |
| 16:42:33 | sean-k-mooney | gibi: when you took over the eventlet work you didnt add a dedicated io thread pool but rather a defult thread pool but we didnt update that code to dispatch the upload to the thread pool. | |
| 17:18:50 | gibi | sean-k-mooney: thanks for the pointers. I don't see how that io executor helps, the usage in RBD is spawning a task to the executor and immediately blocking on waiting for the result. Logically that is the same as executing the function on the caller thread in my eyes (in native threading) | |
| 17:19:14 | gibi | https://review.opendev.org/c/openstack/nova/+/917962/8/nova/storage/rbd_utils.py#56 | |
| 17:19:46 | sean-k-mooney | i wrote it before dan told me that the rbd client was doing that internally | |
| 17:20:04 | sean-k-mooney | so its not useful for that | |
| 17:20:44 | gibi | ack | |
| 17:20:53 | sean-k-mooney | so the up shot is we have 1 less executor then i tought we had (i.e. we dont have a dedicated io executor for long running file and api calls | |
| 17:21:01 | sean-k-mooney | ) | |
| 17:22:25 | sean-k-mooney | it was orgilly suggestign puting the neutron netrokign call on that but i guess the only thing that impoant to consider is the _upload_data function | |
| 17:22:40 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/image/glance.py#L580-L586 | |
| 17:22:42 | gibi | OK, I will check the _upload_data codepath | |
| 17:23:09 | sean-k-mooney | im not sure we want to block the RPC thread with doing the file upload for snapshots | |
| 17:24:04 | sean-k-mooney | but as dan also pointed out unless we have a futre we can pass in or simialr i dont know hwe we are going to deal with returning the image uuid that is created form this call | |
| 17:24:45 | sean-k-mooney | when you do openstack server image create we need to return teh glance image id for the snapshot form the api if i recall correctly | |
| 17:24:49 | gibi | yepp, I need to think about all these. | |
| 17:26:05 | sean-k-mooney | doign it inline is fine if we move thie operation entrily to teh long runing thread pool but th ereply path is still an unknow i guess | |
| 17:26:26 | gibi | sean-k-mooney: food for thought. How do you feel about https://github.com/openstack/futurist/blob/master/futurist/_futures.py#L232 as a way out of deadlocks due to limited executor sizes? | |
| 17:26:37 | gibi | DynamicThreadPoolExecutor | |
| 17:27:07 | sean-k-mooney | i have not looked at that before but i was debeating about creatin a new executor propsosla that handeled prities canclation and delayed exection | |
| 17:27:53 | gibi | for the delayed execution I have this WIP in futurist https://review.opendev.org/c/openstack/futurist/+/975508 | |
| 17:27:53 | sean-k-mooney | gibi: but i dont feel terible about one that cna grow as a way out | |
| 17:28:39 | gibi | yeah we still need to limit our parallel work due to IO and overall memory usage but at least the deadlock becomes something else :) | |
| 17:28:52 | sean-k-mooney | so the lib that watcher and zuul uses has lots of interest feature but the reason im not really suggesting that at the morment is that lib is 4? yes int a v4 rewirte which break backward compatiblity | |
| 17:29:02 | sean-k-mooney | *4 years? | |
| 17:30:27 | sean-k-mooney | gibi: ill try and rominate on it. im not a huge fan of async io. i dont hate it but i was also wonderign if we could/should consider limited use fo an asynio executor | |
| 17:32:05 | sean-k-mooney | if we were to use the DynamicThreadPoolExecutor | |
| 17:32:33 | sean-k-mooney | are you suggesting we woudl not set a max workers or set it relitivly high with the expcation taht in reality it will stay small? | |
| 17:33:12 | gibi | I have to read on what the Dynamic supports regarding sizing but I see that it can grow and shrink | |
| 17:33:38 | sean-k-mooney | """ If threads are not created often in your application, the number of idle | |
| 17:33:40 | sean-k-mooney | threads may stay high for a long time. To avoid it, you can call | |
| 17:33:42 | sean-k-mooney | :py:meth:`.maintain` periodically to keep the number of threads within | |
| 17:33:44 | sean-k-mooney | the thresholds.""" | |
| 17:34:07 | sean-k-mooney | we might need to do that ^ | |
| 17:35:32 | sean-k-mooney | gibi: i dont hate that idea if im honest. but its proably the rpc pool in oslo service that woudl be the most benifical to use that with right? | |
| 17:36:02 | sean-k-mooney | sorry in oslo.messaging | |
| 17:36:56 | gibi | yeah that too :) | |
| 17:37:24 | sean-k-mooney | i know we can set an executor type when we create the rpc servier im wondering if we can just provide an rpc instance | |
| 17:37:30 | sean-k-mooney | *executor instance | |
| 17:38:31 | sean-k-mooney | ya its just the name https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/rpc/server.py#L226-L240 | |
| 17:41:15 | sean-k-mooney | so we woudl have ot update https://github.com/openstack/oslo.messaging/blob/master/pyproject.toml#L53 | |
| 17:41:24 | sean-k-mooney | or add a new value | |
| 17:41:55 | sean-k-mooney | might be worth suggeting that to the oslo folks and see what they think | |
| 18:03:16 | dansmith | I'm not sure how the dynamic one really helps | |
| 18:03:43 | dansmith | you still have to set your max to the upper limit of what you're willing tolerate.. it uses less memory in slow times, which is a benefit, but it's still the same problem when you hit the limit | |
| 18:06:50 | gmaan | yeah, it does not solve the limit issue. I think we should be gradually learning about those limit issue (after solving the known one) and keep improving the defaults limit or better separate executor if any specific operations causing problem | |
| 18:36:20 | gibi | https://etherpad.opendev.org/p/eventlet-executor-semaphore-limit this is my brain dump looking at the long running task executor possibilities | |
| 18:36:47 | gibi | we have a list of pros and cons to choose from | |
| 18:38:45 | gmaan | thanks for catching those in etherpad | |
| 19:01:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move the concurrent builds to its own Executor https://review.opendev.org/c/openstack/nova/+/975694 | |
| 19:01:43 | gibi | this is the very raw idea of optionA) from the etherpad ^^ not tested at all :) | |
| 19:01:52 | gibi | and that marks my end of day | |
| 19:01:54 | gibi | o/ | |
| 19:43:44 | opendevreview | Marius Leustean proposed openstack/nova-specs master: Add spec for handling orphan BDMs from late RPC processing https://review.opendev.org/c/openstack/nova-specs/+/975698 | |
| 22:20:50 | opendevreview | Merged openstack/nova master: Fix blockio generation for LUN volumes https://review.opendev.org/c/openstack/nova/+/975542 | |
| #openstack-nova - 2026-02-05 | |||
| 01:17:56 | gmaan | sean-k-mooney: I did not +W this as you might want to review it too, if not let me know and I can apply +W https://review.opendev.org/c/openstack/nova/+/974445 | |
| 01:18:11 | gmaan | rest other in the series are good to go | |
| 01:19:41 | opendevreview | melanie witt proposed openstack/nova master: TPM: prepare to bump service version for live migration https://review.opendev.org/c/openstack/nova/+/962051 | |
| 01:19:41 | opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `host` secret security https://review.opendev.org/c/openstack/nova/+/941483 | |
| 01:19:42 | opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | |
| 01:19:42 | opendevreview | melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629 | |
| 01:19:43 | opendevreview | melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975 | |
| 01:19:43 | opendevreview | melanie witt proposed openstack/nova master: TPM: opt-in to new TPM secret security via resize https://review.opendev.org/c/openstack/nova/+/962052 | |
| 01:19:44 | opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | |
| 01:19:45 | opendevreview | melanie witt proposed openstack/nova master: TPM: bump service version to enable live migration https://review.opendev.org/c/openstack/nova/+/975724 | |
| 01:22:22 | gmaan | sean-k-mooney: ah you already checked and left comment there, got it now. I +w it. | |
| 02:32:50 | opendevreview | Takashi Natsume proposed openstack/nova master: Update contributor guide for 2026.1 Gazpacho https://review.opendev.org/c/openstack/nova/+/961896 | |
| 02:37:50 | opendevreview | Ghanshyam proposed openstack/nova master: DNM: test oslo.service set_service_opts_defaults https://review.opendev.org/c/openstack/nova/+/975739 | |
| 02:38:52 | opendevreview | Ghanshyam proposed openstack/nova master: DNM: test oslo.service set_service_opts_defaults https://review.opendev.org/c/openstack/nova/+/975739 | |
| 03:14:07 | opendevreview | Merged openstack/nova master: Libvirt event handling without eventlet https://review.opendev.org/c/openstack/nova/+/965949 | |
| 03:14:23 | opendevreview | Merged openstack/nova master: SubclassSignatureTestCase to use NoDBTestCase as base https://review.opendev.org/c/openstack/nova/+/974861 | |
| 03:43:48 | opendevreview | Merged openstack/nova master: Enable mypy on nova/utils.py https://review.opendev.org/c/openstack/nova/+/969936 | |
| 03:56:57 | opendevreview | Ghanshyam proposed openstack/nova master: DNM: test oslo.service set_service_opts_defaults https://review.opendev.org/c/openstack/nova/+/975739 | |
| 06:36:05 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Extend functional test coverage of UEFI boot guests https://review.opendev.org/c/openstack/nova/+/969263 | |
| 06:36:05 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add basic xml generation for firmware auto selection https://review.opendev.org/c/openstack/nova/+/969085 | |
| 06:36:06 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add capability to load loader and nvram from xml https://review.opendev.org/c/openstack/nova/+/969086 | |
| 06:36:06 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Add capability to load smm feature from existing xml https://review.opendev.org/c/openstack/nova/+/969131 | |
| 06:36:07 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Use firmware auto-selection by libvirt https://review.opendev.org/c/openstack/nova/+/969132 | |
| 07:40:42 | opendevreview | Takashi Kajinami proposed openstack/nova master: AMD SEV: omit iommu='on' for virtio devices https://review.opendev.org/c/openstack/nova/+/909635 | |
| 07:40:55 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove tpm support detection for libvirt < 8.0.0 https://review.opendev.org/c/openstack/nova/+/952308 | |
| 07:41:03 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Drop redundant chown of tpm data directory https://review.opendev.org/c/openstack/nova/+/962446 | |
| 10:56:25 | opendevreview | Merged openstack/nova master: Live migration with iothreads https://review.opendev.org/c/openstack/nova/+/975000 | |
| 11:18:09 | opendevreview | John Garbutt proposed openstack/nova master: Make PCPUs not land on VCPUs by default https://review.opendev.org/c/openstack/nova/+/975779 | |
| 12:18:10 | opendevreview | Max proposed openstack/nova master: fix: _get_guest_disk_device UnboundLocalError https://review.opendev.org/c/openstack/nova/+/975783 | |
| #openstack-nova - 2026-02-19 | |||
| 02:57:44 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Use 2nd RPC server in compute operations https://review.opendev.org/c/openstack/nova/+/975588 | |
| 04:34:26 | opendevreview | Ghanshyam Maan proposed openstack/nova master: Prepare resize/cold migration for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977182 | |