| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-09-05 | |||
| 15:34:29 | sean-k-mooney | did you actully look at where the converstaion started 3-4 hours before you came on line | |
| 15:34:56 | dansmith | yes | |
| 15:35:37 | opendevreview | Elod Illes proposed openstack/osc-placement master: [CI] Drop unsupported py39 based functional job https://review.opendev.org/c/openstack/osc-placement/+/959873 | |
| 15:36:15 | opendevreview | Merged openstack/nova master: [PCI tracker]Remove non configured devs when freed https://review.opendev.org/c/openstack/nova/+/954613 | |
| 15:36:22 | opendevreview | Elod Illes proposed openstack/osc-placement stable/2025.2: [CI] Drop unsupported py39 based functional job https://review.opendev.org/c/openstack/osc-placement/+/959874 | |
| 15:36:32 | opendevreview | Merged openstack/nova master: [pci]Keep used dev in Placement regardless of dev_spec https://review.opendev.org/c/openstack/nova/+/954149 | |
| 15:38:15 | sean-k-mooney | i lirtally startded workin on it when i said "bauzas: look im just going to go fix this becuase im -2 on just riping it ou8t" jkulik provided me to the link to the bug gibi filed earlier and i checcked out the branch adn started workign on it | |
| 15:40:06 | sean-k-mooney | every time i replied on irc or slack after that yesterdy until i push my patch i was swappign form it to reply | |
| 15:53:47 | bauzas | I just saw it from the logs, I have to say | |
| 15:54:14 | bauzas | after that I said that I'd like to have a consensus about the solution, and then I moved it quickly | |
| 15:54:57 | bauzas | so I understand your concern, but please understand as well that my main point is that I want that fix to be part of RC1 and backportable, now that we have a consensus | |
| 15:55:02 | sean-k-mooney | i think that were we diverged | |
| 15:55:11 | sean-k-mooney | the was part is my unit test is stil failing... | |
| 15:55:51 | bauzas | sean-k-mooney: if you look at the API test, I had to modify some knob given we're directly passing back the object | |
| 15:56:13 | bauzas | you need to delete the stats field before returning the whole dict | |
| 15:56:31 | sean-k-mooney | right os i was tryitng to avoid doing exacty what you did | |
| 15:56:49 | bauzas | (that's the only piece where I used Cursor, in order to understand the root cause but I wrote the code myself) | |
| 15:57:11 | sean-k-mooney | you added https://review.opendev.org/c/openstack/nova/+/959571/3/nova/tests/unit/api/openstack/compute/test_hypervisors.py#80 | |
| 15:57:19 | sean-k-mooney | which woudl work and i coudl od it too | |
| 15:57:47 | bauzas | on the second compute | |
| 15:57:51 | sean-k-mooney | i have been tryign to not change that but fake_compute_node_statistics | |
| 15:57:51 | bauzas | not on the first one | |
| 15:58:16 | bauzas | we have two fake computes, I updated the second one and then I skim the stats field before passing the object back | |
| 15:58:34 | bauzas | anyway, 6pm here on a Friday, /me stops | |
| 15:58:41 | sean-k-mooney | ya so i way trying to avoid that because i dint want to change teh v21 data | |
| 15:58:53 | sean-k-mooney | but i think ill just do what you did instead | |
| 15:59:10 | sean-k-mooney | we are using self.stub_out('nova.db.main.api.compute_node_statistics', | |
| 15:59:12 | sean-k-mooney | fake_compute_node_statistics) | |
| 15:59:33 | sean-k-mooney | and i was try8ign to figure out how to refacto rthat so i coudl update the mock only in one specific test | |
| 16:00:13 | sean-k-mooney | im making it a lot harder for myself by doing that | |
| 16:01:35 | sean-k-mooney | effectily i was tryign to avoid touchign the test setup for the older micoversion but you approch is not matirally changing what they are testegin so ill adopt that instead | |
| 16:08:48 | sean-k-mooney | oh i see your testing show not list. ill do both. and include your test in my version | |
| 16:32:26 | opendevreview | Merged openstack/nova master: libvirt: Disable VMCoreInfo device for SEV-encrypted instances https://review.opendev.org/c/openstack/nova/+/958868 | |
| 16:32:50 | opendevreview | Merged openstack/nova stable/2024.2: Reproduce that only half of the PCI devs are removed https://review.opendev.org/c/openstack/nova/+/959310 | |
| 16:33:00 | opendevreview | sean mooney proposed openstack/nova master: hypervisors: Optimize uptime retrieval for better performance https://review.opendev.org/c/openstack/nova/+/959604 | |
| 17:36:36 | opendevreview | Merged openstack/nova stable/2024.2: Fix pci_tracker.save to delete all removed devs https://review.opendev.org/c/openstack/nova/+/959311 | |
| 17:50:55 | opendevreview | sean mooney proposed openstack/nova master: hypervisors: Optimize uptime retrieval for better performance https://review.opendev.org/c/openstack/nova/+/959604 | |
| 17:52:00 | sean-k-mooney | dan ^ implement the defaulting in the resouce tracker you wnated. i can update it more if needed | |
| 17:53:45 | sean-k-mooney | well technially not in the resouce trracker | |
| 17:54:04 | sean-k-mooney | but in the stats module https://review.opendev.org/c/openstack/nova/+/959604/3/nova/compute/stats.py | |
| 17:54:36 | sean-k-mooney | which will make it work for all driver and now the api can jsut use that as a sentenil | |
| 17:57:07 | sean-k-mooney | actully that not quite right fixing | |
| 17:59:59 | opendevreview | sean mooney proposed openstack/nova master: hypervisors: Optimize uptime retrieval for better performance https://review.opendev.org/c/openstack/nova/+/959604 | |
| 18:04:32 | opendevreview | sean mooney proposed openstack/nova master: hypervisors: Optimize uptime retrieval for better performance https://review.opendev.org/c/openstack/nova/+/959604 | |
| 19:18:33 | atmark | Hello, I have volume that got stuck that I dad to run `openstack volume set --state available --detached` but the instance still think it's attached ( volume ID shows up in volumes_attached). How do I get the instance to detach volume? | |
| 19:18:46 | atmark | s/dad/had | |
| 20:50:39 | opendevreview | Merged openstack/nova stable/2024.1: Reproduce that only half of the PCI devs are removed https://review.opendev.org/c/openstack/nova/+/959313 | |
| 21:55:35 | opendevreview | Merged openstack/nova stable/2024.1: Fix pci_tracker.save to delete all removed devs https://review.opendev.org/c/openstack/nova/+/959314 | |
| 22:07:21 | opendevreview | Takashi Kajinami proposed openstack/nova stable/2024.2: libvirt: Disable VMCoreInfo device for SEV-encrypted instances https://review.opendev.org/c/openstack/nova/+/959913 | |
| 22:08:03 | opendevreview | Takashi Kajinami proposed openstack/nova stable/2024.1: libvirt: Disable VMCoreInfo device for SEV-encrypted instances https://review.opendev.org/c/openstack/nova/+/959914 | |
| #openstack-nova - 2025-09-07 | |||
| 15:40:56 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore unsupported firmware architectures https://review.opendev.org/c/openstack/nova/+/959985 | |
| 15:46:23 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore unsupported firmware architectures https://review.opendev.org/c/openstack/nova/+/959985 | |
| 18:33:22 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Select appropriate firmware for stateless firmware support https://review.opendev.org/c/openstack/nova/+/959988 | |
| 18:33:42 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Select appropriate firmware for stateless firmware support https://review.opendev.org/c/openstack/nova/+/959988 | |
| 18:34:38 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Select appropriate firmware for stateless firmware support https://review.opendev.org/c/openstack/nova/+/959988 | |
| 18:36:35 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore unsupported firmware architectures https://review.opendev.org/c/openstack/nova/+/959985 | |
| 18:37:53 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore unsupported firmware architectures https://review.opendev.org/c/openstack/nova/+/959985 | |
| 18:38:22 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore unsupported firmware architectures https://review.opendev.org/c/openstack/nova/+/959985 | |
| 18:39:05 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Select appropriate firmware for stateless firmware support https://review.opendev.org/c/openstack/nova/+/959988 | |
| 18:39:05 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore unsupported firmware architectures https://review.opendev.org/c/openstack/nova/+/959985 | |
| 18:41:16 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Select appropriate firmware for stateless firmware support https://review.opendev.org/c/openstack/nova/+/959988 | |
| 18:41:16 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore unsupported firmware architectures https://review.opendev.org/c/openstack/nova/+/959985 | |
| 19:16:22 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Select appropriate image for stateless firmware https://review.opendev.org/c/openstack/nova/+/959988 | |
| 19:16:23 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Ignore unsupported firmware architectures https://review.opendev.org/c/openstack/nova/+/959985 | |
| #openstack-nova - 2025-09-08 | |||
| 10:38:45 | sean-k-mooney | atmark: we have never supproted detacting volume via cinder like that and it actully cause security problem if you do that | |
| 10:39:06 | sean-k-mooney | atmark: the only way to detach a volume form an instnace is via nova's api | |
| 10:41:51 | sean-k-mooney | depending on the relase of openstack we have two volume healing operations, in newer relase a hard reboot will regenerate teh bdms using cidner as the source of truth for what shoudl be attached, we also have a nova-manage command that predates it and uses the bdm as the souce of truth and will recreate the attachments | |
| 13:26:54 | opendevreview | Takashi Kajinami proposed openstack/nova stable/2024.1: hardware: Fix image_meta.id within get_mem_encryption_constraint https://review.opendev.org/c/openstack/nova/+/960050 | |
| 13:27:14 | opendevreview | Takashi Kajinami proposed openstack/nova stable/2024.1: libvirt: Disable VMCoreInfo device for SEV-encrypted instances https://review.opendev.org/c/openstack/nova/+/959914 | |
| 13:38:31 | opendevreview | Merged openstack/python-novaclient master: Update master for stable/2025.2 https://review.opendev.org/c/openstack/python-novaclient/+/959749 | |
| 13:40:16 | opendevreview | Takashi Kajinami proposed openstack/nova stable/2025.1: libvirt: Disable VMCoreInfo device for SEV-encrypted instances https://review.opendev.org/c/openstack/nova/+/958874 | |
| 13:41:11 | opendevreview | Takashi Kajinami proposed openstack/nova stable/2024.2: libvirt: Disable VMCoreInfo device for SEV-encrypted instances https://review.opendev.org/c/openstack/nova/+/959913 | |
| 14:45:04 | dansmith | I'm sick of autopep8 reformatting my code instead of suggesting it when I run `tox -epep8` | |
| 14:45:16 | dansmith | surely there's some way I can locally prefer not to do that right? | |
| 14:45:23 | dansmith | bauzas: Uggla ? | |
| 14:45:44 | dansmith | not sure when the team agreed to do this, but man it's annoying | |
| 14:47:12 | bauzas | dansmith: pre-commit is already doing that :( | |
| 14:47:40 | dansmith | I know | |
| 14:47:44 | dansmith | I want to turn it off | |
| 14:47:57 | bauzas | apart finding another agreement, I don't see what we can do | |
| 14:48:11 | bauzas | the agreement being that autopep8 is and should always be optional | |
| 14:48:23 | bauzas | including in the tox target | |
| 14:48:31 | dansmith | bauzas: +1000 | |
| 14:48:52 | bauzas | also, skipping pre-commit is unfair, as I need pre-commit for adding the gerrit change ID automatically, I can't just skip autopep8 | |
| 14:49:15 | bauzas | (AFAIK, no way to only skip a subset of the multiple pre-commit hooks) | |
| 14:49:51 | Uggla | hum it is the case for quite some time right ? | |
| 14:50:34 | dansmith | Uggla: it has been yes and I've hated it this whole time, but this morning it's really killing me and I want it to stop | |
| 14:50:56 | dansmith | I also argued against it when it was even proposed before it was autopep8'ing | |
| 14:51:14 | dansmith | IIRC it used to just show the suggestions but not force them on me | |
| 14:59:12 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rally job for eventlet-removal https://review.opendev.org/c/openstack/nova/+/960130 | |
| 14:59:18 | Uggla | it depends some changes are left to the author, but some basic reformatting are applied, if I'm not wrong. | |
| 14:59:44 | dansmith | yes and I never ever want it to do that.. | |
| 15:00:14 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rally job for eventlet-removal https://review.opendev.org/c/openstack/nova/+/960130 | |
| 15:00:18 | dansmith | if I have uncommitted changes and I run pep8, it will make a bunch of extra changes that I did not want that are all "opinions" of the tool and now I have more change queued | |
| 15:01:44 | dansmith | right now it keeps forcing this on me: 3 | |
| 15:01:49 | dansmith | https://paste.opendev.org/show/bjPrI7fQi2rx3TH1ndDB/ | |
| 15:02:03 | dansmith | which takes the code from readable to stupid for no effing reason | |
| 16:10:55 | ratailor__ | bauzas, melwitt can I get reviews on backports https://review.opendev.org/c/openstack/nova/+/958834 and https://review.opendev.org/q/project:openstack/nova+branch:stable/2024.2+owner:ratailor@redhat.com | |
| 16:12:15 | opendevreview | Takashi Kajinami proposed openstack/nova stable/2024.1: libvirt: Disable VMCoreInfo device for SEV-encrypted instances https://review.opendev.org/c/openstack/nova/+/959914 | |
| 16:20:06 | sean-k-mooney | bauzas: the change-id hook is entirly seperate | |