| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-08-26 | |||
| 17:13:10 | tkajinam | bauzas, the current functional tests covers instance creation before reshape and creation after reshape using a single RP, so that proves sev instance can be scheduled to old compute node and also new compute node | |
| 17:13:41 | bauzas | it doesn't prove that instance creation can be fulfiled on a mixed env, that's the point | |
| 17:14:11 | bauzas | oh, I see what you mean | |
| 17:14:44 | tkajinam | I can create a scenario with two RPs, but do you expect that we create two servers in that case but I'm not sure if I can enforce these two scheduled to two different (old/new) compute nodes | |
| 17:15:25 | bauzas | tkajinam: that is doable, we have other functional tests where we fake the targets | |
| 17:15:54 | bauzas | but anyway, I see your point | |
| 17:16:13 | bauzas | shall work anyway, so here I think a follow-up patch is only needed | |
| 17:17:14 | tkajinam | ok | |
| 17:18:35 | tkajinam | I'll push follow-up to run similar scenario with two mixed nodes, but I believe that compatibility scenario is already covered by the existing scenario using one node. | |
| 17:19:38 | bauzas | thanks, appreciated | |
| 17:41:55 | opendevreview | Merged openstack/nova stable/2024.2: Ignore metadata tags in pci/stats _find_pool logic https://review.opendev.org/c/openstack/nova/+/945099 | |
| 17:53:01 | opendevreview | Takashi Kajinami proposed openstack/nova master: Add functional test scenario for mixed SEV RPs https://review.opendev.org/c/openstack/nova/+/958562 | |
| 17:53:58 | tkajinam | bauzas, I hope this matches your expectation but lmk if you want additional steps (like creating servers before reshape) | |
| 17:54:10 | bauzas | tkajinam: <3 | |
| 17:54:40 | tkajinam | I put it on the last one to avoid mass rebase but I can change the order... I noticed that I didn't add that comment to the initial functional test scenario so I'll move that part to the reshape patch if I have to respin | |
| 17:54:53 | bauzas | tkajinam: putting it on top is fine by me | |
| 17:55:11 | bauzas | anyway, I just need to review your series for now | |
| 17:55:39 | tkajinam | (the comment I'm referring to is https://review.opendev.org/c/openstack/nova/+/958562/1/nova/tests/functional/libvirt/test_reshape.py#259 ) | |
| 17:55:41 | tkajinam | bauzas, thanks !! | |
| 17:59:25 | bauzas | tkajinam: one thing, we keep providing capabilities as traits to the root RP, not the children ones, right? | |
| 17:59:47 | bauzas | oh nevermind, no | |
| 18:01:31 | tkajinam | bauzas, no we have to migrate the trait to its children, so that we can have SEV children tree as well as SEV-ES children tree | |
| 18:01:51 | tkajinam | MEM_ENCRYPTION_CONTEXT for SEV-ES can't be used for SEV so we have to define the trait at children layer | |
| 18:02:01 | bauzas | yup, and your functional traits test covers that, so I understood my mistake | |
| 18:05:12 | tkajinam | :-) | |
| 18:05:32 | tkajinam | I'm leaving soon but will check the irc logs as well as any review comments tomorrow | |
| 19:14:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: Ask for pre-prod testing for native threading https://review.opendev.org/c/openstack/nova/+/957424 | |
| 19:14:39 | opendevreview | Balazs Gibizer proposed openstack/nova master: Switch nova-conductor to use ThreadPoolExecutor https://review.opendev.org/c/openstack/nova/+/957088 | |
| 19:14:39 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow to start unit test without eventlet https://review.opendev.org/c/openstack/nova/+/953436 | |
| 19:14:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run unit test with threading mode https://review.opendev.org/c/openstack/nova/+/953475 | |
| 19:14:40 | opendevreview | Balazs Gibizer proposed openstack/nova master: [test]RPC using threading or eventlet selectively https://review.opendev.org/c/openstack/nova/+/953815 | |
| 19:14:41 | opendevreview | Balazs Gibizer proposed openstack/nova master: [CI]Make nova-tox-py312-threading voting https://review.opendev.org/c/openstack/nova/+/955791 | |
| 19:14:41 | opendevreview | Balazs Gibizer proposed openstack/nova master: Do not yield in threading mode https://review.opendev.org/c/openstack/nova/+/950994 | |
| 19:14:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make RBD Tpool usage conditional https://review.opendev.org/c/openstack/nova/+/956089 | |
| 19:14:42 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make libvirt Tpool proxying conditional https://review.opendev.org/c/openstack/nova/+/956090 | |
| 19:14:44 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix ProviderTree copying with threading Lock https://review.opendev.org/c/openstack/nova/+/956091 | |
| 19:14:44 | opendevreview | Balazs Gibizer proposed openstack/nova master: [test]Further categorization of disabled unit tests https://review.opendev.org/c/openstack/nova/+/956092 | |
| 19:14:46 | opendevreview | Balazs Gibizer proposed openstack/nova master: [vncproxy]Handle ssl.wrap_socket removal in py312 https://review.opendev.org/c/openstack/nova/+/955915 | |
| 19:14:46 | opendevreview | Balazs Gibizer proposed openstack/nova master: Warn on long task wait time for executor https://review.opendev.org/c/openstack/nova/+/952666 | |
| 19:14:48 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-conductor in native threading mode https://review.opendev.org/c/openstack/nova/+/958575 | |
| 19:17:22 | gibi | I rearranged the series ^^ so we will get unit test run with native threading with the conductor change | |
| 19:17:45 | sean-k-mooney | ack ill start reviewign those now | |
| 19:18:26 | gibi | locally py312-threading passing for me with the conductor changes. I will do the manual testing in devstack tomorrow | |
| 19:31:08 | sean-k-mooney | gibi: bar the conductor change which i need to review im +2 on all of those up until "Do not yield in threading mode" | |
| #openstack-nova - 2025-08-27 | |||
| 01:02:53 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 01:02:54 | opendevreview | Takashi Kajinami proposed openstack/nova master: Add hw_mem_encryption_model image property https://review.opendev.org/c/openstack/nova/+/927706 | |
| 01:02:54 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| 01:02:55 | opendevreview | Takashi Kajinami proposed openstack/nova master: Add functional test scenario for mixed SEV RPs https://review.opendev.org/c/openstack/nova/+/958562 | |
| 01:16:30 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 01:16:31 | opendevreview | Takashi Kajinami proposed openstack/nova master: Add hw_mem_encryption_model image property https://review.opendev.org/c/openstack/nova/+/927706 | |
| 01:16:31 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| 01:16:32 | opendevreview | Takashi Kajinami proposed openstack/nova master: Add functional test scenario for mixed SEV RPs https://review.opendev.org/c/openstack/nova/+/958562 | |
| 01:20:24 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 01:20:25 | opendevreview | Takashi Kajinami proposed openstack/nova master: Add hw_mem_encryption_model image property https://review.opendev.org/c/openstack/nova/+/927706 | |
| 01:20:25 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| 01:20:26 | opendevreview | Takashi Kajinami proposed openstack/nova master: Add functional test scenario for mixed SEV RPs https://review.opendev.org/c/openstack/nova/+/958562 | |
| 04:43:05 | opendevreview | Merged openstack/nova master: Remove logic for unsupported old libvirt/qemu https://review.opendev.org/c/openstack/nova/+/952318 | |
| 04:50:54 | opendevreview | Merged openstack/nova master: libvirt: Get info with abs path, rebase with rel path https://review.opendev.org/c/openstack/nova/+/955039 | |
| 04:54:28 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix 'nova-manage image_property set' command https://review.opendev.org/c/openstack/nova/+/946733 | |
| 04:57:00 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix concurrent migration of vms with multiattach volume failure https://review.opendev.org/c/openstack/nova/+/872278 | |
| 05:02:30 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix instance vm_state during shelve https://review.opendev.org/c/openstack/nova/+/934294 | |
| 05:11:53 | opendevreview | Rajesh Tailor proposed openstack/nova master: Update the api-ref for unshelve https://review.opendev.org/c/openstack/nova/+/938054 | |
| 05:26:39 | opendevreview | Ghanshyam proposed openstack/nova master: Add service role in Nova policy https://review.opendev.org/c/openstack/nova/+/957578 | |
| 05:26:54 | opendevreview | Merged openstack/nova stable/2025.1: Don't reset port dns_name when shelving instances https://review.opendev.org/c/openstack/nova/+/956216 | |
| 05:27:08 | opendevreview | Merged openstack/nova stable/2025.1: Fix case-sensitivity for metadata keys https://review.opendev.org/c/openstack/nova/+/945842 | |
| 05:30:39 | opendevreview | Merged openstack/nova stable/2025.1: Fix disable memballoon device https://review.opendev.org/c/openstack/nova/+/952959 | |
| 05:30:51 | opendevreview | Merged openstack/nova stable/2025.1: Fix case sensitive comparison https://review.opendev.org/c/openstack/nova/+/945843 | |
| 05:34:24 | opendevreview | Rajesh Tailor proposed openstack/nova master: Update api-ref for server create https://review.opendev.org/c/openstack/nova/+/937534 | |
| 05:35:39 | opendevreview | Merged openstack/nova stable/2025.1: [doc]Clarify where to set pci_in_placement https://review.opendev.org/c/openstack/nova/+/951624 | |
| 05:36:02 | opendevreview | Merged openstack/nova master: api: Separate volume, snapshot and volume attachments https://review.opendev.org/c/openstack/nova/+/952347 | |
| 05:36:23 | opendevreview | Merged openstack/nova master: tests: Use valid UUIDs for cinder resources https://review.opendev.org/c/openstack/nova/+/952935 | |
| 05:49:47 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix KeyError on assisted snapshot call https://review.opendev.org/c/openstack/nova/+/900783 | |
| 05:59:53 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add upgrade status check for duplicate cell names https://review.opendev.org/c/openstack/nova/+/901810 | |
| 06:04:38 | opendevreview | Merged openstack/nova master: api: Only apply "soft" additionalProperties validation to requests https://review.opendev.org/c/openstack/nova/+/952936 | |
| 06:04:51 | opendevreview | Merged openstack/nova stable/2024.2: wrap wsgi_app.init_application with latch_error_on_raise https://review.opendev.org/c/openstack/nova/+/945440 | |
| 06:43:09 | opendevreview | Max proposed openstack/nova master: performance: reduce calls to libvirt / add caching https://review.opendev.org/c/openstack/nova/+/922855 | |
| 07:32:07 | opendevreview | Florian proposed openstack/nova master: Add check for PCIe devices attach limit for volume and ports https://review.opendev.org/c/openstack/nova/+/955584 | |
| 07:58:17 | ralonsoh | sean-k-mooney, hello! qq regarding this: https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/sriov-trusted-vfs.html | |
| 07:59:30 | ralonsoh | so if we have a VF bond inside the VM (with trusted VFs), it is possible to change the port MAC. But that will make the SR-IOV agent to fail. When the MAC-PCI address pair doesn't match, it returns a warning and forces a full resync | |
| 07:59:58 | ralonsoh | it will repeat this every cycle (that means, every 2 seconds, by default) | |
| 08:00:24 | ralonsoh | did we considered somehow this scenario?? from the Neutron point of view | |
| 08:00:47 | opendevreview | Balazs Gibizer proposed openstack/nova stable/2024.2: [doc]Clarify where to set pci_in_placement https://review.opendev.org/c/openstack/nova/+/958623 | |
| 08:27:21 | gibi | sean-k-mooney: dansmith: bauzas: we have both green nova-next and unit test results for the nova-conductor eventlet removal change. See my comment in https://review.opendev.org/c/openstack/nova/+/957088/6#message-5d92177333ca556fc30c6934603d37ab55cd161c | |
| 08:27:25 | gibi | sambork: ^^ | |
| 08:27:41 | bauzas | gibi: that's on my today's duties | |
| 08:27:52 | bauzas | I'm finishing up the AMD SEV-ES series | |
| 08:27:59 | gibi | I will do some local manual testing now and report back on the same patch | |
| 08:30:39 | bauzas | ++ | |
| 08:32:08 | gibi | sambork: as far as I see this is the only remaining ask form yesterday https://review.opendev.org/c/openstack/nova/+/957088/6#message-cd81d9ce4afbc379e730f15d8df8334a5303e42f | |
| 08:32:27 | sambork | gibi, ack, thanks | |
| 08:32:33 | gibi | sambork: hm | |
| 08:32:36 | gibi | sambork: wait a sec | |
| 08:33:45 | gibi | sambork: I have a small thing in the parent of that https://review.opendev.org/c/openstack/nova/+/957424 so if we anyhow want to touch the top then I would like to fix the bottom as well in the same run | |
| 08:34:22 | gibi | sambork: I guess it is easier if I just go and do both changes in the same push | |
| 08:34:46 | sambork | gibi, ok thanks a lot! | |
| 08:34:57 | gibi | sambork: also sean-k-mooney is happy that the doc/reno/zuul patch is separate so I will not squash that in https://review.opendev.org/c/openstack/nova/+/958575/1 | |
| 08:35:28 | gibi | bauzas: ^^ hold you reviews until I re-spin | |
| 08:36:02 | bauzas | ack, anyway, I was aiming to review only by the next 30 mins, no worries | |
| 08:36:39 | opendevreview | Merged openstack/nova stable/2024.1: Reproduce bug/2098496 https://review.opendev.org/c/openstack/nova/+/945100 | |
| 08:42:51 | bauzas | tkajinam: I finished reviewing your series, nothing holding (I mostly +2d) except one breaking change you introduce by requiring a SEV trait | |