Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2025-08-18
08:44:55 gibi yeah. bauzas is still on PTO
08:45:02 gibi and US is asleep
08:55:58 opendevreview Balazs Gibizer proposed openstack/nova stable/2024.2: DNM: Reproduce bug/2116852 with decreasing mem limit https://review.opendev.org/c/openstack/nova/+/957541
09:08:22 opendevreview Balazs Gibizer proposed openstack/nova master: [vncproxy]Handle ssl.wrap_socket removal in py312 https://review.opendev.org/c/openstack/nova/+/955915
09:08:22 opendevreview Balazs Gibizer proposed openstack/nova master: Warn on long task wait time for executor https://review.opendev.org/c/openstack/nova/+/952666
13:00:45 opendevreview Takashi Kajinami proposed openstack/nova master: Remove unused validator for uri element https://review.opendev.org/c/openstack/nova/+/951084
13:05:35 tkajinam it has been a while since https://review.opendev.org/c/openstack/nova/+/879021 got one +2. I wonder if it can be merged.
13:15:12 opendevreview Balazs Gibizer proposed openstack/nova stable/2024.2: DNM: Reproduce bug/2116852 with decreasing mem limit https://review.opendev.org/c/openstack/nova/+/957541
15:15:47 opendevreview Stephen Finucane proposed openstack/nova master: api: Fix validators for hw:cpu_max_* extra specs https://review.opendev.org/c/openstack/nova/+/957732
15:21:19 opendevreview Stephen Finucane proposed openstack/nova stable/2025.1: api: Fix validators for hw:cpu_max_* extra specs https://review.opendev.org/c/openstack/nova/+/957739
15:25:05 opendevreview Stephen Finucane proposed openstack/nova stable/2024.2: api: Fix validators for hw:cpu_max_* extra specs https://review.opendev.org/c/openstack/nova/+/957744
15:25:29 opendevreview Stephen Finucane proposed openstack/nova stable/2024.1: api: Fix validators for hw:cpu_max_* extra specs https://review.opendev.org/c/openstack/nova/+/957745
16:05:38 opendevreview sean mooney proposed openstack/nova master: restrict swap volume to cinder https://review.opendev.org/c/openstack/nova/+/957757
16:06:23 opendevreview sean mooney proposed openstack/nova stable/2025.1: restrict swap volume to cinder https://review.opendev.org/c/openstack/nova/+/957759
16:06:52 opendevreview sean mooney proposed openstack/nova stable/2024.2: restrict swap volume to cinder https://review.opendev.org/c/openstack/nova/+/957762
16:07:23 opendevreview sean mooney proposed openstack/nova stable/2024.1: restrict swap volume to cinder https://review.opendev.org/c/openstack/nova/+/957764
16:11:20 opendevreview sean mooney proposed openstack/nova master: restrict swap volume to cinder https://review.opendev.org/c/openstack/nova/+/957757
16:11:42 opendevreview sean mooney proposed openstack/nova master: restrict swap volume to cinder https://review.opendev.org/c/openstack/nova/+/957757
16:13:54 opendevreview sean mooney proposed openstack/nova stable/2025.1: restrict swap volume to cinder https://review.opendev.org/c/openstack/nova/+/957759
16:14:42 opendevreview sean mooney proposed openstack/nova stable/2024.2: restrict swap volume to cinder https://review.opendev.org/c/openstack/nova/+/957762
16:15:29 opendevreview sean mooney proposed openstack/nova stable/2024.1: restrict swap volume to cinder https://review.opendev.org/c/openstack/nova/+/957764
17:22:44 melwitt gibi: hi, sorry there is one more thread on the vtpm series that would appreciate your thought. it's about the default_tpm_secret_security config option + the user confirmation mechanism https://review.opendev.org/c/openstack/nova/+/942502/13/nova/scheduler/request_filter.py#477
17:23:11 gibi melwitt: OK i will check
17:24:31 melwitt gibi: thanks 🙏 the last few comments are where you are mentioned for input
22:18:56 opendevreview Merged openstack/nova master: api: Deprecate v2 API https://review.opendev.org/c/openstack/nova/+/954102
#openstack-nova - 2025-08-19
01:00:43 opendevreview Merged openstack/nova master: restrict swap volume to cinder https://review.opendev.org/c/openstack/nova/+/957757
05:38:34 gibi elodilles: when you are up could you look at https://review.opendev.org/q/topic:%22bug/2112187%22+project:openstack/nova backports. It is important as it is a security hardening bug
07:02:45 sean-k-mooney[m] gibi thanks for updating tempest, is that third test new? i tought ran tempest full - the encyption adn cinder backup tests on friday so im not sure why i didnt see it fail
07:07:11 sean-k-mooney[m] hum no i must not have set the approate tempest config locally and it must have skiped
07:07:48 sean-k-mooney[m] i proably didnt explictly define the multiatch volume type of something along those lines
07:17:18 gibi sean-k-mooney[m]: yeah it is not new
09:08:06 opendevreview Merged openstack/nova stable/2025.1: restrict swap volume to cinder https://review.opendev.org/c/openstack/nova/+/957759
09:16:31 opendevreview Max proposed openstack/nova master: fix: leftover volume_attachment on instance delete https://review.opendev.org/c/openstack/nova/+/934984
12:02:24 sean-k-mooney gibi: did you see my comment last week about using RSS instead of adress_sapce for the prlimit for the qemu-img commands by the way?
12:04:43 sean-k-mooney priteau: approved
12:05:48 priteau Thank you sean-k-mooney :)
12:41:56 opendevreview Kamil Sambor proposed openstack/nova master: Switch nova-conductor to use ThreadPoolExecutor https://review.opendev.org/c/openstack/nova/+/957088
13:18:08 gibi sean-k-mooney: I saw and made a note abuot it
13:18:39 gibi I have to get back to it eventually
13:27:16 sean-k-mooney gibi: i assum you have not pushed a poc patch to bump the limit yet? i could try and push one to swap ti to rss and depend on the DNM ci job revert patch you have
13:32:53 gibi sean-k-mooney: I only pinpointed the address space limit increase we need on master +5MB. And I tried to see how much address space we used before the new ceph but I cannot get that data as i) I cannot roll back the ceph version in ubuntu as the package repo already cleaned ii) the older ubuntu based jobs does not want to run the specific test for me even though I think I set everything. But I had
13:32:59 gibi not time to dig deep into RSS at all
13:33:39 gibi the problem with RSS is similar, we don't know the baseline usage.
13:34:05 gibi so we cannot judge the that the increase is just small and OK, or it is a huge bump from the previous version
13:34:34 gibi if you have time you sure you can play with it to get an RSS number we need on master
13:35:13 sean-k-mooney well i was orginally thinking fo using the same 1G limit to start with but on RSS not adress space
13:35:35 sean-k-mooney and then cosndiering if we need to factor it out to a tuneable config option later
13:36:10 sean-k-mooney the orgianl intent of the limit was to workaroudn some pathological beahivor in old version of qemu-img with untrusted input
13:36:13 gibi I suggest to at least try locally with different volume sizes to see if the RSS is depending on the size of the volume
13:36:32 gibi sean-k-mooney: I affraid we might have a new pathological behavior :)
13:37:02 gibi today the test resizes an 1G volume to a 2G volume
13:37:02 sean-k-mooney well i think sinc ethey are now recfacotring things to use stackless corutiens in the newer version of c++
13:37:20 gibi so the test is not really realistic. Out there the volumes are lot bigger
13:37:22 sean-k-mooney that the amoutn of adress space has increase but not nessisarly the amount of commit memory
13:37:32 gibi yeah I agree about that ^^
13:37:36 gibi so RSS is a good direction
13:37:44 sean-k-mooney gibi: in principal this does not matter abot voluems corroct
13:37:56 sean-k-mooney we coudl do some local testign with files of diffent size
13:38:12 sean-k-mooney or do you think the volumes actully play an imporant role
13:38:28 sean-k-mooney oh actully this iss in the rbd code path
13:38:39 sean-k-mooney so we likely do need ceph right?
13:38:42 gibi either the volume, or the fact that it is luksv1 encrypted, or the fact that the test case is resizing plays a role as other test cases does not fail
13:39:05 sean-k-mooney ack so ya we woudl need to test a few diffent ways.
13:39:19 gibi File "/opt/stack/tempest/tempest/api/volume/admin/test_encrypted_volumes_extend.py", line 41, in test_extend_attached_encrypted_volume_luksv1
13:39:21 sean-k-mooney i wonder fi there is a way to log this info
13:39:24 gibi this is the test case that triggers it
13:39:55 sean-k-mooney we porobaly shoudl park this for now but sinc ehte ceph folks are interested i also dont want to loose too much momentem
13:40:04 gibi we call a bunch of qemu-img info during tempest, but only this test trigger the out of memory for qemu-img info
13:40:31 sean-k-mooney ya so dans comment that the encyption may impact it seams valid
13:40:36 gibi yeah I have a bz open on ceph and they are responsive but we don't have a clear non tempest repro for them
13:41:11 sean-k-mooney i was wondering if we coudl create a smaller non openstack repdocuer too
13:41:18 sean-k-mooney that why i was wondering about a file
13:41:40 gibi I copied the volume out of ceph as a file and run the same command it did not failed
13:41:41 sean-k-mooney but we could likely jsut see if we can manually repoduce this with ceph and qemu directly
13:41:51 sean-k-mooney i just dont happen to have a ceph install to hand currently
13:41:53 gibi so rbd is in the picture
13:42:02 sean-k-mooney ack
13:42:32 sean-k-mooney so im wondering is it as simple as create a raw image wiht luks, upload that to ceph as a voluem
13:42:50 sean-k-mooney extend the volume and messure the adress space and rss
13:42:56 sean-k-mooney fo qemu image as you grow it
13:43:19 gibi yeah that can be tried
13:43:39 gibi realistically for me it is not earlier than next week when I can try
13:43:54 sean-k-mooney ya i was goign to say the same
13:43:57 sean-k-mooney post FF
13:44:32 sean-k-mooney i can do the quick RSS hack and push but digging deeper will take more time then ill have before FF or perhaps RC1 is done
13:45:09 gibi ack
14:07:36 dansmith gibi: I wonder if you could look at this conversation: https://review.opendev.org/c/openstack/nova/+/952630/12/nova/conductor/manager.py#322
14:07:52 dansmith I really hate this idea that we have to do a mini data migration (from instance to reqspec) every time we do a move operation
14:08:18 dansmith it feels fragile to me, like we could end up missing that step in some cases, and/or get other weird rebuild/evac/whatever behavior later, and after hours of debugging,
14:08:36 dansmith realize that one instance worked because it had been migrated once (and thus got the reqspec change) and another failed because it had never been migrated
14:09:23 gibi dansmith: OK, added to my list along with the other place https://review.opendev.org/c/openstack/nova/+/942502/13/nova/scheduler/request_filter.py#477 melwitt ping me about yesterday
14:09:27 dansmith (in this case I mean s/migrated/moved in some way/)
14:09:39 dansmith gibi: ack, thanks
14:14:09 dansmith gibi: that's a similar theme to the question above.. all about how we define, choose, and expose the default policy we choose for new instances when they don't otherwise request one
15:01:49 Uggla Hello, nova meeting in ~1h.
15:05:46 jssfr Uggla, I might not make it, but I'd like to bring https://review.opendev.org/c/openstack/nova/+/955657 to the table -- I managed to (hopefully) bring the patch into shape as discussed two weeks ago and I'd appreciate any reviews or feedback :)
15:06:01 jssfr I'll read up on IRC discussion if I'm pinged here, too (but probably I'm going to be preparing dinner at the meeting time :-X) :)
16:00:25 Uggla #startmeeting nova
16:00:25 opendevmeet Meeting started Tue Aug 19 16:00:25 2025 UTC and is due to finish in 60 minutes. The chair is Uggla. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:25 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.

Earlier   Later