| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-07-31 | |||
| 16:32:41 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (1/6) https://review.opendev.org/c/openstack/nova/+/956234 | |
| 16:32:41 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (2/6) https://review.opendev.org/c/openstack/nova/+/956236 | |
| 16:32:43 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (3/6) https://review.opendev.org/c/openstack/nova/+/956237 | |
| 16:32:43 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (4/6) https://review.opendev.org/c/openstack/nova/+/956238 | |
| 16:32:45 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (5/6) https://review.opendev.org/c/openstack/nova/+/956239 | |
| 16:32:45 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for servers APIs (6/6) https://review.opendev.org/c/openstack/nova/+/956240 | |
| 16:32:47 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Invert validation check https://review.opendev.org/c/openstack/nova/+/956241 | |
| 16:32:47 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server shares APIs https://review.opendev.org/c/openstack/nova/+/956266 | |
| 16:33:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow to start unit test without eventlet https://review.opendev.org/c/openstack/nova/+/953436 | |
| 16:33:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run unit test with threading mode https://review.opendev.org/c/openstack/nova/+/953475 | |
| 16:33:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: [test]RPC using threading or eventlet selectively https://review.opendev.org/c/openstack/nova/+/953815 | |
| 16:33:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: [CI]Make nova-tox-py312-threading voting https://review.opendev.org/c/openstack/nova/+/955791 | |
| 16:33:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: [vncproxy]Handle ssl.wrap_socket removal in py312 https://review.opendev.org/c/openstack/nova/+/955915 | |
| 16:34:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make RBD Tpool usage conditional https://review.opendev.org/c/openstack/nova/+/956089 | |
| 16:34:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make libvirt Tpool proxying conditional https://review.opendev.org/c/openstack/nova/+/956090 | |
| 16:34:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix ProviderTree copying with threading Lock https://review.opendev.org/c/openstack/nova/+/956091 | |
| 16:34:01 | opendevreview | Balazs Gibizer proposed openstack/nova master: [test]Further categorization of disabled unit tests https://review.opendev.org/c/openstack/nova/+/956092 | |
| 16:34:03 | opendevreview | Balazs Gibizer proposed openstack/nova master: Warn on long task wait time for executor https://review.opendev.org/c/openstack/nova/+/952666 | |
| 16:38:10 | gmaan | stephenfin: sure? I was happy on tuesday that i finished the series :P | |
| 16:39:34 | stephenfin | I mean, I can find more things 🙃 But no, done. I wasn't submitting them all at once because...107 (!) patches is a lot of patches | |
| 16:50:06 | gmaan | I know and understand. | |
| 17:14:03 | sean-k-mooney | gmaan: speaking of patchs i left some comment on your docs fix yesterday | |
| 17:14:27 | sean-k-mooney | oh stephen adressed them | |
| 17:14:54 | gmaan | sean-k-mooney: yeah, I updated those and further stephenfin refined those more | |
| 17:15:41 | sean-k-mooney | ok ill review that now and we can hopefully land that soonish | |
| 17:16:16 | gmaan | thanks | |
| 17:51:45 | opendevreview | melanie witt proposed openstack/nova master: DNM test volume snapshot NFS https://review.opendev.org/c/openstack/nova/+/956282 | |
| 17:54:15 | opendevreview | melanie witt proposed openstack/nova master: DNM test volume snapshot NFS https://review.opendev.org/c/openstack/nova/+/956282 | |
| 17:54:37 | melwitt | sean-k-mooney: you are too fast 😂 | |
| 17:55:29 | sean-k-mooney | hehe it was just good timing | |
| 17:55:30 | melwitt | I actually did it right on my WIP patch but now I want to test the baseline and see if the existing volume snapshot scenario test repro's the bug or if I need to add something to the tempest test | |
| 17:56:26 | sean-k-mooney | this is for the removal of the last snapshot or a diffent nfs snapthot bug | |
| 17:57:13 | sean-k-mooney | sorry its for https://review.opendev.org/c/openstack/nova/+/955039 | |
| 17:57:23 | sean-k-mooney | the absulte path issue | |
| 17:58:56 | sean-k-mooney | melwitt: did we confirm if devstack-plugin-nfs-tempest-full is doing cinder nfs nova nfs or both | |
| 17:59:17 | melwitt | sean-k-mooney: oh bleh I forgot about that | |
| 17:59:19 | sean-k-mooney | i see only one compute so i assuem cidner nfs but not nova on nfs | |
| 17:59:34 | melwitt | yeah I expect you're right | |
| 17:59:48 | sean-k-mooney | it could be both but it would not test live migraiton | |
| 18:00:05 | melwitt | thanks for mentioning it. my brain is just 😑 | |
| 18:01:01 | sean-k-mooney | ya so its cinder nfs and that will verify the issue your tryign to fix | |
| 18:01:03 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/ae12c161604b49e49e05b8ccef739785/log/controller/logs/etc/cinder/cinder_conf.txt | |
| 18:03:16 | sean-k-mooney | so the nova-ovs-hybrid plug job currently test well ml2/ovs with hybrid plug for move ops but also spice on debian 12 | |
| 18:03:27 | sean-k-mooney | i want to rename that to nova-alt | |
| 18:03:51 | sean-k-mooney | so like nova-next but no implciation that the alternitive config it is testing are intended to become new defaults | |
| 18:04:11 | sean-k-mooney | i think we could slot nfs testing into that too | |
| 18:05:49 | melwitt | ah ok | |
| 18:07:23 | melwitt | I'd at least name it nova-alt-config because nova-alt sounds too vague to me | |
| 19:10:37 | sean-k-mooney | but want if i want a dark mode emo job :) | |
| 19:11:09 | sean-k-mooney | but ya good idea i just want to name it somehting better then it is currenlty if we extend the focus of the job | |
| 19:12:30 | opendevreview | Merged openstack/nova master: Fix doc comment on manager role change https://review.opendev.org/c/openstack/nova/+/956189 | |
| 19:16:04 | melwitt | yep agreed | |
| 19:16:58 | melwitt | nova-goth | |
| 19:17:10 | melwitt | the dark practice of using nfs | |
| 19:18:26 | melwitt | ok so the existing tempest test doesn't trigger the bug so I'll try adding something to it | |
| 19:24:51 | sean-k-mooney | oh so you wont see it in single node | |
| 19:25:32 | sean-k-mooney | so the relitive path bug happens because thing are mounted at diffent locations based on cidner volume vs nova presecitve right | |
| 19:26:06 | sean-k-mooney | so i think to see it you will need a 2 node jobs wherne you run nova compute on a serepte ndoe form cidner | |
| 19:26:09 | melwitt | yes | |
| 19:26:42 | sean-k-mooney | ya so you will need to tweak the job to do that by usign the multi node node set and disbale n-cpu on the contoller | |
| 19:27:03 | melwitt | I wonder if the lack of a second snapshot is related | |
| 19:27:20 | sean-k-mooney | yes perhaps try that first | |
| 19:27:29 | melwitt | ++ | |
| 19:27:52 | sean-k-mooney | im not sure if it iss but that was what war reported right multiple snaphost and it was the last oen that failed to be removed | |
| 19:28:14 | melwitt | right. the repro steps also say to create 2 or more snapshots | |
| 19:28:35 | sean-k-mooney | im not entirly sure why that woudl matter but it woudl likely explain why it was missed | |
| 19:29:03 | sean-k-mooney | beyond the fact we dont test nfs i mean :) | |
| 19:29:29 | melwitt | heh | |
| 20:02:12 | opendevreview | melanie witt proposed openstack/nova master: DNM test volume snapshot NFS https://review.opendev.org/c/openstack/nova/+/956282 | |
| 20:46:06 | mikal | sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/950643 is ready for a quick re-review whenever you have a minute. | |
| 21:05:13 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Get info with abs path, rebase with rel path https://review.opendev.org/c/openstack/nova/+/955039 | |
| 21:32:26 | melwitt | ok cool the use of two snapshots did repro the bug without needing to go to multinode | |
| 21:36:26 | sean-k-mooney | mikal: well i just got back from a dog walk and put food in the oven so sure i have 20 mins | |
| 21:39:28 | sean-k-mooney | mikal: looks good to me | |
| 21:40:15 | sean-k-mooney | melwitt: i wonder why it needs two, do you know? | |
| 21:47:55 | melwitt | sean-k-mooney: something to do with nova rebasing the image. there's something where when you delete a volume snapshot while the instance is stopped, nova will end up rebasing the image which corrupts the metadata and then attempt to delete the last snapshot fails on the cinder side | |
| 21:49:27 | melwitt | so the repro is, boot from volume, create two volume snapshots, stop instance, delete the newest volume snapshot (works), delete the oldest volume snapshot (fails) | |
| 21:49:50 | melwitt | this is what I uploaded to do ^ https://review.opendev.org/c/openstack/tempest/+/956302/1/tempest/scenario/test_volume_boot_pattern.py | |
| 21:54:51 | sean-k-mooney | melwitt: so nova is not ment to allow that | |
| 21:55:07 | sean-k-mooney | when the instnace is stopped nova returns a 400 to cinder | |
| 21:55:30 | sean-k-mooney | when it calls the assisted voluem snapshot delete api | |
| 21:56:47 | sean-k-mooney | ya that tesss looks resonable | |
| 21:57:11 | gmaan | sean-k-mooney: that is only case (nova reject based on instance state )when merge_target_file is None https://github.com/openstack/nova/blob/master/nova/compute/api.py#L5926C34-L5926C51 | |
| 21:57:39 | gmaan | NOT None | |
| 21:57:59 | gmaan | when i looked into this bug, i also got confused with when nova reject based on instance state and when not | |
| 21:58:02 | sean-k-mooney | hum | |
| 21:58:25 | sean-k-mooney | well that is proably too narrorw | |
| 21:58:42 | gmaan | yeah | |
| 21:58:45 | sean-k-mooney | i mean we could make it work offline | |
| 21:58:57 | sean-k-mooney | but for right now there are obviously other cases where it can fail | |
| 21:59:29 | sean-k-mooney | https://bugs.launchpad.net/nova/+bug/1919487 | |
| 21:59:36 | sean-k-mooney | that was the bug lee was tryign to mitigate | |
| 22:00:22 | sean-k-mooney | ok so thinking about this | |
| 22:00:57 | sean-k-mooney | if (delete_info.get('merge_target_file') is not None and | |
| 22:00:59 | sean-k-mooney | instance.vm_state != vm_states.ACTIVE | |
| 22:01:01 | sean-k-mooney | ): | |
| 22:01:26 | melwitt | not supposed to allow it? I did not know that | |
| 22:01:26 | sean-k-mooney | so if there is a merge_target_file | |
| 22:01:32 | sean-k-mooney | and the vm is stopped | |
| 22:01:34 | melwitt | coincidence I guess that it works fine with relative paths | |