| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-07-02 | |||
| 15:31:18 | opendevreview | ribaudr proposed openstack/nova-specs master: Enable memfd support for shared memory backing https://review.opendev.org/c/openstack/nova-specs/+/951689 | |
| 15:32:17 | gibi | gmaan: cool, I agree that we need a deprecation first | |
| 15:32:57 | Uggla | sean-k-mooney, if you can have a look at 951689: Enable memfd support for shared memory backing | https://review.opendev.org/c/openstack/nova-specs/+/951689 let me know if I manage to capture all you inputs. | |
| 15:33:14 | Uggla | sean-k-mooney, no urgency on that one. | |
| 15:33:36 | gibi | fyi, Sree while verifying PCI in Placement caught a nice, long standing bug in our pci tracker https://bugs.launchpad.net/nova/+bug/2115729 | |
| 15:34:56 | opendevreview | Merged openstack/nova-specs master: Deprecate v2.0 API https://review.opendev.org/c/openstack/nova-specs/+/951949 | |
| 15:48:30 | Uggla | gibi, I have seen this bug yesterday. kudos to Sree. I guess I can triage it as a valid one ? | |
| 15:48:47 | gibi | I did the triage now that I found the root cause | |
| 15:49:03 | gibi | I will push a fix in 30 mins... | |
| 15:50:50 | Uggla | gibi, faster than light ! | |
| 15:54:37 | gibi | this is a typical bug where finding the root cause is the hard thing, fixing it is the easy | |
| 16:05:02 | ratailor | gmaan, could you please provide your feedback on https://review.opendev.org/c/openstack/nova-specs/+/929780/ my replies ? | |
| 16:08:33 | opendevreview | Rajesh Tailor proposed openstack/nova-specs master: Show finish_time field in instance action show https://review.opendev.org/c/openstack/nova-specs/+/929780 | |
| 16:09:05 | ratailor | sean-k-mooney, gibi could you please also review ^^ as tomorrow is last date for FF. | |
| 16:12:16 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce that only half of the PCI devs are removed https://review.opendev.org/c/openstack/nova/+/953971 | |
| 16:12:17 | opendevreview | Balazs Gibizer proposed openstack/nova master: Fix pci_tracker.save to delete all removed devs https://review.opendev.org/c/openstack/nova/+/953972 | |
| 16:12:46 | gmaan | ratailor: sure, will check today | |
| 16:13:20 | ratailor | gmaan, Thanks! | |
| 18:29:46 | opendevreview | Alexey Stupnikov proposed openstack/nova master: Use updated_at to purge shadow_instance_extra https://review.opendev.org/c/openstack/nova/+/953984 | |
| 18:33:58 | opendevreview | Alexey Stupnikov proposed openstack/nova master: Use updated_at to purge shadow_instance_extra https://review.opendev.org/c/openstack/nova/+/953984 | |
| 18:41:46 | sean-k-mooney | gibi: bauzas Uggla did ye look at my verion of the iothreads spec by the wayhttps://review.opendev.org/c/openstack/nova-specs/+/953940/2/specs/2025.2/approved/dynamic-vm-iothreads.rst | |
| 18:42:02 | sean-k-mooney | we are unlikely to merge either by tomorrow but i fell like my version is closer | |
| 18:50:55 | opendevreview | Merged openstack/nova-specs master: Add flavor-search-by-name spec https://review.opendev.org/c/openstack/nova-specs/+/940440 | |
| 19:28:45 | Uggla | sean-k-mooney, yep I have quickly looked at it. Tbh I think from technical point of view It looks great. I'm just annoyed about how masahito feels about it. I'd like a kind of co authoring and make sure his need is fulfill by the spec too. I will discuss with him tomorrow, because I'd like to explain, the goal is not to overwrite his spec but | |
| 19:28:45 | Uggla | combine the two. | |
| 19:31:24 | mikal | fungi: my general recollection of this decade old coversation aligns with what sean-k-mooney said. Config drive v2 was always meant as a stop gap until everyone was using the metadata service. It really only existed at all because it was copied from AWS. I'm confused by your x86 address detection comments because the metadata service just uses a | |
| 19:31:24 | mikal | hard coded zeroconf IP address on any of the clouds I can think of. | |
| 19:32:07 | mikal | fungi: certainly a lot of the warts in config drive (like it originally not being able to be updated, although I think maybe that's fixed now) were because it was seen as a temporary thing. | |
| 19:35:41 | fungi | mikal: i was mis-remembering the bug, looking at the cloud-init commit it's "nova detection" really. they want to only contact the metadata server address for discovery if run in an openstack (or ec2) cloud, so are checking dmi to determine if it's safe to do so, but that check is only viable on x86 | |
| 19:36:51 | fungi | so when it comes to booting generic non-x86 distro cloud images with cloud-init included, the recommendation is to rely on configdrive instead | |
| 19:37:06 | mikal | Honestly most of that DMI stuff is a bit dumb. That data exists in metadata, why do we ram it into two places one of which doesn't work on other architectures? | |
| 19:38:06 | fungi | yeah, and so if nova didn't do that even on x86, then cloud-init would really just recommend distros go back to making openstack-specific images so they could set the override in the kernel command-line or an embedded conffile | |
| 19:38:40 | fungi | (or suggest always using configdrive maybe) | |
| 19:38:42 | mikal | I'm not here to hate on config drive. My point is more that its outlived its expected life, had some weird implementation choices because of the time it was done in, and probably needs some love if its really here forever. | |
| 19:39:14 | opendevreview | Brett Holman proposed openstack/nova master: Add DMI data to non-x86 architectures https://review.opendev.org/c/openstack/nova/+/953989 | |
| 19:39:35 | mikal | Like for example it execs a command line to build the ISO image, solely because the only library we could find at the time to do it nicely was GPL and we refused to use GPL dependencies. | |
| 19:39:37 | fungi | agreed, it has challenges, for example the earlier change at the start of this discussion about using virtio for cdrom devices by default, because debian doesn't include ahci drivers in their genericcloud kernel configs | |
| 19:40:07 | mikal | FAT config drives should work too? IIRC it doesn't _have_ to be a CDROM, it just defaults to that? | |
| 19:40:12 | mikal | Its been a long time. | |
| 19:40:52 | fungi | it probably could be any kind of block device, i think it was virtual cd by convention so not sure if that assumption is baked into places (e.g. in cloud-init) | |
| 19:42:11 | fungi | granted, forcing a different device type is still going to be a custom image property on upload or some similar override, if it's not nova's default | |
| 19:51:47 | mikal | So cloud-init will only probe for a couple of things to match -- device ID matters (config2) and type. The probing code only looks for CDROMs or FAT formatted disks IIRC. | |
| 19:53:10 | mikal | Honestly, most of the people I know who really use metadata use it as a poor man's replacement for Nova not having some sort of mature out of band agent thing. They really want AWS SSM agent or equivalent -- https://docs.aws.amazon.com/systems-manager/latest/userguide/ssm-agent.html. | |
| 19:54:17 | mikal | We could do the same with either a custom agent or the qemu agent (although the qemu agent has some pretty big limitations), that bit isn't too hard. The hard bit is marshalling the requests into the instance. That likely involves some sort of per-instance queue that Nova doesn't have right now. | |
| 19:58:38 | fungi | yeah, an actual communication channel from host to guest at least, if not bi-directional | |
| 19:59:04 | mikal | Yeah, specifically one which doesn't not require networking to be configured and working. | |
| 19:59:38 | mikal | I worked for a training startup for a bit... We did all sorts of contortions to rescue VMs when students messed up their networking. This would have made it so much easier. | |
| 19:59:49 | fungi | a fifo-like proc interface in the kernel or something would be amazing | |
| 20:00:29 | fungi | and/or pseudofiles like device drivers tend to expose | |
| 20:00:32 | mikal | So qemu-agent uses a unix domain socket on the outside and virtio-serial on the inside and speaks JSON blobs, which is a bit terrible. Serial means only one talker at a time. | |
| 20:01:39 | fungi | though at boot time, one talker in the guest is generally sufficient? | |
| 20:01:48 | mikal | ShakenFist does this with a unix domain socket on the outside and virtio-vsock on the inside, and speaks protobufs. That's actually really cool if I don't say so myself because the in-guest agent can just run a socket server like you're used to and serve N requests at the same time because virtio-vsock does all the multiplexing for you. | |
| 20:01:59 | fungi | or maybe not these days, with the advent of parallel boot processing | |
| 20:02:40 | mikal | Serialized requests forces you to come up with some sort of queueing / locking mechanism to handle the case of multiplem requests, even if its not used much. | |
| 20:03:14 | fungi | the protobuf design sounds nice, if only protobuf libraries weren't such shifting sand these days (ut maybe they're getting better) | |
| 20:03:53 | mikal | https://www.madebymikal.com/virtio-vsock-python-examples-of-running-the-server-in-the-guest/ is what I wrote up when I was playing with virtio-vsock. | |
| 20:06:23 | fungi | yeah, i guess low-level socket access like that is probably enough for these cases, you don't need google's own protobuf libs | |
| 20:09:34 | fungi | oh, i see what you're saying, shakenfist tunnels protobufs over an interface like that | |
| 20:09:52 | fungi | you'd still need separate libs for the serialization i guess | |
| 20:12:10 | mikal | Yes, virtio-vsock is the transport, and I talk protobuf down it. Qemu talks JSON in its similar but slightly more terrible case. | |
| 20:12:21 | mikal | Notably I do not talk gRPC, just the serialization protocol. | |
| 20:12:39 | mikal | But meh, its just serialization. It could be JSON for all it matters. | |
| 20:12:59 | mikal | The in-guest agent could present a REST API for example over virtio-vsock and that would not be insane. | |
| 20:15:57 | fungi | makes sense, and yes grpc is a much bigger mess | |
| 20:17:34 | mikal | On reflection, I am also a bit confused about the "tangled python deependencies" answer to why glean is needed compared to cloud-init. Isn't that just a case of using venvs for the various competing components? Especially when modern pythons are super opposed to you installing directly into the system pip? | |
| 20:29:41 | fungi | devstack is finally in a position to be able to isolate openstack services from the system python module search path, but that's an extremely recent change | |
| 20:35:21 | fungi | i recall clarkb hacked on versions of that improvement for years before it reached a state others in the community were comfortable with | |
| 20:36:41 | clarkb | from the CI/OpenDev perspective I think there are two primary reasons we liek config drive. The first is that it is incredibly reliable. The boot error rate with metadata service is >0 and in some cases quite high. The other is that it is simple. Cloud-init configures a lot of stuff and sometimes in desctructive ways (it once decided to do bad things to volume mounts). Glean | |
| 20:36:43 | clarkb | sets up your network and ssh keys and that is about it | |
| 20:37:17 | clarkb | today we can only boot ubuntu noble in rackspace classic with config drive. Metadata does not work. This is with the upstream ubuntu noble cloud image which uses cloud init (not glean) | |
| 20:37:55 | clarkb | (that is because rackspace doesn't do metadata in the way normal clouds do iirc and they don't have their custom image for noble yet (or ever) so the only way it works with standard tools is config drive) | |
| 20:39:09 | clarkb | naively I'm not sure what the issue is. From the end user standpoint config drive is simple and bullet proof | |
| 20:40:26 | clarkb | the ability to mount iso9660 or fat32 devices is near univeral, the data is small and static. Using a complicated api service that requires hosts know how to magically negotiate a protocal more complicated than `mount` is always going to be more error prone. | |
| 20:40:53 | clarkb | iirc there are layers of proxies involved ont he backend too (which I want to say was the assumed source of the flakyness when we shifted all our ci nodes to config drive) | |
| 21:00:54 | mikal | I am not sure there is an issue, I am just surprised given config drive was meant to be a temporary fix which seems to have "rusted on". If it's genuinely around forever it could probably do with some love. | |
| 21:07:30 | clarkb | I think the primary downside to config drive is that it consumes one of your disk slots. I know this is a problem for Xen. Not sure about KVM | |
| 21:08:11 | clarkb | with Xen you only get something like 16 disks. One of which is implicitly owned by the root disk then config drive consumes a second. This limits you to 14 devices which may limit the total storage attachable to the instance if you also have volume size limits | |
| #openstack-nova - 2025-07-03 | |||
| 01:45:58 | sean-k-mooney[m] | i dont think we should supprot the dmi info at all | |
| 01:46:28 | sean-k-mooney[m] | its a libvirt internal implation detail so im really not a fan of building on that for config drive or any other metadata mechanium | |
| 01:47:12 | sean-k-mooney[m] | i certainly dont want to rush into adding supprot for this as a bug fix without propper discussion as this si an undocumjented internal detail | |
| 01:51:04 | sean-k-mooney[m] | if your using virtio-scsi you can have 100s of disks if needed but iconfig drive does consume a pci/pcie sloct by default but iits not generally a problem | |
| 06:43:33 | mikal | sean-k-mooney[m]: I finally have all the USB and sound changes passing CI, so that's nice. | |
| 09:00:03 | Uggla | sean-k-mooney[m], fyi I did a first review pass on 953940: support iothread for nova vms | https://review.opendev.org/c/openstack/nova-specs/+/953940 | |
| 09:25:49 | bauzas | sean-k-mooney[m]: honestly, I'd prefer to leave the current owner to provide a new revision from him | |
| 09:54:34 | mikal | For what its worth, https://review.opendev.org/q/topic:%22libvirt-vdi%22 is a series of four patches all with passing CI and a +2 on them if someone has a spare minute or two. | |
| 10:01:26 | sean-k-mooney | bauzas: well i wanted to hevilaly revise there proposal, also i have propsoed thie in some form twice before so i wrote it form scratch based on my prior exploration of this in past cycles | |
| 10:38:14 | opendevreview | Alexey Stupnikov proposed openstack/nova master: Don't create instance_extra entry for deleted instance https://review.opendev.org/c/openstack/nova/+/412771 | |
| 11:49:18 | opendevreview | Rajesh Tailor proposed openstack/nova-specs master: Show finish_time field in instance action show https://review.opendev.org/c/openstack/nova-specs/+/929780 | |
| 12:10:16 | opendevreview | sean mooney proposed openstack/nova-specs master: support iothread for nova vms https://review.opendev.org/c/openstack/nova-specs/+/953940 | |
| 12:43:01 | opendevreview | Biser Milanov proposed openstack/nova master: Hardcode the use of iothreads for KVM. https://review.opendev.org/c/openstack/nova/+/918669 | |
| 12:43:31 | opendevreview | Biser Milanov proposed openstack/nova master: Hardcode the use of iothreads for KVM. https://review.opendev.org/c/openstack/nova/+/918669 | |
| 12:54:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-api and -metadata in threaded mode https://review.opendev.org/c/openstack/nova/+/951957 | |
| 12:54:22 | opendevreview | Balazs Gibizer proposed openstack/nova master: Warn on long task wait time for executor https://review.opendev.org/c/openstack/nova/+/952666 | |
| 12:54:23 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow to start unit test without eventlet https://review.opendev.org/c/openstack/nova/+/953436 | |
| 12:54:23 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run unit test with threading mode https://review.opendev.org/c/openstack/nova/+/953475 | |
| 12:54:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: [test]RPC using threading or eventlet selectively https://review.opendev.org/c/openstack/nova/+/953815 | |
| 12:59:19 | opendevreview | Balazs Gibizer proposed openstack/nova master: Do not yield in threading mode https://review.opendev.org/c/openstack/nova/+/950994 | |
| 12:59:20 | opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-api and -metadata in threaded mode https://review.opendev.org/c/openstack/nova/+/951957 | |
| 12:59:20 | opendevreview | Balazs Gibizer proposed openstack/nova master: Warn on long task wait time for executor https://review.opendev.org/c/openstack/nova/+/952666 | |
| 12:59:21 | opendevreview | Balazs Gibizer proposed openstack/nova master: Allow to start unit test without eventlet https://review.opendev.org/c/openstack/nova/+/953436 | |