| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-06-12 | |||
| 17:26:05 | sean-k-mooney | but if you have already fixed it on the ironic side | |
| 17:26:09 | sean-k-mooney | then thats fine too | |
| 17:26:23 | JayF | Having Ironic own some of the newtork metadata is a feature we'd need for standalone anyway | |
| 17:26:35 | JayF | and gives us more flexibility since (as I said before) we often know more than you all do about the physical world | |
| 17:26:37 | sean-k-mooney | ya that makes sense | |
| 17:26:58 | TheJulia | Yeah, we're seeing more asks for smoothing that general experience so, just makes sense to spot/address the highly specific items to make things better | |
| 17:26:59 | sean-k-mooney | i also think thie idea of ironic haveign the ablity to generate or enrish the config drive is also useful for that case | |
| 17:27:12 | TheJulia | So... | |
| 17:27:16 | TheJulia | Funny you should mention that! | |
| 17:27:23 | JayF | and honestly, the more I think about ^^ (the physical world not always being perfectly modelled in nova) is a ... feature not a bug? The entire benefit of ironic+nova integrated is keeping the experience simple ... and the real world is complex as hell lol | |
| 17:27:33 | TheJulia | we've semi-wondered outloud about "should we offer ssh key injection?!" | |
| 17:28:03 | sean-k-mooney | well keyparis works with ironic already right | |
| 17:28:08 | TheJulia | oh yeah | |
| 17:28:08 | sean-k-mooney | but you mean in standalone | |
| 17:28:11 | TheJulia | yeah | |
| 17:28:27 | sean-k-mooney | i sort of feel like the keypari really shoudl be in keystone | |
| 17:28:31 | JayF | we already support it in a supremely roundabout way | |
| 17:28:40 | sean-k-mooney | and hten we jsut get it form there or in barbican | |
| 17:28:42 | JayF | sean-k-mooney: notably that doesn't help most of our standalone users who use basic auth :) | |
| 17:28:43 | TheJulia | sean-k-mooney: agree, and that would make it sort of easier | |
| 17:28:43 | sean-k-mooney | btu legacy | |
| 17:28:48 | TheJulia | yup | |
| 17:28:50 | JayF | you can do arbitrary file injection in a deploy template | |
| 17:28:58 | JayF | but that's a lot of crap to do just to get an ssh key in | |
| 17:29:01 | TheJulia | yeah | |
| 17:29:28 | sean-k-mooney | i mean teh format of the config drive/metadata is pretty standarsied | |
| 17:29:38 | sean-k-mooney | so having the ablity for ironic to do that is not a bad thing | |
| 17:29:46 | JayF | TheJulia: the killer potential feature hiding under the surface there: Ironic somehow being able to inject troubleshooting-keys into IPA at boot time :D | |
| 17:29:53 | sean-k-mooney | woudl we use it in the combined case proably not but maybe | |
| 17:30:12 | TheJulia | JayF: I'd have concerns about doing that, but yeah, I've had asks for it in the past | |
| 17:30:15 | sean-k-mooney | JayF: cant it od that or do you have to buidl them in | |
| 17:30:30 | JayF | TheJulia: I have concerns about the whole thing but I'm assuming we can find a way to have the cake and eat it too :D | |
| 17:30:30 | sean-k-mooney | its been a long time since i deployed with bifrost | |
| 17:30:39 | TheJulia | So one thing on this entire subject, I'd <3 if nova just shipped us the dicts, but I'd have to double check the constraints and modeling for user input in nova again | |
| 17:30:42 | sean-k-mooney | but i remeber sshing into the ipa in the past to debug somthing | |
| 17:30:47 | TheJulia | its been years since I've walked that code path | |
| 17:31:24 | sean-k-mooney | TheJulia: JayF may rememebr this better then i but i think we just send you json blobs today | |
| 17:31:40 | sean-k-mooney | i woudl have to look but i dont think we provide a filesytem but i oculd be wrong | |
| 17:31:42 | TheJulia | sean-k-mooney: I don't think y'all actually do | |
| 17:31:43 | JayF | I remember nothing :) | |
| 17:31:47 | JayF | but we can check! | |
| 17:31:50 | TheJulia | I think we get handed an iso9660 file right now | |
| 17:32:02 | sean-k-mooney | oh ok | |
| 17:32:23 | sean-k-mooney | i mean we can always change that if you come up with a design | |
| 17:32:42 | TheJulia | the factory which builds it in the overall virt utils, if memory serves just hands us the file pre-formed | |
| 17:32:53 | sean-k-mooney | i might be conflating this with the auto leasee feature | |
| 17:32:58 | TheJulia | yeah | |
| 17:33:28 | sean-k-mooney | so the reaosn i was quistioning it is we currently store it in memcache | |
| 17:33:35 | sean-k-mooney | if you turn that one | |
| 17:33:47 | sean-k-mooney | so we ahve it in a dict like serisable datascuture | |
| 17:34:10 | TheJulia | Isent there a mechanism on the nova side to do file injection? | |
| 17:34:28 | sean-k-mooney | yes its deprecated and ahs been for about a decaade or so | |
| 17:34:31 | TheJulia | oh, good | |
| 17:34:41 | sean-k-mooney | its called personality files | |
| 17:35:11 | sean-k-mooney | you can also pass a user-data cript for cloud init that is what was ment to repalce arbity file injection | |
| 17:35:21 | TheJulia | okay, as I mentioned, it has been ages | |
| 17:35:28 | TheJulia | in the user-data payload right? | |
| 17:35:59 | sean-k-mooney | ya, either by passing somethign like a valut cred and downloading the afctul data on first boot or inline | |
| 17:36:03 | sean-k-mooney | it depens on the usecase | |
| 17:36:27 | TheJulia | yup, unfortunately I've done stuff like that long ago | |
| 17:37:41 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L1108-L1141 | |
| 17:38:58 | TheJulia | Yeah, we don't allow file passing today, but if that is the personality files stuff, maybe since its been deprecated so long it might make sense to drop and refactor? | |
| 17:38:59 | sean-k-mooney | so righ now we create a tempory file generate the config data gzip it, base64 encode and then decode it and pass that ot ironci | |
| 17:38:59 | TheJulia | dunno | |
| 17:39:41 | TheJulia | we only permit a pass-in of meta-data, user-data, and network-data via configdrive api on our provision endpoint | |
| 17:40:03 | TheJulia | I could have sworn that was structured a little differnetly in nova, but thanks! | |
| 17:40:17 | sean-k-mooney | it is | |
| 17:40:24 | sean-k-mooney | this is the ironic customtioation | |
| 17:41:12 | sean-k-mooney | all the other virt drviers share common code. the ironic driver uses the common code but then modifyes it before sending to to the ironci api | |
| 17:41:44 | sean-k-mooney | TheJulia: the ironic driver enriches the network metadta for exmaple https://github.com/openstack/nova/blob/master/nova/virt/ironic/driver.py#L1045-L1106 | |
| 17:42:36 | sean-k-mooney | the rest use https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L112 | |
| 17:44:22 | sean-k-mooney | so we have an objet in memoy thaat can redner subpaths into json for the metadta api https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L317 | |
| 17:45:00 | sean-k-mooney | or produce the content for the config drive https://github.com/openstack/nova/blob/master/nova/api/metadata/base.py#L590 | |
| 17:45:06 | TheJulia | Yeah, for portgroups. we can likely just rip that out and address it locally in ironic at some point | |
| 17:46:00 | sean-k-mooney | so it would not take much to jsut add a method to this obejc tthat wil return the data in a singel json dict | |
| 17:46:07 | sean-k-mooney | filepath -> file content | |
| 17:46:16 | TheJulia | yeah, that would be fairly straight forward | |
| 17:46:38 | sean-k-mooney | that acctully what that generator returns already | |
| 17:47:06 | sean-k-mooney | its just a mateter of passing it to ironic in a way that would work better for ye | |
| 17:47:58 | TheJulia | something for some point down the road | |
| 17:50:23 | sean-k-mooney | yep, we can always imrpove things like that if we know about the pain point and someone has time to od the work | |
| 17:51:24 | sean-k-mooney | TheJulia: speaning of improment https://review.opendev.org/c/openstack/nova-specs/+/471815 | |
| 17:51:55 | sean-k-mooney | i need to get back to that but tha tis aimed at making the data we pass more useful for the vlan trunking case | |
| 17:52:28 | sean-k-mooney | although that not nessisarly ironic speicific it shoudl be useful for any dirver the support neutron trunk ports | |
| 17:52:37 | TheJulia | Hmmmm | |
| 17:52:49 | TheJulia | I'll add that to my list to look at when I don't have a migraine | |
| 17:52:55 | TheJulia | Unfortunately, I woke up with one today :( | |
| 17:53:43 | sean-k-mooney | that sucks, i often get eystrain headaches or if i forget to take my blodd pressure medication but i fortunate to never had to deal with migraines | |
| 17:55:23 | sean-k-mooney | that actully is propsoing inlcudign the mtu info for the vlan sub intereface by the way | |
| 17:56:46 | TheJulia | oh good, becuase that would be a logical requirement. | |
| #openstack-nova - 2025-06-13 | |||
| 07:11:21 | opendevreview | Johannes Beisiegel proposed openstack/nova master: Adds packing_host_pci_numa_cells_allocation_strategy option https://review.opendev.org/c/openstack/nova/+/952451 | |
| 08:55:37 | opendevreview | Balazs Gibizer proposed openstack/nova stable/2024.1: Cache [pci]alias parsing https://review.opendev.org/c/openstack/nova/+/952489 | |
| 10:20:32 | opendevreview | Lajos Katona proposed openstack/os-vif stable/2025.1: OVS Trunk: Add bridge_name to external_ids https://review.opendev.org/c/openstack/os-vif/+/952567 | |
| 10:53:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Translate scatter-gather to futurist https://review.opendev.org/c/openstack/nova/+/947966 | |
| 10:53:56 | opendevreview | Balazs Gibizer proposed openstack/nova master: Use futurist for _get_default_green_pool() https://review.opendev.org/c/openstack/nova/+/948072 | |
| 10:53:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Replace utils.spawn_n with spawn https://review.opendev.org/c/openstack/nova/+/948076 | |
| 10:53:57 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add spawn_on https://review.opendev.org/c/openstack/nova/+/948079 | |
| 10:53:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move ComputeManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948186 | |
| 10:53:58 | opendevreview | Balazs Gibizer proposed openstack/nova master: Move ConductorManager to use spawn_on https://review.opendev.org/c/openstack/nova/+/948187 | |
| 10:53:59 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make nova.utils.pass_context private https://review.opendev.org/c/openstack/nova/+/948188 | |