| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-05-27 | |||
| 16:45:09 | sean-k-mooney | track this as a wishlist RFE bug? | |
| 16:45:12 | sean-k-mooney | spec? | |
| 16:45:38 | sean-k-mooney | i feel like this is one of those things where is quicker to write then disucss :) | |
| 16:46:19 | Uggla | Yep that sounds quite strait forward so specless BP, I think. | |
| 16:46:23 | gibi | if this is hardcode as enalbed then specless | |
| 16:46:25 | sean-k-mooney | all of our qemu and linvert version miniums are above wehre this was added so there is no migration or upgrade aspect either | |
| 16:46:48 | gibi | does it effect realtime / nfv guest performance? | |
| 16:46:54 | sean-k-mooney | :) | |
| 16:47:13 | sean-k-mooney | well yes but they normlaly turn off the mem ballon entirly | |
| 16:47:22 | sean-k-mooney | because it addds overhead that they dont tolllerate | |
| 16:47:38 | sean-k-mooney | whicih is why we shoudl fix the bug that stops you form being able to do that | |
| 16:47:43 | gibi | ahh | |
| 16:47:50 | sean-k-mooney | https://bugs.launchpad.net/nova/+bug/2069192 | |
| 16:47:57 | gibi | so we should not make that situation worse :) Lets fix the bug first then | |
| 16:48:13 | sean-k-mooney | so this would be hard code on if you have the mem balloan enabled | |
| 16:48:37 | sean-k-mooney | gibi: rajesh ahs a patch up to fix that bug https://review.opendev.org/c/openstack/nova/+/945621 | |
| 16:48:44 | gibi | cool | |
| 16:49:06 | gibi | so I'm OK with a specless | |
| 16:49:14 | gibi | and I will look at that bugfix | |
| 16:49:30 | sean-k-mooney | Uggla: gibi ok lets do this. if i find time to work on this before m2 ill file a specless blueprint and we can aprove it then | |
| 16:49:51 | sean-k-mooney | if not i can file a RFE bug or similar tracker and if someone has time we can work on it later | |
| 16:50:01 | gibi | sounds good to me | |
| 16:50:53 | Uggla | +1 | |
| 16:51:20 | Uggla | I have tracked that in the etherpad no to forget. | |
| 16:52:30 | Uggla | Something else to discuss ? | |
| 16:52:48 | gibi | - | |
| 16:53:11 | Uggla | Do you have still energy left to triage 1 or 2 bugs ? | |
| 16:53:26 | gibi | - | |
| 16:53:49 | sean-k-mooney | we can proably do one | |
| 16:54:17 | sean-k-mooney | although if you have not noticed im a littel disrtrated today. but we can try to do one | |
| 16:54:51 | Uggla | #topic Bug scrubbing | |
| 16:54:56 | Uggla | #link: https://etherpad.opendev.org/p/nova-bug-selection-for-triaging#L4 | |
| 16:55:02 | Uggla | Just one | |
| 16:55:17 | Uggla | https://bugs.launchpad.net/nova/+bug/2103500 | |
| 16:56:21 | Uggla | To my mind that sounds a valid one. At least regarding the comment from Brian. | |
| 16:58:29 | gibi | db error in the neutron code, this is a neutron bug | |
| 16:58:49 | gibi | at least neutron should not return 500 | |
| 16:59:14 | sean-k-mooney | so we had a vm create request with --network | |
| 16:59:28 | sean-k-mooney | it existsed at the api but by the time we got to the compute it as deleteed | |
| 16:59:48 | sean-k-mooney | i guesss it coudl happen when we do the quota check as well | |
| 17:00:01 | gmaan | and nova do capture NetworkNotFound exception if it is not found and requested https://github.com/openstack/nova/blob/221a3e89e8988bc664298106ee691a4e41ca71f9/nova/api/openstack/compute/servers.py#L842 | |
| 17:00:02 | sean-k-mooney | in anycase ya we shoudl get back a 400 not a 500 | |
| 17:00:43 | gmaan | or somewhere neutron exception is lost and not raised to controller ? | |
| 17:00:47 | sean-k-mooney | the expected behivor here shold be that nova puts the vm in error | |
| 17:01:03 | sean-k-mooney | and when the vm is deleted we would clean up any prot that were created then | |
| 17:01:09 | sean-k-mooney | based on teh delete on termeinate behaivor | |
| 17:01:20 | gmaan | yeah, bug say ignore the deleted network port and continue VM creation which does not seems right | |
| 17:01:42 | sean-k-mooney | its not form a nova point of view because we could not honner the orginal request | |
| 17:02:33 | sean-k-mooney | so depending on where this failed it soudl be burried in cell 0, rejected at the quoata check with a 400 or in error in the cell db if it got all the way to the compute | |
| 17:04:05 | sean-k-mooney | reading it more careflyy im tempeted to mark it inviald in nova | |
| 17:04:35 | sean-k-mooney | in there case its the quota check that is failing whne we list all prots for a tenatnt | |
| 17:05:05 | Uggla | sean-k-mooney, if you are unsure we can keep it open for next week. | |
| 17:05:26 | sean-k-mooney | althogh if we are missing the try accpate on teh network not found then thats a valid bug i guess | |
| 17:07:18 | Uggla | sale for valid ? | |
| 17:07:55 | gmaan | I have not tracked the exact call of validate_networks() but nova handle NetworkNotFound in _validate_requested_network_ids | |
| 17:07:55 | gmaan | https://github.com/openstack/nova/blob/221a3e89e8988bc664298106ee691a4e41ca71f9/nova/network/neutron.py#L988 | |
| 17:09:06 | gmaan | does bug mention 500 is returned? or 400 ? | |
| 17:09:14 | sean-k-mooney | gmaan: i think neturon is returnign a 500 | |
| 17:09:17 | sean-k-mooney | https://paste.openstack.org/show/bt3BWnyrBbQspiFx8KPZ/ | |
| 17:09:39 | gmaan | ohk | |
| 17:09:51 | sean-k-mooney | i think we need more info to be sure | |
| 17:10:13 | sean-k-mooney | the do have a NetworkNotFound excption https://paste.openstack.org/show/bJL9b5aY99XpZlLZdzgy/ | |
| 17:10:15 | gmaan | I think nova hanlding the error correctly if neuton return NetworkNotFound | |
| 17:10:35 | gmaan | and controller also handle NetworkNotFound so 400 will be return | |
| 17:11:21 | sean-k-mooney | can you comment to that effect on the bug | |
| 17:11:47 | gmaan | sure, will do after TC meeting | |
| 17:11:58 | sean-k-mooney | the first step to fixing this if we were to fix it in nova woudl be a repoducer test anyway | |
| 17:12:03 | sean-k-mooney | iesally a functional one | |
| 17:13:45 | Uggla | sean-k-mooney, does that mean we can set it as valid ? | |
| 17:15:43 | Uggla | I need to close the meeting, so I propose to look at that bug offline later or next week. | |
| 17:15:47 | Uggla | Thanks all and thanks for the extended time for bug triage. | |
| 17:15:54 | gmaan | Uggla: I will check exact trace of validate_network and see if nova missing NetworkNotFound handling anywhere | |
| 17:15:54 | Uggla | #endmeeting | |
| 17:15:54 | opendevmeet | Meeting ended Tue May 27 17:15:54 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 17:15:54 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2025/nova.2025-05-27-16.00.html | |
| 17:15:54 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2025/nova.2025-05-27-16.00.txt | |
| 17:15:54 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2025/nova.2025-05-27-16.00.log.html | |
| 17:15:57 | gmaan | and comment in bug | |
| 17:16:02 | gmaan | aftr TC meeting | |
| 17:16:37 | Uggla | thanks gmaan | |
| 17:16:52 | Uggla | Sorry I close the meeting a bit too quickly | |
| 17:17:47 | Uggla | Anyway time for me to afk, see you tomorrow. | |
| 17:17:50 | gmaan | its fine, actually 17 UTC, TC meeting start so difficult to respond here on time :) | |
| 17:19:19 | Uggla | no worries, I think I would close the meeting without bug triage because we were almost on top of the hour. | |
| 17:21:35 | sean-k-mooney | i set it to incomplete | |
| 17:21:39 | sean-k-mooney | we can come back next week | |
| 17:22:00 | Uggla | ok sean-k-mooney | |
| 17:22:03 | sean-k-mooney | but i suspect if the neutorn issue is fixed nova will do the right thing | |
| 21:04:30 | opendevreview | Callum Dickinson proposed openstack/nova master: Fix image ID in libvirt metadata when unshelving https://review.opendev.org/c/openstack/nova/+/942973 | |
| 21:04:30 | opendevreview | Callum Dickinson proposed openstack/nova master: Add image meta to libvirt XML metadata https://review.opendev.org/c/openstack/nova/+/942766 | |
| 21:09:05 | opendevreview | Callum Dickinson proposed openstack/nova master: Add more flavor metadata to libvirt guest XML https://review.opendev.org/c/openstack/nova/+/942974 | |
| 21:09:49 | Callum027 | sean-k-mooney: I know it's not strictly necessary but I've rebased the branches to make sure they're fine to merge with the newer master branch | |
| 21:10:05 | Callum027 | (the image meta blueprint ones, and the bugfix for image ID in libvirt metadata) | |
| 21:10:32 | Callum027 | Also added some more detail to the release notes as discussed in the meeting | |
| #openstack-nova - 2025-05-28 | |||
| 05:12:38 | opendevreview | Takashi Kajinami proposed openstack/nova master: Remove unused validator for uri element https://review.opendev.org/c/openstack/nova/+/951084 | |
| 09:05:39 | opendevreview | DongHun, Kim proposed openstack/nova master: Fix PCI device mapping leak after evacuate for GPU VMs https://review.opendev.org/c/openstack/nova/+/951099 | |
| 09:09:34 | opendevreview | DongHun, Kim proposed openstack/nova master: Fix PCI device mapping leak after evacuate for GPU VMs https://review.opendev.org/c/openstack/nova/+/951099 | |
| 10:26:33 | sean-k-mooney | Callum027: thanks ill see if i can review them this morning before i get distracted by other things | |
| 10:27:19 | sean-k-mooney | Callum027: i would suggest putting https://review.opendev.org/c/openstack/nova/+/942974 in the same seriese as the rest given its indicating it will be in merge conflcit with it | |
| 10:28:57 | sean-k-mooney | perhaps put the image ones on top or put this on top of them either way works | |