Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2025-05-21
18:46:26 sean-k-mooney so that posivie
18:47:09 Callum027 Yeah, I'm sure they'd be interested since this improves the scalability of Ceilometer polling
18:47:58 Callum027 I can understand why people wouldn't be happy about it since this is basically putting lipstick on a pig, but anything more radical would require more fundamental design changes and I'm not sure I'm capable of championing that at this stage :)
18:49:14 sean-k-mooney well with my nova hat on it replaceing Ceilometer pooling the nova api with Ceilometer polling the libvirt api so if its a perfroamc eissue its not someone elses probelem. on the ohter had the domain xml is ment to be internal state
18:49:29 sean-k-mooney so if we just stop using them or libvirt changed ot yaml
18:49:47 sean-k-mooney that not a breakign change form a nova perspecitve as the xml is not public
18:49:55 sean-k-mooney but realisticlly that not going to happen
18:50:09 sean-k-mooney so as long as ceilometer is readonly its proably a net win
18:58:56 Callum027 I do think it's a relatively elegant solution to the scalability issues Ceiilometer faced, with the drawback that changes to the files require all instances to be shelved-and-unshelved to apply the changes (or updated in place using virsh commands)
18:59:34 sean-k-mooney no it just requries a hard reboot
19:00:04 sean-k-mooney the xml is regenerated on every hard reboot or start/power on call
19:00:10 Callum027 Oh, right, of course
19:00:31 sean-k-mooney shelve would work too but there are cheaper options
19:00:33 Callum027 I should update the release notes on those commits to mention that
19:00:50 Callum027 But the main thing is live migrating doesn't work since the XML gets copied over without modificaiton
19:01:02 sean-k-mooney it will also get added on a live migrate i think
19:01:16 Callum027 In our testing it didn't, but we're using an older version of Nova
19:01:17 sean-k-mooney or at least it would if you implemnted that in your code change
19:01:43 sean-k-mooney well no i mean nova can do that but you need to write the code
19:01:59 Callum027 Maybe part of "standardising" this would be that we write a more elegant way of updating the metadata of instances in place
19:02:08 sean-k-mooney https://github.com/openstack/nova/blob/master/nova/virt/libvirt/migration.py#L55-L97
19:02:14 Callum027 For our production environment we wrote a one-off Ansible playbook to do it
19:02:28 sean-k-mooney i mean that fair too
19:02:37 sean-k-mooney although we dont like operators touching the xml
19:02:55 Callum027 Yeah, I definitely would have preferred to use the proper core for it
19:03:32 sean-k-mooney so perhaps as a follow up we could add updating of the metadata in the domain on live migrate
19:03:37 sean-k-mooney that not doen today in general
19:03:43 sean-k-mooney so its not really a bug in yoru patch
19:03:57 sean-k-mooney its just exsitng beahvior. cold migrate would pick up the chakge as weel
19:04:13 Callum027 Yeah, it's definitely a useful change though
19:04:39 Callum027 For now I've added the item to the agenda, I'll make sure I'm at the next meeting
19:04:58 sean-k-mooney ack
19:17:53 opendevreview sean mooney proposed openstack/nova master: move compile earlier https://review.opendev.org/c/openstack/nova/+/950516
#openstack-nova - 2025-05-22
01:10:35 mikal Potentially silly question(s), but is there a git plugin or precommit or whatever that will just make me magically DCO compliant with minimal effort? I am assuming that DCO implies GPG signed commits, although I cannot find a web page which clearly states tat -- it might just be some text in the commit message which alleges to come from me? If I
01:10:35 mikal didn't in fact hallucinate the GPG signature requirement, are there minimum requirements for the GPG key used to sign the commit? My GPG key is relatively well connected, but also ancient.
01:11:19 mikal Like... it would be cool if "git review" added missing DCO entries like it does missing change ids.
01:11:29 opendevreview Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126
01:11:29 opendevreview Michael Still proposed openstack/nova master: Protect older compute managers from sound model requests. https://review.opendev.org/c/openstack/nova/+/940770
01:11:30 opendevreview Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354
04:57:34 opendevreview sean mooney proposed openstack/nova master: move compile earlier https://review.opendev.org/c/openstack/nova/+/950516
04:57:35 opendevreview sean mooney proposed openstack/nova master: Add mtty/mdpy support for testing fake mdevs https://review.opendev.org/c/openstack/nova/+/898100
04:57:35 opendevreview sean mooney proposed openstack/nova master: WIP : Add mtty support to nova-next https://review.opendev.org/c/openstack/nova/+/922140
05:03:15 sean-k-mooney mikal: "git commit -s" should be all you need to do but im not sure yet about an automatic way yet. most seam to recomemd a git alis like "git config --global alias.cs commit --signoff" but `git commit -s` vs `git cs` does not help much
05:04:05 sean-k-mooney mikal: you do not need ot sign comites with DCO
05:04:24 sean-k-mooney you can but git now supprot using ssh keys instead of GPG keys for sgining if you want to do that
05:04:29 mikal Yeah, that bit confuses me. What's to stop a forgery of a signoff if its just a text string in the commit message?
05:04:48 sean-k-mooney https://dev.to/janderssonse/git-signoff-and-signing-like-a-champ-41f3
05:05:41 mikal Ahhh, so signoff != signing.
05:05:42 sean-k-mooney mikal: well gerrit will prevent forgin the authero but the commit message can be updated
05:05:56 sean-k-mooney signing commtis wont help because we dont use mege commits
05:06:13 sean-k-mooney so your commit will be rebasees/cherry picked anyway when its merged by zuul
05:06:35 mikal Well, at least this means I can still stick with my 25 year old GPG key!
05:06:42 mikal Its an antique and needs to be cherished.
05:07:13 sean-k-mooney so i have gpg siging setup or at least id did before i reinstalled my laptop....
05:07:41 mikal I GPG sign tags on some personal projects, although I am unclear on how meaningful that is with such an old key.
05:07:43 sean-k-mooney but i tend not to use it because i had issue with geting it to prompt both locally and if i ssh into my work laptop
05:08:17 sean-k-mooney i.e. if i sshed in it woudl tyr ot pop up a unlock prome in a window on my work laptop instead of in the ssh terminal
05:08:53 sean-k-mooney i think i eventrally got it to work by alwasy forcign the gpg agent to use the tty for promting instead of the shel integration btu i remember that beign a bit of a pain
05:09:22 sean-k-mooney mikal: i mean if that key has never been leaked
05:09:26 mikal Yeah fair enough. I feel like GPG never really took off because its a huge pain in the ass.
05:09:31 sean-k-mooney its a as valid as min
05:10:12 sean-k-mooney ya it kind of used to be. i inally set it up because i wanted to be able to sgin tag for networking-ovs-dpdk and my emails
05:10:33 sean-k-mooney but signing emails with gpg keys causes all sort of issues at times
05:10:33 mikal Dr Google assures me that a 1024 bit DSA key is crackable by motivated players. So that's nice.
05:13:32 sean-k-mooney mikal: by the way git-review is nto the thing that adds the change id for you
05:14:04 sean-k-mooney mikal: we have configured our gerrit to server a commit hook which git review will download and install for you
05:14:31 sean-k-mooney im not sure if we can do something similar ot reject or amend your commit automticlly for you in a sane way
05:14:53 mikal Ahhh ok. My lived experience is "git review" saying "you're missing thingies" and adding them, but I've never looked at the mechanism all that hard.
05:15:34 sean-k-mooney ah https://gerrit.cloudera.org/Documentation/project-configuration.html#_require_signed_off_by
05:15:42 sean-k-mooney so ya we can just turn on the enforcement in gerrit
05:16:10 sean-k-mooney but im not sure about the auto fixign i suspect we woudl need to dig deaper
05:16:28 sean-k-mooney im sure git can suprpot this in a hook but we might need to write it
05:18:52 mikal The commit message hook appears to already understand "Signed-off-by trailers" based on a cursory reading?
05:19:45 mikal It uses https://git-scm.com/docs/git-interpret-trailers to do... things.
05:22:23 mikal Ahhh, ok. I think its trying quite hard to have the Change-Id before the signed off by trailers. Dr Google does suggest that if you turn on DCO enforcement on the project in gerrit then some amount of magic will happen.
05:27:11 opendevreview Abhishek Kekane proposed openstack/nova master: [DNM] Revert^2 "Support glance's new location API" https://review.opendev.org/c/openstack/nova/+/950623
05:27:54 sean-k-mooney mikal: regarding pre-commit it does supprot writing "commit-msg" hooks which are pass a single parmeter the path to the file
05:28:36 sean-k-mooney mikal: so we coudl write one to either abort the comiit if Signed-off-by was not there ot ro add it for you before the commit was actully finalised
05:29:03 mikal As a forgetful person I quite like the idea of option two there.
05:29:10 mikal It is after all what we already do for change ids.
05:29:36 mikal And my global git config already knows my name and email address, which it needs to know for the log.
05:29:47 sean-k-mooney yep
05:30:16 sean-k-mooney its proably a good weekend hackign project which is also where we shoudl put it
05:30:30 sean-k-mooney in the hacking repo so we can share it acrross other repos
05:30:33 mikal It would also make the transition largely transparent... People do a git review, land a new version of the hook automatically, and blam they're compliant. Much more fun than herding cats.
05:31:09 sean-k-mooney we can add a new hook there and then enable it in the relevent repos https://github.com/openstack/hacking/blob/master/.pre-commit-hooks.yaml
05:31:42 mikal Although... Other projects also use signed-off-by to track who reviewed and approved a change. Is there any intent to do that as well?
05:34:25 sean-k-mooney mikal: that actully a missues of it
05:34:36 sean-k-mooney mikal: there are other standared lables for that
05:35:04 sean-k-mooney mikal: so no not currently however you can actully config gerrit to auto ammend the commit with that info to some degree
05:35:24 sean-k-mooney we had that enabeld downstream untile they moved use to gitlab.....
05:35:41 mikal I kind of like the history being all in one place to be honest.
05:36:30 mikal So yeah, review history in the commit would be cool. I don't really care what labels are used to be honest. I do agree the kernel seems to use "Signed-off-by", "Tested-by", "Reviewed-by", etc.
05:37:36 sean-k-mooney your ment to use Reviewed-by, Acked-by and Tested-by instead of sgined-off by to track that
05:38:33 sean-k-mooney so you coudl update the comit with the review vots and add acted by for the person that +w'd and tested-by by zuul (the verifed label votes)
05:39:17 sean-k-mooney however to do that gerrit would have to be sett to cerry pick mode which will alwasy cheryy pick the commit on to the target branch changign it git sha
05:39:38 sean-k-mooney which will mean you will not be able to knwo the sha to use for backportign until after it has merged because it will alwasy change
05:40:10 sean-k-mooney so to do that we loose our current cherry-picked form workflow/lines when backporting
05:42:49 sean-k-mooney mikal: the convetions for the by lines alll come form teh linke kernel and are part of there patch submission process https://github.com/torvalds/linux/blob/master/Documentation/process/submitting-patches.rst#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
07:07:37 sean-k-mooney bauzas: just so your aware i rebased your mtty_suppot sersie and moved my patch to the bottom.

Earlier   Later