| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-04-23 | |||
| 14:22:55 | opendevreview | Balazs Gibizer proposed openstack/nova master: [hacking] N373 do not use eventlet primitives https://review.opendev.org/c/openstack/nova/+/947265 | |
| 14:31:23 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove nova.service.process_launcher https://review.opendev.org/c/openstack/nova/+/947260 | |
| 14:33:29 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove nova debugger functionality https://review.opendev.org/c/openstack/nova/+/922496 | |
| 14:33:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: split monkey_patching form import https://review.opendev.org/c/openstack/nova/+/922425 | |
| 14:33:30 | opendevreview | Balazs Gibizer proposed openstack/nova master: Remove superfluous monkey patching form func test https://review.opendev.org/c/openstack/nova/+/947237 | |
| 14:40:25 | dansmith | bauzas: gibi: could one of you +W this? https://review.opendev.org/c/openstack/nova/+/946065 | |
| 14:40:33 | dansmith | just tests and you've both +Wed already | |
| 14:40:39 | dansmith | that would close that work out on the nova side I think | |
| 14:41:00 | bauzas | done | |
| 14:42:06 | gibi | bauzas was faster :) | |
| 14:44:29 | dansmith | thanks | |
| 15:30:58 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix 'nova-manage image_property set' command https://review.opendev.org/c/openstack/nova/+/946733 | |
| 16:01:09 | opendevreview | Merged openstack/nova master: Functional tests for one-time-use devices https://review.opendev.org/c/openstack/nova/+/946065 | |
| 16:15:03 | Uggla | sean-k-mooney, if you have a moment, can you have a look at 947558: update constraint for oslo.utils to new release 7.3.1 | https://review.opendev.org/c/openstack/requirements/+/947558 I found the issue, proposed a fix in the comments. But that's probably not the good way to fix the issue. So I'll appreciate your thought about it. | |
| 16:27:12 | sean-k-mooney | loading context | |
| 16:27:49 | sean-k-mooney | oh so py38 has not been part of the runtimes for a while | |
| 16:28:12 | sean-k-mooney | it was there for oslo because they lag one release behind | |
| 16:28:21 | sean-k-mooney | but we shoudl be remvoing that now | |
| 16:28:59 | sean-k-mooney | Uggla: its failing because oslo.utils bumpted teh min version to 39 https://github.com/openstack/oslo.utils/blob/master/setup.cfg#L9 | |
| 16:29:08 | sean-k-mooney | that why it can install in 3.8 | |
| 16:32:13 | sean-k-mooney | oh this is 2024.2 | |
| 16:34:22 | Uggla | sean-k-mooney, not for the requested version https://opendev.org/openstack/oslo.utils/src/commit/145e0455d75fe11d55595e1c5dedcde0a1acdc05/setup.cfg#L9 | |
| 16:34:48 | sean-k-mooney | ya i noticed that after i typed up a respocne | |
| 16:34:59 | sean-k-mooney | im goign to take a look at the actul error quickly | |
| 16:37:07 | sean-k-mooney | so they have not merge the pyprojec.toml paces an dnew version of pip and setup tools hae stared dropping supprot for that | |
| 16:37:20 | sean-k-mooney | im not sure if that is related | |
| 16:37:31 | sean-k-mooney | given this is python 3.8 i guess this job is still on ubuntu 22.04 | |
| 16:37:54 | sean-k-mooney | Distro: Ubuntu 20.04 | |
| 16:37:58 | sean-k-mooney | ok even older. | |
| 16:41:51 | Uggla | sean-k-mooney, there is somethink related to the package named produced as I state in my comment. | |
| 16:42:00 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/dd880dad1d3a486a92d8decd7fc9fd7c/log/job-output.txt#3576 | |
| 16:42:29 | sean-k-mooney | pkg_resources.DistributionNotFound: The 'oslo.utils>=3.36.0' distribution was not found and is required by oslo.log | |
| 16:43:36 | sean-k-mooney | which is odd becaues we are adding 7.3.1 | |
| 16:43:42 | sean-k-mooney | so we need to look earlier | |
| 16:43:58 | sean-k-mooney | normally this happens if some package has a cap (max version pin) | |
| 16:45:12 | Uggla | sean-k-mooney, please look at my comment this is due to the fact that the package is oslo_utils instead of oslo.utils. | |
| 16:46:07 | sean-k-mooney | it does look like we installed oslo.utils-7.3.1 | |
| 16:47:06 | sean-k-mooney | so kind of | |
| 16:47:15 | sean-k-mooney | teh pytohn modluel is oslo_utils | |
| 16:47:31 | sean-k-mooney | you saying that the way pbr built it is broken | |
| 16:47:53 | sean-k-mooney | and now its reproting as oslo_utils in pip freeze? | |
| 16:48:01 | sean-k-mooney | or when its built | |
| 16:48:21 | sean-k-mooney | if so that coudl be because we dont have a pyproject.toml file | |
| 16:51:06 | sean-k-mooney | its oslo.utils here too https://zuul.opendev.org/t/openstack/build/dd880dad1d3a486a92d8decd7fc9fd7c/log/job-output.txt#2433-2434 | |
| 16:54:02 | sean-k-mooney | Uggla: have you tired repoducing this locally? | |
| 16:59:38 | opendevreview | Balazs Gibizer proposed openstack/nova master: WIP:Translate scatter-gather to futurist https://review.opendev.org/c/openstack/nova/+/947966 | |
| 17:08:38 | sean-k-mooney | Uggla: im running the command locally in a ubuntu 20.04 container now ill let you know if i find anyting | |
| 18:03:45 | Uggla | sean-k-mooney, as you can see I managed to fix the issue. But using an mv is probably not really clean. | |
| 18:04:44 | sean-k-mooney | Uggla: i dont see how you fixed the issue | |
| 18:05:23 | sean-k-mooney | ugh did you put it in a comment instead of actully pushign a patch | |
| 18:06:28 | Uggla | yes | |
| 18:06:47 | Uggla | https://review.opendev.org/c/openstack/requirements/+/947558/comments/16851def_9bf88f81 | |
| 18:07:02 | sean-k-mooney | ths really confusing when you ping some one out of the blue to look at a patch where there is not clear indication that you changed anything | |
| 18:09:05 | Uggla | sorry :( | |
| 18:09:48 | sean-k-mooney | its ok. so packege_resouce on py38 | |
| 18:09:57 | sean-k-mooney | does not return or use the same name as pip | |
| 18:10:02 | sean-k-mooney | specificly pip freeze | |
| 18:10:17 | sean-k-mooney | we can make this work by doign pkg_resources.require(name.replace('.','_')) | |
| 18:10:23 | sean-k-mooney | instead of pkg_resources.require(name) | |
| 18:10:27 | sean-k-mooney | on python 3.8 | |
| 18:10:39 | sean-k-mooney | however that is not really teh correct fix | |
| 18:10:52 | sean-k-mooney | we could do that here https://github.com/openstack/requirements/blob/master/openstack_requirements/cmds/check_conflicts.py#L51C25-L51C52 | |
| 18:11:04 | sean-k-mooney | and gard i by the python version. | |
| 18:11:32 | Uggla | yep I agree this is another possibility. | |
| 18:11:45 | sean-k-mooney | but it would be beter to undersand why it is behviing diffently | |
| 18:13:06 | Uggla | yes that was the reason why I asked you. If you have an idea about the reason. | |
| 18:13:48 | sean-k-mooney | my guess is somethign in pkg_resouces has changed | |
| 18:14:00 | sean-k-mooney | i woudl have to see if there are any recent releases | |
| 18:15:09 | sean-k-mooney | https://setuptools.pypa.io/en/latest/pkg_resources.html | |
| 18:15:17 | sean-k-mooney | so pkg_resouces is deprecated for removal | |
| 18:15:39 | sean-k-mooney | we may want to swap to import lib instead | |
| 18:17:48 | sean-k-mooney | pkg_resocue i think is gon in python 3.13 | |
| 18:18:07 | sean-k-mooney | i think we are ment to use https://docs.python.org/3/library/importlib.resources.html instead | |
| 18:18:27 | sean-k-mooney | or well import lib in general | |
| 20:26:42 | masahito | sean-k-mooney: hi, please review the API bug fix, again. gmaan_pto +2ed so all comments are solved. https://review.opendev.org/c/openstack/nova/+/939658 | |
| 20:27:15 | sean-k-mooney | ah sure. im just about to finsih for todday but i can take a look quickly | |
| 20:28:50 | sean-k-mooney | masahito: i agree it looks like gmanns comment have been addressed and i was happy with it before so +2w | |
| 20:30:51 | masahito | sean-k-mooney: thanks! I appreciate you check it even though you're going to finish today. | |
| 23:16:48 | opendevreview | Merged openstack/nova master: Use dict object for request_specs_dict in the _list_view https://review.opendev.org/c/openstack/nova/+/939658 | |
| #openstack-nova - 2025-04-24 | |||
| 10:08:10 | Uggla | sean-k-mooney[m], I proposed this as a fix: https://review.opendev.org/c/openstack/requirements/+/947558/1..2 please let me know what you think about it. | |
| 10:08:19 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: debug gate https://review.opendev.org/c/openstack/nova/+/948057 | |
| 10:36:50 | opendevreview | sean mooney proposed openstack/nova stable/2025.1: Use dict object for request_specs_dict in the _list_view https://review.opendev.org/c/openstack/nova/+/948061 | |
| 11:02:11 | opendevreview | Balazs Gibizer proposed openstack/nova master: [quota]Refactor group counting to scatter-gather https://review.opendev.org/c/openstack/nova/+/948064 | |
| 11:03:10 | opendevreview | Balazs Gibizer proposed openstack/nova master: [quota]Refactor group counting to scatter-gather https://review.opendev.org/c/openstack/nova/+/948064 | |
| 11:14:07 | opendevreview | Kamil Sambor proposed openstack/nova master: Replace eventlet sleep with time.sleep https://review.opendev.org/c/openstack/nova/+/947212 | |
| 12:09:31 | opendevreview | Kamil Sambor proposed openstack/nova master: Replace eventlet sleep with time.sleep https://review.opendev.org/c/openstack/nova/+/947212 | |
| 12:58:02 | opendevreview | Balazs Gibizer proposed openstack/nova master: WIP:Translate scatter-gather to futurist https://review.opendev.org/c/openstack/nova/+/947966 | |
| 12:58:03 | opendevreview | Balazs Gibizer proposed openstack/nova master: Use futurist for _get_default_green_pool() https://review.opendev.org/c/openstack/nova/+/948072 | |
| 13:29:19 | opendevreview | Balazs Gibizer proposed openstack/nova master: Replace utils.spawn_n with spawn https://review.opendev.org/c/openstack/nova/+/948076 | |
| 13:40:00 | opendevreview | Balazs Gibizer proposed openstack/nova master: [hacking] N373 do not use eventlet primitives https://review.opendev.org/c/openstack/nova/+/947265 | |
| 13:58:31 | opendevreview | Balazs Gibizer proposed openstack/nova master: Replace utils.spawn_n with spawn https://review.opendev.org/c/openstack/nova/+/948076 | |
| 14:08:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: Replace utils.spawn_n with spawn https://review.opendev.org/c/openstack/nova/+/948076 | |
| 14:17:45 | opendevreview | Balazs Gibizer proposed openstack/nova master: Add spawn_to https://review.opendev.org/c/openstack/nova/+/948079 | |
| 14:21:46 | JayF | Does a doc like https://docs.openstack.org/nova/latest/reference/vm-states.html exist except for instance.status? | |
| 14:52:33 | opendevreview | Balazs Gibizer proposed openstack/nova master: Rename DEFAULT_GREEN_POOL to DEFAULT_EXECUTOR https://review.opendev.org/c/openstack/nova/+/948086 | |
| 14:52:34 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make the default executor configurable https://review.opendev.org/c/openstack/nova/+/948087 | |
| 15:29:18 | opendevreview | Balazs Gibizer proposed openstack/nova master: Make the default executor configurable https://review.opendev.org/c/openstack/nova/+/948087 | |
| 15:46:20 | dansmith | bauzas: https://review.opendev.org/c/openstack/nova/+/891036 | |
| 15:47:52 | gibi | sean-k-mooney[m]: this is ready to land now I think https://review.opendev.org/c/openstack/nova/+/947212 | |
| 15:48:17 | sean-k-mooney | gibi: sure. about the eventlet removal | |