| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-04-04 | |||
| 15:20:31 | sean-k-mooney | i dont knwo what the orginal usecase for allowing the reserved to be change was but if thats the case then il upgrade to +w | |
| 15:21:00 | dansmith | so we _could_ potentially follow up with this and use the OTU trait as well to control invalidation, but I think he would argue it's best if we just don't so that future developers are clear that we won't get stuck in the same way I initially did until I added this :) | |
| 15:21:04 | sean-k-mooney | ah https://review.opendev.org/c/openstack/nova/+/944149/6//COMMIT_MSG#15 | |
| 15:21:22 | sean-k-mooney | ok i missed that when i looked at the comit | |
| 15:22:03 | gibi | sean-k-mooney: the idea behind it is that nova should own as small part of the inventory as it cares about. Before OTU it only cared about total and max_unit (as it is mandatory) so the rest of the field was never set in the inventory of a PCI RP | |
| 15:22:09 | gibi | making it possible to set externally | |
| 15:22:14 | sean-k-mooney | dansmith: well as we dicussed a few weeks ago im not really sure why we are caching at all | |
| 15:22:25 | sean-k-mooney | so im all for being safe with correctness here | |
| 15:22:32 | sean-k-mooney | even if it might be slightly slower | |
| 15:23:00 | sean-k-mooney | gibi: right and nova cares about reserved even without OTU | |
| 15:23:08 | sean-k-mooney | we report the inventory based on the devspec | |
| 15:23:15 | dansmith | well, for a big tree of lots of providers it probably is a real gain, but brings problems like this (as does all caching of course) | |
| 15:23:29 | sean-k-mooney | so you shoudl never be chanign reserved since that will mnake placement and the pci deivces tabel be sort of out of sync | |
| 15:24:32 | sean-k-mooney | anywya dont wnat ot boil the ocean i was just wonderigy why we were not checkifn for "is pci in placement and one time use" rather then just "is pci in placment" | |
| 15:25:20 | dansmith | well, that patch is before OTU, so that's part of why :) | |
| 15:26:08 | sean-k-mooney | ya i was orgianly wondering if that was the reason nad if you were going to modify it again in the next patch | |
| 15:26:10 | dansmith | nova is not currently reporting anything reserved for pci-in-placement providers, AFAIK (other than OTU in the next patch), so I think gibi's point is that if you want to reserve some VFs you would do it in placement directly | |
| 15:26:23 | dansmith | sean-k-mooney: yeah I understand now, I just didn't get that from your comment :) | |
| 15:27:54 | sean-k-mooney | no worries. so +2w on the first too. ill take a look at the rest once i have devstack deploying | |
| 15:28:01 | dansmith | thanks | |
| 15:33:24 | sean-k-mooney | dansmith: as an aside, you have a vexhost lable created have you tried to use this in ci yet? | |
| 15:40:01 | sean-k-mooney | so the host im using is not the one that has igb support. you said in your testing the rng didnt crash the host vm? | |
| 15:40:17 | sean-k-mooney | if so ill see if i can ply with that as well | |
| 15:49:39 | dansmith | (on a call) | |
| 16:03:43 | melwitt | zigo: just fyi that we had a partial regression involving mdevs with that patch which was tracked and fixed here https://bugs.launchpad.net/nova/+bug/2098892 | |
| 16:21:01 | sean-k-mooney | dansmith: not urgent but you have a trival bug in the unit test. https://review.opendev.org/c/openstack/nova/+/943816/comment/4d20bb05_6116bff7/ it does no tactully break anything so it can be a follow up | |
| 16:26:36 | dansmith | sean-k-mooney: ah yeah will fix in a follow up.. | |
| 16:27:34 | sean-k-mooney | your not actully building it into a treee or populating the pci tracker so technically it wont break anything. it just will be confusing if we read it in like a year so ya no need to respine but nice to fix | |
| 16:28:55 | dansmith | yep, spinning a follow-up now | |
| 16:29:03 | dansmith | sean-k-mooney: are you holding the +W until you test locally? | |
| 16:29:44 | dansmith | oh nm :) | |
| 16:30:01 | sean-k-mooney | i was until my devstack failed for the 3 time | |
| 16:30:08 | dansmith | heh | |
| 16:33:57 | sean-k-mooney | there is a patch sitting in ci to make our new prometous plugin not fail if /etc/promethous exists and i keep forgetting i need to delete the dir before i restack | |
| 16:34:57 | sean-k-mooney | i should just checkout the fixed version but im manually testing a docs change for the default local.conf | |
| 16:36:03 | sean-k-mooney | * default of watcher + promethous | |
| 16:39:42 | melwitt | p8s 😛 | |
| 16:41:58 | sean-k-mooney | i rather unofrtunetly misclicked yesterday and added a commone misspelling of approch to my firefox? or garmmerly dictonatry instead of fixing it | |
| 16:42:04 | sean-k-mooney | i need to go fix that before i forget | |
| 16:43:32 | sean-k-mooney | intorspeciton that is also not a correct spelling.... how do i spellcheck my dictionary | |
| 16:43:35 | sean-k-mooney | i guess google | |
| 16:44:18 | sean-k-mooney | this is a very sean problem | |
| 16:44:31 | dansmith | heh | |
| 16:45:08 | sean-k-mooney | skipable also has too Ps | |
| 16:45:38 | melwitt | you're on a roll | |
| 16:46:00 | sean-k-mooney | i have custom dictionaries for jagon like podman or mixed-rhel | |
| 16:46:18 | sean-k-mooney | but i really shoudl just delete anything that a real word because it proably wrong | |
| 16:48:09 | sean-k-mooney | sudo mkdir /etc/prometheus | |
| 16:48:11 | sean-k-mooney | mkdir: cannot create directory '/etc/prometheus': File exists | |
| 16:48:24 | sean-k-mooney | ... attepmpt 5 | |
| 16:48:32 | sean-k-mooney | this tim eim just going to use the fixed versions | |
| 16:48:55 | sahid | sean-k-mooney: thanks for the reference :-) we are running a version a bit too old I guess... | |
| 16:49:26 | sean-k-mooney | sahid: its a pretty trivial backport if thats an option for you | |
| 16:53:32 | sahid | no I don't think we need to backport it. we don't run in debug anyway it was more about to proof the change on UAT | |
| 16:53:38 | sahid | thank you sean-k-mooney | |
| 17:57:50 | sean-k-mooney | just as an fyi if you end up with passt or pasta installed on your system becuase of docker/podman or i think technially libvirt? not sure | |
| 17:57:52 | sean-k-mooney | https://bugs.launchpad.net/ubuntu/+source/apparmor/+bug/2065685/comments/7 | |
| 17:58:09 | sean-k-mooney | you may need to manually fix apparmor to fix your devstack | |
| 17:58:46 | sean-k-mooney | the issue is fixed just not on 24.04... | |
| 18:01:25 | sean-k-mooney | finally | |
| 18:08:16 | sean-k-mooney | Invalid [pci]device_spec config: one_time_use=true requires pci.report_in_placement to be enabled | |
| 18:08:24 | sean-k-mooney | well at least i confrimed that works | |
| 18:09:40 | sean-k-mooney | right... AttributeError: module 'os_traits' has no attribute 'HW_PCI_ONE_TIME_USE' | |
| 18:16:57 | sean-k-mooney | dansmith: so the db and placement all looks good https://paste.opendev.org/show/bpBlYPAE5cvPwAK1pOuS/ im quite tired but this is almost set up so im going to quickly create an alias and flaovr and see if i can boot a vm and dlete it and reset it | |
| 18:17:03 | sean-k-mooney | then ill call it a day and rest | |
| 18:22:17 | dansmith | sean-k-mooney: cool | |
| 18:29:08 | sean-k-mooney | ... Uggla the new alias example swe added for live migrateble dvice are wrong | |
| 18:29:20 | sean-k-mooney | Uggla: you used `'` not `"` | |
| 18:29:31 | sean-k-mooney | they are json so the have to be double quotes | |
| 18:30:06 | dansmith | ooh, yeah I see | |
| 18:31:16 | sean-k-mooney | you get a really unintuivie error | |
| 18:31:18 | sean-k-mooney | BadRequestException: 400: Client Error for url: http://192.168.16.185/compute/v2.1/servers, Invalid PCI alias definition: Expecting property name enclosed in double quotes: line 1 column 2 (char 1) | |
| 18:31:42 | sean-k-mooney | i mean it makes sense but i dont expect end users to get that excption | |
| 18:31:56 | sean-k-mooney | wehn its an error in your alias in the config file | |
| 18:32:44 | sean-k-mooney | its really a server side error not a client side one | |
| 18:33:11 | dansmith | ah yeah, exposing that to the user is probably not a great idea either | |
| 18:33:59 | sean-k-mooney | it might be becaus i did that as admin | |
| 18:34:06 | sean-k-mooney | ill check that after im done | |
| 18:36:45 | sean-k-mooney | https://paste.opendev.org/show/bwJuKNE7VW3NvAjnxiWr/ | |
| 18:36:53 | sean-k-mooney | so cool i was able to boot a vm | |
| 18:37:01 | sean-k-mooney | it reserved the device | |
| 18:37:10 | sean-k-mooney | and after deleting it i now get a no valid host | |
| 18:38:01 | dansmith | \o/ | |
| 18:40:07 | sean-k-mooney | and cool i can reset it and boot again | |
| 18:40:37 | dansmith | \o\ /o/ \o/ | |
| 18:41:15 | sean-k-mooney | im too tired this envning to review the final functional test patch but ill do that on monday | |
| 18:41:22 | sean-k-mooney | i was testing with the reno patch just before it | |
| 18:41:41 | dansmith | no worries, good to have another confirmation, thanks | |
| 18:41:45 | dansmith | rest up for next week ;) | |
| 18:43:35 | sean-k-mooney | o/ | |
| 19:03:42 | dansmith | gmann: melwitt: this recently-added test seems to be failing a *lot* https://review.opendev.org/c/openstack/tempest/+/858885 | |
| 19:04:13 | dansmith | and it seems to be failing because the swap devices don't actually show up or disappear in the guest | |
| 19:05:01 | dansmith | probably because it doesn't wait for SSHABLE I'm guessing | |
| 19:05:37 | sean-k-mooney | that shoudl not matter for rezise since there is no hotplug | |
| 19:05:49 | sean-k-mooney | but i dotn think it will auto swap on | |
| 19:06:11 | sean-k-mooney | so depending on what the test is doing it might now be stable | |
| 19:06:46 | sean-k-mooney | hum blkid looking for type swap | |
| 19:07:02 | sean-k-mooney | do we format the disk with a swap partion | |
| 19:07:10 | dansmith | what I mean is, I'm not sure it's waiting for the instance to have actually been resized | |
| 19:07:20 | sean-k-mooney | oh | |