Earlier  
Posted Nick Remark
#openstack-nova - 2025-04-01
18:07:34 dansmith right, seems like they should use try..finally: unlink()
18:07:41 sean-k-mooney that works... but not how i would have done that
18:07:46 dansmith yeah
18:08:08 sean-k-mooney dont we use context lib.exit_stack or something like that to handel it in nova/oslo
18:08:34 dansmith in some places yeah but I don't think it's really necessary here
18:08:35 sean-k-mooney we might not even need that
18:08:54 sean-k-mooney right that really only needed if we have multipel resocue we need to clean up
18:10:27 sean-k-mooney gmann: are we sure this is not just hard failing but it looks like its only failign sometimes due to the backport fo that patch
18:10:44 sean-k-mooney gmann: given the "fix" id dont see how this could sometiems work and sometiems not
18:11:28 sean-k-mooney enabling the qcow image type and this abckprot have all been happening over the last week
18:11:55 gmann sean-k-mooney: after this fix merged in master and stable/2025.1, I have not seen failure. in my devstack change on stable/2025.1 it started passing once this fix backport merged on stable/2025.1. I checked the timing to make sure that
18:12:27 sean-k-mooney ack
18:12:37 sean-k-mooney well let just wait for the final patch to land i guess
18:12:40 gmann stable/2024.2 backport still not merged so there we have 100%
18:12:44 gmann 100% failing
18:12:45 gmann yeah
18:13:47 sean-k-mooney ack that makes sense
18:16:13 sean-k-mooney gmann: the default chagne of image formats was in tempest yes?
18:16:56 gmann yes
18:17:35 sean-k-mooney i wonder if it would make sense to replace https://github.com/openstack/tempest/blob/80c0477f78c71a2bd2e1a324c41cd2f50329b200/zuul.d/project.yaml#L113-L115 with the nova ceph multistore job
18:18:39 sean-k-mooney that would provide the same level fo ceph coverage but allso test this configuration where upload go to a glance backed by file in this case.
18:20:01 sean-k-mooney that might be an over reaction but that would ahve caught this
18:20:16 sean-k-mooney ye already have quite a lot in check
18:20:27 gmann sean-k-mooney: +1, that make sense. we do have nova-ceph-multistore in tempest but as experimental which is what we forget to run on related changes
18:20:27 sean-k-mooney so i would be hesitent to suggest adding more jobs
18:20:44 sean-k-mooney its in devstack too
18:20:55 sean-k-mooney https://github.com/openstack/devstack/blob/master/.zuul.yaml#L933-L934
18:21:12 sean-k-mooney that how we are testing ceph integration on devstack changes
18:21:30 gmann yes, I think replacing devstack-plugin-ceph-tempest-py3->nova-ceph-multistore in tempest will cover more cases
18:22:03 gmann catching in devstack is late where tempest things get merged
18:23:15 gmann sean-k-mooney: might be late for you but tomorrow or later if you can propose that in tempest I can merge. if not then I will do sometime later this week
18:24:06 sean-k-mooney i can do it now. its 19:23 but ill be around until at least the top of the hour
18:24:14 gmann thanks
18:27:06 sean-k-mooney gmann: am what will i do about https://github.com/openstack/tempest/blob/80c0477f78c71a2bd2e1a324c41cd2f50329b200/zuul.d/project.yaml#L159-L160
18:27:49 sean-k-mooney it was temporaly disabled in gate 3 years ago
18:28:04 sean-k-mooney when i replace it will i add nova-ceph-multinode or just remove that comment
18:28:16 sean-k-mooney https://github.com/openstack/tempest/commit/b1ea4327108cbbd518dfc75482dff79493b4edc9
18:28:26 gmann sean-k-mooney: yeah, mostly due to stability. but you can keep nova ceph as voting and remove from experimental queue https://github.com/openstack/tempest/blob/80c0477f78c71a2bd2e1a324c41cd2f50329b200/zuul.d/project.yaml#L176
18:28:30 gmann yeah
18:28:46 sean-k-mooney ok ill add it to both
18:29:08 sean-k-mooney its voting on nova and devstack and stable so i dont see a reason to skip in gate
18:29:30 gmann yeah
18:31:00 sean-k-mooney gmann: last question will i put the curernt devstack-ceph job in experimental. i think no but i can replace nova-ceph-multistore with it if its useful to have there
18:31:48 sean-k-mooney experiental quite a lot in it too and we can easilly add a dnm to run it if needed
18:31:57 supamatt sean-k-mooney: here's the lp bug for the security group problem, https://bugs.launchpad.net/nova/+bug/2105896
18:32:16 sean-k-mooney thanksi htink i figured out how to fix it and commented in the orginal patch
18:40:00 sean-k-mooney gmann: i think https://review.opendev.org/c/openstack/tempest/+/946076 should be good. i will respin it tomorrow if you have any issues
18:40:46 gmann sean-k-mooney: looks good, thanks
19:28:14 opendevreview Matthew Heler proposed openstack/nova master: Fix creating virtual servers with multiple security groups https://review.opendev.org/c/openstack/nova/+/946079
19:42:38 opendevreview Goutham Pacha Ravi proposed openstack/nova stable/2025.1: DNM: test dependency on devstack-plugin-ceph changes https://review.opendev.org/c/openstack/nova/+/946082
20:14:18 sean-k-mooney supamatt: we will need some test coverage but https://review.opendev.org/c/openstack/nova/+/946079/1/nova/network/neutron.py looks like it implementes the changes i suggested.
20:14:33 sean-k-mooney supamatt: im not sure if you have had a chace to test it or not
20:15:28 sean-k-mooney i can help you write a functionl repoducer or perhaps write one for you if you dont have time but lets see how ci goes over night
20:15:37 sean-k-mooney im going to drop for today but ill check back tomorrow
20:38:31 supamatt I tested the patch in lab, seems to have worked and the vm built. When previously it did not.
22:54:07 opendevreview Matthew Heler proposed openstack/nova master: Fix creating virtual servers with multiple security groups https://review.opendev.org/c/openstack/nova/+/946079
23:38:09 opendevreview Matthew Heler proposed openstack/nova master: Fix creating virtual servers with multiple security groups https://review.opendev.org/c/openstack/nova/+/946079
#openstack-nova - 2025-04-02
00:15:55 gmann melwitt: in case you are around, please check this one to unblock osc-placement gate https://review.opendev.org/c/openstack/osc-placement/+/946031
01:11:10 opendevreview Merged openstack/nova master: ironic: fix logging of validation errors https://review.opendev.org/c/openstack/nova/+/942019
02:00:24 opendevreview Doug Goldstein proposed openstack/nova stable/2025.1: ironic: fix logging of validation errors https://review.opendev.org/c/openstack/nova/+/946095
07:11:52 opendevreview Merged openstack/osc-placement master: Add bindep.txt for ubunutu 24.04 support https://review.opendev.org/c/openstack/osc-placement/+/946031
07:40:14 mikal sean-k-mooney: I read the scroll back of the meeting. Thanks for trying to explain what I was thinking. I'd prefer not to attend the PTG (its after midnight and I am not a late night guy), but I will if there is any controversy around the proposal. If there's no controversy however, let's just work on landing the things and skip the talking.
12:07:02 opendevreview sean mooney proposed openstack/placement master: improve test logging and replace psycopg2 with psycopg2-binary https://review.opendev.org/c/openstack/placement/+/945487
12:23:07 opendevreview Balazs Gibizer proposed openstack/nova master: Remove nova debugger functionality https://review.opendev.org/c/openstack/nova/+/922496
12:57:40 opendevreview Merged openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/944963
13:32:32 opendevreview Dan Smith proposed openstack/nova master: Support "one-time-use" PCI devices https://review.opendev.org/c/openstack/nova/+/943816
13:32:32 opendevreview Dan Smith proposed openstack/nova master: Add one-time-use devices docs and reno https://review.opendev.org/c/openstack/nova/+/944262
13:32:33 opendevreview Dan Smith proposed openstack/nova master: WIP: Functional tests for one-time-use devices https://review.opendev.org/c/openstack/nova/+/946065
13:55:02 opendevreview Balazs Gibizer proposed openstack/nova master: Remove nova debugger functionality https://review.opendev.org/c/openstack/nova/+/922496
13:55:02 opendevreview Balazs Gibizer proposed openstack/nova master: split monkey_patching form import https://review.opendev.org/c/openstack/nova/+/922425
14:17:07 opendevreview Dan Smith proposed openstack/nova master: WIP: Functional tests for one-time-use devices https://review.opendev.org/c/openstack/nova/+/946065
14:17:38 dansmith gibi: ^ this adds a post-configure heal test..I'll have to think on the migration thing a bit
14:17:53 Uggla @dansmith, just to confirm: 1h for PTG the cross team meeting with glance, do you think it is ok ?
14:18:03 dansmith Uggla: yes
14:18:56 Uggla dansmith, cool. thx. So it should be Wed 14h->15h, I'm just waiting for cinder confirmation.
14:19:12 dansmith okay
14:19:31 dansmith Uggla: remind me what the schedule is for getting the os-traits thing out.. you said after epoxy, which is supposed to be today right?
14:20:06 dansmith I really want to get as much of OTU wrapped up as possible before I leave for a week and come back with a vegetable brain
14:20:23 gibi dansmith: thanks!
14:20:41 Uggla dansmith, yes assuming it is released today. I will open the os-trait tomorrow morning my time. Is that ok 4 you ?
14:21:08 dansmith Uggla: okay
14:23:25 gibi release machinery is in progress I think we will have announcement as soon as the top of the hour
14:23:39 gibi elodilles can keep me honest here :)
14:23:59 Uggla dansmith, gibi, I have a pb with the eventlet. Eventlet "team" is doing a session Tue 14 --> 16h UTC. Will you want to go to this meeting. Do you want to address the "nova" eventlet point within this meeting or keeping it one the nova side ?
14:24:47 gibi Uggla: I would like to go to the global eventlet session to gather input
14:25:36 gibi Uggla: if possible it woudl be nice to have the nova specific eventlet discussion after the global session
14:28:53 Uggla Ok fine by me, if possible I'll try to not set something at the same time so people could go to the eventlet session. But we have a lot of topics, so I'm unsure we can do it yet. So at least you will be our nova representative guy in that session.
14:29:48 gibi Uggla: feel free to schedule things for nova in that timeslot I can add my views as comment to the etherpad for those topics and the team can discuss without me
14:30:24 dansmith Uggla: also, you don't need to ruin anything just to work around my schedule
14:30:51 dansmith things I really need to be part of would be nice to be earlier in the week, but if it's not possible, it's not worth breaking everything
14:30:51 Uggla gibi, sure, but I'd like to assist if possible. TBH that sounds difficult.
14:31:07 dansmith not sure if that's the reason for the scheduling problems or not, but.. it shouldn't be
14:32:04 gibi Uggla: sure appreciate that you try, just not worry too much :)
14:33:21 Uggla I try to adapt to all constraints if possible. If not that's life.
14:34:19 Uggla dansmith, fyi cinder confirms the timeslot for glance/cinder/nova session.
14:34:43 dansmith Uggla: wait, nova/cinder/glance or nova/glance?
14:35:01 Uggla nova/cinder/glance
14:35:57 dansmith okay is that when we're discussing the locations stuff?
14:35:59 Uggla dansmith, Cyril requested cinder too.
14:36:17 dansmith ah okay I'm not sure that's the best plan for that but... okay

Earlier   Later