Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2025-03-25
15:06:59 sean-k-mooney Uggla: am we could the topics i wanted to raise are not only relvent to watcher but it does not need to be super formal
15:07:05 dansmith sean-k-mooney: yep, already tried that, but you can use testtools directly, just not for a specific test. you have to run all the gabbit tests
15:07:46 sean-k-mooney did you try the stestr pdb supprot?
15:10:15 sean-k-mooney ... AttributeError: module 'placement.tests.functional.test_api' has no attribute 'allocations-bug-1778743_post_multiple_allocations'
15:10:22 sean-k-mooney right
15:11:09 Uggla sean-k-mooney, ok so I will not create a specific time slot only for watcher and will "distribute" the topic in the agenda where it fits best. Is that ok ?
15:11:26 sean-k-mooney sounds good
15:12:21 sean-k-mooney dansmith: so passing --pdb to stestr didnt help either how fun
15:13:32 dansmith lovely
15:16:14 opendevreview Dan Smith proposed openstack/placement master: Fix placement allocate while over-capacity https://review.opendev.org/c/openstack/placement/+/945465
15:16:37 sean-k-mooney dansmith: https://github.com/cdent/gabbi/commit/2469b1617fde2ee62f42ef48fc38a7d075c1dd62#diff-af026a8f8ce5b1d6bf2c2b9a33c71ba0566feb828ca0fbc8ec4f3970c2835c75
15:16:46 sean-k-mooney appreently you can mark a test as verbose
15:17:14 dansmith and that lets logs go?
15:19:20 sean-k-mooney not exactly https://paste.opendev.org/show/bI2SFFiDmfx51VXu7CrD/
15:19:36 sean-k-mooney you do get more output
15:19:54 dansmith unhelpful output
15:20:19 sean-k-mooney its jsut increasing the verbosity of the client
15:26:56 dansmith yeah
15:33:59 sean-k-mooney ok i have logs but i need to change code
15:34:08 sean-k-mooney ill make this configuable in a env var
15:34:46 sean-k-mooney tldr set this to false https://github.com/openstack/placement/blob/master/placement/tests/functional/fixtures/capture.py#L55
15:35:12 dansmith WAT
15:35:16 dansmith set to false?
15:35:35 sean-k-mooney yep to turn off the log capture and allow it to print to stderr
15:35:36 dansmith I have commented out the usage of that thing entirely and I still don't get logs
15:36:09 dansmith do you also have to disable the stdio capture?
15:36:10 sean-k-mooney i also invoked it liek this wiht a few other changes
15:36:12 sean-k-mooney OS_DEBUG=1 OS_LOG_CAPTURE=1 tox -e functional -- --failing
15:36:43 dansmith okay are you going to push up a change so I can see what all?
15:36:49 sean-k-mooney yep
15:37:03 dansmith aight
15:37:22 sean-k-mooney i mean its just this https://termbin.com/gj5q
15:37:39 sean-k-mooney but not all of that is relevent
15:38:11 sean-k-mooney ill past you the output so you can review
15:38:19 sean-k-mooney then ill figure out what bits actully matter
15:39:44 sean-k-mooney https://termbin.com/zacx
15:40:40 sean-k-mooney File "/home/smooney/repos/placement/placement/objects/allocation.py", line 262, in _check_capacity_exceeded
15:40:41 sean-k-mooney prev_used = prev_usage[alloc.resource_provider.id][rc_id]
15:40:43 opendevreview Dan Smith proposed openstack/placement master: Reproduce bug 2104040: allocate in over-capacity https://review.opendev.org/c/openstack/placement/+/945464
15:40:43 opendevreview Dan Smith proposed openstack/placement master: Fix placement allocate while over-capacity https://review.opendev.org/c/openstack/placement/+/945465
15:40:43 sean-k-mooney ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^
15:40:45 sean-k-mooney KeyError: 0
15:41:34 dansmith OS_LOG_CAPTURE=1 sets capture_logs=True on oslo right?
15:41:55 sean-k-mooney i need to see if thats actully needed but proably
15:42:17 dansmith very confusing if we need to set that on the parent *and* =False on the child.. I suspect one of those and not the other is to blame
15:42:36 sean-k-mooney ok so that is not relevnet
15:42:42 sean-k-mooney i can set it to 0 and it still work
15:42:48 sean-k-mooney i was gong to use that to contole it however
15:43:27 dansmith okay, isn't that capture_logs flag telling oslo to capture the logs in memory so they can be reported with the test failure?
15:43:29 sean-k-mooney so instead of hardcoding this to true defualt that to 0 or 1 i dont know what makes the most sense and allow you to override it
15:43:43 dansmith I'm not sure why we'd ever want that to be false unless the reporting is wrong
15:45:27 sean-k-mooney i need to read the related code to answer properly but this is the relevnet code https://github.com/openstack/oslotest/blob/1fe445863e124f8a10c1496fb8244c745e546b21/oslotest/log.py#L35-L91
15:46:13 sean-k-mooney this is why i have not pushed a patch yet im trying to load context and then figurout what the correct behavior should be before commiting and pushing
15:47:36 Uggla nova meeting in aound 15mn.
15:48:03 sean-k-mooney dansmith: by hardcodign it to ture we were alsways addign the fake loonger
15:48:25 sean-k-mooney which make shte logs aviable in the tests
15:48:37 dansmith right, but that's the intent so it gets reported to the test runner so the runner can report the test fail with logs right?
15:48:39 sean-k-mooney btu im not sure if that will attach them to the tests to print on output
15:48:47 dansmith yeah, idk
15:49:03 dansmith so many layers and years of crust, I'm not even sure how it's supposed to work
15:49:20 sean-k-mooney since we know what to flip we can easly expose that bool as an env var in any case
15:51:43 sean-k-mooney dansmith: so its wrapping a logging fixture form fixtures and nuke_handeler is set to true
15:51:45 sean-k-mooney https://github.com/testing-cabal/fixtures/blob/master/fixtures/_fixtures/logger.py#L39-L40
15:52:03 sean-k-mooney which prevent it going to stdout
15:53:15 sean-k-mooney dansmith: i have not trast all the code it possibel we ar attachign the logs as an addtional attachment to the test
15:53:27 dansmith right, but I thought things like testr were doing their own capturing of the logs, as long as they don't get swallowed so they can be reported per-test (in the "logging" section)
15:53:28 sean-k-mooney there is an stester flag to print addtional attachments
15:53:37 dansmith right, unittest does that with addSection() or whatever
15:53:54 sean-k-mooney ya let me see if passing that flag helps
15:54:52 sean-k-mooney oh that just for succesful test "--all-attachments"
15:55:00 dansmith yeah
15:56:03 opendevreview Merged openstack/nova master: Fix case sensitive comparison https://review.opendev.org/c/openstack/nova/+/933107
15:57:28 opendevreview Merged openstack/nova master: Fix case-sensitivity for metadata keys https://review.opendev.org/c/openstack/nova/+/873901
15:57:36 opendevreview Merged openstack/nova master: Update master for stable/2025.1 https://review.opendev.org/c/openstack/nova/+/944890
16:00:20 Uggla #startmeeting nova
16:00:20 opendevmeet Meeting started Tue Mar 25 16:00:20 2025 UTC and is due to finish in 60 minutes. The chair is Uggla. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:20 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:20 opendevmeet The meeting name has been set to 'nova'
16:00:42 Uggla Hello everyone
16:01:41 masahito o/
16:02:02 elodilles o/
16:02:24 gibi o/
16:02:35 Uggla awaiting a moment for people to join.
16:02:43 dansmith o/
16:03:24 bauzas \o (in another meeting)
16:03:45 Uggla #topic Bugs (stuck/critical)
16:03:54 Uggla #info No Critical bug
16:04:02 Uggla #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster
16:04:34 Uggla anything about bugs ?
16:05:30 Uggla #topic Gate status
16:06:06 Uggla #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs
16:06:14 Uggla #link https://etherpad.opendev.org/p/nova-ci-failures-minimal
16:06:25 Uggla #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&branch=stable%2F*&branch=master&pipeline=periodic-weekly&skip=0 Nova&Placement periodic jobs status
16:06:32 Uggla #info Please look at the gate failures and file a bug report with the gate-failure tag.
16:06:39 Uggla #info Please try to provide meaningful comment when you recheck
16:06:58 Uggla anything about the gate ?
16:07:46 Uggla seems not.
16:07:57 Uggla #topic Release Planning
16:08:07 Uggla #link https://releases.openstack.org/epoxy/schedule.html
16:08:15 Uggla #info Nova deadlines are set in the above schedule

Earlier   Later