Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2025-02-26
16:30:52 frickler Uggla: please check https://review.opendev.org/c/openstack/governance/+/942507/comment/029df38c_6df9f638/ . it would likely also be helpful if you could join the #openstack-tc channel while you are PTL
16:32:36 Uggla frickler, I'm currently in a meeting, but I'will have a look after.
16:34:04 frickler Uggla: thx, not urgent, just so you don't miss it
16:53:44 sean-k-mooney dviroel: left some minor feedback on https://review.opendev.org/c/openstack/nova/+/938604 but i think this is mostly good to go
16:55:56 dviroel sean-k-mooney: oh, thanks, indeed, going to update it
16:56:25 sean-k-mooney im looking at the tempest patch now so far looks good to me
17:05:21 sean-k-mooney dviroel: minor comment on https://review.opendev.org/c/openstack/tempest/+/939375 as well
17:05:40 sean-k-mooney over all it looks fine to me but i htink you need to update teh import
17:06:19 sean-k-mooney gmann: ^ would you be able to comment on the questions i have inline and confirm the schema inheritance is correct or not?
17:38:49 opendevreview Douglas Viroel proposed openstack/nova master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/nova/+/938604
17:40:42 dviroel sean-k-mooney: ^ updated. Lets see if functional is going to pass. I added a scheduler hint to the server creation req
17:41:00 dviroel in the api_sample_tests
17:45:34 sean-k-mooney assuming it green i think ill be +2
17:45:41 sean-k-mooney ill check back in a bit once we get some results
17:46:40 sean-k-mooney if it does break thign we can revert that chagne and try and update it in a follow uponce the feature is merged
17:48:15 sean-k-mooney dviroel: it looks a little funky https://5671b50e1757693146fd-d2676880cd4ce07846d9d5d9e5ab28d1.ssl.cf1.rackcdn.com/938604/11/check/build-openstack-api-ref/6d89054/docs/#id30
17:48:35 sean-k-mooney i have not looked at the code but did you really use a regex?
17:48:37 sean-k-mooney "scheduler_hints": {
17:48:39 sean-k-mooney "same_host": [
17:48:41 sean-k-mooney "[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}"
17:48:43 sean-k-mooney ]
17:48:45 sean-k-mooney },
17:51:40 dviroel i was reusing an example from a sever creation
17:51:45 dviroel v2.63 i think
17:52:08 sean-k-mooney ok well it net to be a uuid
17:52:19 sean-k-mooney as in the example respocne shoudl not be the validation critia
17:52:37 sean-k-mooney it shoudl be somethign like "dc877f7e-7d69-4c3c-956b-1978cd8ed754"
17:52:59 dviroel yeah, let me fix that
17:53:28 sean-k-mooney its apprently an arry of uuids
17:53:45 sean-k-mooney at least based on your tempets change
17:55:25 sean-k-mooney oh
17:55:36 sean-k-mooney it can be a single uuid as a stirng or an away or them
17:55:59 sean-k-mooney the 2.90 create exmaple has
17:56:04 sean-k-mooney "OS-SCH-HNT:scheduler_hints": {
17:56:06 sean-k-mooney "same_host": "48e6a9f6-30af-47e0-bc04-acaed113bb4e"
17:56:08 sean-k-mooney }
17:56:43 sean-k-mooney as an example in the request
17:56:58 sean-k-mooney so you can just do the same in the responce example
17:57:18 sean-k-mooney well without the OS-SCH-HNT prefix
17:57:52 sean-k-mooney everything else looked good excpti the example value
18:01:10 dviroel yeah, they are adding this in the request sample, but not in the template, but the test does not validate that
18:03:48 melwitt huh, yeah, this should not have been a regex 😝 https://github.com/openstack/nova/blob/master/doc/api_samples/servers/v2.63/server-create-req.json someone missed that in review
18:04:08 sean-k-mooney ya.. i noticed it was broken there
18:04:25 sean-k-mooney but given that out of scop of dviroel's patch i decied not to mention that
18:04:36 sean-k-mooney im sure we have other cases where that has happen
18:05:12 melwitt well he mentioned it above, that's how I found it
18:06:33 sean-k-mooney melwitt: since your about would you have tim eto take a look at dviroel patch since you have recently look at all this for the other api changes
18:07:15 dviroel i used the 'uuid' - and it the end, it was replace in the post server: https://opendev.org/openstack/nova/src/commit/8f57fa7359d57e186fc6b75424b4900dc63c564f/nova/tests/functional/api_sample_tests/test_servers.py#L70
18:07:18 melwitt yeah, I can look at it
18:07:39 sean-k-mooney cool https://review.opendev.org/c/openstack/nova/+/938604/11 is the nova change and https://review.opendev.org/c/openstack/tempest/+/939375 is the tempest update, finall https://review.opendev.org/c/openstack/nova/+/942728 pulls those together
18:08:09 sean-k-mooney dviroel: i will try and look at the sdk and clinet changes also but nova and tempest are the priorities
18:09:52 dviroel ack, thanks sean-k-mooney - yeah, not so sure if my client change is correct, ptal when you have some time
18:21:22 opendevreview Douglas Viroel proposed openstack/nova master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/nova/+/938604
18:30:41 gmann sean-k-mooney: sure, checking
18:50:39 opendevreview ribaudr proposed openstack/nova master: Augment the LiveMigrateData object https://review.opendev.org/c/openstack/nova/+/942143
18:50:39 opendevreview ribaudr proposed openstack/nova master: Add live_migratable flag to PCI device specification https://review.opendev.org/c/openstack/nova/+/942144
18:50:40 opendevreview ribaudr proposed openstack/nova master: Update manager to allow vfio pci device live migration https://review.opendev.org/c/openstack/nova/+/942145
18:50:40 opendevreview ribaudr proposed openstack/nova master: Update conductor and filters allowing migration with SR-IOV devices https://review.opendev.org/c/openstack/nova/+/942146
18:50:41 opendevreview ribaudr proposed openstack/nova master: Update driver to map the targeted address for SR-IOV PCI devices https://review.opendev.org/c/openstack/nova/+/942147
19:04:47 opendevreview ribaudr proposed openstack/nova master: Update conductor and filters allowing migration with SR-IOV devices https://review.opendev.org/c/openstack/nova/+/942146
19:04:48 opendevreview ribaudr proposed openstack/nova master: Update driver to map the targeted address for SR-IOV PCI devices https://review.opendev.org/c/openstack/nova/+/942147
19:14:58 mikal Morning
19:19:22 opendevreview Callum Dickinson proposed openstack/nova master: Add image meta to libvirt XML metadata https://review.opendev.org/c/openstack/nova/+/942766
19:21:52 opendevreview Ryota, Ochiai proposed openstack/nova master: doc: Delete deprecated settings of the installation guide https://review.opendev.org/c/openstack/nova/+/896074
20:12:31 gmann sean-k-mooney: dviroel: reviewed the nova and tempest change, we are missing the update server APIs changes which is also impacted when we update the views/servers.py
20:13:04 gmann in nova side it is just documentation and test and in tempest tests we need to add schems and test for update server
20:16:28 dviroel gmann: oh thanks, I missed the update server. going to propose an update, thanks
20:20:48 opendevreview Callum Dickinson proposed openstack/nova master: Add image meta to libvirt XML metadata https://review.opendev.org/c/openstack/nova/+/942766
20:29:59 opendevreview Callum Dickinson proposed openstack/nova master: Add image meta to libvirt XML metadata https://review.opendev.org/c/openstack/nova/+/942766
20:53:24 opendevreview Douglas Viroel proposed openstack/nova master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/nova/+/938604
21:27:41 opendevreview Max proposed openstack/nova master: feat: nova-manage db instance events cleanup https://review.opendev.org/c/openstack/nova/+/916927
22:03:36 gmann 34
22:05:02 gmann please ignore
22:09:34 gmann dviroel_bbl: ack
22:11:34 sean-k-mooney[m] gmann: so dviroel dint modify server update in this api microverions
22:12:04 sean-k-mooney[m] if we missed that in this change its also missing from 2.98
22:12:17 sean-k-mooney[m] for the image properies in server show
23:30:41 dviroel sean-k-mooney: and pinned_availability_zone in 2.96 too
23:31:24 sean-k-mooney[m] yes more then likely but we should fix that seperatly
23:33:48 dviroel my tempest change is not going to pass without theses fixes in tempest side, since now I am testing update server too, and thy are missing
23:38:38 gmann sean-k-mooney[m]: it does. this line change the update server API also https://review.opendev.org/c/openstack/nova/+/938604/12/nova/api/openstack/compute/views/servers.py#335
23:39:42 sean-k-mooney[m] in directly via reusing show
23:40:03 gmann basically we have to keep these 4 APIs (GET, GET details, Rebuild, update server) response consistent (we fixed it in 2.74). I commented in the spec also to mention all these 4 APIs response change together
23:41:19 gmann I did not check earlier microversion 2.98 or 2.96 but we should keep all these 4 APIs response consistently and they get changed together when we change the views/servers.py
#openstack-nova - 2025-02-27
00:20:45 opendevreview ribaudr proposed openstack/nova master: Bump MIN_{LIBVIRT,QEMU} for "Epoxy" https://review.opendev.org/c/openstack/nova/+/942871
00:20:46 opendevreview ribaudr proposed openstack/nova master: WIP Below version constants removal for MIN_{LIBVIRT,QEMU} https://review.opendev.org/c/openstack/nova/+/942872
00:24:55 dviroel gmann: thanks for proposing the fix to 2.96 and 2.98 in tempest
00:28:52 gmann dviroel: those should fix and nova documentation for 2.96, 2.98 we can fix after that
00:29:42 dviroel +1
02:09:12 opendevreview Ghanshyam proposed openstack/nova master: Fix microversion 2.96 for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942875
03:39:44 opendevreview Ghanshyam proposed openstack/nova master: Fix microversion 2.96 for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942875
04:53:16 opendevreview Ghanshyam proposed openstack/nova master: Fix microversion 2.98 doc/tests for update/rebuild APIs https://review.opendev.org/c/openstack/nova/+/942878
09:17:05 jkulik anybody up for a review on https://review.opendev.org/c/openstack/nova/+/942371 ? it's a 2-line fix for a bug in libvirt's maxphysaddr support
09:22:14 gibi jkulik: thanks for fixing that bug, if you can fix my comment in the unit test then I'm happy to +2 it
09:22:53 jkulik gibi: thanks. will do
09:33:12 opendevreview Johannes Kulik proposed openstack/nova master: libvirt: fix maxphysaddr passthrough dom parsing https://review.opendev.org/c/openstack/nova/+/942371
09:55:43 gibi jkulik: thanks, +2
10:17:32 frickler looks like tempest.api.compute.servers.test_create_server.ServersV294TestFqdnHostnames.test_verify_hostname_allows_fqdn is unstable, haven't seen this before https://zuul.opendev.org/t/openstack/build/4cb5f1127e464ab3b2b5cf651fd5ac9e
10:54:17 opendevreview ribaudr proposed openstack/nova master: Bump MIN_{LIBVIRT,QEMU} for "Epoxy" https://review.opendev.org/c/openstack/nova/+/942871
10:54:17 opendevreview ribaudr proposed openstack/nova master: WIP Below version constants removal for MIN_{LIBVIRT,QEMU} https://review.opendev.org/c/openstack/nova/+/942872

Earlier   Later