| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-02-21 | |||
| 12:12:48 | sean-k-mooney | {"os_vif_delegation": true} was not ment to be the only content by the way it was ment to be added to the prociel and remvoe dlater | |
| 12:14:23 | sean-k-mooney | the bug doe snot say it just say "openstack port set $port_id --binding-profile aaa=bbb --binding-profile ccc=ddd" | |
| 12:14:29 | sean-k-mooney | which is not supproted | |
| 12:15:10 | sean-k-mooney | there is only one filed that can be set by a human in the bidnign profile ant that trusted_vf | |
| 12:15:32 | sean-k-mooney | and removing that has been on our todo list forever | |
| 12:21:46 | nisha | in our case, the bgp network settings are set to the port in the binding profile and after live migration it is completely overwritten by os_vif_delegation | |
| 12:27:51 | sean-k-mooney | that doesn not sound like a supprote setup. can you point to the neutron pluging and confirm what virt driver your using | |
| 12:29:12 | sean-k-mooney | in the case of use with nova the content of the binding profile is exlicively resrevd for novas use, for zun it reserved for zun for standalone ironic it cna use it but it may not modify it when used via nova | |
| 12:29:53 | sean-k-mooney | there is a bug on the nova side but its not ok for neturon to modify the content of that filed | |
| 12:30:18 | sean-k-mooney | so if the ml2 dirver is modifying its incorrect | |
| 12:35:50 | nisha | yes, ml2 is the neutron core plugin and libvirt driver | |
| 12:36:06 | sean-k-mooney | that does not answer my question | |
| 12:36:13 | sean-k-mooney | which ml2 driver? | |
| 12:36:17 | sean-k-mooney | there are many | |
| 12:49:05 | cardoe | vsaienko: so fwiw, your trunk details patch https://review.opendev.org/c/openstack/nova/+/941227 with my suggested change works for us on real hardware | |
| 12:54:27 | opendevreview | Vasyl Saienko proposed openstack/nova-specs master: Expose vlan trunking in metadata/configdrive https://review.opendev.org/c/openstack/nova-specs/+/471815 | |
| 12:55:37 | vsaienko | cordoe: thanks, nova team asked to create a spec https://review.opendev.org/c/openstack/nova-specs/+/471815, and I've discovered that in my patch grenade job is failing because of issues with Instance object format not recognized correctly by older nova-compute. | |
| 13:05:40 | opendevreview | Luis Enrique Morales Mendez proposed openstack/nova master: Add 'LOG' to archive_deleted_rows function https://review.opendev.org/c/openstack/nova/+/942441 | |
| 13:06:59 | cardoe | Looking to land https://review.opendev.org/c/openstack/nova/+/942019 and then create some backports to 2024.2 and 2024.1 without that change those versions just log the SDK Result Object at <0xDEADBEEF> as the error message. | |
| 13:12:47 | nisha | sean-k-mooney: we use custom driver which is a combination of srv6 and l2isolate type driver using linuxbridge based agent, i suspect this is responsible to overwrite the binding_profile. i understand the current situation on nova's side. thank you for sharing the details. | |
| 15:57:53 | ratailor | sean-k-mooney, you around ? | |
| 21:01:56 | opendevreview | melanie witt proposed openstack/nova master: DNM test microversion 2.99 https://review.opendev.org/c/openstack/nova/+/942493 | |
| 21:11:25 | mikal | melwitt / sean-k-mooney: https://review.opendev.org/c/openstack/tempest/+/942495 is an attempt at the schema changes in tempest for v2.98. I am fairly confident it is wrong. | |
| 21:18:21 | melwitt | mikal: I also uploaded one a few minutes ago heh. I'm running a DNM patch at the end of the series to see if it works | |
| 21:18:40 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 21:18:40 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 21:18:41 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 21:18:58 | mikal | melwitt: oh I saw your nova one, did you do a tempest one too? | |
| 21:19:10 | melwitt | aaand it just got orphaned I think | |
| 21:19:14 | melwitt | haha, yes I did | |
| 21:19:17 | mikal | melwitt: I might have just stomped on yours then... | |
| 21:19:28 | mikal | Ok, I'll revert mine changes to the nova series. Sorry. | |
| 21:19:36 | melwitt | no I think it's ok | |
| 21:19:58 | mikal | Well the series now depends on my lame attempt at a v2.98 schema in tempest | |
| 21:20:04 | melwitt | mikal: it looks like it's still working anyway | |
| 21:20:57 | mikal | melwitt: your tempest patch is definitely better than mine. I am pretty sure mine will get in your way unless your orphan test is just continuing to run? | |
| 21:21:05 | melwitt | it looks like it's pinned to PS 40. that's pretty cool | |
| 21:21:35 | melwitt | mikal: it's continuing to run. I didn't think it used to work that way but this is nice | |
| 21:22:06 | mikal | I'll still have to drop the depends on for my WIP tempest change or it will get in the way. I'll do that now. | |
| 21:22:11 | opendevreview | Douglas Viroel proposed openstack/nova master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/nova/+/938604 | |
| 21:22:52 | melwitt | sorry for duplicating. I wanted to try to help since the microversion race messed everything up | |
| 21:23:31 | mikal | Oh, I am very grateful for the help. I definitely don't want to be chasing this over the weekend, but I am also very worried about missing feature freeze at this point. | |
| 21:23:55 | mikal | error: remote unpack failed: error Missing tree 4a45ed28aa51f7ae9791b3f90a1fe8fef3c42dab | |
| 21:23:55 | mikal | fatal: Unpack error, check server log | |
| 21:24:00 | mikal | I have no idea what that means. | |
| 21:24:08 | melwitt | no, we will get it working | |
| 21:29:17 | melwitt | bleh. my DNM patch just failed. must be something in my tempest patch, I'll figure out what's wrong with it | |
| 21:30:39 | mikal | I am just arguing with gerrit to try and remove that depends-on I only just added, but for reasons too boring to explain git review takes like five minutes in my workflow. | |
| 21:30:48 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 21:30:49 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 21:30:49 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 21:31:22 | mikal | Right, depends-on for my bad tempest change removed. melwitt, feel free to add a depends on to your change if that's easier. I am not offended by you uploading patches to that series. | |
| 21:33:36 | melwitt | sure. yeah adding depends-on would probably be better. tbh I didn't expect anyone would be doing anything with it today so I just stacked it on top :P | |
| 21:33:55 | melwitt | and will obviously abandon once this gets working | |
| 21:37:23 | mikal | Whatever works for you is fine with me. | |
| 21:37:49 | mikal | I need to go for a run before it gets any hotter outside, but I will check back in a couple of hours. | |
| 22:07:56 | opendevreview | Max proposed openstack/nova master: feat: nova-manage db instance events cleanup https://review.opendev.org/c/openstack/nova/+/916927 | |
| 23:28:49 | melwitt | sean-k-mooney, mikal: I think I got things working for 2.98 in tempest here https://review.opendev.org/c/openstack/tempest/+/942492. the spice series passes the spice tempest test with that cc gmann | |
| 23:39:11 | sean-k-mooney | so skimming that i think that looks corect to me | |
| 23:39:30 | sean-k-mooney | and it "shoudl" fix the spice test i belvie | |
| 23:39:38 | melwitt | I tested it here https://review.opendev.org/c/openstack/nova/+/942493 | |
| 23:39:54 | sean-k-mooney | oh awsome | |
| 23:40:49 | melwitt | it definitely works for now. but if we change the schema again (I saw the fix you are working on) then we'll need to correspondingly adjust tempest after I think | |
| 23:41:15 | sean-k-mooney | am we should not need to change it | |
| 23:42:12 | sean-k-mooney | if we change it from properties to image properties like ragesh suggested we woudl be ut that need a new microversion | |
| 23:42:19 | sean-k-mooney | so we shoudl avoid that | |
| 23:42:21 | melwitt | we definitely need to add 'null' as a type bc the api is currently returning None for some properties like hw_input_bus. I comment about it on your patch | |
| 23:43:32 | mikal | Thanks for chasing this down guys, I really appreciate it. | |
| 23:43:40 | melwitt | the previous failure of the spice test was because 'null' wasn't allowed by the schema, so I added it to the schema on the tempest side | |
| 23:44:00 | mikal | Is there anything I can do here to be helpful, or do you think its largely sorted out now? | |
| 23:45:33 | melwitt | afaict I think it's sorted. just need to merge this tempest patch and then we need to re-apply +2s and +W the bottom 3 patches. I assume we can diff against PS40 to see that no code changed | |
| 23:45:50 | melwitt | *3 spice patches | |
| 23:47:23 | mikal | The first two still have their +2s in gerrit, the third one was clobbered. | |
| 23:50:40 | sean-k-mooney | i guess we have 2 chocies | |
| 23:50:55 | sean-k-mooney | we coudl add null or we could jsut not print that key in that case | |
| 23:51:16 | sean-k-mooney | is None a valid value or is it just printign that because its unset? | |
| 23:52:06 | sean-k-mooney | i had to step away to let freya (my frieds dog im minding for the week) out | |
| 23:52:16 | sean-k-mooney | but i started lookign at the third spice patch | |
| 23:52:45 | sean-k-mooney | melwitt: we can add a depends on on my image property patch to make sure its tested with your tempest patch to make sure we confrom to it | |
| 23:54:06 | melwitt | you know better than I do whether None is a valid/meaningful value. I would think it's not but I don't know for sure | |
| 23:54:48 | sean-k-mooney | we would have had to require it to be set to null in glance i think | |
| 23:55:10 | sean-k-mooney | i suspect not but we can adress that in my bugfix patch | |
| 23:55:25 | melwitt | ++ | |
| 23:55:59 | melwitt | mikal: ah ok, thanks | |
| 23:56:23 | sean-k-mooney | i readded +2 on hte third | |
| 23:58:05 | sean-k-mooney | so reading your schema patch comment | |
| 23:58:05 | mikal | sean-k-mooney: I assume the door has now closed on that os-traits change landing this cycle, yeah? | |
| 23:58:21 | sean-k-mooney | for the bools ectra i thinks we can make sure we alwasy convert the vlues to stings | |
| 23:58:50 | sean-k-mooney | mikal: am technically the release should have haappend today | |
| 23:59:10 | sean-k-mooney | but in realisty i dont know if it has so we could try and squeeze it in | |
| 23:59:13 | sean-k-mooney | let me check | |
| #openstack-nova - 2025-02-22 | |||
| 00:01:28 | sean-k-mooney | technially the final reales patch for os-traits has not been done yet... that may have been an oversite. | |
| 00:02:09 | mikal | If its too late its too late, but it does mean there's no chance of getting the USB stuff in and we should let shadow.tech know that. | |
| 00:03:46 | melwitt | does the os-traits have usefulness without the remaining spice patches? IMHO I'm not sure it's realistic to land those by the end of next week | |
| 00:04:21 | sean-k-mooney | not really | |
| 00:04:34 | sean-k-mooney | the vid series has some utility without the speice patches | |
| 00:04:35 | mikal | No, its only helpful if the usb and sound series lands as well. That said, that functionality has been trying to get in for two releases now from multiple proposers. | |
| 00:04:51 | sean-k-mooney | but the os-triats one doesnt have unitlyt with out the usb/sound changes | |
| 00:06:02 | sean-k-mooney | in either case i think there is a stong argument to try and land the usb/sound change after rc1 is cut early in 2025.2 | |
| 00:06:16 | sean-k-mooney | i.e. before the ptg | |