| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-02-17 | |||
| 19:14:56 | sean-k-mooney | o/ | |
| 19:17:38 | mikal | Apart from people being generally time poor, is there anything blocking the SPICE API changes right now that I should know about? I feel with the tempest test and devstack changes merged we should probably try and merge the matching API microversion sooner rather than later. | |
| 19:19:34 | sean-k-mooney | so https://review.opendev.org/c/openstack/os-traits/+/940418 is still pending and we are coming up to the non client lib freeze so the followup serise for sound and usb is at risk. i think that an easy review ot land IMO but i dont knwo if melwitt will have time to revisit teh patch or if others will | |
| 19:19:42 | sean-k-mooney | i have not looked at the rest in a few days | |
| 19:21:10 | mikal | I think the API changes are more important as they're the most painful bit to keep rebasing, but I would link to try and land all of them if possible. I've been rebasing these things for over a year now. | |
| 19:23:46 | melwitt | sean-k-mooney: for the os-traits patch I don't have an opinion about since I don't really know anything about that stuff. I asked questions in case it could spark yalls memory whether anything was missing or needed to be changed. so if no one else finds any problem about it I think I can +W with your SME +2 on there | |
| 19:26:04 | melwitt | I will look at the API changes again. it can be more challenging if past comments are not addressed yet and we have to keep going back and forth on that. if that's all squared away and the tempest test is done and passing, that's good and helps a lot | |
| 19:28:34 | sean-k-mooney | ack | |
| 19:28:54 | sean-k-mooney | so on the testing font we have a few related patches | |
| 19:29:27 | sean-k-mooney | i have patches up to move the nova-ovs-hybrid-plug job to debain and enabel spice (including speice testing in tempest) | |
| 19:29:50 | sean-k-mooney | that involes change to nova and devstack and tempest | |
| 19:30:29 | sean-k-mooney | melwitt: mikal split there serise in 2 1 for spice direct, and a second indepently mergable vid series for the usb/soudn devices | |
| 19:31:08 | sean-k-mooney | in the spice serise they have a depends on agains the tepmest change and my ci testing series so that pulls everything toghter and showe it working end to end | |
| 19:32:05 | melwitt | sean-k-mooney: ok cool. my understanding is we are focusing on the spice direct, the first 3 patches | |
| 19:32:15 | sean-k-mooney | so https://review.opendev.org/c/openstack/nova/+/924844/36 is the patch that pulls everythign togheter and depend on the rest | |
| 19:32:22 | sean-k-mooney | yes | |
| 19:33:18 | melwitt | right, cool | |
| 19:34:34 | sean-k-mooney | so one thing we might need to do is change the depns on order | |
| 19:35:04 | sean-k-mooney | the devstack and tempest changes have merged | |
| 19:35:37 | sean-k-mooney | so i shoudl proably merge my 2 jobs changes into one and rebase it on mikal's series | |
| 19:36:00 | sean-k-mooney | actuly no | |
| 19:36:05 | sean-k-mooney | it can merge as is | |
| 19:36:15 | sean-k-mooney | in my serise i dont update the regex to enabel the new test | |
| 19:36:21 | sean-k-mooney | that only happens in mikal's | |
| 19:36:27 | mikal | sean-k-mooney: at least one of your patches needs a recheck too I think. | |
| 19:36:46 | sean-k-mooney | i have a pep8 issue | |
| 19:36:47 | melwitt | ack | |
| 19:36:55 | sean-k-mooney | so i need to update mine anyway | |
| 19:37:14 | sean-k-mooney | releasenotes/notes/make-virtio-the-default-spice-video-model-fff5189fa637d4bd.yaml:8: supprot ==> support | |
| 19:37:24 | sean-k-mooney | i have a typo in the release note | |
| 19:39:03 | sean-k-mooney | its in the bottom of my two paches so ill update them both now | |
| 19:42:45 | sean-k-mooney | hum odd that was already fixed | |
| 19:43:50 | sean-k-mooney | ill just rebase them and check again | |
| 19:52:46 | opendevreview | sean mooney proposed openstack/nova master: move nova-ovs-hybrid-plug to deploy with spice and fix qxl default https://review.opendev.org/c/openstack/nova/+/940835 | |
| 19:52:46 | opendevreview | sean mooney proposed openstack/nova master: Dont deploy n-spice on compute nodes. https://review.opendev.org/c/openstack/nova/+/940873 | |
| 19:55:35 | sean-k-mooney | gerrit rejected my rebase as identical | |
| 19:55:55 | sean-k-mooney | so i just reflowed the release note to be less then 80 cols | |
| 19:56:08 | mikal | Oh they typo one? I pushed a fix for that to your review a week or so ago IIRC. | |
| 20:04:32 | sean-k-mooney | ya for some reason pep8 didnt run again? | |
| 20:04:36 | sean-k-mooney | it super odd | |
| 20:07:31 | opendevreview | Merged openstack/nova master: Drop dependency on netifaces https://review.opendev.org/c/openstack/nova/+/931582 | |
| 20:07:42 | opendevreview | Merged openstack/nova master: Reproduce bug/2097359 https://review.opendev.org/c/openstack/nova/+/940603 | |
| 20:07:49 | opendevreview | Merged openstack/nova master: Update InstanceNUMACell version after data migration https://review.opendev.org/c/openstack/nova/+/940604 | |
| 20:45:50 | opendevreview | Merged openstack/nova master: Update InstanceNUMACell version in more cases https://review.opendev.org/c/openstack/nova/+/940953 | |
| 20:46:02 | opendevreview | Merged openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | |
| 20:46:08 | opendevreview | Merged openstack/nova master: Disable the heal instance info cache periodic task https://review.opendev.org/c/openstack/nova/+/939476 | |
| 23:05:16 | sean-k-mooney | mikal: since https://review.opendev.org/c/openstack/nova/+/939649 was landed we will unfortunlty need to bump the microversion for the spice direct patch | |
| 23:19:52 | opendevreview | Doug Goldstein proposed openstack/nova master: ironic: fix logging of validation errors https://review.opendev.org/c/openstack/nova/+/942019 | |
| 23:26:34 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]default_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940194 | |
| 23:26:35 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]supported_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940195 | |
| 23:26:36 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add hw_tpm_secret_security image property https://review.opendev.org/c/openstack/nova/+/940196 | |
| 23:26:36 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add hw:tpm_secret_security extra spec validation https://review.opendev.org/c/openstack/nova/+/940197 | |
| 23:26:37 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Ensure secret security policy for TPM instances https://review.opendev.org/c/openstack/nova/+/941062 | |
| 23:26:37 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: TPM: support instances with `host` secret security https://review.opendev.org/c/openstack/nova/+/941795 | |
| 23:26:38 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Allow vTPM live migration for `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | |
| 23:26:38 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Modify vTPM LM block to block legacy instances https://review.opendev.org/c/openstack/nova/+/941483 | |
| 23:26:39 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: TPM: support instances with `deployment` secret security https://review.opendev.org/c/openstack/nova/+/942021 | |
| 23:32:43 | mikal | sean-k-mooney: ummm, that will require a new tempest change as well then. That's very disappointing. | |
| 23:33:20 | sean-k-mooney | ya i really didnt want ot merge that until your patch was in | |
| 23:40:31 | mikal | https://review.opendev.org/c/openstack/tempest/+/942023 is the tempest renumbering. gmann you'll need to take a look at that one soonish please. | |
| 23:41:00 | mikal | We wont see an end-to-end run though until I get a chance to renumber the nova API changes as well. | |
| 23:41:13 | sean-k-mooney | strictly speakign that should have a depends on against the nova change | |
| 23:41:24 | sean-k-mooney | the tempest changes are only ment to merge after the nova api change | |
| 23:41:41 | sean-k-mooney | i was orginally surrpised to find the tempest patch meged eailier | |
| 23:43:40 | mikal | Ok, I added that. | |
| #openstack-nova - 2025-02-18 | |||
| 00:13:05 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 00:13:06 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 00:13:06 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 00:13:33 | mikal | ^--- the third patch will fail because there's some subtle API testing thing I need to figure out, but I don't have time right now. | |
| 00:23:08 | sean-k-mooney | i think its https://review.opendev.org/c/openstack/nova/+/924844/37/nova/api/openstack/compute/console_auth_tokens.py#93 | |
| 00:23:18 | sean-k-mooney | that shoudl be 2.98 not 2.97 | |
| 00:26:10 | sean-k-mooney | im comemntign on a few more | |
| 00:28:38 | sean-k-mooney | mikal: ok comment left on the thing i think that need to be updated but im not 100% sure | |
| 04:28:38 | opendevreview | Amit Uniyal proposed openstack/nova master: WIP: remove swap.disk from disk.info https://review.opendev.org/c/openstack/nova/+/939643 | |
| 04:39:05 | opendevreview | Amit Uniyal proposed openstack/nova master: WIP: remove swap.disk from disk.info https://review.opendev.org/c/openstack/nova/+/939643 | |
| 09:38:50 | opendevreview | Merged openstack/nova master: allow discover host to be enabled in multiple schedulers https://review.opendev.org/c/openstack/nova/+/938523 | |
| 10:18:00 | tkajinam | sean-k-mooney gibi, could one of you nudge https://review.opendev.org/c/openstack/nova/+/936287 to gate ? its parent was already merged | |
| 10:18:12 | tkajinam | (it already has two +2s but no +A | |
| 10:18:36 | tkajinam | I had to rebase it, and that wiped out +A :-( | |
| 10:19:23 | sean-k-mooney[m] | done | |
| 10:20:01 | tkajinam | sean-k-mooney[m], thx ! | |
| 10:43:08 | mikal | sean-k-mooney: thanks for the pointer on the review, I'm uploading a new set of patches nowish that should pass tests. | |
| 10:43:41 | mikal | I am not sure what timezone gmann is in, but we might want to make sure they're aware of the tempest SNAFU. | |
| 10:48:40 | opendevreview | Merged openstack/nova master: Add unit test coverage of get_machine_ips https://review.opendev.org/c/openstack/nova/+/936287 | |
| 10:49:19 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 10:49:20 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 10:49:20 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 10:51:47 | bauzas | mikal: I need to leave now but I left some comments on your series | |
| 10:52:16 | mikal | bauzas: the spice-direct or the USB / sound one? | |
| 10:52:27 | bauzas | mikal: nothing critical as most of them were related to the 2.99 fixes you need to do, but there is also another question about the returned value of tls_port in case of a rolling upgrade | |
| 10:52:32 | bauzas | mikal: the former | |
| 10:53:34 | bauzas | tl;dr: if the API calls some old compute for getting the ConsoleAuthToken object, it will obtain a None value for the tls_port field | |
| 10:54:04 | bauzas | which basically works but returns 'null' (IIRC) as an API returned value | |
| 10:54:05 | mikal | I think that is ok. That would also happen if you had spice.require_secure set to false. | |
| 10:54:23 | mikal | i.e. a user of the API already has to handle that case. | |
| 10:54:30 | bauzas | mikal: cool, I wanted you to be aware of such value, feel free to leave a comment then to reply you're good with that | |
| 10:54:39 | mikal | Ok, will do. | |
| 11:09:16 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 11:09:17 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 11:09:17 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |