| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-02-12 | |||
| 16:46:59 | sean-k-mooney | yes | |
| 16:47:24 | sean-k-mooney | so i was randomly hackign on https://review.opendev.org/c/openstack/nova/+/933478 a while ago and wanted to use them and found its not aviabel | |
| 16:48:51 | sean-k-mooney | dansmith: we didnt have ether aviabel to the weiers untile pci in palcemnt and gibi only passed the allcoation since that is all they needed | |
| 16:49:19 | bauzas | okay, I hear your voices, I'll keep that weigher stupidly simple | |
| 16:50:03 | dansmith | maybe we should have a gmeet amongst the four of us and make sure we have a path forward | |
| 16:50:31 | dansmith | I don't think gibi is going to be happy with simple, and it may not address the actual concern according to him, so we might just want to get on the same page | |
| 16:51:22 | sean-k-mooney | we can if we want too | |
| 16:51:35 | sean-k-mooney | but i wonder if we should be rushing into the design | |
| 16:52:14 | sean-k-mooney | im find we havign a call to see if we have a common undersanding | |
| 16:52:50 | sean-k-mooney | i just wonder if we shoudl disucss this at the ptg instead. we can totally do it now if we think there is a useful veriosn we coudl deviler this cycle | |
| 16:53:26 | sean-k-mooney | but i dont want to merge somethign we think wont acutlly be useful | |
| 16:53:33 | dansmith | I don't want to rush, but I also don't think this is complicated enough that we need to push it off... it doesn't affect rpc or api, which means getting it perfect the first time is not really a big deal, IMHO | |
| 16:54:21 | sean-k-mooney | ack | |
| 16:54:36 | sean-k-mooney | fyi https://github.com/openstack/nova/blob/32326d48949525a995d132bddc90e710c229947f/nova/scheduler/manager.py#L195-L205 is where we have the allcoation and the provider summeries already | |
| 16:55:57 | sean-k-mooney | we also pass them into _schedule https://github.com/openstack/nova/blob/32326d48949525a995d132bddc90e710c229947f/nova/scheduler/manager.py#L195-L343 | |
| 16:56:45 | sean-k-mooney | we are just not assocating them with the host or pasing them to get_sorted_hosts https://github.com/openstack/nova/blob/32326d48949525a995d132bddc90e710c229947f/nova/scheduler/manager.py#L421 | |
| 17:28:36 | gibi | sorry I was not able to follow this discussion as I had parallel back to back meetings. At this point I only care about solving the real use case. | |
| 17:31:06 | gibi | If there is an agreement that the current proposal solves the real use case, or even solve a real use case, then I'm OK with it. | |
| 17:35:10 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add a new ImagePropertiesWeigher https://review.opendev.org/c/openstack/nova/+/940642 | |
| 17:35:21 | bauzas | I just uploaded a new rev | |
| 17:35:29 | bauzas | but I'm fried for today | |
| 17:35:48 | bauzas | I'll rather grab a beer and hardstop | |
| 17:36:06 | bauzas | -ETOOMUCHCONTEXTSWITCHING | |
| 17:37:49 | sean-k-mooney | ya im feeling really unproductive today for the same reason | |
| 17:44:11 | gibi | indeed a lot of parallel things these days | |
| 17:49:07 | bauzas | this chan is logged and public, but you guys know and I'm just a sad panda to not have decent time for reviewing | |
| 17:49:18 | bauzas | tomorrow, I'll litterally block my agenda for such thing | |
| 18:06:25 | sean-k-mooney | gibi: bauzas i comemted on the latest version. i think the best path forward would be to have a second patch to copy the metric where imple for matching on indiviual properteis if we really want to supprot that | |
| 18:06:57 | sean-k-mooney | that way we keep the syntax common between the two weigher and if we agree we want both then we can merge both pathces | |
| 18:07:12 | sean-k-mooney | if we think we just want to keep it simple then we merge the first one | |
| 18:43:57 | mikal | What user do tempest tests run as? Because https://zuul.opendev.org/t/openstack/build/a2c28aa2ebc248509f5b586411172955 is getting {'code': 403, 'message': "Policy doesn't allow os_compute_api:os-console-auth-tokens to be performed."} which it shouldn't if its an admin user. | |
| 18:48:54 | dansmith | depends on the test and the client you use | |
| 18:49:28 | dansmith | there's like a self.client and self.admin_client on most test classes, but I think maybe not always if the setup didn't foresee the need | |
| 18:49:35 | dansmith | but that might give you a grep thread to follow | |
| 18:49:51 | sean-k-mooney | if you want to call admin apis you expelcity need to use an admin client in the test ya | |
| 18:50:19 | mikal | Hmmm, ok. I cargo culted the vnc tests, and its using "self.servers_client", whatever that is. | |
| 18:50:43 | sean-k-mooney | you might be ablle to just pass admin=ture to that | |
| 18:51:00 | sean-k-mooney | there are diffent helpers in different parts to do that | |
| 18:51:56 | sean-k-mooney | https://github.com/openstack/tempest/blob/master/tempest/api/compute/base.py#L691C13-L691C33 | |
| 18:52:32 | sean-k-mooney | you can maybe just copy paste cls.admin_servers_client = cls.os_admin.servers_client | |
| 18:53:14 | mikal | Oh, I can just inherit from BaseV2ComputeAdminTest not BaseV2ComputeTest I think. | |
| 18:53:24 | sean-k-mooney | that would proably work too | |
| 18:54:04 | sean-k-mooney | if you do that you might want to move the test to https://github.com/openstack/tempest/tree/master/tempest/api/compute/admin | |
| 18:54:26 | dansmith | just curious though, why is admin required here? | |
| 18:54:46 | sean-k-mooney | the hypervior ip/ports are only shown to the admin | |
| 18:54:59 | mikal | Turning a console token into hypervisor IP and port requires admin. | |
| 18:55:21 | dansmith | oh because no proxy like normal I guess? | |
| 18:55:36 | sean-k-mooney | right so we allow kerbside to get them but not the normal user | |
| 18:55:46 | dansmith | gotcha | |
| 18:56:00 | mikal | Yeah, a normal user can request a console but then has to ask kerbside to connect to it for them. | |
| 18:56:30 | mikal | Oh, which I guess means I need two clients in this test... | |
| 18:56:34 | mikal | Attempt 11! | |
| 18:58:38 | sean-k-mooney | well you could cheat and jsut do everythin as admin but if you wanted to have a negitive test adn show normal user cant see this then ya | |
| 19:01:45 | opendevreview | Alan Bishop proposed openstack/nova master: Show swap_progress in attachment details https://review.opendev.org/c/openstack/nova/+/941476 | |
| 20:10:06 | opendevreview | Mengyang Zhang proposed openstack/nova master: Add Burst Length Support to Cinder QoS https://review.opendev.org/c/openstack/nova/+/939490 | |
| 20:15:41 | opendevreview | Mengyang Zhang proposed openstack/nova master: Add Burst Length Support to Cinder QoS https://review.opendev.org/c/openstack/nova/+/939490 | |
| 20:25:11 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]default_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940194 | |
| 20:25:11 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add [libvirt]supported_tpm_secret_security https://review.opendev.org/c/openstack/nova/+/940195 | |
| 20:25:12 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add hw_tpm_secret_security image property https://review.opendev.org/c/openstack/nova/+/940196 | |
| 20:25:12 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add hw:tpm_secret_security extra spec validation https://review.opendev.org/c/openstack/nova/+/940197 | |
| 20:25:13 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Ensure secret security policy for TPM instances https://review.opendev.org/c/openstack/nova/+/941062 | |
| 20:25:13 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Allow vTPM live migration for `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | |
| 20:25:14 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Modify vTPM LM block to block legacy instances https://review.opendev.org/c/openstack/nova/+/941483 | |
| 21:22:44 | mikal | oh nice, because os-console-auth-tokens previously had zero testing, I also need to define what schema it should have in tempest. | |
| 21:23:10 | mikal | Does anyone have an opinion on if I should just add that schema in the new microversion, or try to work out when it was actually introduced and add it back then? | |
| 21:28:29 | melwitt | gmann: ^ | |
| 21:45:00 | opendevreview | Tobias Urdin proposed openstack/nova master: Add minute to instance_usage_audit_period https://review.opendev.org/c/openstack/nova/+/941488 | |
| 22:34:28 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 22:34:29 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 22:34:29 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| #openstack-nova - 2025-02-13 | |||
| 01:47:07 | mikal | sean-k-mooney / melwitt / gmann / dansmith: to my mild surprise, after a mere 147 test runs the tempest test for spice-direct is now passing on the nova-ovs-hybrid-plug job. I think that means a whole bunch of changes are probably ready for re-review. Specifically: | |
| 01:47:13 | mikal | spice-direct itself: https://review.opendev.org/c/openstack/nova/+/926876, https://review.opendev.org/c/openstack/nova/+/926877, https://review.opendev.org/c/openstack/nova/+/924844 | |
| 01:47:19 | mikal | tempest testing for spice-direct: https://review.opendev.org/c/openstack/tempest/+/940943, https://review.opendev.org/c/openstack/devstack/+/940838, https://review.opendev.org/c/openstack/nova/+/940835, https://review.opendev.org/c/openstack/nova/+/940873 (the last three are from sean-k-mooney) | |
| 01:47:55 | mikal | The other patch series for USB / sound support is blocked at the moment on https://review.opendev.org/c/openstack/os-traits/+/940418 merging, but it lacks a second +2. | |
| 04:19:21 | gmann | mikal: RE on os-console-auth-tokens schema: for easy way, add it in the new microversion for what you are adding the test with min_microversion. I think that should work and worth trying it instead of adding it for old/base microversion | |
| 04:19:32 | gmann | I will check tempest and devstack change tomorrow | |
| 07:01:17 | mikal | gmann: thanks. I added it to my change, we can always shift it back in time later if anyone ever needs it. | |
| 07:59:44 | opendevreview | Vasyl Saienko proposed openstack/nova master: WIP: Add trunk subports to network metadata https://review.opendev.org/c/openstack/nova/+/941227 | |
| 08:34:48 | tkajinam | this cleanup has been sitting here for some time and I wonder if it can be merged https://review.opendev.org/c/openstack/nova/+/879021 | |
| 10:36:22 | zuhal | hi the root volumes of the virtual machines remain in the attaching process, and since the cinder update volume attachment takes a long time, the Nova gives a cinder client gateway timeout error. how can I make a setting for this? | |
| 11:36:05 | sean-k-mooney | mikal: awsome news | |
| 14:16:03 | opendevreview | Merged openstack/nova master: Bump os-traits to 3.3.0 in requirements https://review.opendev.org/c/openstack/nova/+/940975 | |
| 14:32:52 | bauzas | because https://github.com/openstack/tempest/blob/master/tempest/scenario/test_volume_boot_pattern.py#L222 only fails with my weigher patch on those two jobs https://review.opendev.org/c/openstack/nova/+/940642 | |
| 14:33:55 | bauzas | bottom line, when turning the ImageMetaProps object into a primitive dict, we get some fields that are a CoercedList typ | |
| 14:34:13 | bauzas | and given CoercedList o.vo object doesn't have a hash method, then we fail | |
| 14:38:18 | dansmith | bauzas: that's just when using our old toplevel obj_to_primitive right? I assume because that doesn't go deep enough or know about those o.vo things | |
| 15:16:06 | sean-k-mooney | i see | |
| 15:17:14 | sean-k-mooney | class CoercedList(CoercedCollectionMixin, list): | |
| 15:17:33 | sean-k-mooney | so list does not have a hash function then | |
| 15:18:34 | sean-k-mooney | we should not get CoercedList normlaly form ImageMetaProps | |
| 15:19:46 | sean-k-mooney | oh maybe form tags | |
| 15:19:49 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L71 | |
| 15:20:02 | sean-k-mooney | sorry that ImageMeta | |
| 15:20:43 | sean-k-mooney | ok so it might be from hw_numa_cpus https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L410 | |
| 15:21:21 | sean-k-mooney | in general we dont have any list fies but hw_numa_cpus and hw_numa_mem are | |
| 15:22:08 | opendevreview | Merged openstack/placement master: Bump os-traits to 3.3.0 in requirements https://review.opendev.org/c/openstack/placement/+/940976 | |
| 15:22:44 | sean-k-mooney | we can likely just updat the list type here with a simple hash funtion of that take the hash of all element in the list | |
| 15:22:46 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/fields.py#L48-L69 | |
| 15:25:14 | sean-k-mooney | alternitivly instead of storing the key/values in a map or set we can store them as a sting or tuple | |
| 15:27:27 | bauzas | yeah I could avoid the set calculation I think, I need to rethink the design | |