| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-02-10 | |||
| 11:14:41 | sean-k-mooney | https://github.com/openstack/nova/blob/e27bbe72e0d293e55c30d4f90ca0afcf47427419/nova/virt/hardware.py#L2294 | |
| 11:15:13 | sean-k-mooney | yep that exactly what i rememebred and wanted to confrim | |
| 11:15:55 | gibi | anyhow I pushed a fix that considers None the same as SHARED | |
| 11:16:12 | sean-k-mooney | yep i saw | |
| 11:16:15 | gibi | it seems we don't have the bot active posting the incoming patchsets | |
| 11:16:34 | sean-k-mooney | i still got the emails | |
| 11:16:59 | sean-k-mooney | i think there was a gerrit restart at teh weekend maybe the bot need to be restarted? | |
| 11:17:31 | gibi | yeah | |
| 11:17:47 | sean-k-mooney | the last review email was from friday as far as i can tell | |
| 11:17:52 | sean-k-mooney | any idea how to do that? | |
| 11:18:19 | gibi | nope | |
| 11:18:25 | gibi | probably infra knows | |
| 11:18:34 | sean-k-mooney | ok i was going to say letst just ask there | |
| 11:21:42 | sean-k-mooney | if i open a chat to opendevreview it does nto prompt with anythign so i guess its not contolled like that | |
| 13:59:48 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | |
| 14:06:12 | gibi | hey the bot is back \o/ | |
| 14:06:55 | sean-k-mooney | yep fungi restarted it. there was an unplanned gerrit outage over the weekend i think and it just didnt reconnect | |
| 14:08:39 | fungi | yeah, if gerrit vanishes like happened that time (nova spontaneously stopped the vm, still waiting to hear back from the provider on a root cause), the client doesn't notice the server has gone away and continues listening on a tcp connection that will never receive new packets | |
| 14:09:23 | sean-k-mooney | nova only updates it to stopped if it sees it stopped on the libvirt side | |
| 14:09:32 | sean-k-mooney | or if it recived an api request to do so | |
| 14:09:58 | sean-k-mooney | so proably an issue on the underlying host like an OOM kills would be my guess | |
| 14:10:27 | sean-k-mooney | if they cant root cause it tell them to file a nova but and let use know and we can maybe point them in the right direction | |
| 15:10:57 | bauzas | hmmmpffff, I got a similar nova-next and nova-multicell failure for my patch | |
| 15:10:59 | bauzas | https://6944f33f3ef66c20bc22-320386062a8fef96051148fe5e7af6b1.ssl.cf5.rackcdn.com/940642/5/check/nova-next/c60809e/testr_results.html | |
| 15:11:05 | bauzas | https://8ea52cf6ed28836394cc-227b19b7b0e554c64ba32d661a445fcc.ssl.cf1.rackcdn.com/940642/5/check/nova-multi-cell/13c8443/testr_results.html | |
| 15:11:18 | bauzas | looks like our lordy gate is b0rken | |
| 15:43:20 | MengyangZhang[m] | <sean-k-mooney> "Mengyang Zhang: i suspect the..." <- Hi Sean, after giving another thought about this. I don't think we need to add this min version check. Migrating instances between compute hosts with different versions should be fine. | |
| 15:43:20 | MengyangZhang[m] | During the live migration process, pre_live_migration is called on the source host, which calls the Cinder API to re-create volume attachments, updating connection_info and attachment_id on all volume BDMS to reflect the new destination host attachment and returns the information as migrate_data. Then nova performs live migration by calling LibvirtDriver(driver.ComputeDriver)'s live_migration method to execute the live | |
| 15:43:20 | MengyangZhang[m] | migration, utilizing migrate_data to update the current XML. | |
| 15:47:49 | MengyangZhang[m] | * Hi Sean, after giving another thought about this. I don't think we need to add this min version check. Migrating instances between compute hosts with different versions should be fine.... (full message at <https://matrix.org/oftc/media/v1/media/download/ASNbn5eOSN0eZUGb2nl-I79qeQk8MrG28vSQcbe97Ljgln-5krYH4sKDCO_d1rvB2o3m5nhyeSYEkc3QXYITUeZCeVOKSligAG1hdHJpeC5vcmcvd0NYdFZjcU1wQ3d6cXBvbVdUWGdFWURI>) | |
| 15:49:39 | opendevreview | ribaudr proposed openstack/nova master: Add managed flag to PCI device specification https://review.opendev.org/c/openstack/nova/+/937649 | |
| 15:49:40 | opendevreview | ribaudr proposed openstack/nova master: Update driver to deal with managed flag https://review.opendev.org/c/openstack/nova/+/938405 | |
| 15:49:44 | opendevreview | Fabian Wiesel proposed openstack/nova master: WIP: Re-create volume backed root before destroy https://review.opendev.org/c/openstack/nova/+/941095 | |
| 16:03:40 | bauzas | good news are that apparently nova-next runs are not really stopped https://zuul.openstack.org/builds?job_name=nova-next&skip=0 | |
| 16:04:08 | sean-k-mooney | stopped? | |
| 16:04:14 | sean-k-mooney | by what? | |
| 16:04:33 | sean-k-mooney | oh you saw a few failures | |
| 16:04:36 | bauzas | sean-k-mooney: see my above comment ^ | |
| 16:05:00 | sean-k-mooney | MengyangZhang[m]: migration woudl fail in pre-livemigrate | |
| 16:05:42 | sean-k-mooney | actully no it would not | |
| 16:06:22 | sean-k-mooney | MengyangZhang[m]: migrating form an upgraded compute to an non upgraded one will generate the correct config | |
| 16:06:33 | sean-k-mooney | but then if you hard reboot the qos config would be lost | |
| 16:07:01 | sean-k-mooney | so we woudl need to have the migration fail in that case | |
| 16:46:34 | opendevreview | Merged openstack/nova master: api: Allow min/max_version arguments to response https://review.opendev.org/c/openstack/nova/+/936364 | |
| 16:46:40 | opendevreview | Merged openstack/nova master: trivial: Remove legacy API artifact https://review.opendev.org/c/openstack/nova/+/937377 | |
| 18:50:18 | mikal | Was there a zuul outage yesterday or something? CI doesn't seem to have run on https://review.opendev.org/c/openstack/nova/+/924844 after about 10 hours. | |
| 19:23:02 | sean-k-mooney | there was yesterday at some point i think | |
| 19:23:11 | sean-k-mooney | not today that im aware of | |
| 19:27:44 | sean-k-mooney | mikal: it looks like the last buidl for that was https://zuul.openstack.org/buildset/5704a9aeddb44126966dad2b267a6263 | |
| 19:28:03 | sean-k-mooney | so around "2025-02-09 00:09:08" | |
| 19:29:30 | sean-k-mooney | mikal: i see your recheck from 30 mins ago but i dont see anyign in zuul for that | |
| 19:30:20 | sean-k-mooney | i wonder is there a merge confligt with the depends on agaisnt my patch | |
| 19:32:06 | mikal | Yeah, I did that recheck because I couldn't find any evidence that zuul had actually run a check on the latest patchset. | |
| 19:32:55 | mikal | That recheck did cause the vmware test to run at least, but I agree I can't see anything in zuul. | |
| 19:33:04 | sean-k-mooney | let me rebase my patch quickly | |
| 19:33:28 | sean-k-mooney | v4 is not based on teh latest verion of its parent https://review.opendev.org/c/openstack/nova/+/940873/4 | |
| 19:33:43 | mikal | I fixed a typo in one of yours to remove a stray pep8 error in my test results. I wonder if that is the problem?> | |
| 19:33:52 | opendevreview | sean mooney proposed openstack/nova master: Dont deploy n-spice on compute nodes. https://review.opendev.org/c/openstack/nova/+/940873 | |
| 19:34:32 | sean-k-mooney | maybe, when you did that you did not update the follow up patch which is the one your referncing | |
| 19:34:53 | mikal | Yeah, I did it quickly in the web UI and didn't really think it through... | |
| 19:35:32 | sean-k-mooney | ok now its running | |
| 19:35:46 | sean-k-mooney | that was all that was wrong it seams | |
| 19:36:24 | sean-k-mooney | https://zuul.openstack.org/status?change=924844 | |
| 19:36:27 | mikal | Oh nice. Thank you. | |
| 19:36:56 | mikal | gmann left some comments on the tempest patch, so I'll address those today now that I have a test run to observe. | |
| 19:37:18 | sean-k-mooney | ya i clicked into it but didnt look at the code yet | |
| 19:38:13 | sean-k-mooney | i dont think ether of the issues will prevent the test form running but the feedback maskes sense | |
| 19:38:49 | sean-k-mooney | at least with my almost 0 knowladge of tempest convetions if gmann says it shoudl be done a certin way i tend to agree :) | |
| 19:39:16 | mikal | I see your zero knowledge and raise you negative knowledge! | |
| 19:39:24 | mikal | I just cargo culted the previous VNC test. | |
| 19:41:08 | sean-k-mooney | well you actully implemnted part fo the spice handshake it seams | |
| 19:41:25 | sean-k-mooney | so you proably deserve more credit then your giving yourself | |
| 19:42:20 | mikal | Heh. Well yeah, the scaffolding is all cargo culted. The SPICE protocol bit was a cut and paste from the Kerbside code and some tweaks. | |
| 19:42:54 | JayF | good artists borrow; great artists steal :) | |
| 19:43:18 | mikal | Heh | |
| 19:43:34 | mikal | sean-k-mooney: has there been any more discussion of an os-traits release? I think that blocks the other patchset for now. | |
| 19:44:45 | sean-k-mooney | are the traits patches merged | |
| 19:45:17 | gmann | sean-k-mooney: commented in devstack change to enable tempest cofig option also, https://review.opendev.org/c/openstack/devstack/+/940838 | |
| 19:45:55 | sean-k-mooney | https://review.opendev.org/c/openstack/os-traits/+/940418 | |
| 19:46:06 | sean-k-mooney | gmann: did you see my nova job changes? | |
| 19:46:26 | gmann | sean-k-mooney this one? https://review.opendev.org/c/openstack/nova/+/940873 | |
| 19:46:38 | sean-k-mooney | yep | |
| 19:47:02 | gmann | yeah, but that does not set tempest config | |
| 19:47:07 | sean-k-mooney | so that is what enabled the testing in the nova check pipelien | |
| 19:47:23 | sean-k-mooney | right so ill update devstack with the change you susggeted | |
| 19:47:30 | gmann | either you can set tempest option also in job or better is devstack set it based on nova configuration | |
| 19:47:38 | sean-k-mooney | i was orginling thinkign of configuring that in the job as a followup | |
| 19:47:48 | gmann | i see | |
| 19:47:56 | sean-k-mooney | but im fine with devstack | |
| 19:48:12 | gmann | that will be easy if we want to test it in more jobs or so | |
| 19:49:32 | sean-k-mooney | sure so i dont neesisaly want to kick the current run out of the gate on the other hand the job has not started yet its still queue | |
| 19:49:55 | sean-k-mooney | so will i just do it now or do it after the current execution completes so we have one test run? | |
| 19:50:10 | sean-k-mooney | i guess in its current state it wont run the new test | |
| 19:50:20 | sean-k-mooney | so its proably better to update devstack now | |
| 19:50:24 | gmann | yeah | |
| 19:51:02 | gmann | at least to merge the tempest tests (which is almost ready), we need to see test running somewhere. | |
| 19:52:02 | sean-k-mooney | yep, do you have an example of how we set this in devstack normally | |
| 19:52:11 | sean-k-mooney | is it in lib/tempest or lib/nova | |
| 19:52:28 | mikal | sean-k-mooney: no, the os-traits change hasn't seen any more review recently. | |
| 19:52:48 | sean-k-mooney | ah found it | |