| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-02-05 | |||
| 18:58:51 | sean-k-mooney | jsut not the kerbside part wich is probaly ok | |
| 18:59:21 | sean-k-mooney | mikal: shadow.tech can actully work with the nova-spiceproxy too | |
| 18:59:38 | sean-k-mooney | they dont actully need spice-dicret they want teh sound and usb supprot your adding at the end | |
| 19:00:27 | sean-k-mooney | they need the usb ports to do rediectoin so gaming periferals to the vm which works over the nova websocket proxy | |
| 19:00:39 | sean-k-mooney | they have there own custom spice client that can work with that | |
| 19:01:28 | sean-k-mooney | spice-direct is proably faster so they might move to that in the future, they currently deploy one nova-spice proxy per compute node to keep latency down | |
| 19:01:50 | mikal | Huh. | |
| 19:03:28 | mikal | Well, I'll go spelunking in tempest today and see what I can work out. | |
| 19:04:00 | mikal | sean-k-mooney: I'm a bit confused about your comments on the sound model patch. I am not sure if I should read them as saying that https://review.opendev.org/c/openstack/nova/+/940770/1 isn't actually needed any more. | |
| 19:04:04 | sean-k-mooney | anyway i think that off topic. the minium useful tempets test would use the new api microverion to get the connecction info kerbside would use adn then check the banner | |
| 19:04:53 | sean-k-mooney | it looks like i didt push my late set of comemtns one sec | |
| 19:05:15 | sean-k-mooney | ok i ment to push them this morning | |
| 19:05:35 | sean-k-mooney | mikal: that is still needed | |
| 19:05:44 | sean-k-mooney | it shoudl be merged into the previous change | |
| 19:05:53 | sean-k-mooney | but the comptue service bump is needed | |
| 19:07:08 | mikal | Yeah, I split it out so it was easier to see what was happening. I can squash it back into the sound patch. It seems you're largely happy, you just want that hardware.py helper used? | |
| 19:07:58 | sean-k-mooney | yep that was my main ask | |
| 19:08:10 | mikal | Ok, so I'll do that and take a look at tempest today then. | |
| 19:08:13 | sean-k-mooney | reuse the helper btu the rest looks ok | |
| 19:09:04 | sean-k-mooney | its unrelate but you ahve a nice performance improment in that too by only doing the min verison check once | |
| 19:10:10 | mikal | Honestly fixing that and the affected unit tests was by far the slowest bit, but I didn't like how we looked up the version over and over. | |
| 19:10:38 | sean-k-mooney | im debating if that should be its own patch because its a ligit performance bug | |
| 19:12:38 | sean-k-mooney | your new check for the sound modle whoudl be with the patch that intoduced it. the refactor of the single lookup could be its own patch but im not going to ask you to split it now. other might but i think its ok to incoperate in a signel patch | |
| 19:13:37 | mikal | That wouldn't be hard to do, but it would nicer if it was before the sound patch. I could split the series into two series? objects-db-impl for spice-direct, and then performance-sound-usb? | |
| 19:14:12 | mikal | That would also make a cherry pick cleaner for shadow.tech if they were that way inclined. | |
| 19:15:02 | mikal | But honestly right now you were right yesterday -- I am mostly focussed on getting those API changes landed, because rebasing them is a huge pain. | |
| 19:15:48 | sean-k-mooney | ya it woudl be nice ot put the perfomance improment as a sepreate patch before the sound patch | |
| 19:16:00 | sean-k-mooney | its up to you | |
| 19:16:24 | mikal | Ok. Well, I am going to focus on the tempest thing and we'll see how far I get and if I have time to rearrange the later patches today or not. | |
| 19:16:38 | sean-k-mooney | ack | |
| 19:16:48 | mikal | Where are those tempest flags set for a nova gate run? I can't see that in the nova repo. Is there a third repo involved or something? | |
| 19:19:30 | sean-k-mooney | we do not have a job in nova ath uses spice as far as i recall | |
| 19:20:09 | sean-k-mooney | so we need to chose one. add the devstack/tempest flag to use spice and have that depend on the tempest change that adds the new test | |
| 19:21:02 | sean-k-mooney | so one patch to tempest to add the new test, and either update patch 3 (the api patch) or add a dedicated ci patch to the nova series | |
| 19:21:32 | mikal | Oh I hadn't thought of that. So if we turn on SPICE we have to turn off VNC and therefore wouldn't be testing that. | |
| 19:21:33 | sean-k-mooney | i think i would be ok with a testing patch at the end of the serise if melwitt and dansmith are ok with that | |
| 19:21:57 | sean-k-mooney | mikal: ya but we have several jobs | |
| 19:22:33 | sean-k-mooney | so we can change it in one of the many jobs teh nova-ovs-hybrid-plug job | |
| 19:22:51 | dansmith | yeah a test at the end is good to me.. even if we can't land it with the rest, being able to see it working (or almost working or whatever) is data for review | |
| 19:23:33 | sean-k-mooney | mikal: i would modify this https://github.com/openstack/nova/blob/master/.zuul.yaml#L144 | |
| 19:23:46 | melwitt | mikal: tempest config are set in https://github.com/openstack/nova/blob/d267ede98f1b0aa25630b1efe07db5a8b478d473/.zuul.yaml#L136 for example | |
| 19:23:55 | mikal | Ok, so the moving parts are: add a test to tempest; add plumbing in devstack to enable that test; fiddle with nova gate jobs to use a devstack with the spice test turned on? | |
| 19:23:55 | sean-k-mooney | we use it to mainly test with ml2/ovs but its a good candiate for non standard configs | |
| 19:24:40 | sean-k-mooney | ya i might be able to help by putting up a poc patch of just enabling spice in that job | |
| 19:25:08 | sean-k-mooney | you coudl modify it and make it depend on your tempest patch when that is ready | |
| 19:25:10 | mikal | Ok, well I'll take a swing at this today but its sounding like more than I'll get done in a single day to be honest. | |
| 19:29:33 | opendevreview | Merged openstack/nova master: [Trivial] Fix the typo error https://review.opendev.org/c/openstack/nova/+/937744 | |
| 19:50:32 | opendevreview | sean mooney proposed openstack/nova master: Disable the heal instance info cache periodic task https://review.opendev.org/c/openstack/nova/+/939476 | |
| 19:51:08 | sean-k-mooney | bauzas: i did a spell check pass on ^ otherwise it the same as the last version | |
| 20:25:51 | opendevreview | Merged openstack/nova master: Cleanup RBAC jobs in check/gate pipeline https://review.opendev.org/c/openstack/nova/+/940737 | |
| 20:36:43 | opendevreview | sean mooney proposed openstack/nova master: [WIP] move nova0ovs-hybrid-plug to deploy with spice https://review.opendev.org/c/openstack/nova/+/940835 | |
| 20:45:19 | opendevreview | Doug Goldstein proposed openstack/nova stable/2024.2: ironic: Fix ConflictException when deleting server https://review.opendev.org/c/openstack/nova/+/940836 | |
| 21:02:02 | sean-k-mooney | mikal: https://review.opendev.org/c/openstack/nova/+/940835 might work but i expect it to fail, if it does i think https://review.opendev.org/c/openstack/devstack/+/940838 might fix it. im going to finish for today but if you want to rebase those patches, addign a depend on and setting NOVA_SPICE_ENABLED later feel free. | |
| 21:03:25 | sean-k-mooney | doing a quick search with hound i dont think we have any job anywhere that enables spice so i dont know if there is anything else broken | |
| 21:04:11 | sean-k-mooney | s/any job/any devstack job/ | |
| 22:10:31 | mikal | sean-k-mooney: thanks, I'll take a look soon. | |
| #openstack-nova - 2025-02-06 | |||
| 04:49:04 | chungwon | Hello, can you review this? | |
| 04:49:57 | chungwon | review.opendev.org/c/openstack/nova/+/939929 | |
| 05:21:32 | opendevreview | suiong ng proposed openstack/nova stable/2024.1: ironic: Fix ConflictException when deleting server https://review.opendev.org/c/openstack/nova/+/940846 | |
| 06:42:46 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | |
| 06:42:47 | opendevreview | Michael Still proposed openstack/nova master: Protect older compute managers from sound model requests. https://review.opendev.org/c/openstack/nova/+/940770 | |
| 06:42:47 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354 | |
| 06:42:48 | opendevreview | Michael Still proposed openstack/nova master: Don't calculate the minimum compute version repeatedly. https://review.opendev.org/c/openstack/nova/+/940848 | |
| 06:46:08 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 06:46:09 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 06:46:09 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 06:59:09 | mikal | I have updated the tracking etherpad at https://etherpad.opendev.org/p/nova-2025.1-status with a brain dump of the current state of the various SPICE VDI patches. | |
| 08:25:37 | opendevreview | benlei proposed openstack/nova master: Abort live migration task when stop nova compute service https://review.opendev.org/c/openstack/nova/+/938223 | |
| 08:50:56 | artem_vasilyev | Hey, could you review a small linter and test fixes for macOS support, please https://review.opendev.org/c/openstack/nova/+/937727 | |
| 10:20:15 | bauzas | dansmith: Uggla: thanks for the reviews on https://review.opendev.org/c/openstack/nova/+/940642 | |
| 10:27:26 | Uggla | bauzas, you are welcome. | |
| 10:48:26 | sean-k-mooney | bauzas: i just left my comment too i dont partically like the approch you took | |
| 10:48:43 | sean-k-mooney | it seems complex for what your trying to do | |
| 10:57:21 | bauzas | sean-k-mooney: thanks, I'll look over them after lunch | |
| 10:58:07 | bauzas | sean-k-mooney: your idea of getting all the props by a object property is actually a good one | |
| 10:59:43 | sean-k-mooney | i ocationally have them | |
| 11:00:21 | bauzas | for your algorithm with union/intersection, let's discuss this later, as I need to explain correctly why it wasn't working when I tested them | |
| 11:00:28 | sean-k-mooney | i check ovo and it does not have a funciton for that but they do it often internally. i woudl consider adding set_filed ot novas base object class | |
| 11:01:14 | sean-k-mooney | sure. form my perspecive the cardinatly shoudl not matter | |
| 11:01:47 | sean-k-mooney | i.e. if 2 isntance request the image property on one host adn one instnace request it on anohter shoudl not affect the weight | |
| 11:02:00 | sean-k-mooney | i think you are trying to also include that by using counter right? | |
| 11:02:58 | sean-k-mooney | we can chat later but i was intentionly trying not to have the number of vms on a host affect teh weighing of the host | |
| 11:03:21 | bauzas | I tested it, and the problem is that for example, if you have a host that has already 2 instances and one other that only has 1 using the prop, then it would prefer the second | |
| 11:04:08 | bauzas | so I preferred to just return the number of how many asked properties that are alrady used in the host | |
| 11:04:20 | bauzas | this is simplier to calculate and understand | |
| 11:04:45 | sean-k-mooney | i think that is more complex | |
| 11:04:54 | bauzas | also, I saw with devstack that when you create an instance, you get more props that the one you asked | |
| 11:04:56 | sean-k-mooney | and harder ot understand | |
| 11:05:14 | sean-k-mooney | you do yes we set some like the machine type on boot | |
| 11:05:19 | sean-k-mooney | or config drive | |
| 11:05:36 | bauzas | indeed, but you haven't asked for it, that's my point | |
| 11:05:39 | sean-k-mooney | based on the host config. we will be adding the vtpm secrete type | |
| 11:05:53 | sean-k-mooney | you have not but we shoudl not exclude them | |
| 11:06:15 | bauzas | anyway, I need to go off | |
| 11:06:19 | sean-k-mooney | ack | |
| 12:20:41 | opendevreview | sean mooney proposed openstack/nova master: [WIP] move nova-ovs-hybrid-plug to deploy with spice and fix qxl default https://review.opendev.org/c/openstack/nova/+/940835 | |
| 12:20:41 | opendevreview | sean mooney proposed openstack/nova master: Dont deploy n-spice on compute nodes. https://review.opendev.org/c/openstack/nova/+/940873 | |
| 13:15:49 | opendevreview | suiong ng proposed openstack/nova master: Fix parameter order in add_instance_info_to_node https://review.opendev.org/c/openstack/nova/+/939411 | |
| 13:53:54 | opendevreview | sean mooney proposed openstack/nova master: allow discover host to be enabled in multiple schedulers https://review.opendev.org/c/openstack/nova/+/938523 | |
| 13:54:31 | sean-k-mooney | gibi: i just dropped the job change form ^ | |