| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-02-04 | |||
| 19:38:47 | sean-k-mooney | the server create check prevcent new isntnace usign the fature until everything is upgraded and resize/rebuild checks prevent exisitng instnce form using it until the cloud is fully upgraded | |
| 19:39:03 | mikal | Yeah, if you don't specify a sound model then you don't get one in the domain XML according to _add_sound_device() | |
| 19:39:19 | mikal | Ok. | |
| 19:39:24 | sean-k-mooney | ack thats what i was expecting | |
| 19:39:52 | mikal | Yeah, I'm just old and forgetful. This code is probably over six months old now and I forget some of the finer details sometimes. | |
| 19:40:50 | sean-k-mooney | i dont expect perferct recall, i reviewd it 5 days ago and while i tought that what it did i still had to check | |
| 19:41:26 | sean-k-mooney | its sometimes hard to seperate on irc, what does it actully do, vs what woudl i do, without actully looking at the patch | |
| 19:42:36 | mikal | So yeah, I think I have a plan for today at least then. I'll do the sound compute service bumps and checks and hopefully have something for you to take a look at while I'm asleep. | |
| 19:42:51 | mikal | Thanks again for your help. | |
| 19:42:57 | sean-k-mooney | so other then the version check there is only one other thing that is possibel missing | |
| 19:42:59 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/926126/12/nova/virt/libvirt/driver.py | |
| 19:43:24 | sean-k-mooney | you are not checkign if libvirt suprpot the requested sound device modle for virtio | |
| 19:43:52 | sean-k-mooney | oh | |
| 19:44:00 | sean-k-mooney | never mind that version 12 of 26 | |
| 19:44:30 | sean-k-mooney | ok in the latest veriosn that is still missing | |
| 19:44:34 | mikal | No I think you're still right. I don't think the domain XML generation checks if the hypervisor has virtio sound. | |
| 19:44:50 | mikal | Yeah, I had assumed the trait would protect against incoming requests that couldn't be supported. | |
| 19:45:17 | sean-k-mooney | so the trait can but you missing a addtional change to enforce it | |
| 19:45:45 | sean-k-mooney | oh maybe not | |
| 19:46:00 | mikal | Ok, I can add one there as well. I presume I just raise an exception if I can't support virtio sound there? | |
| 19:46:02 | sean-k-mooney | well you added https://review.opendev.org/c/openstack/nova/+/926126/26/nova/scheduler/request_filter.py | |
| 19:46:29 | sean-k-mooney | mikal: ya i think i suggested one in a previous revision | |
| 19:48:44 | sean-k-mooney | mikal: so looking at https://review.opendev.org/c/openstack/nova/+/926126/26/nova/scheduler/request_filter.py | |
| 19:49:14 | sean-k-mooney | they way you chose to add an uncontintiol prefilter means we coudl skip the min version check | |
| 19:49:30 | sean-k-mooney | as that trait will only be present if the host is upgraded | |
| 19:49:45 | sean-k-mooney | actully not that only covers the virtio cases | |
| 19:49:53 | sean-k-mooney | so we need both | |
| 19:50:16 | sean-k-mooney | it does mean you dont need the check in the xml generation as currently written | |
| 19:50:23 | mikal | All the other sound models have been supported for ages though, so apart from virtio do any of them actually need a check? | |
| 19:50:27 | sean-k-mooney | as you will never get schduled to a host that does not suport virtio | |
| 19:50:51 | sean-k-mooney | no only virtio need to be checked | |
| 19:51:13 | mikal | So doesn't that unconditional prefilter mean I don't need a service bump at all then? | |
| 19:51:14 | sean-k-mooney | we still need the min versin check to protect non upgraded hosts | |
| 19:51:40 | sean-k-mooney | no we need to make sure if you request a diffent model that you land on an upgrade host | |
| 19:51:47 | sean-k-mooney | its almost enouch but not quite | |
| 19:51:59 | mikal | Ok | |
| 19:52:23 | sean-k-mooney | for usb we dont need a prefilter like this since all host that have the correct compute service verion will supprot it | |
| 19:53:18 | sean-k-mooney | mikal: so ya only the comptue service check is missing form the sound change you do not need the xml generation check | |
| 19:53:19 | mikal | So I'm a little confused about why we need USB controller traits at all then? | |
| 19:53:32 | sean-k-mooney | the usb ones are not needed | |
| 19:53:39 | sean-k-mooney | only the virtio one for sound is really required | |
| 19:53:54 | mikal | Yeah, because the others are basically hard coded to true. | |
| 19:53:59 | sean-k-mooney | yep | |
| 19:54:08 | mikal | I guess maybe it matters if another hypervisor wanted to use these extra specs... | |
| 19:54:42 | mikal | That is, I don't think I should remove them from the os-traits patch. | |
| 19:54:43 | sean-k-mooney | technially yes | |
| 19:55:01 | sean-k-mooney | the are ok to keep IMO | |
| 19:55:35 | mikal | I should let you escape. I'll take a swing at the version checks today. | |
| 19:56:01 | sean-k-mooney | ack. i may or may not be back briefly later but if not ill try and review again tomorrow | |
| 19:56:10 | sean-k-mooney | mikal: did you see the nova meeting conversation | |
| 19:56:29 | mikal | About the order of landing the API changes? Yes, that made me happy to be completely honest. | |
| 19:57:03 | sean-k-mooney | cool, ya so hopefully we can get at least the first 3 patches and perhaps all 5 merged this week if others have time to review | |
| 19:57:26 | mikal | I appreciate you handholding me along the way. Thank you. | |
| 19:57:47 | mikal | I think that gaming company probably still want the USB one at least, so it would be nice to get all of them in, but I understand we're starting to run out of time. | |
| 19:58:29 | sean-k-mooney | we still ahve 3 weeks so it think its doabel if we get the first 3 this week | |
| 19:58:46 | mikal | This makes me happy. | |
| 19:58:57 | mikal | Well, I'll let you get on with your life. | |
| 19:58:59 | sean-k-mooney | i think there name was shadow https://shadow.tech/ i think | |
| 19:59:55 | mikal | Yeah, that's them. | |
| 20:00:21 | mikal | Maxime Lubin was commenting on the USB patch at one point, but I haven't seen anything recently. | |
| 20:31:26 | frickler | sean-k-mooney: gibi: fyi we (infra-root) noticed some weird activity by that account earlier and we disabled it yesterday | |
| 20:32:02 | sean-k-mooney | frickler: ack, i was not sure it was the same account but i did see those strange comments | |
| #openstack-nova - 2025-02-05 | |||
| 08:22:37 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | |
| 09:15:20 | mikal | melwitt: I only just saw your comments on https://review.opendev.org/c/openstack/nova/+/924844 -- I'll work through them tomorrow. | |
| 09:51:46 | andrewbonney | Morning. If anyone has time I'd appreciate a review of the bug fix in https://review.opendev.org/c/openstack/nova/+/919961 | |
| 10:03:01 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | |
| 10:03:01 | opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | |
| 10:03:02 | opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | |
| 10:03:02 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | |
| 10:03:03 | opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354 | |
| 10:03:03 | opendevreview | Michael Still proposed openstack/nova master: Protect older compute managers from sound model requests. https://review.opendev.org/c/openstack/nova/+/940770 | |
| 10:03:34 | mikal | sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/940770 is a first attempt at the compute service version bump thing as discussed this morning. | |
| 14:20:24 | opendevreview | Balazs Gibizer proposed openstack/nova master: Bump InstanceNUMACell version after data migration https://review.opendev.org/c/openstack/nova/+/940604 | |
| 14:25:31 | gibi | sean-k-mooney: dansmith: add the extra tests cases and extended the logic to handle the half migrated cases ^^ | |
| 14:35:52 | MengyangZhang[m] | <sean-k-mooney> "Mengyang Zhang: i suspect the..." <- Since Libvirt introduced these burst parameters in 2.4.0, which was released in 2016, do we still have to worry about this? Nova needs to support n-2 versions, but all versions should already support this burst feature. | |
| 14:39:41 | dansmith | gibi: personally I'd prefer that as two patches, even though I know it's more backport work, but I'll defer to the others | |
| 14:42:01 | gibi | OK I can split it | |
| 14:48:04 | dansmith | gibi: wait for the others to opine, I'm just saying that's _my_ opinion | |
| 14:48:21 | sean-k-mooney | MengyangZhang[m]: its not about the libvirt verion. its about the nova compute version deployed on each host | |
| 14:49:00 | sean-k-mooney | MengyangZhang[m]:in 2025.1 we need to supprot a mix of comptue with (2024.1, 2024.2 and 2025.1) because its a skip level upgrade release | |
| 14:49:24 | sean-k-mooney | in 2025.2 we only need to suprot a mix of 2025.1 and 2025.2 nova computes | |
| 14:49:39 | sean-k-mooney | we need to make sure cold/live migration works acorss those mixed versions | |
| 14:50:36 | sean-k-mooney | so we need a min compute service version check to prevent using the feature until the cloud is fully upgraded or explcit schduler supprot to make sure the isntance only get deploy to the upgraded nodes | |
| 14:57:15 | MengyangZhang[m] | understood, make sense | |
| 14:58:05 | gibi | dansmith: understood | |
| 14:59:16 | sean-k-mooney | the min compute service check is simpler todo, in either case cinder need to be prepared for nova to reject the attachment of a volume with brust qos if the compute node is too old. i belive that is already the case however so that does not really change the existing workflow | |
| 16:58:46 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add a new ImagePropertiesWeigher https://review.opendev.org/c/openstack/nova/+/940642 | |
| 17:07:45 | gmann | bauzas: this is ready, rbac job cleanup we talked yesterday https://review.opendev.org/c/openstack/nova/+/940737 | |
| 17:08:58 | gibi | there is an easy review (just adding more spice to the nova-next job) https://review.opendev.org/c/openstack/nova/+/937275 | |
| 17:11:30 | bauzas | gibi: gmann: reviewing your meats | |
| 17:15:12 | gibi | thanks folks | |
| 17:44:41 | gmann | gibi: if you are around, please chekc this https://review.opendev.org/c/openstack/nova/+/940737 | |
| 17:45:32 | gmann | gibi: bauzas and very trivial typo one https://review.opendev.org/c/openstack/nova/+/937744 | |
| 17:48:16 | gibi | done and done :) | |
| 17:50:39 | gmann | thanks guys | |
| 18:34:15 | mikal | Morning. | |
| 18:48:17 | mikal | sean-k-mooney: I'm taking a look at tempest just now based on melwitt's comments on https://review.opendev.org/c/openstack/nova/+/924844/21. Is it just me or are there now SPICE tempest tests at all? https://github.com/openstack/tempest/blob/master/tempest/config.py#L541 | |
| 18:48:28 | mikal | s/now/no/ | |
| 18:49:45 | melwitt | mikal: there are not and when I looked it looked like they were removed in the past https://github.com/openstack/tempest/commit/d5bda712599a329acb865f9a9a41ad55824b1781 I don't know if it | |
| 18:50:24 | mikal | Hmmm, I wonder why the test cases were removed. | |