Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2025-01-30
20:44:24 sean-k-mooney mikal: so to be clear the traits are optional, certently nice to have but can be done next cycle
20:44:58 sean-k-mooney the compute service bump adn min version check are needed so that we ensure we never boot on a host hat does not supprot it
20:45:38 sean-k-mooney without that you can request a usb devices and because old nova does not no about it it will boot without them
20:47:04 sean-k-mooney mikal: that is protected agaist by a compute service bump for each fo the usb and audio emulation patches and a min version check for server create and rebuild.
20:47:23 melwitt to be clear, I'm not opposed to the traits ... I was just trying to understand what I'm reviewing
20:47:59 sean-k-mooney ack, no worries
20:48:34 mikal Sorry, got distracted and missed this...
20:49:01 sean-k-mooney melwitt: my understanding is the first 3 patches up to here https://review.opendev.org/c/openstack/nova/+/924844/26 is the mvp for spice direct
20:49:17 mikal So, I think my take is that if the traits thing isn't too hard to do we should just do it.
20:49:39 mikal However you're right, I will be disappointed if I have to do this game for a third time next release so I don't want to put that at risk if I can avoid it.
20:49:54 sean-k-mooney melwitt: the folowing 2 patches enable the usecase request in https://review.opendev.org/c/openstack/nova-specs/+/920687 and make the spice direct feature more useful in general
20:50:20 mikal I guess my problem is that having never done a trait before I don't really know how far https://review.opendev.org/c/openstack/nova/+/926126/12 is from being a working implementation.
20:51:12 sean-k-mooney mikal: reviesion 23 is much close then 12 :)
20:51:28 mikal Honestly for VDI to be a thing people will actually want to use you do need sound and USB.
20:51:55 sean-k-mooney mikal: so https://review.opendev.org/c/openstack/nova/+/926126/23/nova/virt/libvirt/driver.py should work as is
20:52:13 mikal Think desktop replacement with a thin terminal on someone's desk -- they'd want sound for notifications etc and USB for smartcard / yubikey / local printer or scanner / etc.
20:53:23 sean-k-mooney mikal: instead of hardcodign them we normally get cleaver and constcut them form the ovo filed defnitions
20:53:42 sean-k-mooney or use the os-traits constants but the hardcode string will work
20:54:25 mikal So I really wanted to do it like the video models, that is obtain it from getDomainCapabilities(), but that doesn't report the sound models.
20:54:53 sean-k-mooney ya we got them to add the video models
20:55:12 sean-k-mooney among other things a while back to avoid matching on version
20:55:19 sean-k-mooney but we did version matches before that
20:55:29 melwitt ok, so IIUC the traits aren't required until the latter two patches. and os-traits release freeze is what, Feb 21
20:55:40 mikal We could do that here, but I would assume that landing something in libvirt, waiting for it to be covered by our minimum version, and then rewriting that code would likely take literally years.
20:55:58 sean-k-mooney melwitt: ya only the last too
20:56:12 sean-k-mooney and ya its the non clinet lib feeze so about the 21st
20:56:48 mikal That's another thing... There are a few client patches for this stuff as well, but those are sitting queued up waiting for the nova support to land first. I was intending to propose those next release at this rate.
20:56:59 sean-k-mooney mikal: ya so next time we wrap around the alpahpbet we can revisit it but what you ahve now is fine :
20:57:01 sean-k-mooney :)
20:57:35 sean-k-mooney the client patches are only for the new console type right
20:57:38 mikal We are getting dangerously close to me having coworkers who are younger than openstack as it is... I am not sure I'll be around in another alphabet.
20:57:46 mikal sean-k-mooney: yeah.
20:57:58 mikal Its been a while since I looked at them, let me double check that.
20:58:14 sean-k-mooney so honetly i would push the two patches for the sdk and osc and just add a depend on on the third patch that adds the api supprot
20:59:16 mikal Yeah, I am carrying client patches for openstacksdk, python-novaclient, and python-openstackclient.
20:59:36 sean-k-mooney i think you jst need to extend https://github.com/openstack/openstacksdk/blob/master/openstack/compute/v2/server_remote_console.py#L16-L23
20:59:58 sean-k-mooney but ya if you have workign patches i would post them for review
21:00:25 mikal https://github.com/shakenfist/kerbside-patches/blob/develop/openstacksdk/patch006-openstacksdk-expose-spice-direct-consoles.patch is what I have right now for openstacksdk.
21:01:02 mikal The microversion in that is wrong, I should update that.
21:01:30 mikal Do we still add new things to python-novaclient, or is that one a red herring?
21:01:45 sean-k-mooney you do not need to modify python-novaclient
21:02:03 sean-k-mooney we froze the shell and python biding
21:02:14 mikal Ahhh, ok. Cool.
21:02:17 sean-k-mooney so jsut osc
21:02:44 mikal So that would be openstacksdk and python-openstackclient.
21:03:00 sean-k-mooney mikal: we have to supprot python-novaclient until heat/neutron ectra swap to the sdk
21:03:05 sean-k-mooney yep just those
21:03:25 mikal I will double check those and upload them today, with a depends-on for the third patch.
21:03:43 mikal Similarly I have Kolla / Kolla-Ansible deployment patches, but again I am assuming those need to wait until Flamingo to be proposed.
21:04:01 mikal (And I suspect the K/A one needs some HA love, I developed it on an all-in-one so its a bit under baked there).
21:05:08 sean-k-mooney no you can do it in paralle
21:05:16 sean-k-mooney they jsut wont merge it until it lands in nova
21:05:40 mikal They trail by one release don't they?
21:05:43 mikal Honestly, I haven'
21:05:55 mikal t had much luck in getting the Kolla people to answer messages.
21:06:00 sean-k-mooney no
21:06:15 sean-k-mooney they are release trailing but not by one cycle master there is actuall master for epoxy
21:06:26 mikal Le huh.
21:06:35 sean-k-mooney they normlaly release a few weeks after the offical upstream release
21:06:38 mikal Well, I will take a swing at that, but I am going to deal with nova and client patches first.
21:10:53 sean-k-mooney mikal: fyi you have some line length issues in one of the patches
21:11:07 mikal Client patches you mean?
21:11:15 sean-k-mooney the sound device one
21:11:26 sean-k-mooney the pep8 line limiet is actully 79 not 80
21:12:07 sean-k-mooney https://review.opendev.org/c/openstack/nova/+/926126/23/nova/virt/libvirt/driver.py#13354
21:12:12 mikal Oh right. I can fix that. I have tests that run on the patch stack locally, but because there are so many queued up nova patches right now it takes a couple of hours to run and I haven't looked at the output yet today. I'll deal with that today.
21:12:53 sean-k-mooney no rush. i think we(reviews) shoudl focus on the first 3 patches
21:13:34 sean-k-mooney it woudl be ideally to merge all of them buti think the first 3 are pretty close
21:13:43 mikal That would be great. Rebasing the microversion and object version changes is getting a bit old at this point, so landing those first three is actually a pretty big quality of life improvement for me.
21:14:08 sean-k-mooney ya we have 3 patches compiting for the same ones
21:14:20 sean-k-mooney i was hoping your would get 2.98
21:14:28 mikal (Joking!) The others should respect their elders!
21:14:37 sean-k-mooney but we have the image propeties show and scheudler hits ones too
21:17:12 sean-k-mooney ok im going to call it there o/
21:18:03 mikal Have a good long weekend. Thanks again for your help.
21:24:51 opendevreview Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876
21:24:52 opendevreview Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877
21:24:52 opendevreview Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844
21:24:53 opendevreview Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126
21:24:53 opendevreview Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354
#openstack-nova - 2025-01-31
00:44:01 opendevreview Merged openstack/nova master: api: Allow min/max_version arguments to expected_errors https://review.opendev.org/c/openstack/nova/+/936363
03:03:39 mikal Does adding traits to a hypervisor imply incrementing the compute node object version, and if so is that as simple as a bump in nova.objects.compute_node with the associated plumbing?
04:45:41 opendevreview Junya Noguchi proposed openstack/placement master: Changed OS version CentOS to CentOS Stream. https://review.opendev.org/c/openstack/placement/+/940492
08:29:36 opendevreview Masahito Muroi proposed openstack/nova master: Use defaultdict object for request_specs_dict in the _list_view https://review.opendev.org/c/openstack/nova/+/939658
10:21:55 opendevreview Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server diagnostics API https://review.opendev.org/c/openstack/nova/+/940506
10:31:33 opendevreview Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server external events API https://review.opendev.org/c/openstack/nova/+/940508
11:06:59 ganso bauzas: hi! do you have any insight about the vgpu issue discussed yesterday? about nvidia not supporting mdev anymore
13:13:34 opendevreview Salah Hazaa proposed openstack/nova master: [CI][nova-next]test with placement ac breadth-first https://review.opendev.org/c/openstack/nova/+/937275
15:53:32 ratailor_ stephenfin, Hi
15:54:17 ratailor_ stephenfin, could you please help with schema response https://review.opendev.org/c/openstack/nova/+/939649/6/nova/api/openstack/compute/schemas/servers.py here
21:27:47 opendevreview Douglas Viroel proposed openstack/nova master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/nova/+/938604
#openstack-nova - 2025-02-02
09:06:54 opendevreview Salah Hazaa proposed openstack/nova master: [CI][nova-next]test with placement ac breadth-first https://review.opendev.org/c/openstack/nova/+/937275
09:07:33 opendevreview Salah Hazaa proposed openstack/nova master: [CI][nova-next]test with placement ac breadth-first https://review.opendev.org/c/openstack/nova/+/937275
#openstack-nova - 2025-02-03
10:19:31 opendevreview Balazs Gibizer proposed openstack/nova master: Reproduce bug XXX https://review.opendev.org/c/openstack/nova/+/940603
10:19:31 opendevreview Balazs Gibizer proposed openstack/nova master: Bump InstanceNUMACell version after data migration https://review.opendev.org/c/openstack/nova/+/940604
12:00:13 opendevreview Takashi Kajinami proposed openstack/python-novaclient master: Replace oslo_utils.encodeutils.exception_to_unicode https://review.opendev.org/c/openstack/python-novaclient/+/940617
12:04:58 opendevreview Takashi Kajinami proposed openstack/nova master: Replace oslo_utils.encodeutils.exception_to_unicode https://review.opendev.org/c/openstack/nova/+/940619
14:29:33 bauzas sean-k-mooney: I'm just about to upload my weigher but I think I found something I'd like to discuss with you if you have a min
14:30:28 bauzas sean-k-mooney: if we use sets for checking between requested props and existing props, then when looking at the common props by using intersection, we wouldn't know how many instances would have the same props
14:31:22 bauzas so, that would mean that for example if we have two hosts where one has one instance using the prop and another host having two instances with the same prop, then the weigh for both would be the same

Earlier   Later