| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2025-01-21 | |||
| 20:14:42 | sean-k-mooney | of like 10 | |
| 20:14:54 | sean-k-mooney | but it would proably be better to do that in the driver then the object | |
| 20:15:18 | mikal | I can do some reading on the capabilities of the various USB controllers in libvirt today. | |
| 20:16:02 | sean-k-mooney | this is perhaps somethin that could be a followup patch on top by the way | |
| 20:17:18 | mikal | Yeah, that would be my preference. Happy to work on it, don't really want to block on it though. | |
| 20:17:38 | mikal | Anyways, I'll take a look today / tonight and should let you go. I have to go learn how shoes work before I miss my bus. | |
| 20:18:30 | sean-k-mooney | https://libvirt.org/formatdomain.html#controllers the libvirt docs just say " USB controllers accept a ports attribute to configure how many devices can be connected to the controller." | |
| 20:18:43 | sean-k-mooney | but they dont document the limtis so i feel like this will be a qemu limit | |
| 20:18:50 | mikal | Herm. That sounds like "read the qemu code" territory... | |
| 20:19:31 | sean-k-mooney | i think the usb sepc allwos somehting like 256 device but i highly doubt qemu supprots that | |
| 20:19:49 | sean-k-mooney | ok ill chat to you tomorrow o/ | |
| 20:20:06 | mikal | Thanks Sean, sorry if I made you late for anything. I appreciate the chat. | |
| 20:21:34 | sean-k-mooney | https://qemu-project.gitlab.io/qemu/system/devices/usb.html#physical-port-addressing | |
| 20:21:54 | sean-k-mooney | UHCI has two root ports (1,2). EHCI has six root ports (1-6), and the emulated (1.1) USB hub has eight ports. | |
| 20:22:14 | sean-k-mooney | so 8 unless you use hubs so ya i would limit to 8 for now | |
| 20:22:55 | mikal | Yeah, I'm going to be honest and say I don't immediately know the difference between a "root port" and whatever other types of ports there are. | |
| 20:23:30 | sean-k-mooney | usb can have a tree for device below the root port up to 8 level deep i belive | |
| 20:23:55 | sean-k-mooney | linius tech tips did a video tyring to reach the limit pluging usb hubs into usb hubs a few months ago | |
| 20:24:31 | sean-k-mooney | https://www.youtube.com/watch?v=hiwaxlttWow | |
| 20:25:12 | mikal | Heh. Actionable advice right here. | |
| 20:25:17 | mikal | s/here/there/ | |
| #openstack-nova - 2025-01-22 | |||
| 01:32:54 | hemanth | Hi nova team, appreciate for discussing compute memory monitor during weekly meeting (could not attend due to TZ diff) and thanks sean for detail explanation on the PR! | |
| 08:25:21 | opendevreview | zhou zhong proposed openstack/nova master: Add auto_converge parameters for invoking the migration https://review.opendev.org/c/openstack/nova/+/935614 | |
| 08:34:29 | mikal | sean-k-mooney: I did some reading today, and I am left with the distinct impression that we should only add XHCI USB controllers for now. This makes it simpler to predict how many ports are available, but the performance of the older controllers is also not great. So much like we don't support floppies, we should probably not support USB controllers from the 1990s. | |
| 08:35:12 | mikal | sean-k-mooney: that said, I think we should probably support both qemu-xhci and nec-xhci, because I suspect (without testing) that Windows wont know about the qemu version without additional drivers. | |
| 08:35:53 | mikal | sean-k-mooney: it would be trivial to add other controllers back if someone could make a case for them later, but we should probably remove them before the USB redir extra spec lands. | |
| 11:48:58 | sean-k-mooney | ya so the diffent types of port in the list i proved were basicly usb 1 2 and 3 | |
| 11:49:07 | sean-k-mooney | xhci being usb 3 | |
| 11:49:33 | sean-k-mooney | i think that makes sense as a baseline | |
| 15:44:42 | opendevreview | Dan Smith proposed openstack/nova master: DNM: Test with latest oslo.utils https://review.opendev.org/c/openstack/nova/+/933444 | |
| 15:44:42 | opendevreview | Dan Smith proposed openstack/nova master: WIP Inspect snapshot images and adjust disk_format https://review.opendev.org/c/openstack/nova/+/939815 | |
| 16:08:07 | opendevreview | Balazs Gibizer proposed openstack/nova master: [CI][nova-next]test with placement ac breadth-first https://review.opendev.org/c/openstack/nova/+/937275 | |
| 16:49:09 | opendevreview | James Page proposed openstack/nova master: Restore nova.virt.__init__ https://review.opendev.org/c/openstack/nova/+/939827 | |
| 18:27:15 | mikal | sean-k-mooney: so, mostly. If I am reading this stuff right, OHCI / UHCI are USB 1.1. If you want USB 2.0 you need both EHCI _and_ one of OHCI / UCHI as a "companion controller". None of these controllers are particularly virt (or 64 bit!) friendly. XHCI supports USB 1.1 / 2 / 3 without a companion controller, while also being 64 bit and virt friendly. | |
| 18:28:21 | mikal | sean-k-mooney: XHCI 1.0 was released in 2010, so I would hope that basically anything people would want to run would support it. | |
| 18:30:39 | opendevreview | Merged openstack/nova master: Run nova-next without periodic cache healing https://review.opendev.org/c/openstack/nova/+/939453 | |
| 18:33:10 | sean-k-mooney | mikal: yep it should | |
| 18:33:22 | sean-k-mooney | its a good baseline if nothing else | |
| 18:36:50 | mikal | Honestly, adding the others back would be relatively trivial (less than ten lines of code), so if you think that's reasonable I'll tweak that PR to just do XHCI and we can limit the number of redirected channels to the number of root ports on a XHCI controller. | |
| 18:37:30 | mikal | I would like to test to see if qemu-xhci works for me because for reasons I no longer remember I used nec-xhci in my testing last time. | |
| 18:38:32 | sean-k-mooney | ack sounds like a plan | |
| 18:40:29 | mikal | Cool. I personally don't think any of that should hold up reviews of the earlier patches, I see this as a relatively minor tweak to the final patch in the series. | |
| 19:46:45 | mikal | While I think of it, for reference oVirt appears to use a qemu-xhci controller with 8 ports. So that should be a reasonably safe choice. | |
| 19:56:29 | sean-k-mooney | mikal: i run my windows gaming pc in a vm | |
| 19:56:34 | sean-k-mooney | mikal: and it has | |
| 19:56:36 | sean-k-mooney | <controller type="usb" index="0" model="qemu-xhci" ports="15"> | |
| 19:56:38 | sean-k-mooney | <address type="pci" domain="0x0000" bus="0x02" slot="0x00" function="0x0"/> | |
| 19:56:40 | sean-k-mooney | </controller> | |
| 19:57:12 | mikal | Yeah, there is some ovirt code I'm reading which seems to change the controller type based on guest OS, but if qemu-xhci works for Linux and modern Windows I think we're good to go. | |
| 19:57:35 | sean-k-mooney | i may have installed virtio drivers for it but that was the default model that virt-manager selected | |
| 19:59:06 | sean-k-mooney | it worked fine when i was passhtihg though a phsical mouse and keyboard to the vm | |
| 19:59:22 | sean-k-mooney | again i dont recall if installed a dirver but i dont think i had to | |
| 20:00:11 | mikal | I think https://github.com/oVirt/ovirt-engine/blob/master/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/OsRepositoryImplTest.java#L79 is effectively saying that RHEL 6 and 7 need nec-xhci but maybe nothing else? I still need to find the code which does that thing, instead of the test which tests it. | |
| 20:00:20 | mikal | But Java is not a thing I've read in quite a while now... | |
| 20:00:49 | mikal | I need to wander off for now, but I will keep poking at this and let you know if I find anything interesting. | |
| #openstack-nova - 2025-01-23 | |||
| 04:22:31 | opendevreview | ChungWon Lee proposed openstack/nova master: Reduce node build fail value by time https://review.opendev.org/c/openstack/nova/+/939929 | |
| 05:11:31 | opendevreview | ChungWon Lee proposed openstack/nova master: Reduce node build fail value by time https://review.opendev.org/c/openstack/nova/+/939929 | |
| 07:25:51 | opendevreview | benlei proposed openstack/nova master: Abort live migration task when stop nova compute service https://review.opendev.org/c/openstack/nova/+/938223 | |
| 07:26:13 | opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing finish_time https://review.opendev.org/c/openstack/nova/+/928933 | |
| 08:37:30 | opendevreview | James Page proposed openstack/nova master: Restore nova.virt.__init__ https://review.opendev.org/c/openstack/nova/+/939827 | |
| 09:09:10 | gibi | bauzas: when you are up this seems to be important ^^ and needs a second core | |
| 09:18:55 | bauzas | gibi: noted | |
| 09:20:53 | gibi | thanks | |
| 09:22:46 | ratailor | gibi, sean-k-mooney artom_ bauzas could you please review https://review.opendev.org/c/openstack/nova/+/939649 and provide your initial feedback on approach. | |
| 09:40:39 | gibi | ratailor: did a quick review on the patch, see my comments inline | |
| 09:41:01 | ratailor | gibi, ack. Thanks! | |
| 10:48:57 | opendevreview | Pavlo Shchelokovskyy proposed openstack/nova master: Fix device type when booting from ISO image https://review.opendev.org/c/openstack/nova/+/909611 | |
| 13:23:44 | opendevreview | Merged openstack/nova master: Restore nova.virt.__init__ https://review.opendev.org/c/openstack/nova/+/939827 | |
| 16:23:18 | opendevreview | Kaloyan Kotlarski proposed openstack/nova master: libvirt: Fetch the available vCPUs from the respective cgroup https://review.opendev.org/c/openstack/nova/+/927474 | |
| 18:20:35 | opendevreview | melanie witt proposed openstack/nova master: tests: Functional reproducer for bug 2088831 https://review.opendev.org/c/openstack/nova/+/935565 | |
| 19:59:00 | opendevreview | Tobias Urdin proposed openstack/nova master: Remove libvirt tunnelled migration https://review.opendev.org/c/openstack/nova/+/879021 | |
| 19:59:13 | opendevreview | Tobias Urdin proposed openstack/nova master: Remove libvirt tunnelled migration https://review.opendev.org/c/openstack/nova/+/879021 | |
| #openstack-nova - 2025-01-24 | |||
| 06:48:28 | masanori | Hello. I have created this bug fix: https://review.opendev.org/c/openstack/nova/+/936910 Could you please review it when you have time. > gibi, stephenfin or anyone :) This fixes the process to get the image's metadata from instance.image_meta instead of request_spec.image during resize. | |
| 10:11:09 | stephenfin | sean-k-mooney: Would you be able to take a look at https://review.opendev.org/c/openstack/nova/+/937377/ today? | |
| 10:18:15 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Allow min/max_version arguments to expected_errors https://review.opendev.org/c/openstack/nova/+/936363 | |
| 10:18:15 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Allow min/max_version arguments to response https://review.opendev.org/c/openstack/nova/+/936364 | |
| 10:18:16 | opendevreview | Stephen Finucane proposed openstack/nova master: trivial: Remove legacy API artifact https://review.opendev.org/c/openstack/nova/+/937377 | |
| 10:18:16 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Adjust validation helpers for a single-method future https://review.opendev.org/c/openstack/nova/+/936365 | |
| 10:18:17 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Stop using wsgi.Controller.api_version to switch between API versions https://review.opendev.org/c/openstack/nova/+/936366 | |
| 10:18:17 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add new, simpler api_version decorator https://review.opendev.org/c/openstack/nova/+/936367 | |
| 10:18:18 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Only run format checks on strings https://review.opendev.org/c/openstack/nova/+/936368 | |
| 10:18:19 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Simplify parameter types https://review.opendev.org/c/openstack/nova/+/936369 | |
| 10:18:19 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Ensure all APIs have a response body schema https://review.opendev.org/c/openstack/nova/+/924598 | |
| 10:18:21 | opendevreview | Stephen Finucane proposed openstack/nova master: doc: Add missing API samples https://review.opendev.org/c/openstack/nova/+/937012 | |
| 10:18:21 | opendevreview | Stephen Finucane proposed openstack/nova master: tests: Use UUIDs in TestOpenStackClient https://review.opendev.org/c/openstack/nova/+/937013 | |
| 10:18:23 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hosts APIs https://review.opendev.org/c/openstack/nova/+/937047 | |
| 10:18:23 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for instance actions https://review.opendev.org/c/openstack/nova/+/937048 | |
| 10:18:25 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hypervisors APIs (1/3) https://review.opendev.org/c/openstack/nova/+/937245 | |
| 10:18:25 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hypervisors APIs (2/3) https://review.opendev.org/c/openstack/nova/+/937246 | |
| 10:18:27 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for hypervisors APIs (3/3) https://review.opendev.org/c/openstack/nova/+/937247 | |
| 10:18:27 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server IPs APIs https://review.opendev.org/c/openstack/nova/+/937608 | |
| 10:18:29 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for remote consoles https://review.opendev.org/c/openstack/nova/+/940114 | |
| 10:18:29 | opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for keypairs APIs https://review.opendev.org/c/openstack/nova/+/940115 | |
| 14:24:42 | bauzas | sean-k-mooney: reading your whiteboard comment on https://blueprints.launchpad.net/nova/+spec/image-metadata-props-weigher | |
| 14:24:55 | bauzas | sean-k-mooney: are we clear that I *need* to create those sets , | |
| 14:24:57 | bauzas | ? | |
| 14:29:15 | sean-k-mooney | can you repahse that | |
| 14:29:31 | sean-k-mooney | they dont already exist but they are trivial to construct from the data you have | |
| 14:29:55 | sean-k-mooney | i was trying to descibe the algorithum i would use and its the one i would have documented in a spec if we were to have had a spec | |
| 14:31:42 | sean-k-mooney | are you askign are free to come up with an entirly diffent design? from my perspecitve i was agreeing to treat this treat it as a specless blueprint on the understadign that you would implemnt the design in the whiteboard but if you ahve a diffent approch i can review it | |