| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-12-06 | |||
| 14:46:39 | opendevreview | Ildiko Vancsa proposed openstack/nova master: Update contributor process documentation https://review.opendev.org/c/openstack/nova/+/936759 | |
| 14:48:59 | ildikov | sean-k-mooney: gmann has a patch that adds a new link to the tracking etherpad in contributing.rst. I think that would be a better place to update links and references, and make sure that the changes are consistent throughout the Nova repo: https://review.opendev.org/c/openstack/nova/+/936776/1/doc/source/contributor/contributing.rst | |
| 14:49:05 | ildikov | What do you all think? | |
| 14:49:54 | sean-k-mooney | yep we can do that too | |
| 14:50:19 | sean-k-mooney | but part of the problemis its quite hard to find the process doc in the contibutor docs | |
| 14:50:28 | sean-k-mooney | there is a lot of text too read through first | |
| 14:50:47 | sean-k-mooney | so that is why i wated to add riectrly links to the process doc in the readme | |
| 14:51:23 | sean-k-mooney | *direct links | |
| 14:51:44 | sean-k-mooney | i dont want to link directly to the etherpad there | |
| 14:53:04 | sean-k-mooney | ildikov: developer will generally look at the git repo before anythign else so that why i wante to have this clear in the readme | |
| 14:53:47 | sean-k-mooney | we can do that as a sperate chagne if you want but it took me some time to find the prcoess doc when i wanted to find the links for the comment | |
| 14:56:30 | ildikov | sean-k-mooney: I don't question the value to add links to the process doc more directly, I'm personally good with that direction | |
| 14:56:51 | sean-k-mooney | ok ill just submit a patch for that later myself | |
| 14:56:56 | ildikov | based on pervious discussions, it doesn't seem like there's an overall agreement on what should be linked from where | |
| 14:57:22 | ildikov | and I would like to avoid holding up landing the process documentation, because people don't agree on where to put what link :) | |
| 14:57:45 | sean-k-mooney | my main concern is peopel still wont find the procss doc | |
| 14:58:16 | sean-k-mooney | the feed back we got was there was very littel docusmation for contibutors and as you have seen that is not the case | |
| 14:58:29 | sean-k-mooney | so +1 for makeign the exitsing docs correct | |
| 14:58:36 | ildikov | I can add the process doc link back into my patch, and leave the decision to another path whether or not to update the link to contributing.rst vs contributor/index.rst | |
| 14:58:37 | sean-k-mooney | but we need to also fix the discoveray aspect | |
| 14:58:53 | ildikov | would that be a good middle ground? | |
| 14:59:07 | sean-k-mooney | sure | |
| 14:59:12 | ildikov | ok, cool | |
| 14:59:18 | sean-k-mooney | findig that process link was actully what took time | |
| 14:59:29 | ildikov | and yes, I totally agree on the discoverability aspect | |
| 14:59:30 | sean-k-mooney | so that the part i find hard to discover | |
| 14:59:39 | ildikov | +1 | |
| 15:01:32 | opendevreview | Ildiko Vancsa proposed openstack/nova master: Update contributor process documentation https://review.opendev.org/c/openstack/nova/+/936759 | |
| 15:02:35 | ildikov | sean-k-mooney: done ^^ | |
| 15:03:08 | ildikov | I also consolidated the template part in process.rst, I missed your comment on that earlier, apologies for the delay on that. | |
| 15:03:41 | sean-k-mooney | no worries | |
| 15:04:08 | sean-k-mooney | im ok with the current version | |
| 15:04:21 | ildikov | awesome, thank you for checking! | |
| 15:04:25 | sean-k-mooney | i was ok without consolidating them by the way | |
| 15:04:51 | ildikov | ah ok, I wasn't sure | |
| 15:05:14 | ildikov | with the comment from bauzas, I think it's better consolidated | |
| 15:05:27 | sean-k-mooney | i wanted the template but not pushed on which is more readable | |
| 15:05:48 | sean-k-mooney | so if sylvain has a prefence thats fine by me | |
| 15:13:31 | ildikov | sounds good | |
| 15:13:32 | ildikov | I'll keep an eye out for his review and see if there are any more updates he would like to have | |
| 15:16:44 | opendevreview | Ildiko Vancsa proposed openstack/nova master: Update contributor process documentation https://review.opendev.org/c/openstack/nova/+/936759 | |
| 15:17:35 | ildikov | it looks like I got the formatting wrong in rst, haven't done rst in a while so I'm a bit rusty :) | |
| 15:23:34 | opendevreview | Balazs Gibizer proposed openstack/placement master: Add a global limit on the number of allocation candidates https://review.opendev.org/c/openstack/placement/+/936658 | |
| 15:23:35 | opendevreview | Balazs Gibizer proposed openstack/placement master: Add round-robin candidate generation strategy https://review.opendev.org/c/openstack/placement/+/936832 | |
| 15:24:29 | opendevreview | Balazs Gibizer proposed openstack/placement master: Add a global limit on the number of allocation candidates https://review.opendev.org/c/openstack/placement/+/936658 | |
| 15:24:29 | opendevreview | Balazs Gibizer proposed openstack/placement master: Add round-robin candidate generation strategy https://review.opendev.org/c/openstack/placement/+/936832 | |
| 15:30:29 | opendevreview | Ildiko Vancsa proposed openstack/nova master: Update contributor process documentation https://review.opendev.org/c/openstack/nova/+/936759 | |
| 15:35:19 | gibi | melwitt: thanks for volunteering of looking at the placement a_c explosion fix. The first patch of the series in https://review.opendev.org/q/topic:%22bug/2070257%22 is ready for review. The second is also already working but I still intended to clean it up so that is WIP but any feedback is highly appreciated | |
| 15:37:09 | gibi | melwitt: I'm working on getting timing and memory numbers for comparision of before / after the fix and I will add that to the commit message as soon as I can convince my test node to build not just 4 but 8 devstack VMs | |
| 16:20:09 | opendevreview | Merged openstack/nova master: api: Add response body schemas for assisted volume snapshots APIs https://review.opendev.org/c/openstack/nova/+/924588 | |
| 17:39:55 | opendevreview | Balazs Gibizer proposed openstack/placement master: Add round-robin candidate generation strategy https://review.opendev.org/c/openstack/placement/+/936832 | |
| 17:39:56 | opendevreview | Balazs Gibizer proposed openstack/placement master: Factor out allocation candidate generation strategy https://review.opendev.org/c/openstack/placement/+/937273 | |
| 17:39:56 | opendevreview | Balazs Gibizer proposed openstack/placement master: DNM: test with breadth-first in tempest https://review.opendev.org/c/openstack/placement/+/937274 | |
| 17:41:31 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: test with placement ac breadth-first https://review.opendev.org/c/openstack/nova/+/937275 | |
| 18:00:08 | gmann | ildikov: current version lgtm, thanks for updates | |
| 18:24:47 | ildikov | gmann: great, thank you for checking! | |
| 18:38:43 | opendevreview | Merged openstack/nova master: Replace deprecated FormatChecker.cls_checks https://review.opendev.org/c/openstack/nova/+/935733 | |
| 18:38:54 | opendevreview | Merged openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 18:39:02 | opendevreview | Merged openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753 | |
| 21:05:44 | opendevreview | Artom Lifshitz proposed openstack/nova-specs master: vTPM live migration https://review.opendev.org/c/openstack/nova-specs/+/936775 | |
| 22:29:15 | opendevreview | Merged openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| #openstack-nova - 2024-12-07 | |||
| 00:11:00 | opendevreview | Merged openstack/nova master: api: Add response body schemas for port interface APIs https://review.opendev.org/c/openstack/nova/+/924589 | |
| 00:11:07 | opendevreview | Merged openstack/nova master: api: Add response body schemas for availability zone APIs https://review.opendev.org/c/openstack/nova/+/924590 | |
| #openstack-nova - 2024-12-08 | |||
| 04:07:36 | opendevreview | Merged openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| #openstack-nova - 2024-12-09 | |||
| 00:38:55 | opendevreview | Merged openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 12:15:57 | opendevreview | Stephen Finucane proposed openstack/nova master: api-ref: Update note on flavor disabled property https://review.opendev.org/c/openstack/nova/+/937356 | |
| 12:17:36 | opendevreview | benlei proposed openstack/nova master: Avoid duplication instances when nova compute servcie restart https://review.opendev.org/c/openstack/nova/+/937357 | |
| 12:21:59 | opendevreview | benlei proposed openstack/nova master: Avoid duplication instances when nova compute servcie restart https://review.opendev.org/c/openstack/nova/+/937357 | |
| 12:27:12 | opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: test with placement ac breadth-first https://review.opendev.org/c/openstack/nova/+/937275 | |
| 13:32:33 | opendevreview | Kaloyan Kotlarski proposed openstack/nova master: libvirt: Fetch the available vCPUs from the respective cgroup https://review.opendev.org/c/openstack/nova/+/927474 | |
| 13:40:39 | opendevreview | Balazs Gibizer proposed openstack/placement master: Add a global limit on the number of allocation candidates https://review.opendev.org/c/openstack/placement/+/936658 | |
| 13:40:39 | opendevreview | Balazs Gibizer proposed openstack/placement master: Factor out allocation candidate generation strategy https://review.opendev.org/c/openstack/placement/+/937273 | |
| 13:40:40 | opendevreview | Balazs Gibizer proposed openstack/placement master: Add round-robin candidate generation strategy https://review.opendev.org/c/openstack/placement/+/936832 | |
| 13:40:40 | opendevreview | Balazs Gibizer proposed openstack/placement master: DNM: test with breadth-first in tempest https://review.opendev.org/c/openstack/placement/+/937274 | |
| 15:21:00 | opendevreview | Merged openstack/nova master: api: Add response body schemas for bare metal node APIs https://review.opendev.org/c/openstack/nova/+/924591 | |
| 15:23:10 | gibi | melwitt: the whole https://review.opendev.org/q/topic:%22bug/2070257%22 is ready for review now | |
| 15:34:01 | opendevreview | Stephen Finucane proposed openstack/nova master: trivial: Remove legacy API artifact https://review.opendev.org/c/openstack/nova/+/937377 | |
| 15:36:48 | sean-k-mooney | gibi: you have 3 actual patches adn two DNMs to test this in ci with the new order if im readign that right? | |
| 15:37:25 | sean-k-mooney | is the plan to enabel the breadth-first appochec in nova-next or similar? | |
| 15:38:17 | sean-k-mooney | i assume we woudl like to have both tested between the set of jobs we have | |
| 15:38:56 | sean-k-mooney | given the limited useage of nested resouce providers in the upstream gate i doubt we woudl see an observable diffence | |
| 15:39:45 | sean-k-mooney | although i coudl see use eventually chanigng the default fo the placement config option in a future release so setting it in nova-next i think woudl make sesne | |
| 15:40:39 | sean-k-mooney | gibi: if you would like me to be a second review on that i can try and do so next year but i wont have time to do that this week | |
| 15:41:03 | sean-k-mooney | if others feel like they have a better grasp on placmenet that fine too | |
| 15:41:35 | sean-k-mooney | i was hopign melwitt would be one of the reviewer on thsi but i dont know who is next best positioned to review | |
| 15:58:49 | gibi | sean-k-mooney: 3 actual placement patch yes, the DNMs are just running tempest with the fix | |
| 15:59:43 | gibi | sean-k-mooney: I feel this patch will wait for review until the new year, so you will have a chance to look at it | |
| 15:59:57 | gibi | melwitt is already signalled interest | |
| 16:00:54 | gibi | I'm OK to enable this config in nova-next, I think it is pretty safe. But as you noted we don't have much nested coverage in upstream CE | |
| 16:00:57 | gibi | CI | |
| 17:23:38 | auniyal | sean-k-mooney, please have a look at https://review.opendev.org/c/openstack/nova/+/929858 for review | |
| 17:24:23 | sean-k-mooney | sure | |
| 17:25:22 | auniyal | thanks :) | |
| 17:44:40 | opendevreview | Stephen Finucane proposed openstack/nova master: trivial: Remove legacy API artifact https://review.opendev.org/c/openstack/nova/+/937377 | |
| 17:50:47 | sean-k-mooney | auniyal: +1.5 comments inline | |
| 18:03:20 | opendevreview | Douglas Viroel proposed openstack/nova-specs master: Add spec for show scheduler hints in server details https://review.opendev.org/c/openstack/nova-specs/+/936140 | |
| 18:29:09 | sean-k-mooney | dviroel: ^ i have +2'd the spec but also left some nits that coudl be improved. i am proably +1.6 which is why i rounded up to a +2 instead of down to a +1 but im happy with the over all direction of this | |
| 18:41:29 | dviroel | thanks sean-k-mooney. yeah, there are some implementation/testing details missing in the spec, but mainly because I am not familiar with all nova doc/test details. But for sure I will follow previous implemented API microversions to check all required changes. | |
| 18:42:27 | sean-k-mooney | yep if other are happy with the implict understandign that all standard testing will be added at implemeation time im happy to just review for that when reviewing the code change | |
| 18:49:53 | opendevreview | Merged openstack/nova master: api: Add response body schemas for console auth token APIs https://review.opendev.org/c/openstack/nova/+/924592 | |