| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-11-20 | |||
| 19:26:22 | melwitt | woohoo | |
| 19:28:58 | sean-k-mooney | ill try and review the second patch again tomorrow | |
| 19:29:18 | melwitt | cool, thank you | |
| 19:30:01 | sean-k-mooney | i have an older veriosn checked out in one... of my devstack vms | |
| 19:30:22 | sean-k-mooney | i might see if i can try enabeling it and test the basics | |
| 19:30:58 | melwitt | the more testing the better :) | |
| 19:33:01 | melwitt | I realized it wouldn't be the right thing to validate resource classes (for quotas) in init_host() bc that's a nova-compute thing and the quota checking happens in nova-api and nova-conductor. so I'm looking for a similar spot I can add the validation for startup | |
| 19:39:43 | melwitt | oh derp, init_host() can be added for any service I see now | |
| 19:41:12 | melwitt | nova-api needs to be different though bc it won't go through nova.service I don't think | |
| 19:44:05 | melwitt | ok the wsgi app does use a nova Service but calls only Service.create() | |
| 19:45:26 | sean-k-mooney | it does not enven need to be init_host | |
| 19:45:46 | sean-k-mooney | we just need a early point to hook after the config is parsrced | |
| 19:45:56 | sean-k-mooney | so the post start hook woudl work too | |
| 19:47:30 | sean-k-mooney | actully pre_start_hook would work too | |
| 19:47:42 | sean-k-mooney | but ya init_host is my go too | |
| 19:50:34 | sean-k-mooney | melwitt: if your feellign laze it technially could go in __init__ https://github.com/openstack/nova/blob/e8a544f0e1134a4b260720cc634ad1997f936d6d/nova/manager.py#L92 but ya init_host or pre_start_hook are proably better | |
| 19:52:15 | melwitt | sean-k-mooney: I think the nova-api wsgi app doesn't go through init_host or pre_start_hook bc it doesn't call Service.start(). so that has to either be done differently or go into __init__ or Service.create | |
| 19:53:41 | sean-k-mooney | is that true... it might be i tough it was common but you might be right | |
| 19:53:57 | sean-k-mooney | i didnt think the manager part changed between the too | |
| 19:54:02 | dansmith | I'm quite sure melwitt is right here | |
| 19:54:13 | dansmith | there's really no service lifecycle for it under wsgi | |
| 19:54:26 | sean-k-mooney | sure but this is not part of the service | |
| 19:54:33 | sean-k-mooney | its part of the manager | |
| 19:54:33 | melwitt | sean-k-mooney: I was looking at this https://github.com/openstack/nova/blob/master/nova/api/openstack/wsgi_app.py#L52 | |
| 19:54:50 | sean-k-mooney | the service calls it but init_host is a methond on the manager | |
| 19:55:07 | dansmith | called by the service stuff though I think | |
| 19:55:35 | melwitt | nova-api has no manager, no? | |
| 19:56:31 | sean-k-mooney | sshhh with you logic and correctness | |
| 19:56:45 | sean-k-mooney | your right it does not | |
| 19:56:46 | melwitt | 😂 | |
| 19:56:56 | melwitt | I'm wrong most of the time, so there's that | |
| 19:57:15 | sean-k-mooney | that has not been my expnce but if you say so | |
| 19:57:29 | melwitt | heh | |
| 19:58:00 | sean-k-mooney | taking a step back | |
| 19:58:09 | sean-k-mooney | we are just talking about validating the config right | |
| 19:58:18 | melwitt | right | |
| 19:58:25 | sean-k-mooney | does oslo allow ues to register a callback for that on the config opt | |
| 19:58:39 | melwitt | hm, dunno but I'll look | |
| 20:01:06 | melwitt | not seeing something like that in https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py | |
| 20:01:32 | sean-k-mooney | so i know we can define our own otp types | |
| 20:01:47 | sean-k-mooney | and for string we have the ablity to provide enum vlaues | |
| 20:02:50 | melwitt | we need dynamic enum (from os-resource-classes standard classes) and a regex for CUSTOM_stuff I think | |
| 20:03:52 | sean-k-mooney | well i was thinking of inheriting form listOpt | |
| 20:04:03 | sean-k-mooney | and just adding the validation | |
| 20:04:18 | sean-k-mooney | basically providing a limitListOPT class | |
| 20:05:23 | melwitt | ah ok | |
| 20:05:47 | melwitt | that sounds interesting. I'll check it out | |
| 20:06:40 | sean-k-mooney | looking at how its implemted fro string | |
| 20:06:43 | sean-k-mooney | https://github.com/openstack/oslo.config/blob/68cefad313bd03522e99b3de95f1786ebea45d4b/oslo_config/types.py#L68 | |
| 20:07:05 | sean-k-mooney | when you create and isntance of the opt you can provide choices (for a enum) or a regex | |
| 20:07:18 | sean-k-mooney | and then the __call__ method actully does the validation | |
| 20:07:37 | melwitt | that's cool | |
| 20:07:39 | sean-k-mooney | and raise a valueError if it invalid | |
| 20:07:47 | sean-k-mooney | https://github.com/openstack/oslo.config/blob/68cefad313bd03522e99b3de95f1786ebea45d4b/oslo_config/types.py#L141-L170 | |
| 20:09:02 | sean-k-mooney | so if you inherited form List your call could call super which would provide a list and you could just loop over all the values and check if they were valid | |
| 20:09:14 | sean-k-mooney | if yes just return the result form the call to super else rais | |
| 20:09:37 | sean-k-mooney | melwitt: im not sure if that is overkill but its doable | |
| 20:10:49 | sean-k-mooney | and it keeps the valdiation in teh config code so thats nice cause it will work for the api the same as everything else | |
| 20:11:00 | sean-k-mooney | anyway o/ | |
| 20:11:05 | melwitt | we could show off pro level oslo.config usage | |
| 20:11:39 | melwitt | thanks for the ideas. seeya tomorrow o/ | |
| 20:56:16 | frickler | sean-k-mooney: sorry if I missed that in scrollback, but https://review.opendev.org/c/openstack/os-vif/+/935653 failed in gate with the error it is supposed to fix, iiuc you wanted to skip that check completely, then? | |
| 20:57:40 | sean-k-mooney[m] | ya i didnt get around to pushing a patch but i was going to make that test skip if the native driver was used | |
| 20:58:14 | sean-k-mooney[m] | i just finished dinner but i can update the patch to do that in a little bit | |
| 20:59:09 | sean-k-mooney[m] | we have 2 drivers ovs-vsctl and the nantive python on. its only the native one that sometimes times out | |
| 21:22:00 | opendevreview | sean mooney proposed openstack/os-vif master: address test stablity under load https://review.opendev.org/c/openstack/os-vif/+/935653 | |
| 21:22:12 | sean-k-mooney | frickler: ^ updated to skip | |
| 21:22:48 | sean-k-mooney | the rest of the change is technially not needed but it does not hurt so i kept it | |
| 21:23:42 | opendevreview | Takashi Kajinami proposed openstack/os-vif master: Clean up Windows support https://review.opendev.org/c/openstack/os-vif/+/932436 | |
| 21:24:37 | sean-k-mooney | i rebsased and reappoved ^ on top so hopefuly that will pass and we can merge both soon | |
| 21:27:15 | frickler | thx, will check for results tomorrow | |
| 21:44:18 | opendevreview | Cyril Roelandt proposed openstack/python-novaclient master: Replace glanceclient with openstacksdk https://review.opendev.org/c/openstack/python-novaclient/+/931276 | |
| 21:54:18 | opendevreview | melanie witt proposed openstack/nova master: nova-manage: Add flavor scanning to migrate_to_unified_limits https://review.opendev.org/c/openstack/nova/+/924110 | |
| 21:56:18 | dansmith | melwitt: why the most recent change? | |
| 21:56:23 | dansmith | did checking the rc not work? | |
| 21:56:33 | dansmith | because if not, that needs fixing I think | |
| 21:56:52 | dansmith | oh I see, you kept the output check without the ... output | |
| 22:11:07 | melwitt | dansmith: yeah :( dumb | |
| 23:54:11 | sean-k-mooney | dansmith: melwitt: https://review.opendev.org/c/openstack/os-vif/+/935653 passed with the test skip woudl one of ye mind reappoving that to unblock the follow up patch which is holding up the oslo requirement bump | |
| #openstack-nova - 2024-11-21 | |||
| 00:08:30 | dansmith | sean-k-mooney: I'm not sure why you added the skip though.. your comment says "I'm not an SME but approved" and then followed up with a skip :) | |
| 01:27:06 | sean-k-mooney | i added the skip because extending the time out to 10 seconds worked in check and failed in gate after 12 seconds... | |
| 01:27:38 | sean-k-mooney | so basically we said fi the longer time out did not work we would skip until we can find a better long term solution. | |
| 01:30:13 | sean-k-mooney | we can leave it till tomorrow, no worries | |
| 01:44:22 | gmann | it seems nova live migration job failing with "openstack server create: error: argument --image: expected one argument" | |
| 01:44:27 | gmann | https://zuul.opendev.org/t/openstack/build/ae91e51ade8147bd8063218f0b88cc12/log/job-output.txt#20779 | |
| 01:44:33 | gmann | anything changed in osc side? | |
| 01:47:08 | gmann | oh, actual error is due to not able to talk to glance. "Failed to contact the endpoint at https://10.210.65.110/image for discovery. Fallback to using that endpoint as the base url." | |
| 01:47:21 | gmann | and image_id is None and so osc error | |
| 02:02:40 | opendevreview | melanie witt proposed openstack/nova master: nova-manage: Add flavor scanning to migrate_to_unified_limits https://review.opendev.org/c/openstack/nova/+/924110 | |
| 05:19:21 | opendevreview | melanie witt proposed openstack/nova master: Add [quota]unified_limits_resource_(strategy|list) https://review.opendev.org/c/openstack/nova/+/924025 | |
| 06:37:13 | frickler | bauzas: gibi: please have another look at https://review.opendev.org/c/openstack/os-vif/+/935653 , I'd really like to get the whole stack that is blocked by this done this week. and I do think we will also need a fresh os-vif release for that once the two fixes are merged | |
| 06:40:14 | frickler | gmann: if you look further up in the log, devstack already failed while deploying glance. not sure about the root cause for that, though | |
| 08:55:13 | opendevreview | Balazs Gibizer proposed openstack/nova master: Improve heal_instance_info_cache periodic https://review.opendev.org/c/openstack/nova/+/935858 | |
| 09:28:36 | opendevreview | ribaudr proposed openstack/nova master: Amend ShareMappingStatus due to asynchronous call https://review.opendev.org/c/openstack/nova/+/908864 | |
| 09:28:36 | opendevreview | ribaudr proposed openstack/nova master: Amend DB model add a unique constraint. https://review.opendev.org/c/openstack/nova/+/912518 | |
| 09:28:37 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 09:28:37 | opendevreview | ribaudr proposed openstack/nova master: Use client token when talking to manila https://review.opendev.org/c/openstack/nova/+/925277 | |
| 09:28:38 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 09:28:38 | opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | |
| 09:28:39 | opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | |