| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-11-19 | |||
| 10:31:42 | zigo | 24 are flavor related, one must be my own patch failing. | |
| 11:15:11 | frickler | zigo: trying to run this locally I'm seeing "TypeError: 'PipeMutex' object does not support the context manager protocol" during discovery, does that ring a bell for you? do you have more fixes than just 935512? | |
| 11:17:29 | zigo | frickler: The patch from tkajinam https://review.opendev.org/c/openstack/oslo.log/+/935620 fixed it for me. | |
| 11:18:05 | zigo | Also, I may have the fix for the issue I just reported ! :) | |
| 11:18:26 | zigo | (my patch repaired at least one unit tests, running them all now...) | |
| 11:25:05 | opendevreview | Thomas Goirand proposed openstack/nova master: Python 3.13: Repair fake_flavor_get_by_id https://review.opendev.org/c/openstack/nova/+/935631 | |
| 11:26:29 | frickler | zigo: ah, tkajinam ftw, thx | |
| 11:39:34 | zigo | This looks like failing under Py 3.13 as well: | |
| 11:39:34 | zigo | msg = _('User %(username)s not found in password file.') | |
| 11:39:34 | zigo | raise exception.NovaException(msg % username) | |
| 11:39:34 | zigo | with: | |
| 11:39:34 | zigo | TypeError: format requires a mapping | |
| 11:39:38 | zigo | Anyone got a clue? | |
| 11:41:11 | sean-k-mooney | i think its saying that the right hand side need to be a dict | |
| 11:41:41 | sean-k-mooney | i guess in the past named parmatere i.e. %(username)s could take postional replacements and they got stricter about that in 3.13 | |
| 11:42:12 | sean-k-mooney | so its expexting (msg % {'username': username}) | |
| 11:42:30 | sean-k-mooney | but i would just replace %(username)s with %s | |
| 11:43:07 | zigo | Ok, so I should just replace username by {'username': username} ? | |
| 11:43:20 | zigo | I can try ... :P | |
| 11:43:32 | sean-k-mooney | that or update msg = _('User %(username)s not found in password file.') to msg = _('User %s not found in password file.') | |
| 11:43:49 | sean-k-mooney | either both should be useing named paramaters or both should be postional | |
| 11:43:56 | sean-k-mooney | its unhappy that we are mixing them | |
| 11:45:22 | zigo | I'm trying the first solution, so it doesn't break translations. | |
| 11:45:53 | zigo | Do we still care about these btw? I thought we were to just stop translating error messages ... | |
| 11:49:49 | zigo | sean-k-mooney: Fixed ! :) | |
| 11:50:10 | zigo | Now I'm worried we have this type of raise all over the place ... | |
| 11:51:20 | zigo | Hum... doesn't look like it. | |
| 11:52:13 | sean-k-mooney | im kind of surprised that this was never flagged by a linter | |
| 11:52:45 | sean-k-mooney | some projects have been more agressive with replacing percent strings with fstring so that woudl also remove that issue | |
| 11:54:54 | opendevreview | Thomas Goirand proposed openstack/nova master: Fix exception raising in inject_data https://review.opendev.org/c/openstack/nova/+/935640 | |
| 11:55:58 | opendevreview | Thomas Goirand proposed openstack/nova master: Fix exception raising in _set_passwd() https://review.opendev.org/c/openstack/nova/+/935640 | |
| 11:56:43 | sean-k-mooney | zigo: did you hit yappi/_yappi.c:1288:5: error: implicit declaration of function ‘_PyEval_SetProfile’; did you mean ‘PyEval_SetProfile’? [-Wimplicit-function-declaration] | |
| 11:57:22 | sean-k-mooney | i was trying to run the unit test with 3.13 locally | |
| 11:58:13 | zigo | sean-k-mooney: Yeah, I fixed that one, you need a local rebuild of yappi probably (since it's a .so based module). | |
| 11:58:21 | zigo | Debian Unstable is already fixed for that. | |
| 11:58:50 | sean-k-mooney | ack im using testing so i guess i need to wait or clone and buidl that myslef | |
| 11:58:58 | sean-k-mooney | i can test this in a vm instead | |
| 11:59:20 | zigo | I used version 1.6.10 instead of 1.6.<something>. | |
| 11:59:25 | zigo | Maybe just bump it? | |
| 12:00:03 | sean-k-mooney | you mean bump the distro packages or the python dep in a requirements file | |
| 12:00:17 | zigo | Whatever you're using, yeah ... :P | |
| 12:00:28 | sean-k-mooney | i need to hop on a 1:1 but i can do a ful dist upgrade after the call | |
| 12:00:50 | sean-k-mooney | oh thats not for 30 mins | |
| 12:02:44 | sean-k-mooney | sorry im using sid which is unstable so ok hopefuly that will fix that | |
| 12:09:50 | sean-k-mooney | zigo: do you know if the version of yappi you used is allwod by uc? | |
| 12:10:17 | sean-k-mooney | that would be a no | |
| 12:10:19 | sean-k-mooney | yappi===1.6.0 | |
| 12:10:42 | sean-k-mooney | ok so thats why its failign localy i can overried with a different version | |
| 12:12:16 | sean-k-mooney | im not sure why that has not been bumpted recently | |
| 12:52:44 | zigo | Thanks for taking care of it. | |
| 13:24:53 | opendevreview | Takashi Kajinami proposed openstack/nova master: Migrate MEM_ENCRYPTION_CONTEXT from root provider https://review.opendev.org/c/openstack/nova/+/921814 | |
| 13:24:54 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 13:25:10 | opendevreview | Takashi Kajinami proposed openstack/nova master: Add hw_mem_encryption_model image property https://review.opendev.org/c/openstack/nova/+/927706 | |
| 13:26:47 | opendevreview | Takashi Kajinami proposed openstack/nova master: Add hw_mem_encryption_model image property https://review.opendev.org/c/openstack/nova/+/927706 | |
| 13:26:56 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| 13:30:41 | opendevreview | sean mooney proposed openstack/os-vif master: address test stablity under load https://review.opendev.org/c/openstack/os-vif/+/935653 | |
| 13:40:24 | sean-k-mooney | zigo: tkajinam im hoping ^ will fix the intermitent os-vif ci failure | |
| 13:44:05 | tkajinam | sean-k-mooney, ah, thanks ! | |
| 13:48:11 | sean-k-mooney | oh pep8 failure because we have not merged the pre-commit change yet... | |
| 13:48:26 | sean-k-mooney | im way to used to using pre-commit to run linting at this point | |
| 13:48:50 | sean-k-mooney | on the plus side it passed ci https://zuul.opendev.org/t/openstack/build/e2c5522cfee741dd89a731afc9c8b19e | |
| 13:48:55 | sean-k-mooney | so ill fix that locally and push again | |
| 13:50:26 | sean-k-mooney | although it passed with a short exectuion time so this also ran on a fast worker vif_plug_ovs.tests.functional.ovsdb.test_ovsdb_lib.TestOVSDBLib.test_create_ovs_vif_port_with_default_qos(native) [0.746099s] ... ok | |
| 13:52:13 | opendevreview | sean mooney proposed openstack/os-vif master: address test stablity under load https://review.opendev.org/c/openstack/os-vif/+/935653 | |
| 15:03:24 | tkajinam | Can I ask for 2nd +2 to https://review.opendev.org/c/openstack/nova/+/930726 ? this removes eventlet related code. | |
| 15:04:29 | tkajinam | and there are a few trivial cleanups pending on 2nd +2s and I appreciate any feedback https://review.opendev.org/c/openstack/nova/+/934517 https://review.opendev.org/c/openstack/nova/+/931146 | |
| 15:12:39 | sean-k-mooney | i think im already +2 on all of those but yes i think those are all easy wins | |
| 15:26:57 | tkajinam | sean-k-mooney, yeah, and thanks for these +2s :-) | |
| 15:41:17 | gibi | tkajinam: I'm +A both. Thanks for the cleanup | |
| 15:55:44 | bauzas | reminder: nova meeting in 5 mins | |
| 16:00:13 | bauzas | #startmeeting nova | |
| 16:00:13 | opendevmeet | Meeting started Tue Nov 19 16:00:13 2024 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:13 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:13 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:21 | bauzas | hello everyone | |
| 16:00:34 | bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 16:01:19 | bauzas | who's around ? | |
| 16:01:26 | elodilles | o/ | |
| 16:01:33 | bauzas | let's wait for a few more | |
| 16:01:42 | bauzas | if we don't have quorum, I'll skip the meeting | |
| 16:01:52 | s3rj1k | hi all | |
| 16:02:25 | tkajinam | o/ | |
| 16:02:34 | gibi | o/ | |
| 16:03:39 | sean-k-mooney | o/ | |
| 16:03:57 | bauzas | okay we can start | |
| 16:04:09 | sean-k-mooney | i have one quick topic for the end of the meetign but i could also ask on the list. just an fyi | |
| 16:04:17 | bauzas | ack | |
| 16:04:25 | bauzas | let's have this meeting being quick | |
| 16:04:36 | bauzas | my whole day was already packed with meetings | |
| 16:04:43 | bauzas | #topic Bugs (stuck/critical) | |
| 16:04:48 | bauzas | #info No Critical bug | |
| 16:04:53 | bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | |
| 16:05:04 | bauzas | nothing about bugs ? | |
| 16:05:42 | bauzas | okay, let's move on | |
| 16:05:48 | tkajinam | sean-k-mooney has proposed the fix for os-vif issue I raised last week | |
| 16:05:53 | tkajinam | https://review.opendev.org/c/openstack/os-vif/+/935653 | |
| 16:05:55 | bauzas | ah cool | |
| 16:06:02 | tkajinam | if we can merge this quickly that would be nice | |
| 16:06:02 | bauzas | sean-k-mooney++ | |
| 16:06:22 | bauzas | I'm not sure I can review that patch but I'll try | |