| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-10-29 | |||
| 16:47:21 | tkajinam | ok I understand what you mean | |
| 16:48:00 | sean-k-mooney | right cinder has an enum https://github.com/openstack/cinder/blob/master/cinder/volume/qos_specs.py#L33 for diffent type of qos | |
| 16:48:34 | sean-k-mooney | and as you foudn the generic manager code shoudl include the qos if its front-end or both | |
| 16:48:58 | sean-k-mooney | it looks like its part of the connection info | |
| 16:49:16 | sean-k-mooney | in a optional qos_specs section | |
| 16:49:23 | tkajinam | yeah | |
| 16:49:42 | sean-k-mooney | looking at https://github.com/openstack/cinder/blob/master/cinder/volume/manager.py#L1836-L1839 | |
| 16:50:00 | sean-k-mooney | im not sure they the burst values they are propsoing are supproted by cinder | |
| 16:50:16 | sean-k-mooney | so i think there shoudl be a cinder spec first to extend the set of qos types | |
| 16:50:23 | sean-k-mooney | and then we woudl just enable them | |
| 16:50:58 | sean-k-mooney | the cinder team may be ok just using the nova spec for both but we would need them to say one way or another | |
| 16:54:22 | tkajinam | sean-k-mooney, quickly looking at cinder code it seems cinder has no mechanism to validate keys in qos specs | |
| 16:54:43 | tkajinam | the documentation even describes the "delay" which is not actually used IIUC https://docs.openstack.org/api-ref/block-storage/v3/index.html#id768 | |
| 16:54:59 | sean-k-mooney | it filters them when puting them in the connection info | |
| 16:55:19 | sean-k-mooney | so it may not filter for backend qos polciies btu it does for frontend ones | |
| 16:56:16 | tkajinam | I mean there is not filtering mechanism in api layer, so what we may need to update is the filtering logic in manager.py which you pointed | |
| 16:56:45 | sean-k-mooney | yes which cinder may or may not consider an api change | |
| 16:57:16 | sean-k-mooney | so they may be happy with jsut the nova spec and say a bug on there side or they may ask for a spec on both sides if they consider it an api change | |
| 16:57:29 | sean-k-mooney | i posted this on the spec more or less | |
| 16:57:49 | sean-k-mooney | although not in those exact words | |
| 16:58:35 | tkajinam | yeah I saw these | |
| 16:59:33 | sean-k-mooney | if you think any addtional context woudl help please reply so the author can condier that. are you overall infaovr or agasitn this feature? | |
| 17:05:02 | tkajinam | sean-k-mooney, I now think that's a good idea. My -1 came from the fact that I overlooked that frontend qos handling | |
| 17:05:57 | opendevreview | Merged openstack/nova master: [ovo]Add igb value to hw_vif_model image property https://review.opendev.org/c/openstack/nova/+/928456 | |
| 17:20:21 | opendevreview | Merged openstack/nova master: [libvirt]Support hw_vif_model = igb https://review.opendev.org/c/openstack/nova/+/928584 | |
| 17:20:31 | opendevreview | Merged openstack/nova master: [doc]Developer doc about PCI and SRIOV testing https://review.opendev.org/c/openstack/nova/+/928834 | |
| 17:20:39 | sean-k-mooney | gibi: :) ^ | |
| 17:23:06 | opendevreview | Takashi Kajinami proposed openstack/nova master: Migrate MEM_ENCRYPTION_CONTEXT from root provider https://review.opendev.org/c/openstack/nova/+/921814 | |
| 17:23:06 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 17:23:07 | opendevreview | Takashi Kajinami proposed openstack/nova master: Add hw_mem_encryption_model image property https://review.opendev.org/c/openstack/nova/+/927706 | |
| 17:23:07 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| 17:26:58 | gibi | sean-k-mooney: \o/ | |
| 17:27:08 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 17:27:08 | gibi | a quick win for Epoxy | |
| 17:27:08 | opendevreview | Takashi Kajinami proposed openstack/nova master: Add hw_mem_encryption_model image property https://review.opendev.org/c/openstack/nova/+/927706 | |
| 17:27:09 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with SEV-ES memory encryption https://review.opendev.org/c/openstack/nova/+/926106 | |
| 20:43:20 | opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: pwr mgmt: power down free PCPUS when updating compute node https://review.opendev.org/c/openstack/nova/+/932926 | |
| #openstack-nova - 2024-10-30 | |||
| 07:00:46 | opendevreview | Luca Miccini proposed openstack/nova master: TEST DNM check CI https://review.opendev.org/c/openstack/nova/+/933702 | |
| 07:08:26 | opendevreview | Luca Miccini proposed openstack/nova master: TEST DNM check CI https://review.opendev.org/c/openstack/nova/+/933702 | |
| 12:33:04 | opendevreview | Balazs Gibizer proposed openstack/nova master: Route shared storage RPC to evac dest at startup https://review.opendev.org/c/openstack/nova/+/933734 | |
| 15:29:52 | opendevreview | Balazs Gibizer proposed openstack/nova master: Route shared storage RPC to evac dest at startup https://review.opendev.org/c/openstack/nova/+/933734 | |
| 15:29:52 | opendevreview | Balazs Gibizer proposed openstack/nova master: Reproduce bug 2085975 in functional https://review.opendev.org/c/openstack/nova/+/933753 | |
| 15:30:12 | sean-k-mooney | that was fast | |
| 15:30:49 | gibi | I had proper focus time | |
| 15:31:11 | sean-k-mooney | :) | |
| 15:32:29 | sean-k-mooney | skiming the repoducer the logic makes sense | |
| 15:32:49 | sean-k-mooney | ill be interested to see if that is stable in ci as we have had issues with using condition variables like that before | |
| 15:33:08 | sean-k-mooney | its seams reasonable to me at a glance however | |
| 15:34:07 | sean-k-mooney | oh the rpc_exception car is set via wrapped_check_shared_storage | |
| 15:34:26 | sean-k-mooney | i think nonlocal is only aviable in newerversion fo python but perhaps that includes 3.9 | |
| 15:35:26 | sean-k-mooney | oh no looks like that is valid form old version of python 3 | |
| 15:36:09 | sean-k-mooney | https://peps.python.org/pep-3104/ | |
| 15:50:26 | gibi | yeah we will see I can run couple of rechecks to see if it is stable | |
| 15:51:01 | gibi | without the events I cannot create a stable reproduction as I need to stop evac int he middle. So we can only have unit tests then | |
| 17:26:43 | sean-k-mooney | gibi: so regarding https://github.com/openstack/nova/blob/110849f7f972d8cb536a9c96c4cb59f06e357eeb/nova/conf/compute.py#L1087-L1104 | |
| 17:26:50 | sean-k-mooney | the help text is actully wrong | |
| 17:27:03 | sean-k-mooney | nova will not update teh network info cache on its own | |
| 17:27:21 | sean-k-mooney | it will howver react to the network-changed external event form neutron if something changes | |
| 17:27:28 | sean-k-mooney | and update the relevent port | |
| 17:29:27 | gibi | sean-k-mooney: I haven't looked at the impl of the heal code yet. But I can do that fur sure. If we want to change the default then we definitly need to change that conf doc as it recommends against it. | |
| 17:33:48 | sean-k-mooney | right it was true at teh tiem becuase ther ewere many out of tree neutron drivers in production use | |
| 17:34:03 | sean-k-mooney | that is really not the case anymore | |
| 17:41:42 | sean-k-mooney | gibi: i cant find it but i was pretty sure i had a patch to update the text or disable it in the past | |
| 17:41:48 | sean-k-mooney | i just cant find it in gerrit | |
| 17:56:03 | sean-k-mooney | hum nope cant find it in my gerrtit review but i did find this https://review.opendev.org/c/openstack/nova/+/713342 | |
| 17:56:25 | sean-k-mooney | i have some other reviw i have not touched in a long time that are fixing real bugs that i shoudl get back to eventually.. | |
| 17:58:02 | sean-k-mooney | like https://review.opendev.org/c/openstack/nova/+/653506 | |
| 17:58:40 | sean-k-mooney | and https://review.opendev.org/q/topic:%22bug/2074219%22 | |
| 17:59:54 | sean-k-mooney | and this https://review.opendev.org/q/topic:%22bug/2048837%22 | |
| 19:22:31 | opendevreview | Ghanshyam proposed openstack/nova stable/2023.1: DNM: testing tempest 41.0.0 on stable/2023.1 https://review.opendev.org/c/openstack/nova/+/933774 | |
| #openstack-nova - 2024-10-31 | |||
| 09:50:45 | opendevreview | ribaudr proposed openstack/nova master: Amend ShareMappingStatus due to asynchronous call https://review.opendev.org/c/openstack/nova/+/908864 | |
| 09:50:46 | opendevreview | ribaudr proposed openstack/nova master: Amend DB model add a unique constraint. https://review.opendev.org/c/openstack/nova/+/912518 | |
| 09:50:46 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 09:50:47 | opendevreview | ribaudr proposed openstack/nova master: Use client token when talking to manila https://review.opendev.org/c/openstack/nova/+/925277 | |
| 09:50:51 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 09:50:53 | opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | |
| 09:50:54 | opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | |
| 09:50:59 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 09:51:01 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 09:51:02 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 09:51:07 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 09:51:08 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 09:51:08 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 09:51:11 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares https://review.opendev.org/c/openstack/nova/+/860287 | |
| 09:51:13 | opendevreview | ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862 | |
| 09:51:14 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (compute manager) https://review.opendev.org/c/openstack/nova/+/885751 | |
| 09:51:15 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 09:51:15 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753 | |
| 09:51:16 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 09:51:16 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 09:51:17 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 09:51:17 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 09:51:18 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 09:51:18 | opendevreview | ribaudr proposed openstack/nova master: Reports instance events to the DB regarding attaching and detaching a share https://review.opendev.org/c/openstack/nova/+/927088 | |
| 09:51:20 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 09:51:20 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 09:51:22 | opendevreview | ribaudr proposed openstack/nova master: Manila shares admin guide documentation https://review.opendev.org/c/openstack/nova/+/871642 | |
| 11:37:18 | jovial | Is there any chance of cherry-picking https://review.opendev.org/c/openstack/nova/+/923910 back to 2024.1? I ask just because I'm interested in the related Ironic "bugfix" that uses this functionality. | |
| 11:38:24 | jovial | Ironic patch: https://review.opendev.org/c/openstack/ironic/+/924887 | |
| 11:38:39 | jovial | My bad it is labelled as a feature, so I guess not. | |