| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-10-15 | |||
| 16:43:29 | bauzas | no worries, we're all busy | |
| 16:43:35 | bauzas | particularly me. | |
| 16:43:51 | bauzas | #topic Open discussion | |
| 16:43:57 | bauzas | (tkajinam): Removing db migration tool from nova_placement to placement: https://review.opendev.org/c/openstack/placement/+/932324 | |
| 16:43:59 | bauzas | shoot | |
| 16:44:28 | tkajinam | I discussed this already with sean-k-mooney and gibi but I think it may make sense to bring the topic here to get any additional feedback | |
| 16:45:10 | tkajinam | placement repository has carried the migration tool which pulls placement db from nova db. This was required in upgrade from Stein to Train and I'm wondering if we can directly drop it now because I don't think anyone may use it from master nowadays | |
| 16:45:45 | bauzas | this is old code | |
| 16:45:55 | bauzas | I don't see any controversy in removing it | |
| 16:46:09 | tkajinam | :-) | |
| 16:46:15 | bauzas | and people wanting to use it could just pip install in a venv an older release of placement | |
| 16:46:23 | bauzas | and use that tool | |
| 16:46:31 | gibi | yeah, drop it. | |
| 16:46:50 | tkajinam | A quick question I still have is whether we should keep the upgrade note which is almost empty https://8f5091142d0d93e54bb3-66f76d6fb4c84b410723fddf17d0dbe7.ssl.cf5.rackcdn.com/932324/2/check/openstack-tox-docs/93314e0/docs/admin/upgrade-notes.html or keep it (and the administrator guide section) as a placeholder | |
| 16:47:03 | opendevreview | Amit Uniyal proposed openstack/nova master: Update Nova bdm with updated swap info https://review.opendev.org/c/openstack/nova/+/929858 | |
| 16:47:04 | bauzas | from a procedural perspective, I litterally see zero paperwork to fill | |
| 16:48:20 | bauzas | tkajinam: keep that | |
| 16:48:26 | gibi | tkajinam: that upgrade-notes seem still relevant | |
| 16:48:35 | bauzas | running a status check pre-flight is important | |
| 16:48:50 | tkajinam | yes | |
| 16:49:10 | bauzas | anyway, I think we're done with that item, we'll review it | |
| 16:49:20 | tkajinam | ok then https://review.opendev.org/c/openstack/placement/+/932324 is ready. I had to wipe previous +2 to fix doc issues | |
| 16:49:22 | tkajinam | thanks ! | |
| 16:49:23 | bauzas | tkajinam: feel free to add your patch into the status etherpad | |
| 16:49:42 | tkajinam | will do | |
| 16:49:48 | bauzas | ++ | |
| 16:50:06 | bauzas | another item, less easy to answer | |
| 16:50:08 | bauzas | (tkajinam): Can we remove (or at least deprecate) WIndows OS support ? | |
| 16:50:21 | bauzas | any good reason for doing it ? | |
| 16:50:55 | bauzas | oh, the hypervisor bits | |
| 16:51:11 | tkajinam | So as you know WinStackers project has been retired and now OpenStack on Windows is no longer maintained | |
| 16:51:12 | bauzas | for a second, I thought it was about the image type and the instances :) | |
| 16:51:41 | tkajinam | I've seen some issues with cross platform support when working on replacing unmaintained libs (eg netifaces) | |
| 16:52:16 | tkajinam | I wonder if we can completely drop the windows support if it's not really tested/maintained or at least deprecate it so that we can get rid of it when something is completely broken | |
| 16:52:23 | bauzas | if that's removing tech debt on things that we removed but left remains, sure I second your work | |
| 16:53:14 | bauzas | anyone having any concerns about that ? | |
| 16:54:11 | bauzas | I checked and apparently you can install a libvirt client on windows | |
| 16:54:39 | bauzas | it would require your hypervisor to be remote tho, which is something we don't support | |
| 16:54:48 | tkajinam | yes | |
| 16:54:54 | tkajinam | as we don't support hyper-v via libvirt | |
| 16:55:02 | tkajinam | I personally prefer direct removal given the fact hyper-v driver was already removed, but if we want to do it safe then we can deprecate it this cycle. We can discuss the strategy in the review https://review.opendev.org/c/openstack/nova/+/932407 | |
| 16:55:29 | sean-k-mooney | ya so hyperv via libvirt ws never supported | |
| 16:55:39 | bauzas | I just think we can process with reviewing your patch | |
| 16:55:49 | bauzas | nothing controversial so far | |
| 16:55:53 | tkajinam | thanks | |
| 16:56:27 | bauzas | anything else before we wrap up ? | |
| 16:56:53 | tkajinam | just fyi. I've added a few bugs (and their fixes) to the bottom of status etherpad https://etherpad.opendev.org/p/nova-2025.1-status (L87-91) | |
| 16:57:14 | sean-k-mooney | tkajinam: we have some windows supprot we can delete in os-vif too by the way | |
| 16:57:15 | tkajinam | these replaces the deprecated/unmaintained libs so I appreciate reviews for these. | |
| 16:57:28 | tkajinam | sean-k-mooney, yeah I remember I did deprecate these in the past cycle | |
| 16:58:01 | bauzas | tkajinam: ack | |
| 16:58:07 | tkajinam | so it maybe time to drop it, as we usually use eventlet patch differently for windows removing the logic may help removing eventlet. | |
| 16:58:27 | gmann | tkajinam: what exactly left to remove window support? | |
| 16:58:41 | tkajinam | gmann, tons of os.name == 'nt' checks | |
| 16:58:42 | bauzas | gmann: see above, there is a cleanup patch | |
| 16:58:59 | tkajinam | maybe not 'tons' but 'numbers' | |
| 16:59:05 | gmann | ohk, just cleanup things. got it | |
| 16:59:28 | gmann | but we have already declared the winbdow support removal during hyper-V removal | |
| 16:59:49 | tkajinam | yes | |
| 17:00:17 | tkajinam | that's all from me today | |
| 17:00:57 | bauzas | cool and we're at time | |
| 17:00:59 | bauzas | thanks all | |
| 17:01:02 | bauzas | #endmeeting | |
| 17:01:02 | opendevmeet | Meeting ended Tue Oct 15 17:01:02 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 17:01:02 | opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-15-16.03.html | |
| 17:01:02 | opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-15-16.03.txt | |
| 17:01:02 | opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-10-15-16.03.log.html | |
| 17:02:44 | elodilles | thanks o/ | |
| 17:03:09 | tkajinam | thank you ! | |
| 17:09:21 | opendevreview | Takashi Kajinami proposed openstack/nova master: Clean up the remaining logic for Windows OS Support https://review.opendev.org/c/openstack/nova/+/932407 | |
| 17:23:29 | opendevreview | Takashi Kajinami proposed openstack/os-vif master: Clean up Windows support https://review.opendev.org/c/openstack/os-vif/+/932436 | |
| 17:36:53 | gmann | tkajinam: I changed my -1 to +2 on the py3.8 drop changes for python_requires flag. let me know if I missed any and that is blocking them to merge. | |
| 17:37:39 | opendevreview | Merged openstack/nova stable/2023.1: add functional repoducer for bug 2065927 https://review.opendev.org/c/openstack/nova/+/922987 | |
| 17:40:16 | sean-k-mooney | gibi: i really dont know why this does not work https://paste.opendev.org/show/bv7MnOwOylKgvUiBOube/ | |
| 17:40:26 | sean-k-mooney | it never print LOG.info(f"Finished after {end_time - start_time} seconds") | |
| 17:41:43 | opendevreview | Takashi Kajinami proposed openstack/placement master: Remove Python 3.8 support https://review.opendev.org/c/openstack/placement/+/925648 | |
| 17:46:40 | sean-k-mooney | maybe im not emulating this well and iw was working ill try soemthign other then sleep as teh worker function | |
| 18:12:37 | sean-k-mooney | oh there first example in https://www.geeksforgeeks.org/python-different-ways-to-kill-a-thread/ does not actlly work | |
| 18:19:46 | sean-k-mooney | ok i have it workign now but im not sure i like it | |
| 18:25:28 | sean-k-mooney | https://paste.opendev.org/show/bl8yqiKsPC6fv8iMA1tG/ | |
| 18:26:45 | sean-k-mooney | that works with eventlet too https://paste.opendev.org/show/bsbrV4lpmgzIBj5WOB2M/ | |
| 18:30:08 | sean-k-mooney | any the behavior is differnt if i eventlet monkeypathc or not | |
| 18:31:13 | sean-k-mooney | ok so this will work for native threads which is what we want it for but not nessiarly for eventlet greenthreads | |
| 18:31:42 | opendevreview | Merged openstack/nova stable/2023.1: retry write_sys call on device busy https://review.opendev.org/c/openstack/nova/+/922988 | |
| 18:31:48 | opendevreview | Merged openstack/nova stable/2023.1: testing: Fix and robustify archive_deleted_rows test https://review.opendev.org/c/openstack/nova/+/887978 | |
| 19:33:10 | opendevreview | Merged openstack/python-novaclient master: Remove Python 3.8 support https://review.opendev.org/c/openstack/python-novaclient/+/931477 | |
| 21:58:53 | opendevreview | Merged openstack/nova stable/2023.1: database: Archive parent and child rows "trees" one at a time https://review.opendev.org/c/openstack/nova/+/887979 | |
| 22:18:50 | opendevreview | melanie witt proposed openstack/nova master: DNM try minimalistic imagebackend refactor https://review.opendev.org/c/openstack/nova/+/925635 | |
| 22:18:51 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Move cache filename generation to imagebackend https://review.opendev.org/c/openstack/nova/+/930961 | |
| 22:18:51 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Add base image format tracking with file extensions https://review.opendev.org/c/openstack/nova/+/930962 | |
| 22:18:52 | opendevreview | melanie witt proposed openstack/nova master: db: Add image_type to block_device_mapping table https://review.opendev.org/c/openstack/nova/+/930964 | |
| 22:18:52 | opendevreview | melanie witt proposed openstack/nova master: objects: Add image_type to BlockDeviceMapping object https://review.opendev.org/c/openstack/nova/+/930965 | |
| 22:18:53 | opendevreview | melanie witt proposed openstack/nova master: virt: Add image_type to relevant DriverBlockDevice https://review.opendev.org/c/openstack/nova/+/930966 | |
| 22:18:53 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Add image multi-backend https://review.opendev.org/c/openstack/nova/+/930967 | |
| 22:18:54 | opendevreview | melanie witt proposed openstack/nova master: WIP trait, filter, request spec https://review.opendev.org/c/openstack/nova/+/932153 | |
| 22:18:54 | opendevreview | melanie witt proposed openstack/nova master: api: Add microversion 2.97 to add image_type to block_device_mapping_v2 https://review.opendev.org/c/openstack/nova/+/930968 | |
| 22:34:14 | opendevreview | melanie witt proposed openstack/nova master: WIP trait, filter, request spec https://review.opendev.org/c/openstack/nova/+/932153 | |
| #openstack-nova - 2024-10-16 | |||
| 00:56:59 | opendevreview | Takashi Kajinami proposed openstack/os-vif master: Clean up Windows support https://review.opendev.org/c/openstack/os-vif/+/932436 | |
| 02:03:38 | opendevreview | Takashi Kajinami proposed openstack/placement master: Switch python version for placement-nova-tox-functional https://review.opendev.org/c/openstack/placement/+/932472 | |
| 02:17:45 | opendevreview | Takashi Kajinami proposed openstack/os-vif master: Drop kuryr-kubernetes job https://review.opendev.org/c/openstack/os-vif/+/932474 | |