| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-10-01 | |||
| 17:48:10 | gmann | ++ | |
| 17:48:18 | sean-k-mooney | we have several patches for it in placement we just need to choose one to proceed with | |
| 17:49:10 | gmann | or merge all in single one, remove py3.8 job + add py301, py311 jobs and leave the min version bump | |
| 17:49:22 | sean-k-mooney | placement-perfload by the way is having a wheel build fialure for a missing header | |
| 17:49:51 | sean-k-mooney | i think that is unrelated and and existing fialure tha twe shoudl fix in a differnt patch | |
| 17:50:15 | sean-k-mooney | it has quite a few failures https://zuul.opendev.org/t/openstack/builds?job_name=placement-perfload&project=openstack%2Fplacement | |
| 17:51:00 | sean-k-mooney | im going to finish for today soon | |
| 17:51:03 | tkajinam | py311 functional job already exists and pass so I prefer to use it now and then replace it by py312 if needed | |
| 17:51:20 | gmann | ah yeah, ++ for py3.12 | |
| 17:51:38 | sean-k-mooney | im happy to go with gmann's suggestion fo a single path to do everythin and just test the upper and lower python version i.e. 3.9 and 3.12 for tox jobs | |
| 17:51:49 | tkajinam | ok | |
| 18:00:41 | sean-k-mooney | by the way 3.12 support is added by https://review.opendev.org/c/openstack/placement/+/919578/3 | |
| 18:01:10 | sean-k-mooney | the pre-commit series was all intended to be in 2024.2... | |
| 18:02:03 | sean-k-mooney | it would likely be best to merge https://review.opendev.org/c/openstack/placement/+/919578/3 first and then rebase tkajinam change on top | |
| 18:02:51 | sean-k-mooney | gmann: if we wanted to avoid the merge conflict merging up to https://review.opendev.org/c/openstack/placement/+/919580/3 before tkajinam's change woudl make sense | |
| 18:03:36 | gmann | sean-k-mooney: sure, will check after tc meeting | |
| 18:03:42 | sean-k-mooney | no worries | |
| 18:10:48 | opendevreview | Takashi Kajinami proposed openstack/placement master: Replace py38 job by py311 job https://review.opendev.org/c/openstack/placement/+/931033 | |
| 18:10:49 | opendevreview | Takashi Kajinami proposed openstack/placement master: Move upper functional job to py312 https://review.opendev.org/c/openstack/placement/+/931052 | |
| 20:39:35 | opendevreview | Merged openstack/placement master: tox: Simplify functional testenv definitions https://review.opendev.org/c/openstack/placement/+/919578 | |
| 21:28:02 | opendevreview | Merged openstack/placement master: Integrate pre-commit https://review.opendev.org/c/openstack/placement/+/919579 | |
| 21:30:04 | opendevreview | Merged openstack/placement master: pre-commit: Add autopep8 https://review.opendev.org/c/openstack/placement/+/923490 | |
| 21:30:05 | opendevreview | Merged openstack/placement master: pre-commit: Add sphinx-lint https://review.opendev.org/c/openstack/placement/+/919580 | |
| 21:59:43 | opendevreview | Merged openstack/placement master: Replace py38 job by py311 job https://review.opendev.org/c/openstack/placement/+/931033 | |
| #openstack-nova - 2024-10-02 | |||
| 01:53:49 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Move cache filename generation to imagebackend https://review.opendev.org/c/openstack/nova/+/930961 | |
| 01:53:49 | opendevreview | melanie witt proposed openstack/nova master: libvirt: Add base image format tracking with file extensions https://review.opendev.org/c/openstack/nova/+/930962 | |
| 01:53:50 | opendevreview | melanie witt proposed openstack/nova master: db: Add image_type to block_device_mapping table https://review.opendev.org/c/openstack/nova/+/930964 | |
| 01:53:50 | opendevreview | melanie witt proposed openstack/nova master: objects: Add image_type to BlockDeviceMapping object https://review.opendev.org/c/openstack/nova/+/930965 | |
| 01:53:51 | opendevreview | melanie witt proposed openstack/nova master: virt: Add image_type to relevant DriverBlockDevice https://review.opendev.org/c/openstack/nova/+/930966 | |
| 01:53:51 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Add image multi-backend https://review.opendev.org/c/openstack/nova/+/930967 | |
| 01:53:52 | opendevreview | melanie witt proposed openstack/nova master: api: Add microversion 2.97 to add image_type to block_device_mapping_v2 https://review.opendev.org/c/openstack/nova/+/930968 | |
| 02:42:31 | opendevreview | Ghanshyam proposed openstack/osc-placement master: Update python classifier in setup.cfg https://review.opendev.org/c/openstack/osc-placement/+/931113 | |
| 03:01:03 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Add image multi-backend https://review.opendev.org/c/openstack/nova/+/930967 | |
| 03:01:03 | opendevreview | melanie witt proposed openstack/nova master: api: Add microversion 2.97 to add image_type to block_device_mapping_v2 https://review.opendev.org/c/openstack/nova/+/930968 | |
| 03:31:15 | opendevreview | Takashi Kajinami proposed openstack/placement master: Move upper functional job to py312 https://review.opendev.org/c/openstack/placement/+/931052 | |
| 06:19:09 | opendevreview | Rajesh Tailor proposed openstack/nova master: Fix typos and punctuation issues https://review.opendev.org/c/openstack/nova/+/878779 | |
| 09:28:05 | opendevreview | Takashi Kajinami proposed openstack/nova master: Replace deprecated constant_time_compare https://review.opendev.org/c/openstack/nova/+/931146 | |
| 14:38:24 | opendevreview | Andrew Bonney proposed openstack/nova master: Don't reset port dns_name when shelving instances https://review.opendev.org/c/openstack/nova/+/919961 | |
| 14:41:01 | tkajinam | I wonder if anyone knows a good replacement of distutils.versionpredicate ? | |
| 14:41:09 | tkajinam | context behind my question is https://bugs.launchpad.net/oslo.versionedobjects/+bug/2083518 | |
| 14:41:40 | tkajinam | distutils was removed in Python 3.12 but that module is still used by nova and oslo.versionedobjects | |
| 16:04:11 | stephenfin | I thought sean-k-mooney had deprecated ImagePropertiesFilter in favour of placement. Apparently not | |
| 16:12:31 | tkajinam | :-( | |
| 16:14:59 | tkajinam | I now understand how huge disaster the removal of pkg_resources and distutils is | |
| 16:15:04 | tkajinam | py 3.12 is mess | |
| 16:39:21 | dansmith | tkajinam: it's been a disaster in every community I'm in | |
| 16:39:59 | tkajinam | yeah | |
| 16:40:47 | tkajinam | and we may see more "exciting" situation with upcoming py313 ... | |
| 16:41:44 | dansmith | yep | |
| 16:41:51 | dansmith | I mean... "yep :(" | |
| 16:43:00 | tkajinam | :-S | |
| 17:03:28 | sean-k-mooney | stephenfin: i tought i did also. there may have been usecase my prefilter could not cover | |
| 17:03:54 | sean-k-mooney | stephenfin: i did add a placement prefilter for image metadtaa | |
| 17:05:19 | sean-k-mooney | stephenfin: https://specs.openstack.org/openstack/nova-specs/specs/ussuri/implemented/image-metadata-prefiltering.html in ussuri apparently | |
| 17:08:14 | sean-k-mooney | i think the gap, if there is one is mainly aournd 2 things. one the prefilter can only support thigns that can be mapped to traits | |
| 17:08:40 | sean-k-mooney | basically meaning only thing that are fixed enuma not arbary values | |
| 17:08:55 | sean-k-mooney | *enums | |
| 17:09:45 | sean-k-mooney | so i could not supprot img_hv_requested_version and hw_maxphysaddr_bits which allwo you specify minium versions | |
| 17:10:19 | sean-k-mooney | i.e. hw_maxphysaddr_bits the image filter will pass any host that supprots at least hw_maxphysaddr_bits | |
| 17:10:52 | sean-k-mooney | we cant express that in placmeent today so whiel its less needed now there are still some cases that require it | |
| 17:11:16 | sean-k-mooney | that is why we have not deprecated or removed it | |
| 17:19:11 | stephenfin | sean-k-mooney: I wonder if we want to keep supporting those long-term. The docs say they were mainly for HyperV which is no longer a thing. It feels unlikely that people use them to request a specific libvirt version, for example | |
| 17:19:28 | stephenfin | not that it'll help us now, but in the long-term | |
| 17:21:26 | sean-k-mooney | stephenfin: some of them are libvirt specirc | |
| 17:21:35 | sean-k-mooney | hw_maxphysaddr_bits specificly is | |
| 17:22:27 | stephenfin | ah, indeed :( | |
| 17:22:29 | sean-k-mooney | we added that in caracal https://specs.openstack.org/openstack/nova-specs/specs/2024.1/implemented/libvirt-maxphysaddr-support.html | |
| 17:22:57 | sean-k-mooney | stephenfin: is there a reason you want to remvoe it | |
| 17:23:14 | stephenfin | see tkajinam's comment above about distutils | |
| 17:23:42 | sean-k-mooney | why woud lthis matter it trivcial to remove that dep | |
| 17:23:50 | sean-k-mooney | we are just using it to parse the version string | |
| 17:25:16 | sean-k-mooney | we have like 5 diffent thing that do somethign similar | |
| 17:25:25 | sean-k-mooney | granted some of them proably use distutils | |
| 17:26:29 | sean-k-mooney | but https://github.com/openstack/nova/blob/master/nova/scheduler/filters/image_props_filter.py#L87-L90 shoudl be fairly simple to repalce | |
| 17:27:58 | sean-k-mooney | stephenfin: the hyper_version is alwasy an int i think by the way | |
| 17:28:56 | sean-k-mooney | so we can litrally just do versionutils.convert_version_to_str can then use gratherthan to do the comparison if im not missing something | |
| 17:31:06 | stephenfin | versionpredicate supports anything you can put on the right side of a dependency in requirements.txt, so something like '> 6.1, < 7.0, != 6.1.0, != 6.1.1, != 6.1.2' is possible | |
| 17:31:32 | sean-k-mooney | ah i see | |
| 17:31:33 | stephenfin | so the solution is probably to vendor the code from cpython 3.11 | |
| 17:31:37 | stephenfin | https://github.com/python/cpython/blob/3.11/Lib/distutils/versionpredicate.py | |
| 17:31:38 | sean-k-mooney | we supprot that for the compute capbality filter | |
| 17:32:38 | sean-k-mooney | ah sorry not that the json filter | |
| 17:32:42 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/json_filter.py#L81-L112 | |
| 17:33:21 | sean-k-mooney | or thather https://github.com/openstack/nova/blob/master/nova/scheduler/filters/json_filter.py#L81-L112 | |
| 17:33:28 | sean-k-mooney | ... https://github.com/openstack/nova/blob/master/nova/scheduler/filters/json_filter.py#L31-L91 | |
| 17:33:40 | sean-k-mooney | but yes that more ahhoying | |
| 17:34:16 | sean-k-mooney | stephenfin: we could certenly consider deprecating that but we have never remvoed an image property before | |
| 17:34:28 | sean-k-mooney | i dont know how people would fell about removing this | |
| 17:35:10 | stephenfin | Probably easiest to just vendor the code and go back to ignoring that filter until the next time it causes issues | |
| 17:36:09 | sean-k-mooney | vendor in https://github.com/openstack/oslo.utils/blob/master/oslo_utils/versionutils.py | |
| 17:36:12 | sean-k-mooney | or in nova | |
| 17:40:50 | sean-k-mooney | looking at https://github.com/python/cpython/blob/3.11/Lib/distutils/versionpredicate.py | |
| 17:41:21 | sean-k-mooney | we have much of th elogic in the json filter bug i kind of hate all the regex logic that uses | |
| 17:42:16 | sean-k-mooney | i kind of understand why but dynamicly building a set of predicates by parsing a string using regexes fells... slow | |
| 19:22:32 | opendevreview | Merged openstack/placement master: Move upper functional job to py312 https://review.opendev.org/c/openstack/placement/+/931052 | |
| #openstack-nova - 2024-10-03 | |||
| 01:01:02 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Add image multi-backend https://review.opendev.org/c/openstack/nova/+/930967 | |
| 01:01:03 | opendevreview | melanie witt proposed openstack/nova master: api: Add microversion 2.97 to add image_type to block_device_mapping_v2 https://review.opendev.org/c/openstack/nova/+/930968 | |
| 01:47:14 | opendevreview | melanie witt proposed openstack/nova master: WIP libvirt: Add image multi-backend https://review.opendev.org/c/openstack/nova/+/930967 | |
| 01:47:15 | opendevreview | melanie witt proposed openstack/nova master: api: Add microversion 2.97 to add image_type to block_device_mapping_v2 https://review.opendev.org/c/openstack/nova/+/930968 | |
| 06:30:52 | opendevreview | melanie witt proposed openstack/nova master: DNM try minimalistic imagebackend refactor https://review.opendev.org/c/openstack/nova/+/925635 | |