Earlier  
Posted Nick Remark
#openstack-nova - 2024-09-05
17:55:30 sean-k-mooney so im not sure why i didnt have to fix that one
17:56:04 melwitt right.. I remember the bot changes but I'm not sure if they still do that? and if so, what impact does it have. it's like a black box for me
17:56:52 melwitt sean-k-mooney: you did fix the `` things. the only remaining fix from the january patch was a it's => its grammar thing so it was technically 1/3 valid still 😛
17:57:11 sean-k-mooney ah ok
17:58:14 melwitt when I looked at it I was like, "this looks really familiar" so I pulled up your patch and linked it in a comment, just for informational purposes
18:00:47 melwitt I've been looking through review dashboards and launchpad bugs seeing what things I could clear out
18:01:58 melwitt which reminds me, I replied to an issue someone opened yesterday about the inability to force live migration destinations that I thought was interesting https://bugs.launchpad.net/nova/+bug/2078932
18:02:51 melwitt I'm not sure if we have an official recommendation on how to do that given the "force" flags removal from the API
18:03:33 melwitt if we do, I'd like to add it to the docs somewhere bc it seems like a common use case
18:46:02 sean-k-mooney melwitt: well you can always use the old microversion but ya that kind of by desing
18:46:17 sean-k-mooney schduler hint are not ment to be changeable for the lifetime of an instance
18:46:21 melwitt right
18:46:50 sean-k-mooney you can specify a host
18:47:01 sean-k-mooney and provide that host passes all filters we will use it
18:47:21 sean-k-mooney the jsonfilter is off by default as its kind of a security problem
18:47:58 sean-k-mooney but obvioulsy if it has been used and used to selct based on host name then that vm is effectivly pinned and needs to be upgraded in place with downtime
18:48:15 melwitt that doesn't work for them because they have a jsonfilter that filters on specific hostnames (I know) but they have some kind of numa pinning requirements and I dunno enough about that to know a better way
18:48:59 sean-k-mooney they have this jsonfilter https://github.com/openstack/nova/blob/master/nova/scheduler/filters/json_filter.py#L24
18:49:06 melwitt I would like to document what is the right way to do this if possible because I think it will come up a lot
18:49:08 sean-k-mooney that allows you to match on anyting in the host state object
18:49:16 melwitt right
18:49:44 sean-k-mooney well the write way is to not live migrate it
18:49:54 melwitt :D
18:49:57 sean-k-mooney what they want to do is intentially not supported
18:50:09 melwitt they said it was a host evacuate situation though
18:50:21 sean-k-mooney the could shelve and unhevle the host but there is no way to move the instance without recreating it
18:50:24 melwitt which seems reasonable to me
18:50:46 sean-k-mooney so how i woudl fix this
18:50:57 melwitt ok. that's what I thought but I wasn't sure if there were more things I didn't know about
18:50:59 sean-k-mooney is implemnt the recreat api i wanted to add a few years ago
18:51:58 sean-k-mooney recreate is ment to be like resize and rebuild combined. one api that by defautl moves the isntance to another host alloing the embded flavor and image property to optionaly be udeated or for either to be chanaged
18:52:17 sean-k-mooney as part of a request it woudl be reasonabel to update the schdeuler hits
18:52:37 sean-k-mooney melwitt: in the short term a nova-mange command to update the reqest spec is proably what we should do
18:53:26 melwitt sean-k-mooney: ok, good. cause that's what I told them :)
18:53:55 sean-k-mooney long them an single api call that is "recreate this vm, keepign its data unless i ask for the image, and optionally changing the flavor" would avoid a lot of user/operator pain
18:54:21 sean-k-mooney s/the image/the image to be changed/
18:54:27 melwitt but yeah, re: the recreate API for the longterm solution, if the nova-manage command isn't good enough, I think it would be helpful
18:54:58 sean-k-mooney i want recreate for like 10 diffent usecase this just beign one of them
18:55:24 sean-k-mooney another short term soltuion woudl be allow schduler hints to be passed to move ops
18:55:47 sean-k-mooney so to migrate (cold/live) resize, unshleve, evacuate
18:56:07 melwitt yeah, I could see that
18:56:27 sean-k-mooney we allow doing thing like chainging the keypair i think for rebuild
18:56:37 melwitt yes, we do
18:56:55 sean-k-mooney so its not entirly strange to say if we are moving it allow the scheduer hits to optionally be updated
18:57:20 sean-k-mooney im less sure if that should be member or admin policy wiese
18:57:26 sean-k-mooney but i could see the argument either way
18:57:33 melwitt yeah, agree
18:58:46 sean-k-mooney the one nice thing about policy is as long as we are secure by default operator can always define there own
18:59:36 melwitt I think regardless we need the nova-manage command. afaik everyone is +1 about it and it could be backported for older versions
19:00:30 sean-k-mooney im slowly coming to the view that nova manage (witin reason) shoudl have more tooling to help operator get out of messes like this
19:00:46 melwitt same
19:01:18 sean-k-mooney i.e. i kind of want a flavor refesh command in nova-manage to check if the host is still valide and update the embded flavor with the latest verion of that flavor
19:01:38 sean-k-mooney or allwo you to also update the embded flavor extra spec liek the image properties
19:01:57 sean-k-mooney that does not change teh advice of never modify flavor once they are in use
19:02:13 sean-k-mooney but it give you an escape hatch if you did without forceing resizes
19:02:23 melwitt why not resize? oh
19:03:17 sean-k-mooney sometimes people pin thing to hosts :) the other reason i have heard is mano integration
19:03:30 sean-k-mooney i.e. there is a system on top that created the worklaod
19:03:42 sean-k-mooney and changing the flavor id is not trivial as a result
19:04:22 sean-k-mooney for example if it was deployed with heat or somethign like that
19:04:37 melwitt hm
19:04:43 sean-k-mooney i soudl argure that you shoudl stop doing it wrong
19:05:08 sean-k-mooney but customer sometimes dont like that
19:05:12 sean-k-mooney not sure why :)
19:06:05 sean-k-mooney anyway if you or they were to propsoe an extention to nova-mange for there usecase
19:06:17 sean-k-mooney or even the addtion of scheduler hits to the move ops
19:06:25 sean-k-mooney i would not really be against that
19:06:26 melwitt yeah.. it's a balance of "how painful is it to do the right thing"
19:07:05 sean-k-mooney do you remmber how horizon used to work ?
19:07:29 sean-k-mooney nova has had imutable flavors for as long as i have worked on openstck
19:07:39 melwitt oh, the "edit" flavor thing?
19:07:51 sean-k-mooney old version of hroizon use to allwo you to update the cpu ram and disk by deleteing and recreatin gthe flavor
19:07:53 sean-k-mooney ya
19:07:55 sean-k-mooney that
19:08:07 melwitt yeah, I remember. I take it that means it no longer does that?
19:08:35 sean-k-mooney no that was removed about 6 year ago after we kept gettting bug and telling them it a hroizon issue
19:08:49 melwitt oh hah
19:09:15 sean-k-mooney melwitt: so keyston also does nto allow you to update role asignment in trusts (a way of delegation access)
19:09:20 melwitt I use horizon sometimes but not for changing flavors
19:09:27 sean-k-mooney tripleo did the delete and recreat thing
19:09:52 sean-k-mooney and it causes similar bugs to this day
19:10:23 sean-k-mooney i use horizon more then i shoudl
19:10:51 sean-k-mooney i have not tried skyline yet
19:11:10 sean-k-mooney its been on my todolist but not high enough to take the time to do it
19:12:23 melwitt and I just finally realized why it's named skyline
19:12:25 melwitt 😝
19:13:19 sean-k-mooney why?
19:13:30 sean-k-mooney oh..
19:13:41 melwitt lol
19:13:42 sean-k-mooney its a horizon pun
19:14:08 sean-k-mooney of couse it is why would anything in ptyhon ever not be a pun
19:14:25 melwitt quite clever really. I liked the name just didn't get it
19:15:50 sean-k-mooney ill begrudgingly admit its pretty good
19:16:23 melwitt :)
19:16:37 sean-k-mooney so you know https://instructlab.ai/
19:16:53 melwitt labrador
19:16:54 sean-k-mooney the dog logo is apprently russel brants dog
19:17:13 JayF using ipxe as the rescue image is the most brilliant thing I've read today
19:17:18 melwitt oh, that's pretty cute. wears corrective lenses
19:17:30 sean-k-mooney ya i also wonder if its a lab

Earlier   Later