Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2024-08-27
15:11:23 bauzas that's been a while but we'll have a nova meeting here in 50 mins
15:15:06 stephenfin sean-k-mooney: Here's the fix for the novaclient issue https://review.opendev.org/c/openstack/python-novaclient/+/927249/ I know you were saying that should test the default configuration of auto-configuring a network, but that will never work with multiple possible networks. If we want to test that properly we'll need a separate job that removes e.g. the share network, but that seems like overkill
15:15:26 stephenfin So hopefully the bit of logic I've copied in there if sufficient
15:15:33 sean-k-mooney the legacy test is testing before the auto network feature was added
15:16:04 sean-k-mooney so ya the issue here is that the job is not conigured to allw the test to run
15:16:19 opendevreview Stephen Finucane proposed openstack/python-novaclient master: functional: Handle multiple networks https://review.opendev.org/c/openstack/python-novaclient/+/927249
15:16:19 opendevreview Stephen Finucane proposed openstack/python-novaclient master: tox: Add Python-specific functional envs https://review.opendev.org/c/openstack/python-novaclient/+/927250
15:16:20 opendevreview Stephen Finucane proposed openstack/python-novaclient master: Fix Python 3.12 compatibility https://review.opendev.org/c/openstack/python-novaclient/+/927251
15:16:32 stephenfin (just spotted so leftover print statements)
15:16:42 sean-k-mooney i saw them
15:16:49 stephenfin s/so/some/
15:16:51 sean-k-mooney but my point it this is ment to be testing when we do not specify a nic
15:16:57 sean-k-mooney so adding a nic invaldiates the test
15:17:15 stephenfin so do we add a skipTest if self.multiple_networks?
15:17:18 sean-k-mooney it would be better to use the skip test funciontion if we detect multiple networks
15:17:32 sean-k-mooney yep that was one of the opetions
15:17:46 sean-k-mooney i was also lookig at modifyitg the job to remove the share network
15:18:07 stephenfin though I'll note there's nothing in the test name or docstring that says this needs to rely on being able to auto-configure a network
15:18:18 sean-k-mooney its not
15:18:18 stephenfin so what makes you say that we're testing that?
15:18:30 sean-k-mooney auto configuring the network is an diffent feature then we are testing
15:18:41 stephenfin right, but we're testing the '--image-with' falg
15:18:43 stephenfin *flag
15:18:46 sean-k-mooney this is testing the bahvior or there is only one network
15:19:02 stephenfin having to/not to pass the '--nic' option is secondary to the main test, from the looks of things?
15:19:06 sean-k-mooney which is diffent then auto config which will create it if there is none
15:19:27 stephenfin right, but do we care? that's not the aim of this test
15:19:49 sean-k-mooney it is the aim to ensure that the old command line argument work as openstack evolves
15:20:02 sean-k-mooney at least fo the legacy version that is testin 2.1
15:20:46 sean-k-mooney stephenfin: if we have a sperate test case for this then im fine with changing this one
15:20:50 stephenfin Again, right, but the test is testing the '--image-with' option, not the '--nic' option (or lack thereof). My change proves the '--image-with' option works on both 2.1 and 2.latest
15:20:59 stephenfin okay, lemme see
15:21:33 sean-k-mooney i think this is the only test without a nic specifed
15:21:36 stephenfin that was easy. It's a short file. None there. Do we add one (with the skip)?
15:22:23 stephenfin relying on there only being one test seems fairly fragile and would prevent us running said tests against a local devstack (at least without doing what CI does and e.g. deleting the 'shared' network)
15:22:30 stephenfin *one network
15:24:21 sean-k-mooney so i think this regression was intoduced by https://github.com/openstack/devstack/commit/24b65adc9cedff9c7a8ab412fb39613ef5d4a627
15:24:50 stephenfin Hardly. That's there since yoga
15:24:57 stephenfin per the GitHub UI anyway
15:25:27 sean-k-mooney maybe not but was srbac enabeld in neutron by default for that long
15:26:06 sean-k-mooney ok im torn personally i want to remvoe the cli testing and the shell module
15:26:20 sean-k-mooney on the other hand while its there we shoudl nto reduce test coverage
15:26:36 sean-k-mooney so if you want to add a test taht will skip if multiple networks i guess that fine
15:26:43 sean-k-mooney but it also kind of useless without fixing the ci
15:26:49 stephenfin agreed
15:26:59 stephenfin maybe we just merge that and move on with our lives? 🤷
15:27:16 stephenfin undoubtedly better than making the whole thing non-voting
15:27:21 sean-k-mooney if we do then i think we need to delete the cli next cycle
15:27:26 stephenfin perfect is the enemy of the good
15:27:28 stephenfin etc. etc.
15:27:59 sean-k-mooney well no voting was just a precuisor to deleting it
15:28:16 sean-k-mooney we can see what people think in the nova meeting in 30 mins
15:28:52 stephenfin ack
15:29:03 sean-k-mooney if they are fine with our patch then we can merge it but i dicussed this with melwitt last week and we wanted to wait for the team meeting
15:29:31 sean-k-mooney as in i discussed skiping or modifying the test to work with multiple networks
16:01:36 bauzas #startmeeting nova
16:01:36 opendevmeet Meeting started Tue Aug 27 16:01:36 2024 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:01:36 opendevmeet Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:01:36 opendevmeet The meeting name has been set to 'nova'
16:01:40 bauzas hey folks
16:01:59 bauzas sorry, that's been so long, maybe you forgot about it
16:02:13 gibi never!
16:02:25 fwiesel o/
16:02:46 elodilles o/
16:03:03 sean-k-mooney o/
16:03:12 auniyal o/
16:03:34 bauzas cool folks
16:03:42 bauzas let's start then :)
16:03:56 bauzas #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting
16:04:05 bauzas #topic Bugs (stuck/critical)
16:04:12 bauzas #info No Critical bug
16:04:18 bauzas (glad to hear it)
16:04:26 bauzas #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster
16:04:45 bauzas any important bug people would want to discuss ?
16:04:59 bauzas I was off for 3 weeks so I don't really know
16:06:01 bauzas looks no
16:06:08 bauzas moving on
16:06:33 sean-k-mooney novaclint is blokced but we will talk about that later
16:06:37 bauzas okay
16:06:43 bauzas #topic Gate status
16:06:49 bauzas #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs
16:06:54 bauzas #link https://etherpad.opendev.org/p/nova-ci-failures-minimal
16:07:01 bauzas #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status
16:07:06 bauzas all greens
16:07:24 bauzas (well, we have a stable/zed job done, but meh)
16:07:33 bauzas #info Please look at the gate failures and file a bug report with the gate-failure tag.
16:07:38 bauzas #info Please try to provide meaningful comment when you recheck
16:08:25 bauzas moving on ?
16:08:52 bauzas #topic Release Planning
16:08:57 bauzas #link https://releases.openstack.org/dalmatian/schedule.html
16:09:04 bauzas #info Dalmatian-3 in 1 week
16:09:10 bauzas #info non-client library freeze happened last week
16:09:15 bauzas #info client library freeze this week
16:09:23 bauzas sean-k-mooney: want to discss the novaclient issue ?
16:10:13 dansmith I kinda have something for release planning
16:10:20 sean-k-mooney we have 2 issues
16:10:30 sean-k-mooney the first one is just a ci job issue
16:10:45 bauzas okay, tell me both
16:10:45 sean-k-mooney the functioanl job is exepcting there to only be one network
16:10:54 sean-k-mooney there are now 2

Earlier   Later