| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-08-26 | |||
| 11:01:38 | sean-k-mooney | which should be ok | |
| 11:04:15 | sean-k-mooney | that is defiend here https://github.com/openstack/devstack-plugin-ceph/blob/stable/2023.2/devstack/lib/ceph#L31 | |
| 11:04:48 | sean-k-mooney | this is in the lib module meaing that it for internal use only otherwise it shoudl be in settings at the top of the plugin | |
| 11:05:29 | sean-k-mooney | it should still be set but lateter so its probaly fine as is | |
| 11:06:46 | sean-k-mooney | so this is just trhe podman pull that is failing an di have seen that fail at least once in the last 2 weeks | |
| 11:07:04 | sean-k-mooney | but i didnt look into why so im not sure this is jobs specific | |
| 11:08:13 | sean-k-mooney | i think the way this is coded we download the container that ceph adm would use | |
| 11:08:32 | sean-k-mooney | then we parse teh version form that and download the corresponding cephadm binary directly | |
| 11:08:35 | sean-k-mooney | and then use that | |
| 11:09:59 | sean-k-mooney | so the fact its using el9 on ubuntu does not matter https://github.com/openstack/devstack-plugin-ceph/blob/stable/2023.2/devstack/lib/cephadm#L132 | |
| 11:10:45 | sean-k-mooney | so ya this look like a generic podman pull issue with quay.io | |
| 11:11:01 | sean-k-mooney | we could perhaps retry that pull to mitigate it | |
| 11:12:12 | sean-k-mooney | although i think ideally we would mirror that or precache the container and cephadm in the base image at least for the default release | |
| 11:25:18 | frickler | iiuc we do have a caching proxy for quay.io, so someone just would have to make that job use it (cc gouthamr) | |
| 11:25:49 | sean-k-mooney | ah ok is that by configuing http_proxy ? or something else? | |
| 11:26:09 | sean-k-mooney | we have a generic setup mirrors role in the openstack-ci-jobs repo i think | |
| 11:26:23 | sean-k-mooney | i kind of assumed that also configured the http proxies | |
| 11:27:14 | frickler | there was some discussion about this in some other channel last week, iirc that work never completed. but kolla does somehow use that proxy already | |
| 11:27:15 | sean-k-mooney | ah i was thinking of https://github.com/openstack/openstack-zuul-jobs/tree/master/roles but i guess the morrior setup is in the generic zuul-jobs repo | |
| 11:28:00 | gibi | sorry for the mixup | |
| 11:28:58 | sean-k-mooney | i guess that does not handel the systm proxies | |
| 11:29:00 | sean-k-mooney | https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/configure-mirrors/defaults/main.yaml | |
| 11:30:09 | frickler | sean-k-mooney: yes, afaict this is still missing for general zuul jobs. cf. https://opendev.org/openstack/kolla-ansible/src/branch/master/tests/templates/globals-default.j2#L82-L88 | |
| 11:30:40 | sean-k-mooney | so that could be a good change to put in the base devstack job | |
| 11:30:58 | sean-k-mooney | do we know why that has not been done before? | |
| 11:32:05 | sean-k-mooney | oh this is doing it via explicly using a difent registry | |
| 11:32:06 | frickler | sean-k-mooney: iiuc this was started by some tripleo folks but never finished. https://meetings.opendev.org/irclogs/%23openstack-infra/%23openstack-infra.2024-08-21.log.html#t2024-08-21T11:06:16 was the discussion I was referring to | |
| 11:32:40 | sean-k-mooney | right i tought this might be settign the generic http proxy but its acatully podman/docker speciric config | |
| 11:33:16 | frickler | yes, we cannot do a generic proxy since we could not properly secure it | |
| 11:33:24 | sean-k-mooney | i think the kolla approch need to have all usage of podman be parmatiarised by the registry | |
| 11:33:46 | sean-k-mooney | so we would need to modify the ceph devstack plugin | |
| 11:33:49 | sean-k-mooney | but that should not be hard | |
| 11:34:43 | frickler | yes, I don't think podman is currently being used anywhere else in devstack? even when it was, that should not be a blocker | |
| 11:35:35 | sean-k-mooney | it might have been used for something else but we can always do it one plugin at a time | |
| 11:35:58 | sean-k-mooney | i dont think we use it in core devstack | |
| 11:41:34 | opendevreview | Balazs Gibizer proposed openstack/nova stable/2024.1: hardware: Correct log https://review.opendev.org/c/openstack/nova/+/927110 | |
| 11:50:14 | sean-k-mooney | frickler: looks like we can either configure a mirror which will take precidnece and then fall back or we can remap prefixes | |
| 11:50:18 | sean-k-mooney | https://www.redhat.com/sysadmin/manage-container-registries | |
| 11:50:53 | sean-k-mooney | i think the mirror approch is prefered as it will try the direct connection if the mirror does not work | |
| 11:51:22 | sean-k-mooney | i can see if i can find time to code that up in core devstack | |
| 14:22:11 | opendevreview | Dan Smith proposed openstack/nova master: Use format_inspector from oslo https://review.opendev.org/c/openstack/nova/+/925025 | |
| 14:55:59 | opendevreview | ribaudr proposed openstack/nova master: Use client token when talking to manila https://review.opendev.org/c/openstack/nova/+/925277 | |
| 14:55:59 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 14:56:00 | opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | |
| 14:56:00 | opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | |
| 14:56:01 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 14:56:01 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 14:56:02 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 14:56:03 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 14:56:03 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 14:56:05 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 14:56:05 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares https://review.opendev.org/c/openstack/nova/+/860287 | |
| 14:56:07 | opendevreview | ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862 | |
| 14:56:07 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (compute manager) https://review.opendev.org/c/openstack/nova/+/885751 | |
| 14:56:09 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 14:56:09 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753 | |
| 14:56:11 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 14:56:11 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 14:56:13 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 14:56:13 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 14:56:15 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 14:56:15 | opendevreview | ribaudr proposed openstack/nova master: Reports instance events to the DB regarding attaching and detaching a share https://review.opendev.org/c/openstack/nova/+/927088 | |
| 14:56:17 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 14:56:17 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 14:56:19 | opendevreview | ribaudr proposed openstack/nova master: Docs about Manila shares API usage https://review.opendev.org/c/openstack/nova/+/871642 | |
| 15:10:04 | dansmith | bauzas: hopefully this will be quick, but here's the patch to deprecate AMI as we discussed.. people wanted to wait for you to return/approve: https://review.opendev.org/c/openstack/nova/+/926144 | |
| 15:10:30 | bauzas | dansmith: all good, will look at it now | |
| 16:48:16 | sean-k-mooney | gibi: so as i was saying in the qa channel thanks for the reivews. i wonder wich is a higher priority to make progress on the healthch code or the eventlet removal | |
| 16:48:54 | sean-k-mooney | i put the healthcheck partly on top of the eventlet serise to avoid a merge conflcit but perhaps i should split them | |
| 16:49:21 | sean-k-mooney | im not convince we will have time to merge both or either of them so im open to input on which to proceed with first | |
| 16:58:13 | melwitt | sean-k-mooney: I just looked at the review comments you mention and yeah, that's the same conclusion that was reached with my patch is that there is no way to cancel a native thread (from the main thread). so it's either let it keep running (and assume it exits on its own eventually) or switch to processes. or like you said somehow run a timer in the child thread to exception exit itself, if there is a way we can do that | |
| 16:59:02 | sean-k-mooney | we might be able to do that with funtools.partil and have it create a time before callign the orginal funciton | |
| 16:59:06 | melwitt | the code as-is in the patch will just move on after the timer expires and leave the worker thread | |
| 16:59:10 | sean-k-mooney | but that feels even more hacky | |
| 16:59:48 | sean-k-mooney | i could use a process pool but that feels a bit heavy weight. if people are ok with that its easy to do i think | |
| 17:00:08 | sean-k-mooney | process pools are ok provide the funciton does not try to modify any shared sate | |
| 17:00:35 | sean-k-mooney | i dont think this code does but thats somethign we would need to be careful of | |
| 17:00:44 | melwitt | yeah. with my patch the review just kept going around in circles with nobody happy with anything so I hopefully you will have better luck | |
| 17:01:13 | sean-k-mooney | im feelign like i might be better off moving that patch to later in the series | |
| 17:01:52 | sean-k-mooney | however i see value in makeing the api eventlet free first | |
| 17:02:08 | sean-k-mooney | since otherwise its the simplest service to do that with | |
| 19:17:50 | opendevreview | melanie witt proposed openstack/nova master: DNM testing https://review.opendev.org/c/openstack/nova/+/925635 | |
| 19:19:19 | opendevreview | melanie witt proposed openstack/nova master: DNM testing https://review.opendev.org/c/openstack/nova/+/925635 | |
| 19:20:54 | sean-k-mooney | melwitt: by the way this is somehting i was playing with https://github.com/SeanMooney/os-vol | |
| 19:30:08 | melwitt | sean-k-mooney: that is very different :) | |
| 19:30:21 | sean-k-mooney | yep kind of intentionally | |
| 19:30:57 | sean-k-mooney | i was playing with the idea of storage backends abstracting how the storage is provisioned and allocating volumed which are then consumed | |
| 19:31:31 | sean-k-mooney | with the connection between a volume and a backend indirect though a storage pool | |
| 19:32:07 | sean-k-mooney | so you would not create a file or rbd volume | |
| 19:32:21 | sean-k-mooney | you would ask the storage pool to allocate a volume of a given size from its backend | |
| 19:33:09 | sean-k-mooney | that volume object is the logical handel to the backing storage | |
| 19:33:25 | melwitt | hm ok | |
| 19:34:10 | sean-k-mooney | my idea was you could have multiple backend and have adaptor that can take data form diffen sources and import it into a volume | |
| 19:35:04 | sean-k-mooney | i have not really fleshed out the interface much as i said i was just playing with that desgin to see what it looked like | |
| 19:35:38 | melwitt | that's cool | |
| 19:36:45 | sean-k-mooney | im not saying you should not consinue with your experiments by the way, the design im going for might be overly generic for what we want | |
| 19:37:09 | sean-k-mooney | on the other hand i kind of like the idea of having this in a self contianed lib or module with a stict inteface | |
| 19:37:58 | sean-k-mooney | the reason i have host_attach in the interafce for example is so we can allocate a file (lvm volume, rbd volume) | |
| 19:38:09 | sean-k-mooney | attach it to the host | |
| 19:38:17 | sean-k-mooney | call makefs on it and unmount it | |