| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-08-20 | |||
| 10:24:35 | sean-k-mooney | so the quest is was that tempest | |
| 10:24:50 | sean-k-mooney | it proably was but we can check the request id | |
| 10:25:18 | ralonsoh | yes | |
| 10:25:19 | ralonsoh | 2024-08-19 12:41:15.096 87668 INFO tempest.lib.common.rest_client [req-54123910-92d9-491b-b845-f8e7d37490dd req-54123910-92d9-491b-b845-f8e7d37490dd ] Request (StatefulNetworkSecGroupTest:_run_cleanups): 204 DELETE https://149.202.166.120/compute/v2.1/servers/4623b509-a848-41a4-9fc2-1cf8227bd4ca 0.147s | |
| 10:25:30 | ralonsoh | I didn't find it before... | |
| 10:25:50 | ralonsoh | sean-k-mooney, thanks a lot!! | |
| 10:26:18 | sean-k-mooney | well that proablju just the test cleanup | |
| 10:26:26 | sean-k-mooney | it does not tells use why it decied to do that | |
| 10:26:34 | sean-k-mooney | but im guessing there is a timeout or something | |
| 10:26:37 | ralonsoh | yes, now I need to know why the test is failing | |
| 10:26:48 | ralonsoh | I see the SSH is working | |
| 10:28:12 | sean-k-mooney | and your not expecting too? | |
| 10:28:24 | ralonsoh | no, that' | |
| 10:28:37 | ralonsoh | that's ok, but the test (ping) is working, and should not | |
| 10:28:52 | ralonsoh | add SG rule -> ping; remove SG rule -> no ping | |
| 10:29:18 | sean-k-mooney | so i think for ml2/ovs we alwasy allow icmp but i might be mistaken | |
| 10:29:38 | sean-k-mooney | ovn, iptables and the ovs security group driver do have some diffent behaivor | |
| 10:30:05 | sean-k-mooney | although maybing im thinkign of arp not icmp | |
| 10:30:36 | sean-k-mooney | is the test stopping the ping when it removes the rule | |
| 10:30:45 | sean-k-mooney | it could be related to contrack | |
| 10:30:56 | ralonsoh | sorry, not ping but nc command | |
| 10:31:26 | sean-k-mooney | :) ok agian it could be related to contrack i dont think we terminate established connections | |
| 12:49:56 | sean-k-mooney | mikal: https://review.opendev.org/c/openstack/nova/+/926126 is correct although dansmith for valid reasons prefer we now split this type of change into 2 commits 1 for the object change and 1 for the driver change. | |
| 13:26:31 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with stateless firmware https://review.opendev.org/c/openstack/nova/+/908890 | |
| 13:29:59 | tkajinam | sean-k-mooney, I've added functional test coverage but I'm struggling to understand why rebuild test fails... I'll dig into it further but it'd be really appreciated if you can take a look to find out what I've overlooked. | |
| 13:30:29 | tkajinam | also there is a bit tricky problem with assertion in live migration. I've summarized it (as well as the problem with rescue) so it'd be nice if you can check it when you have time | |
| 13:36:11 | sean-k-mooney | tkajinam: if i can find time to run it locally ill try and do that | |
| 13:36:34 | tkajinam | sean-k-mooney, thx | |
| 13:36:46 | sean-k-mooney | tkajinam: we have test helper for rebuild by the way adn some of the other actions | |
| 13:36:53 | sean-k-mooney | so you shoudl not need to do a raw post | |
| 13:37:31 | tkajinam | ah, ok. let me find these. I found these bare posts in a few other test files but we can probably replace these, too | |
| 13:37:41 | tkajinam | (in a separate follow-up | |
| 13:37:47 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/functional/integrated_helpers.py#L550 | |
| 13:38:07 | sean-k-mooney | most of the actions shoudl be there and if you need a new one you should just ad it ther | |
| 13:38:35 | sean-k-mooney | thats not yoru issue but just good to know they exist to aovid code duplication | |
| 13:40:03 | sean-k-mooney | OS-DCF:diskConfig is not generaly requrie by the way and it default to auto which iswhy we dont actully set it today | |
| 13:41:27 | sean-k-mooney | oh hehe | |
| 13:41:45 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/908890/15/nova/tests/functional/libvirt/test_stateless_firmware.py#246 | |
| 13:42:00 | sean-k-mooney | tkajinam: your not using the updated server object | |
| 13:42:29 | sean-k-mooney | oh your passing the id and doing the db lookup | |
| 13:42:38 | sean-k-mooney | internally | |
| 13:43:32 | sean-k-mooney | but you rusing self.guest_configs[server_id].os_loader_stateless | |
| 13:43:59 | sean-k-mooney | so i wonder if that has stale info | |
| 13:45:11 | tkajinam | sean-k-mooney, I'm fixing it now. However the current blocker appears in the rescue API call so that line is not related | |
| 13:45:32 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with stateless firmware https://review.opendev.org/c/openstack/nova/+/908890 | |
| 13:46:29 | sean-k-mooney | ok so rescue is your main consern https://review.opendev.org/c/openstack/nova/+/908890/16/nova/tests/functional/libvirt/test_stateless_firmware.py#208 | |
| 13:46:40 | sean-k-mooney | ill quickly pull that review and see what happens locally | |
| 14:09:30 | sean-k-mooney | tkajinam: so rescue is failing beucase the test is tryign to open the unrescue_xml_path i.e. its tryign to write to disk | |
| 14:09:53 | sean-k-mooney | tkajinam: so there is a missing mock somewhere | |
| 14:10:02 | sean-k-mooney | https://paste.opendev.org/show/bCsw4SkPFosMTi0pL4yd/ | |
| 14:13:21 | tkajinam | I was wondering why that instance directory is not created but it might be because fake libvirt driver is used. hmm... there are no rescue functional tests with fake libvirt driver now so I may need to look into additional mocking to make the process pass | |
| 14:14:48 | sean-k-mooney | there are https://github.com/openstack/nova/blob/0b091179d575a5e7cff9cd76223a8016cfbbc019/nova/tests/functional/libvirt/test_rescue_deleted_base.py | |
| 14:15:10 | sean-k-mooney | but but its doing https://github.com/openstack/nova/blob/0b091179d575a5e7cff9cd76223a8016cfbbc019/nova/tests/functional/libvirt/test_rescue_deleted_base.py#L48-L57 | |
| 14:15:20 | tkajinam | ahhh | |
| 14:17:31 | sean-k-mooney | if i add that | |
| 14:17:47 | sean-k-mooney | then it fails with https://paste.opendev.org/show/bLajZLL1mJueSgMkPNAQ/ | |
| 14:18:00 | sean-k-mooney | but that might just be an issue with the assert | |
| 14:18:29 | tkajinam | yeah. rescue uses the image without stateless firmware so that assertion is wrong | |
| 14:19:08 | sean-k-mooney | ok well i trust you can figure out how to fix that | |
| 14:19:19 | sean-k-mooney | ill quickly look at why the live migration test is failing | |
| 14:19:50 | sean-k-mooney | TypeError: Can't upgrade a READER transaction to a WRITER mid-transaction | |
| 14:20:02 | sean-k-mooney | that od | |
| 14:21:03 | sean-k-mooney | i feel like you just missing the migration stub or soemthign liek that | |
| 14:21:37 | sean-k-mooney | no you have the corret mixin | |
| 14:24:03 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with stateless firmware https://review.opendev.org/c/openstack/nova/+/908890 | |
| 14:25:25 | tkajinam | sean-k-mooney, sorry but where did you find that type error ? | |
| 14:26:44 | tkajinam | the remaining problem with live migration tests is that the xml content generated by fake libvirt driver does not contain any loader related fields and it's not possible to assert that these fields are passed in destination_xml. https://github.com/openstack/nova/blob/0b091179d575a5e7cff9cd76223a8016cfbbc019/nova/tests/fixtures/libvirt.py#L1565-L1568 | |
| 14:27:10 | sean-k-mooney | im running it in an IDE but you can get it to print by adding OS_DEBUG=1 to your tox command | |
| 14:27:45 | tkajinam | I can technically extend the implementation to simulate more detailed behavior but I'm inclined to look into whitebox tests instead of importing more libvirt's behaviors into that fixture | |
| 14:27:48 | tkajinam | ah, ok | |
| 14:30:56 | sean-k-mooney | oh weird | |
| 14:31:03 | sean-k-mooney | ok it passes if i run it with stestr | |
| 14:31:41 | sean-k-mooney | i.e. OS_DEBUG=1 stestr --test-path=./nova/tests/functional run -- LibvirtStatelessFirmwareTest.test_live_migrate_server | |
| 14:34:38 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with stateless firmware https://review.opendev.org/c/openstack/nova/+/908890 | |
| 14:35:33 | sean-k-mooney | so that test only fails when i run it form my ide which might be related to how im runing it since im not using stestr and i kind of hacked it to work | |
| 14:36:12 | tkajinam | yeah | |
| 14:36:13 | tkajinam | https://paste.opendev.org/show/bsFDSlO0e6ZaLcsTFX2g/ | |
| 14:36:22 | tkajinam | at least that test passes in my env with OS_DEBUG=1 | |
| 14:36:53 | sean-k-mooney | if it passes in ci thats the main thing | |
| 14:36:59 | sean-k-mooney | ill test v18 now | |
| 14:37:27 | sean-k-mooney | cool all 8 pass under stestr | |
| 14:40:42 | sean-k-mooney | i didnt run all the funcitonal tests but all the libvirt ones pass locally | |
| 14:41:14 | sean-k-mooney | im goig to grab a drink but ill take a look at the current version when i get back | |
| 14:44:35 | tkajinam | sean-k-mooney, thanks... I've added a few comments to explain a few context behind current test coverage which hopefully helps that review... | |
| 15:31:12 | sean-k-mooney | some of those comments are incorrect. in general i think most of the real code changes look correct and the unit test coverage is fine | |
| 15:31:31 | sean-k-mooney | i think the functiontional coverage can be impvoed but its reasonably close | |
| 15:31:45 | sean-k-mooney | to what we woudl need to merge this | |
| 17:12:05 | opendevreview | Masahito Muroi proposed openstack/nova master: Use boot_roles_count and boot_role_ |
|
| 21:49:31 | opendevreview | melanie witt proposed openstack/nova master: Fix deepcopy usage for BlockDeviceMapping in get_root_info https://review.opendev.org/c/openstack/nova/+/920374 | |
| #openstack-nova - 2024-08-21 | |||
| 00:19:29 | mikal | sean-k-mooney: how do I delineate what is the object change vs everything else? For example for https://review.opendev.org/c/openstack/nova/+/924844 are we literally saying just pull the nova/objects/console_auth_token.py bit and associated tests out into its own change? | |
| 00:21:08 | sean-k-mooney[m] | yep more or less jut that and the test | |
| 00:21:45 | sean-k-mooney[m] | normally also the notificaotn object change | |
| 00:21:58 | sean-k-mooney[m] | but in this case you dont have a notifiction object change | |
| 00:23:33 | sean-k-mooney[m] | as i said this is really 3 patches in one. im not genrally against that but its an object change followed by the db change followed by the rest | |
| 01:19:23 | mikal | sean-k-mooney: I can give that a go... I'll start with the nova console change instead of the extra spec one I think though. Give me a day or two. | |
| 01:52:29 | opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Launch instances with stateless firmware https://review.opendev.org/c/openstack/nova/+/908890 | |
| 02:33:28 | opendevreview | Merged openstack/nova master: Fix deepcopy usage for BlockDeviceMapping in get_root_info https://review.opendev.org/c/openstack/nova/+/920374 | |
| 03:41:22 | opendevreview | Zhang Hua proposed openstack/nova stable/2024.1: Fix deepcopy usage for BlockDeviceMapping in get_root_info https://review.opendev.org/c/openstack/nova/+/926696 | |
| 03:44:02 | opendevreview | Zhang Hua proposed openstack/nova stable/2023.2: Fix deepcopy usage for BlockDeviceMapping in get_root_info https://review.opendev.org/c/openstack/nova/+/926697 | |
| 03:46:29 | opendevreview | Zhang Hua proposed openstack/nova stable/2023.1: Fix deepcopy usage for BlockDeviceMapping in get_root_info https://review.opendev.org/c/openstack/nova/+/926698 | |