| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-08-06 | |||
| 13:21:03 | sean-k-mooney | so https://bugs.launchpad.net/nova/+bug/2040986 is partly valid. the request spec shoudl not have the property for iamge b | |
| 13:21:06 | sean-k-mooney | when it faild | |
| 13:21:23 | sean-k-mooney | but the issue is not that we dont revert request spec content | |
| 13:21:33 | sean-k-mooney | it shoudl not have been updated unless it passed the schduler | |
| 13:22:15 | sean-k-mooney | fixing the issue in the excpt class is invliad as propsoed because its trying to use the info form glance and not corm the cell db copy | |
| 13:22:32 | jlejeune | yes we are treating the symthom and not the bug itself, agree about that | |
| 13:22:37 | sean-k-mooney | ideally we woudl fix the orginal issue by not saving the modifed request spec until after the schduler says its ok | |
| 13:23:44 | sean-k-mooney | jlejeune: back to the procedure topic the first step in fixing the bug should be to create a functional regression test for the bug to demonstarte the incorrect behaivor | |
| 13:24:54 | sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1732947.py and https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_2040264.py are two examples of rebuidl regression tests for past bugs | |
| 13:25:48 | sean-k-mooney | https://github.com/openstack/nova/commit/21fd0c430c714d21c52e0a0c996351c374a3e3d6 and https://github.com/openstack/nova/commit/ee9ed0f7c6abf7c4847e6dc31f6d3d79b25b9d99 | |
| 13:25:55 | sean-k-mooney | demontrate the standard pattern | |
| 13:41:04 | jlejeune | are the regression tests are always mandatory ? because I see a lot of changes without them | |
| 13:45:02 | artom | jlejeune, strongly encouraged when fixing bugs. Our so-called "functional" tests are advanced enough that most bugs, even races, can be reproduced with them, with judicious use of stubs or mocks. The accepted standard practice is to first demonstrate the bug in a functional test, then with the patch on top demonstrate that the fix does what it's supposed to. | |
| 13:45:28 | artom | jlejeune, other than that, regression tests are not mandatory (and even for bug fixes there can be exceptions, depending on the nature of the bug). | |
| 13:47:24 | sean-k-mooney | jlejeune: we dont always requrie a funcitonal repoducer sometime unit test repoducer are also fine but for anyting like rebuild or an change that is not targeted to a very speciifc part of code i.e. the xml generation or logging its almost alwayys requried | |
| 13:51:12 | jlejeune | ok so in that case, I need to ? | |
| 13:52:12 | sean-k-mooney | yes in this case you are trying to fix an issue that hapens as a result of multipel api action and an interaction betwwen the conductor and schduler resulting in incositenies betwwen two dbs | |
| 13:52:31 | sean-k-mooney | that is not somethign that unit tests are sufficent to demondatate | |
| 13:52:43 | sean-k-mooney | so we woudl generally requrie a fucntioanl repoducer test | |
| 13:53:01 | jlejeune | ok | |
| 13:54:31 | sean-k-mooney | this is a littel out of date but this is where that was orignally documented https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/README.rst#tests-for-specific-regressions | |
| 13:54:56 | sean-k-mooney | the bit that is a littel out of date is "These should be full stack tests which inherit from nova.test.TestCase directly." | |
| 13:55:04 | sean-k-mooney | that is still prefered but not required anymore | |
| 13:55:32 | sean-k-mooney | it can be a heavy lift to set up all the fixtures unless you are deeply familar with how our test work | |
| 13:56:15 | opendevreview | Artom Lifshitz proposed openstack/nova master: POC/DNM: Remove vTPM live migration block https://review.opendev.org/c/openstack/nova/+/925771 | |
| 13:56:25 | sean-k-mooney | so we do allow inheriting form ntegrated_helpers._IntegratedTestBase | |
| 13:56:55 | sean-k-mooney | as is done in https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1732947.py | |
| 13:57:45 | sean-k-mooney | or sometimes even the libvirt specific vairiant however if its not virt driver specific we avoid using the more complex base classes | |
| 13:59:26 | jlejeune | ok I will try | |
| 14:11:25 | jlejeune | artom: sean-k-mooney: and what about that one: https://review.opendev.org/c/openstack/nova/+/901655 ? | |
| 14:13:01 | artom | jlejeune, IMO that's simple enough to not need a reproducer. | |
| 14:13:44 | sean-k-mooney | that ism more incliend to say is a valid bug but on the other hand im not eintrly sure its safe to not mark the instnace as in error | |
| 14:14:27 | sean-k-mooney | if the rpc timeout happens in pre live migrate i agree the instance should stay in active | |
| 14:14:34 | sean-k-mooney | and only the migration should be in error | |
| 14:15:26 | sean-k-mooney | so https://review.opendev.org/c/openstack/nova/+/901655/4/nova/compute/manager.py i think is the correct approch in this case | |
| 14:16:13 | sean-k-mooney | if the rpc timeout happesn after we have started the migration its get harder | |
| 14:17:47 | sean-k-mooney | jlejeune: i woudl prefer ot have a fucntioal repoducer for that too | |
| 14:18:04 | sean-k-mooney | but i think the way its being fixed is generally ok | |
| 15:45:15 | gibi | nova meeting starts here in 15 minutes | |
| 15:55:03 | opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | |
| 16:00:48 | gibi | #startmeeting nova | |
| 16:00:48 | opendevmeet | Meeting started Tue Aug 6 16:00:48 2024 UTC and is due to finish in 60 minutes. The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:48 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:48 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:55 | elodilles | o/ | |
| 16:01:03 | gibi | I will be your host today as bauzas is on PTO | |
| 16:01:10 | dansmith | o/ | |
| 16:02:18 | gibi | #topic Bugs (stuck/critical) | |
| 16:02:20 | tkajinam | o/ | |
| 16:02:25 | gibi | #info No Critical bug | |
| 16:02:39 | gibi | is there any bug that we need to discuss? | |
| 16:03:27 | gibi | #topic Gate status | |
| 16:03:33 | gibi | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | |
| 16:03:39 | gibi | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | |
| 16:03:46 | gibi | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | |
| 16:04:14 | gibi | centos 9 based jobs are still read | |
| 16:04:16 | gibi | red | |
| 16:04:30 | gibi | due to | |
| 16:04:31 | gibi | Failed to enable unit: Unit file rabbitmq-server.service does not exist. | |
| 16:04:42 | dansmith | so some work was done in devstack recently, | |
| 16:05:07 | dansmith | related to the release repo, which I thought was going to fix some of it | |
| 16:05:12 | dansmith | rocky started working at least | |
| 16:05:40 | dansmith | but it was also (re-)asserted that stream is making it clear it's not stable enough for our purposes, which I definitely agree with :) | |
| 16:06:42 | dansmith | https://review.opendev.org/c/openstack/devstack/+/925368?tab=change-view-tab-header-zuul-results-summary | |
| 16:07:21 | gibi | thank dansmith for the pointers | |
| 16:08:02 | gibi | If somebody has the time to investigate further then go for it. :) | |
| 16:08:40 | gibi | but I guess as it is not blocking the CI directly it will take a while to get to it | |
| 16:09:21 | gibi | anything else about the centos jobs or about the gate in general? | |
| 16:10:06 | gibi | #topic Release Planning | |
| 16:10:20 | gibi | #link https://releases.openstack.org/dalmatian/schedule.html | |
| 16:10:31 | gibi | #info Dalmatian-3 in 3 weeks | |
| 16:10:44 | gibi | #topic Review priorities | |
| 16:10:49 | gibi | #link https://etherpad.opendev.org/p/nova-dalmatian-status | |
| 16:11:07 | gibi | Is there anything to discuss about the upcoming release? | |
| 16:12:07 | tkajinam | there is one open follow-up edit of the spec. would be nice if it can be quickly reviewed https://review.opendev.org/c/openstack/nova-specs/+/924563 | |
| 16:12:36 | gibi | tkajinam: I will look at it after the meeting | |
| 16:12:48 | tkajinam | gibi, thx ! | |
| 16:13:33 | gibi | #topic Stable Branches | |
| 16:13:42 | gibi | elodilles: hi! :) | |
| 16:13:45 | elodilles | o/ | |
| 16:13:50 | elodilles | #info stable/202*.* gates seem to be OK | |
| 16:14:03 | elodilles | #info nova stable release patches (with CVE fix): https://review.opendev.org/q/project:openstack/releases+intopic:nova+is:open | |
| 16:14:18 | sean-k-mooney | dansmith: it may be worth condiering if the fibs jobs could move to rocky to be slightly more stable but ya i still agree in general. we can discusus that later if peopel want to do that work outside the meeting or in open dicussion at the end | |
| 16:14:22 | elodilles | waiting for release liaison reviews ^^^ o:) | |
| 16:14:37 | gibi | bauzas and Uggla are on PTO | |
| 16:14:48 | elodilles | gibi: ACK | |
| 16:14:57 | sean-k-mooney | amit is also a release liason | |
| 16:15:05 | dansmith | sean-k-mooney: yep | |
| 16:15:17 | elodilles | then auniyal is the only available release liaison o:) | |
| 16:15:19 | sean-k-mooney | auniyal: ^ can you prioitse that | |
| 16:15:48 | elodilles | thanks in advance o:) | |
| 16:15:56 | elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | |
| 16:16:22 | elodilles | if anyone finds any gate issue then please add it there ^^^ | |
| 16:16:35 | elodilles | that's all about stable from me | |
| 16:17:01 | gibi | elodilles: thanks! | |
| 16:17:08 | elodilles | np | |
| 16:17:16 | gibi | #topic vmwareapi 3rd-party CI efforts Highlights | |
| 16:17:20 | gibi | #info fwiesel on PTO until the 27th August. | |
| 16:17:33 | gibi | so I guess no news here | |
| 16:17:39 | gibi | #topic Open discussion | |