| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-07-30 | |||
| 15:05:26 | elodilles | clarkb: i see, then it's an other issue. of course in that case probably this is the best workaround | |
| 15:12:27 | jlejeune | sean-k-mooney: something like that : https://review.opendev.org/c/openstack/nova/+/925208 ? | |
| 15:17:32 | elodilles | melwitt dansmith : sorry for pinging you, but when you have some time, could you please review these two fix for the cherry-pick-validator script? o:) https://review.opendev.org/c/openstack/nova/+/924104 and https://review.opendev.org/c/openstack/nova/+/924103 | |
| 15:17:49 | sean-k-mooney | jlejeune: that might be too low level | |
| 15:36:35 | bauzas | reminder: nova meeting in 24 mins here | |
| 15:39:05 | jlejeune | sean-k-mooney: you're tlaking about the mock over processutils.execute() function ? | |
| 15:40:00 | sean-k-mooney | so that test shoudl not be doign image inspection really | |
| 15:40:47 | jlejeune | ok so I need to mock create_image() and extract_snapshot() methods ? | |
| 15:42:48 | sean-k-mooney | this is ment to test https://github.com/openstack/nova/blob/7a7427691e0bd4818bb7a2c5f5371e0244addbbb/nova/virt/driver.py#L757C9-L757C17 | |
| 15:42:55 | sean-k-mooney | using the fake driver | |
| 15:43:18 | sean-k-mooney | so https://github.com/openstack/nova/blob/master/nova/virt/fake.py#L213-L216 | |
| 15:43:59 | sean-k-mooney | however it seam like we are using the libvirt fixutre in theses tests instead | |
| 15:45:44 | sean-k-mooney | in the libvirt driver its calling https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3122 | |
| 15:46:30 | jlejeune | yes | |
| 15:46:38 | sean-k-mooney | we are now intereally callign the image inspection code in that datapaht | |
| 15:46:42 | sean-k-mooney | we sould not be | |
| 15:46:47 | sean-k-mooney | in this thest | |
| 15:46:51 | sean-k-mooney | *test | |
| 15:47:01 | sean-k-mooney | so that is pointing to a gap in the fixutre | |
| 15:47:23 | sean-k-mooney | do you have a traceback of how this failed? | |
| 15:47:46 | jlejeune | here: https://bugs.launchpad.net/nova/+bug/2075178 | |
| 15:50:55 | sean-k-mooney | ok so libvirt_utils.create_image shoudl be stubbed here and should not be callign qemu-img | |
| 15:53:08 | sean-k-mooney | jlejeune: so we need to fix this in https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/test_virt_drivers.py#L817 | |
| 15:53:38 | sean-k-mooney | that subcalses shoudl be stubing the call to create image | |
| 15:53:41 | jlejeune | by adding a new stub | |
| 15:54:08 | jlejeune | ok because I've mocked that function in my ongoing patchset, but I will update it to stub the call instead | |
| 15:54:22 | sean-k-mooney | you are doing it in the wrong place | |
| 15:54:38 | sean-k-mooney | your doing it in the share test function that is used acrros several virt drivers | |
| 15:54:55 | sean-k-mooney | you need to do it in the libvirt specific class that inherits form it | |
| 15:55:16 | jlejeune | ok, ok, I didn't yet pushed it actually | |
| 15:55:35 | jlejeune | I will do it tomorrow, I must leave right now | |
| 15:55:37 | sean-k-mooney | in the bug we see its nova.tests.unit.virt.test_virt_drivers.LibvirtConnTestCase.test_snapshot_running | |
| 15:55:54 | jlejeune | ok I see | |
| 15:55:54 | sean-k-mooney | that is failing so we need to stub it form LibvirtConnTestCase class | |
| 15:56:03 | jlejeune | ok I get it | |
| 15:56:05 | jlejeune | thanks | |
| 15:56:37 | jlejeune | will do it tomoroww, see you | |
| 15:58:48 | sean-k-mooney | dansmith: you might have some insight into what exactly might have changed to cause https://bugs.launchpad.net/nova/+bug/2075178 | |
| 15:59:11 | sean-k-mooney | you mentioned seeing some NotImplementedError in the tests | |
| 15:59:46 | dansmith | I think that's because we call qemu-img in those paths but didn't before right? | |
| 15:59:46 | sean-k-mooney | i had taught we have a poison fixtreure in our tests that prevented all calls to qemu like the libivrt one but perhaps imagined that. | |
| 15:59:54 | sean-k-mooney | yep | |
| 16:00:03 | sean-k-mooney | well yes and no | |
| 16:00:03 | dansmith | not sure if that's comprehensive enough | |
| 16:00:14 | bauzas | #startmeeting nova | |
| 16:00:14 | opendevmeet | Meeting started Tue Jul 30 16:00:14 2024 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:14 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:14 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:15 | sean-k-mooney | we clearly are based on the failure | |
| 16:00:23 | sean-k-mooney | ah lest talk about this after the meeting | |
| 16:00:23 | bauzas | hey folks | |
| 16:00:34 | bauzas | let's do a short meeting if you want | |
| 16:00:55 | bauzas | https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 16:01:01 | bauzas | doh | |
| 16:01:22 | bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 16:01:22 | bauzas | who's around ? | |
| 16:01:22 | elodilles | o/ | |
| 16:01:26 | dansmith | o/ | |
| 16:01:30 | auniyal | o/ | |
| 16:01:56 | bauzas | let's start | |
| 16:02:04 | bauzas | #topic Bugs (stuck/critical) | |
| 16:02:09 | bauzas | #info No Critical bug | |
| 16:02:15 | bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | |
| 16:02:22 | bauzas | anything people want to talk about bugs ? | |
| 16:03:18 | bauzas | looks nothing | |
| 16:03:24 | bauzas | #topic Gate status | |
| 16:03:29 | bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | |
| 16:03:34 | bauzas | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | |
| 16:03:38 | bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | |
| 16:03:41 | bauzas | #info centos9 jobs seem b0rked | |
| 16:03:47 | bauzas | #info centos9 jobs seem b0rked | |
| 16:04:26 | bauzas | same issue for all of them | |
| 16:04:32 | bauzas | Failed to enable unit: Unit file rabbitmq-server.service does not exist. | |
| 16:04:43 | bauzas | I guess a launchpad bug exists for devstack | |
| 16:05:33 | dansmith | maybe they renamed the service or something? | |
| 16:05:47 | dansmith | but, further support for my feeling that stream is not stable enough for us to run tests on :) | |
| 16:06:09 | bauzas | fun fact : apparently no devstack bug report already exists for that issue | |
| 16:06:51 | sean-k-mooney | ya its posible it was renamed | |
| 16:06:56 | sean-k-mooney | im not sure how much we care | |
| 16:07:02 | sean-k-mooney | althoguh its goign to break the fips job | |
| 16:07:07 | bauzas | yeah that's the most possible one | |
| 16:07:08 | sean-k-mooney | thats the only thing that uses it | |
| 16:07:18 | bauzas | it already broke the fips one | |
| 16:07:35 | bauzas | https://zuul.openstack.org/build/1e22dd2615f14f2ea29f34575b822471 | |
| 16:07:53 | sean-k-mooney | it might be good to highlight this to our downstream secuirty folks | |
| 16:08:02 | bauzas | we also run periodic jobs on centos9 for integrated compute | |
| 16:08:04 | sean-k-mooney | althoufu if you have tiem to debug it im sure they would be happy for the help | |
| 16:08:32 | bauzas | I'll just create the devstack bug | |
| 16:08:39 | sean-k-mooney | ack | |
| 16:09:16 | bauzas | and then I could ping folks, but given I'll disappear for 3.1 weeks on Thursday I will wait for other folks | |
| 16:10:15 | bauzas | anyway, moving on | |
| 16:10:22 | bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | |
| 16:10:27 | bauzas | #info Please try to provide meaningful comment when you recheck | |
| 16:10:32 | bauzas | #topic Release Planning | |
| 16:10:37 | bauzas | #link https://releases.openstack.org/dalmatian/schedule.html | |
| 16:10:41 | bauzas | #info Dalmatian-3 in 4 weeks | |
| 16:10:47 | bauzas | #topic Review priorities | |
| 16:10:56 | bauzas | #link https://etherpad.opendev.org/p/nova-dalmatian-status | |
| 16:11:14 | bauzas | I need to modify this etherpad ^ | |
| 16:11:28 | bauzas | to verify which changes are now merged | |