Earlier  
Posted Nick Remark
#openstack-nova - 2024-07-05
16:59:56 sean-k-mooney we said it was proably too complex and out of scope of nova but that was also like 6 years ago so thngs have changes somewhat
17:00:18 sean-k-mooney the last time we really talks about this properly was pre/start of the pandmeic
17:00:51 sean-k-mooney mnaser: there is a request ot do az anti affinty this/last cycle
17:01:28 sean-k-mooney in generally i woul dnot be agsint this in principal. it just would not be high on my list of thing to do next
17:01:28 mnaser working in this case, it feels odd to have 1 az per rack
17:01:50 mnaser like that feels like its brute forcing the az feature if you're on rack level
17:01:52 sean-k-mooney az's are just named aggreates
17:02:37 mnaser yeah but I feel like in the perspective of a consumer of the cloud they might be like "oh isn't this like a azure/aws/etc az?"
17:03:08 sean-k-mooney and the answer to hell no
17:03:20 sean-k-mooney but i get that persective
17:03:42 sean-k-mooney so what i would say is we could and might want to make nova eand other services better able to supprot that usecase
17:03:57 mnaser cause like maybe it would be nice to be like.. this is an az .. but also you can have different fault domains
17:04:06 sean-k-mooney but i think we would need some feature in placment to do it effeictly
17:04:24 sean-k-mooney doing it in a filter or weigher would likely be slow an maybe buggy
17:05:40 sean-k-mooney im not saying we could not do it in nova alone but we would need to becareful with how we design it
17:05:44 fungi in retrospect it was probably a mistake to call them availability zones when the implementation wasn't equivalent to aws's az concept, because we've had to fight that confusion ever since, but it'd be hard to change now (i still refer to projects as tenants, after all)
17:06:35 sean-k-mooney nova still has instance_type and flavor depending on what your looking at
17:06:44 fungi indeed
17:07:20 sean-k-mooney so i think an aggerate groups feature is definlty doable and i like cpehs model
17:07:38 fungi we just missed rounding out the suite of renames with "color" and "texture" and maybe "odor"
17:07:48 sean-k-mooney i just feel like crambing that into the existing filters/weither might be sub optimal
17:09:04 sean-k-mooney im sure if we renamed flavors to Terroir it would confuse noone
17:23:45 mnaser sean-k-mooney: I think the path of least resistance is a filter that checks if there is a server group assigned, and a scheduler hint called `different_failure_domain` .. and that goes over host aggregates which have a `failure_domain` attribute and ensures that the hosts in the server group dont end up in that same host aggregate
17:24:51 sean-k-mooney mnaser: i really dont like schduler hits
17:24:58 sean-k-mooney btu thats an option
17:25:22 mnaser sean-k-mooney: could also use `rules` for server groups to have `different_failure_domain` too
17:25:29 opendevreview Dan Smith proposed openstack/nova master: Reproduce iso regression with deep format inspection https://review.opendev.org/c/openstack/nova/+/923507
17:25:29 opendevreview Dan Smith proposed openstack/nova master: Add iso file format inspector https://review.opendev.org/c/openstack/nova/+/923533
17:25:31 mnaser but that would mean an api change
17:25:34 sean-k-mooney server group/instance wawere filteres are some of the most ram/compute intesitve you can create
17:27:29 mnaser yeah
17:27:37 mnaser that is for sure going to be a busy one
17:28:17 mnaser im not sure if there's another approach
17:43:44 fungi 923287 failed out on nova-next and nova-multi-cell: https://zuul.opendev.org/t/openstack/buildset/0a50e0745e3e4759bf743b39208ed1dc
17:44:07 fungi i've reenqueued it and repromoted
18:02:10 opendevreview Dan Smith proposed openstack/nova master: Add iso file format inspector https://review.opendev.org/c/openstack/nova/+/923533
18:27:44 dansmith fungi: confirmed at least one of those was a guest kernel panic so obviously unrelated
18:28:03 fungi exciting!
18:28:25 fungi and good to know, thanks for taking a look
18:28:26 dansmith not really, we see guest kernel panics way too often :(
18:28:42 fungi yeah, my excitement was understated sarcasm really, sorry
18:28:49 dansmith heh, okay
18:29:48 fungi i've about worn out all other tools at my disposal, so sarcasm is what's left at this point
18:30:27 dansmith yeah, you don't have to apologize to me for that.. I'm beyond exhausted.. I dunno what's after that before death, maybe "acceptance" ?
18:51:31 opendevreview Pavlo Shchelokovskyy proposed openstack/nova master: Fix device type when booting from ISO image https://review.opendev.org/c/openstack/nova/+/909611
19:33:15 opendevreview Dan Smith proposed openstack/nova master: Add iso file format inspector https://review.opendev.org/c/openstack/nova/+/923533
19:54:58 opendevreview Merged openstack/nova stable/2023.2: Fix vmdk_allowed_types checking https://review.opendev.org/c/openstack/nova/+/923287
19:55:04 opendevreview Merged openstack/nova stable/2023.1: Check images with format_inspector for safety https://review.opendev.org/c/openstack/nova/+/923289
20:11:30 fungi 923290 hit a package install error, and that knocked out 923291 as a child commit. i'll get them both back into play but they're the only changes left from the ossa
20:13:42 fungi waiting to promote them to the front since there's a stack of 5 succeeding changes that are due to merge in the next 10 minutes
20:14:08 fungi but once those land i'll shuffle them up
20:27:34 fungi and done
22:31:56 opendevreview Merged openstack/nova stable/2023.1: Additional qemu safety checking on base images https://review.opendev.org/c/openstack/nova/+/923290
22:32:02 opendevreview Merged openstack/nova stable/2023.1: Fix vmdk_allowed_types checking https://review.opendev.org/c/openstack/nova/+/923291
22:32:05 fungi yay!!!
22:44:43 dansmith fungi: thanks for all your work, I didn't appreciate how much that would involve you and your clicky finger
22:45:14 fungi no worries, it was thoroughly calloused already
22:46:02 fungi (no actual clicking was done, unless you count the clickity-clack of my mechanical keyboard)
22:46:29 fungi like all real software, zuul has a proper cli
#openstack-nova - 2024-07-06
01:28:00 JayF hey, thanks to you both! and congratulations on getting the last of it landed
#openstack-nova - 2024-07-07
00:02:40 opendevreview Merged openstack/nova master: scheduler: fix _get_sharing_providers to support unlimited aggr https://review.opendev.org/c/openstack/nova/+/921665
01:00:47 opendevreview melanie witt proposed openstack/nova master: Consolidate vTPM and ephemeral encryption secret creation https://review.opendev.org/c/openstack/nova/+/912094
01:00:47 opendevreview melanie witt proposed openstack/nova master: libvirt: Add optional 'description' kwarg to create_secret() https://review.opendev.org/c/openstack/nova/+/919986
01:00:48 opendevreview melanie witt proposed openstack/nova master: Follow up for encryption secret create consolidation https://review.opendev.org/c/openstack/nova/+/921586
01:00:48 opendevreview melanie witt proposed openstack/nova master: Remove use of (hw:|hw_)ephemeral_encryption_format https://review.opendev.org/c/openstack/nova/+/921343
01:00:50 opendevreview melanie witt proposed openstack/nova master: Add EncryptDetails object for ephemeral encryption https://review.opendev.org/c/openstack/nova/+/921344
01:00:50 opendevreview melanie witt proposed openstack/nova master: Add database migration to ALTER encryption_options https://review.opendev.org/c/openstack/nova/+/921587
01:01:38 opendevreview melanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870932
01:01:41 opendevreview melanie witt proposed openstack/nova master: Validate key manager create access in API https://review.opendev.org/c/openstack/nova/+/919989
01:01:44 opendevreview melanie witt proposed openstack/nova master: Clean up unused ephemeral encryption libvirt secrets https://review.opendev.org/c/openstack/nova/+/919990
01:01:45 opendevreview melanie witt proposed openstack/nova master: libvirt: "Auto heal" ephemeral encryption secrets on guest launch https://review.opendev.org/c/openstack/nova/+/919991
01:02:21 opendevreview melanie witt proposed openstack/nova master: Support (resize|cold migration) with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870933
01:02:47 opendevreview melanie witt proposed openstack/nova master: Support live migration with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/905512
01:03:26 opendevreview melanie witt proposed openstack/nova master: Support rebuild with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870939
01:03:27 opendevreview melanie witt proposed openstack/nova master: Add Glance standardized encryption image properties https://review.opendev.org/c/openstack/nova/+/921345
01:03:27 opendevreview melanie witt proposed openstack/nova master: Support encrypted source images for qcow2 https://review.opendev.org/c/openstack/nova/+/919992
01:04:05 opendevreview melanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase https://review.opendev.org/c/openstack/nova/+/870936
01:04:05 opendevreview melanie witt proposed openstack/nova master: Add backing_encryption_secret_uuid to BlockDeviceMapping https://review.opendev.org/c/openstack/nova/+/907960
01:04:06 opendevreview melanie witt proposed openstack/nova master: Support encrypted backing files for qcow2 https://review.opendev.org/c/openstack/nova/+/907961
#openstack-nova - 2024-07-08
01:07:19 opendevreview Merged openstack/nova master: Server Rescue leads to Server ERROR state if original image is deleted https://review.opendev.org/c/openstack/nova/+/872385
04:07:35 opendevreview melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937
04:07:35 opendevreview melanie witt proposed openstack/nova master: Support cross cell resize with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/909595
04:07:36 opendevreview melanie witt proposed openstack/nova master: libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313
04:07:36 opendevreview melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912
04:26:26 spatel any idea what is this error in nova_libvirt
04:26:29 spatel 2024-07-08 04:25:59.489+0000: 2691: error : qemuDomainObjBeginJobInternal:968 : Timed out during operation: cannot acquire state change lock (held by monitor=remoteDispatchDomainCreateWithFlags)
04:26:51 spatel This is happening after ceph failure. Now ceph is health but nova doesn't like to talk
07:18:50 opendevreview melanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/870937
07:18:50 opendevreview melanie witt proposed openstack/nova master: Support cross cell resize with ephemeral encryption for qcow2 https://review.opendev.org/c/openstack/nova/+/909595
07:18:51 opendevreview melanie witt proposed openstack/nova master: libvirt: Introduce support for raw with LUKS https://review.opendev.org/c/openstack/nova/+/884313
07:18:51 opendevreview melanie witt proposed openstack/nova master: libvirt: Introduce support for rbd with LUKS https://review.opendev.org/c/openstack/nova/+/889912
10:19:48 sean-k-mooney gibi: regarding the time out how would you feel if i only tested one block size for iso
10:20:27 sean-k-mooney either 64 * units.Ki, or 1 * units.Mi
10:20:37 sean-k-mooney both would get the entiry header section in one read
10:21:05 sean-k-mooney 512 is not as bad as 17 but its proably why it takes so long
10:22:38 sean-k-mooney im going to try that locally and see how much of a speed up that gives
10:24:18 sean-k-mooney we can see it timed out in chunk = wrapper.read(block_size) so its definetly in that read loop and making progress it just takes too long
10:30:46 sean-k-mooney 5.5-5.9 second with the optimization vs 18.9-19 seconds without
10:30:56 sean-k-mooney i think that is a reasonable trade off
10:32:45 sean-k-mooney none of the logic im adding for the iso inspector cares about unaliged reads, that is just generic and shared with the other parsers so im personally happy with not testing it for these formats.

Earlier   Later