| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-07-04 | |||
| 17:56:53 | frickler | frickler: either recheck or if you want to approve the check, I can also enqueue into gate directly, the V-1 is ignored then | |
| 17:57:01 | frickler | s/check/stack/ | |
| 17:58:04 | dansmith | oh I see it's missing votes | |
| 18:01:51 | dansmith | frickler: green all the way down on 2024.1 now, I didn't recheck if you want to promote, but left the reason there too | |
| 18:05:07 | frickler | I won't promote, as that would reset the glance stack currently merging, but just enqueue into gate, which isn't too full right now I'd hope | |
| 18:11:23 | opendevreview | Mohammed Naser proposed openstack/nova master: Fix port group network metadata generation https://review.opendev.org/c/openstack/nova/+/923530 | |
| 18:13:35 | dansmith | I meant s/promote/treat specially/ but yeah, cool | |
| 18:22:20 | opendevreview | Andrei Yachmenev proposed openstack/nova master: Fix processing uniqueness of instance host names https://review.opendev.org/c/openstack/nova/+/923395 | |
| 19:11:23 | opendevreview | sean mooney proposed openstack/nova master: [WIP] add iso file format inspector https://review.opendev.org/c/openstack/nova/+/923533 | |
| 20:03:22 | opendevreview | sean mooney proposed openstack/nova master: [WIP] add iso file format inspector https://review.opendev.org/c/openstack/nova/+/923533 | |
| 20:51:51 | opendevreview | Merged openstack/nova master: port format inspector tests from glance https://review.opendev.org/c/openstack/nova/+/923504 | |
| 21:35:38 | opendevreview | Merged openstack/nova stable/2024.1: Reject qcow files with data-file attributes https://review.opendev.org/c/openstack/nova/+/923273 | |
| 21:35:44 | opendevreview | Merged openstack/nova stable/2024.1: Check images with format_inspector for safety https://review.opendev.org/c/openstack/nova/+/923274 | |
| 21:35:50 | opendevreview | Merged openstack/nova stable/2024.1: Additional qemu safety checking on base images https://review.opendev.org/c/openstack/nova/+/923275 | |
| 21:36:35 | opendevreview | Merged openstack/nova stable/2024.1: Fix vmdk_allowed_types checking https://review.opendev.org/c/openstack/nova/+/923276 | |
| 21:36:53 | opendevreview | Merged openstack/nova master: api: Migrate to JSON Schema Draft 2020-12 https://review.opendev.org/c/openstack/nova/+/915845 | |
| 22:14:32 | fungi | looks like all the ossa-2024-001 nova patches for master and stable/2024.1 have merged now, changes for older branches are still lacking approvals | |
| 22:15:32 | fungi | glance will be in a similar state as soon as the one change that bounced out earlier merges (i've tossed it back into the gate) | |
| 22:15:45 | fungi | cinder's are all merged at this point | |
| 23:06:09 | opendevreview | Merged openstack/nova master: api: Correct bug in flavors schema https://review.opendev.org/c/openstack/nova/+/923144 | |
| 23:12:13 | opendevreview | Merged openstack/nova master: api: Add 'removed' decorator https://review.opendev.org/c/openstack/nova/+/915736 | |
| 23:12:20 | opendevreview | Merged openstack/nova master: api: Don't do version check if nothing required https://review.opendev.org/c/openstack/nova/+/915737 | |
| #openstack-nova - 2024-07-05 | |||
| 06:54:18 | frickler | nova-next failed with two unrelated issues in tempest.scenario.test_security_groups_basic_ops.TestSecurityGroupsBasicOps for https://review.opendev.org/c/openstack/nova/+/923284 , I'm now going to resubmit that stack into gate directly | |
| 08:05:41 | frickler | bauzas: sean-k-mooney: there are some failures on the 2023.1 stack, also these still need reviews so they can be gated once the 2023.2 ones go in (in 2+ hours if no more gate issues happen) https://review.opendev.org/q/project:openstack/nova+branch:stable/2023.1+status:open+topic:%22bug/2059809%22 | |
| 08:29:56 | frickler | and nova-grenade-multinode failing on https://review.opendev.org/c/openstack/nova/+/923286 :-( | |
| 09:24:38 | frickler | bauzas: sean-k-mooney: gibi: please check ^^ and sorry for keeping to nag you, but I think it would be really great to get the remainder of the stack merged before the weekend | |
| 09:24:50 | opendevreview | Merged openstack/nova stable/2023.2: Reject qcow files with data-file attributes https://review.opendev.org/c/openstack/nova/+/923284 | |
| 09:24:57 | opendevreview | Merged openstack/nova stable/2023.2: Check images with format_inspector for safety https://review.opendev.org/c/openstack/nova/+/923285 | |
| 09:34:23 | frickler | I've resubmitted the two remaining 2023.2 patches into gate now, but please check those errors later, just in case | |
| 09:34:57 | frickler | dansmith: ^^ fyi | |
| 09:53:03 | sean-k-mooney | frickler: yep this is still our priority today | |
| 09:55:28 | sean-k-mooney | im just going though my morning email routine but ill take a look at the backport before i go back to the iso regression | |
| 09:56:53 | sean-k-mooney | i asked gibi to respine the backport yesterday for the ami/ari/aki format regression so it looks like that has been doen back to 2023.1 correctly | |
| 09:59:56 | frickler | sean-k-mooney: yes, the backports look fine, but 2023.1 had some CI failures and is also missing approvals | |
| 10:13:32 | stephenfin | sean-k-mooney: Seeing as it's the last quiet day before ze Americans return, any chance of some further reviews on the OpenAPI series so that can keep ticking forward? https://review.opendev.org/c/openstack/nova/+/915738/ | |
| 10:15:51 | sean-k-mooney | ill see how things go with the cve stuff but i may have a chance to look at some of them later today. if not then ill look at them on monday | |
| 10:16:22 | stephenfin | ack, ty! | |
| 10:24:59 | sean-k-mooney | ok downstream email and pings sorted | |
| 10:25:19 | sean-k-mooney | frickler: anywhere i should start with the backports | |
| 10:25:50 | sean-k-mooney | or will i just work my way form top to bottom | |
| 10:27:06 | frickler | sean-k-mooney: well bottom to top I'd say in how I look at the stack (and gerrit UI seems to agree) | |
| 10:27:27 | sean-k-mooney | i ment form newest to oldes branch | |
| 10:27:36 | sean-k-mooney | but yes bottom to top within the chain | |
| 10:27:58 | sean-k-mooney | i was just checkign where we are in teh diffentb branches https://review.opendev.org/q/topic:%22bug/2059809%22+project:openstack/nova | |
| 10:28:14 | sean-k-mooney | looks like 2023.2 is almost done | |
| 10:28:30 | sean-k-mooney | so 2023.1 is next | |
| 10:28:37 | frickler | yes, only 2023.1 open, so starting at https://review.opendev.org/c/openstack/nova/+/923288/2 should be fine | |
| 10:29:18 | frickler | I'll ignore unmaintained branches fwiw | |
| 10:30:51 | sean-k-mooney | mnaser: may have na invested intreset :) they have the zed backports up | |
| 10:31:03 | sean-k-mooney | but i cant appoved them there anyway so ill stick to stabel | |
| 10:37:19 | sean-k-mooney | on a lighter note this is the before https://fileshare.seanmooney.info/average_tempest_runtime_for_tempest-integrated-compute_by_provider.png and after https://fileshare.seanmooney.info/average_tempest_runtime_for_tempest-integrated-compute_by_provider_2024-07-03.png for truning on the the devstack optimisations. both graphs are build form 600-700 ish succesful job runs orver | |
| 10:37:21 | sean-k-mooney | the proceeding 2 weeks | |
| 10:38:26 | sean-k-mooney | new runs are faster but still not quite enough to account for the job to job varince sometimes causing timeouts on slow nodews but we went form about a 10% timout rate to aroudn 5% and hopefully that is still droping | |
| 10:40:22 | frickler | sean-k-mooney: do you also want to approve the stack or do you think you need to wait for another review? just for comparison melwitt single-approved the 2023.2 ones | |
| 10:40:51 | sean-k-mooney | frickler: ill approve it once i get to the top im goign to +w all of the rest and then ill +w the bottom patch | |
| 10:41:35 | sean-k-mooney | im hoping the 2 that are pending in 2023.2 will merge before then so that the backport check does not kick the final patches out of gate | |
| 10:42:49 | frickler | does that check work on the speculative state in zuul or on the actual repos? the former should be fine as long as the other patches are ahead in the queue | |
| 10:42:59 | sean-k-mooney | actual | |
| 10:43:14 | sean-k-mooney | although if you have stable-only in the commit i think it skip it | |
| 10:43:24 | sean-k-mooney | that how we gerenally workaround it when we need to fast merge | |
| 10:43:35 | sean-k-mooney | we mark it stable only even when its not | |
| 10:44:46 | frickler | hmm, ok, then let's wait for the 2023.2 patches, then I can simply promote the whole 2023.1 stack once it is approved and don't need to do more reshuffling | |
| 10:45:22 | sean-k-mooney | ok in that case ill leave +w off the base until those merge then we can send the full set | |
| 10:45:42 | frickler | ack | |
| 10:59:10 | sean-k-mooney | looks like there is about 30 left on thje 2023.2 gate jobs so ill keep an eye on them | |
| 11:00:17 | sean-k-mooney | ok coffee then back to the iso regression | |
| 11:00:51 | sean-k-mooney | part of me does not like release the cve fixes without that as its a pretty common usecase but im hoping we can have that fixed properly today or very early next week | |
| 11:15:20 | frickler | I wouldn't worry about a release too much at this stage, as most people are running with the provisional patches currently anyway and might switch to head of master after today, but getting the iso issue fixed soon certainly will be a good idea | |
| 11:16:18 | frickler | humm, nova-multi-cell failing on https://review.opendev.org/c/openstack/nova/+/923287 | |
| 11:16:21 | sean-k-mooney | personally im not sure i would deploy this in production without the iso fixes but ya | |
| 11:17:15 | sean-k-mooney | annorying but letss see why | |
| 11:17:59 | sean-k-mooney | its one of the volume test sbut not one of the normal kernel panics or similar | |
| 11:18:15 | frickler | you would rather run your cloud vulnerable? | |
| 11:18:38 | frickler | security group cleanup failure https://zuul.opendev.org/t/openstack/build/1f6d9308d0bb46999682ee43e856ee19 | |
| 11:19:11 | sean-k-mooney | then break all usage of iso in nova (and ami iamges if you dont have the stable version of the patches) | |
| 11:19:21 | sean-k-mooney | it would depend on what my custoemrs are using | |
| 11:19:38 | sean-k-mooney | and if its a public or private cloud | |
| 11:20:17 | sean-k-mooney | for a private cloud with semi trusted workloads or iamges like our internal ci cloud i would wait | |
| 11:20:36 | sean-k-mooney | if i was vexhost or ovh i proably woudl not | |
| 11:21:14 | sean-k-mooney | frickler: anyway lookign at the failure i dont think its related so we can recheck when the job reports back | |
| 11:23:41 | frickler | I wouldn't even recheck but promote into gate again immediately, just behind the 2023.1 stack | |
| 11:24:25 | sean-k-mooney | fair, that works for me too | |
| 11:35:51 | opendevreview | Merged openstack/nova stable/2023.2: Additional qemu safety checking on base images https://review.opendev.org/c/openstack/nova/+/923286 | |
| 11:36:11 | frickler | sean-k-mooney: ready to approve 2023.1 ^^ | |
| 11:36:44 | sean-k-mooney | dont we still need to wait for https://review.opendev.org/c/openstack/nova/+/923287/3 | |
| 11:37:33 | frickler | sean-k-mooney: no, that is the one that failed, I'm re-enqueueing it now | |
| 11:37:34 | sean-k-mooney | i can appove and most of them will merge but i think its imporant to not cover the vmdk part too | |
| 11:37:56 | sean-k-mooney | oh ok | |
| 11:39:07 | sean-k-mooney | ill send them but we might need to handel that on 2023.1 seperatly | |
| 11:39:13 | sean-k-mooney | we will see what the timeing looks like | |
| 11:40:26 | frickler | sean-k-mooney: ah, right, maybe drop the W+1 from 923291 for now, then | |
| 11:41:49 | sean-k-mooney | sure done | |
| 11:44:45 | frickler | thx, promoted all the other changes now, we'll see more in 2h hopefully | |
| 11:45:38 | sean-k-mooney | let me know if i can help with anything else, ill check on them perodicly | |
| 11:50:40 | frickler | ack | |
| 12:45:30 | fungi | looks like https://review.opendev.org/c/openstack/nova/+/923291 got unapproved at some point, are we ready to reapprove it? | |
| 12:47:15 | fungi | oh, though it's not explicitly listed in the ossa so i guess it's not as urgent | |
| 12:47:59 | sean-k-mooney | i unapproved it because the 2023.2 version failed and it would fail if it went to the gate on the backport check | |
| 12:48:25 | sean-k-mooney | fungi: so ill reappoave it when https://review.opendev.org/c/openstack/nova/+/923287 is merged | |
| 12:48:58 | fungi | hopefully the backport check wouldn't fail when the 2023.2 was ahead of it in the gate unless that test isn't properly speculative, but it seems there's no harm in waiting on that one either | |