| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-05-15 | |||
| 17:49:13 | sean-k-mooney | so the speedup on the compute while non 0 will not be the main speedup in the job | |
| 17:49:18 | clarkb | I bet all of the osc stuff is on the controller too | |
| 17:49:27 | clarkb | since you interact with the apis on the controller and not compute nodes directly. | |
| 17:49:37 | sean-k-mooney | ya most if not all | |
| 17:50:00 | sean-k-mooney | actully i can check the devstack log on the compute | |
| 17:50:05 | dansmith | sean-k-mooney: I haven't looked yet, but almost if not all is on the controller, and they don't *need* to both use the server | |
| 17:51:02 | sean-k-mooney | osc 0 | |
| 17:51:06 | dansmith | yeah :) | |
| 17:51:10 | sean-k-mooney | ok so the compute does not use osc | |
| 17:51:18 | sean-k-mooney | in that case ill change my -1 to +2 | |
| 17:51:59 | dansmith | JayF: 4 minutes is about the minimum speedup I've been seeing, yeah.. up to like 6 minutes on some jobs that setup more services | |
| 17:52:33 | dansmith | ten jobs at 4 minutes each is 40 minutes of cumulative gate time which is non-trivial, IMHO | |
| 17:52:50 | JayF | 4 minutes on a job that usually takes 40-60 is amazing | |
| 17:57:35 | opendevreview | Dmitriy Rabotyagov proposed openstack/nova master: Handle MAC dash-addresses during migration https://review.opendev.org/c/openstack/nova/+/919760 | |
| 18:04:01 | dansmith | JayF: yeah, that does not suck | |
| 18:09:42 | opendevreview | ribaudr proposed openstack/nova master: Amend ShareMappingStatus due to asynchronous call https://review.opendev.org/c/openstack/nova/+/908864 | |
| 18:09:42 | opendevreview | ribaudr proposed openstack/nova master: Amend DB model add a unique constraint. https://review.opendev.org/c/openstack/nova/+/912518 | |
| 18:09:43 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction) https://review.opendev.org/c/openstack/nova/+/831194 | |
| 18:09:43 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part) https://review.opendev.org/c/openstack/nova/+/833090 | |
| 18:09:44 | opendevreview | ribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process https://review.opendev.org/c/openstack/nova/+/880075 | |
| 18:09:44 | opendevreview | ribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion https://review.opendev.org/c/openstack/nova/+/881472 | |
| 18:09:45 | opendevreview | ribaudr proposed openstack/nova master: Add metadata for shares https://review.opendev.org/c/openstack/nova/+/850500 | |
| 18:09:46 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/854823 | |
| 18:09:46 | opendevreview | ribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/854824 | |
| 18:09:48 | opendevreview | ribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part) https://review.opendev.org/c/openstack/nova/+/860284 | |
| 18:09:48 | opendevreview | ribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860285 | |
| 18:09:50 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares https://review.opendev.org/c/openstack/nova/+/860286 | |
| 18:09:50 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (driver part) https://review.opendev.org/c/openstack/nova/+/860287 | |
| 18:09:52 | opendevreview | ribaudr proposed openstack/nova master: Support rescuing an instance with shares (compute manager part) https://review.opendev.org/c/openstack/nova/+/860288 | |
| 18:09:52 | opendevreview | ribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol https://review.opendev.org/c/openstack/nova/+/883862 | |
| 18:09:54 | opendevreview | ribaudr proposed openstack/nova master: Check shares support (compute manager) https://review.opendev.org/c/openstack/nova/+/885751 | |
| 18:09:54 | opendevreview | ribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API) https://review.opendev.org/c/openstack/nova/+/836830 | |
| 18:09:56 | opendevreview | ribaudr proposed openstack/nova master: Add helper methods to attach/detach shares https://review.opendev.org/c/openstack/nova/+/885753 | |
| 18:09:56 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach notification https://review.opendev.org/c/openstack/nova/+/850501 | |
| 18:09:58 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach notification https://review.opendev.org/c/openstack/nova/+/851028 | |
| 18:09:58 | opendevreview | ribaudr proposed openstack/nova master: Add shares to InstancePayload https://review.opendev.org/c/openstack/nova/+/851029 | |
| 18:10:00 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_attach_error notification https://review.opendev.org/c/openstack/nova/+/860282 | |
| 18:10:00 | opendevreview | ribaudr proposed openstack/nova master: Add instance.share_detach_error notification https://review.opendev.org/c/openstack/nova/+/860283 | |
| 18:10:02 | opendevreview | ribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working. https://review.opendev.org/c/openstack/nova/+/852086 | |
| 18:10:02 | opendevreview | ribaudr proposed openstack/nova master: Add virt/libvirt error test cases https://review.opendev.org/c/openstack/nova/+/852087 | |
| 18:10:04 | opendevreview | ribaudr proposed openstack/nova master: Docs about Manila shares API usage https://review.opendev.org/c/openstack/nova/+/871642 | |
| 18:16:30 | sean-k-mooney | dansmith: by the way i have like 4 other test tweek patchs that these are conficting with but ill rebase my commits after your two land | |
| 18:17:05 | dansmith | sean-k-mooney: ack, no rush on mine, but might make yours faster if you do :) | |
| 18:17:11 | dansmith | so.. | |
| 18:17:35 | dansmith | python3.12 changes the repr() format for collections.OrderedDict, which is breaking our object hash calculation (for notifications) | |
| 18:25:18 | sean-k-mooney | i added all the ci job patches im aware of to https://etherpad.opendev.org/p/nova-dalmatian-status#L17 | |
| 18:47:13 | opendevreview | Dan Smith proposed openstack/nova master: Fix notification object hashes for python 3.12 https://review.opendev.org/c/openstack/nova/+/919763 | |
| 18:47:13 | opendevreview | Dan Smith proposed openstack/nova master: Fix hacking test with syntax error https://review.opendev.org/c/openstack/nova/+/919764 | |
| 18:47:20 | dansmith | this should get the py3.12 unit job working ^ | |
| 18:51:20 | dansmith | I wonder if we could get Uggla_ to submit the manila series in smaller chunks.. I think that series is basically consuming all the nova quota in check right now | |
| 19:08:46 | opendevreview | Dan Smith proposed openstack/nova master: Make python 3.12 unit tests voting https://review.opendev.org/c/openstack/nova/+/919767 | |
| 19:10:01 | opendevreview | Dan Smith proposed openstack/nova master: Make python 3.12 unit tests voting https://review.opendev.org/c/openstack/nova/+/919767 | |
| 19:10:27 | opendevreview | Dan Smith proposed openstack/nova master: Make python 3.12 unit tests voting https://review.opendev.org/c/openstack/nova/+/919767 | |
| 19:11:28 | sean-k-mooney | dansmith: so the fix is to just bite the bullet and update the hash | |
| 19:11:57 | dansmith | sean-k-mooney: well, change the hashed things to something that is stable on both, and then yeah, update them all :( | |
| 19:11:58 | dansmith | it sucked | |
| 19:13:35 | opendevreview | Dan Smith proposed openstack/nova master: Fix notification object hashes for python 3.12 https://review.opendev.org/c/openstack/nova/+/919763 | |
| 19:13:35 | opendevreview | Dan Smith proposed openstack/nova master: Fix hacking test with syntax error https://review.opendev.org/c/openstack/nova/+/919764 | |
| 19:13:36 | opendevreview | Dan Smith proposed openstack/nova master: Make python 3.12 unit tests voting https://review.opendev.org/c/openstack/nova/+/919767 | |
| 19:14:40 | sean-k-mooney | ack so you cahnged form an ordered dict to calling sorted on the maping over the items of the schema | |
| 19:16:17 | dansmith | it was already calling sorted on the dict.items(), it was just re-dicting them with OrderedDict, which isn't necessary (dicts are ordered in python3) but even still, we don't need the extra dict layer anyway | |
| 19:16:37 | sean-k-mooney | SCHEMA is technialy a normal dict which maintains insertion order as of py3.7 i think an dhten calling items on that gives us a view object | |
| 19:16:38 | dansmith | so I just removed the ordereddict layer | |
| 19:17:17 | sean-k-mooney | yep im just confirming that the thing we are now string should be still ordered and stable | |
| 19:17:20 | dansmith | yep, sorted() is a good safety measure to keep it stable, but we don't need the extra top-level dict | |
| 19:17:21 | sean-k-mooney | which it should be | |
| 19:17:27 | dansmith | yeah | |
| 19:22:05 | dansmith | gmann: why no functional 3.12 job yet? our functionals pass on 3.12, but based on my experience above, we better go ahead and have a voting job to make sure we don't regress on that | |
| 19:23:02 | dansmith | or, hmm, do we only get functional jobs from our own tree? we don't even have a 311 job in nova | |
| 19:24:55 | dansmith | ah, I guess the base is there and I can add it | |
| 19:26:12 | sean-k-mooney | dansmith: i think gmann had a patch up for this for placement but i have not seen one for nova | |
| 19:26:19 | dansmith | coming | |
| 19:26:27 | sean-k-mooney | i think the definiton of the functional 3.12 job was pending | |
| 19:26:48 | opendevreview | Dan Smith proposed openstack/nova master: Make python 3.12 unit and functional voting https://review.opendev.org/c/openstack/nova/+/919767 | |
| 19:26:54 | dansmith | the base job appears to exist, so I think this ^ should do it | |
| 19:27:55 | sean-k-mooney | oh i was thinking of https://review.opendev.org/c/openstack/osc-placement/+/904612 | |
| 19:28:21 | sean-k-mooney | yep they were added by https://review.opendev.org/c/openstack/openstack-zuul-jobs/+/918946 | |
| 19:28:31 | sean-k-mooney | which looks like it merged last week | |
| 19:29:26 | opendevreview | Dan Smith proposed openstack/nova master: Make python 3.12 unit and functional voting https://review.opendev.org/c/openstack/nova/+/919767 | |
| 19:29:30 | dansmith | this patch removes 38 too by the way | |
| 19:29:34 | dansmith | which I think is legit now | |
| 19:29:43 | sean-k-mooney | yes it is | |
| 19:30:02 | sean-k-mooney | som ehave started blocking install on 38 but i know you dont want to do that in nova | |
| 19:30:23 | dansmith | yeah I wouldn't personally, but I'm just one guy :) | |
| 19:31:24 | sean-k-mooney | so we are missing 3.11 for functional | |
| 19:31:36 | sean-k-mooney | 3.12 is not requried but if its passing and voting then sure | |
| 19:31:45 | dansmith | yeah, missing 3.11 | |
| 19:31:47 | sean-k-mooney | do we want to remove 3.10 or bump it to 3.11 | |
| 19:31:51 | dansmith | I think we should keep 3.12 passing as long as it is | |
| 19:32:14 | dansmith | we could.. testing either end is enough for me | |
| 19:32:15 | sean-k-mooney | yep just wonder if you want 2 jobs or 3 while its working | |
| 19:33:02 | sean-k-mooney | ok im going to finish for today ill take a look at this tomorwow | |
| 19:33:18 | sean-k-mooney | 3.10 may have been the default on ubuntu 22.04 | |
| 19:33:37 | dansmith | it is, and that's still our primary platform for this release | |
| 19:33:38 | sean-k-mooney | so that might have been why we were tsting it and not 3.11 or we just forgot | |
| 19:34:00 | sean-k-mooney | ya so i would be fine not adding 3.11 and keeping 3.10 | |
| 19:34:05 | dansmith | me too | |
| 19:34:46 | sean-k-mooney | in that case ill +2 https://review.opendev.org/c/openstack/nova/+/919767 and gmann or others can disagree | |
| 19:36:16 | dansmith | ack, thanks | |
| 19:36:42 | dansmith | py312 unit job passed now on the patch below | |