| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-03-20 | |||
| 13:32:47 | dansmith | I thought we already had that because we flip the shared/dedicated set between the two? | |
| 13:34:13 | sean-k-mooney | in whitebox we partly do, we just dont have any test that asserts the xml was updated for non numa instnaces | |
| 13:34:24 | opendevreview | Merged openstack/nova master: Correctly reset instance task state in rebooting hard https://review.opendev.org/c/openstack/nova/+/867832 | |
| 13:34:33 | sean-k-mooney | we do live migrations with non numa instance we jsut dont check the xml | |
| 13:34:39 | dansmith | ah | |
| 13:34:59 | sean-k-mooney | so i just want to add a dedicated test with a vanial flaovr that checks as a follow up | |
| 13:35:07 | sean-k-mooney | i did in manually in the modifed ci job | |
| 13:35:15 | sean-k-mooney | but we can automate that | |
| 13:38:10 | dansmith | we should do that in a test though and not with a different job right? or is that what you mean by "automate that" | |
| 13:38:12 | dansmith | ? | |
| 13:38:27 | sean-k-mooney | yes not a diffent job | |
| 13:38:42 | sean-k-mooney | just a tempest testcase | |
| 13:41:05 | dansmith | ack | |
| 13:54:24 | opendevreview | Merged openstack/os-vif master: Update python classifier in setup.cfg https://review.opendev.org/c/openstack/os-vif/+/904613 | |
| 13:57:48 | opendevreview | Merged openstack/os-vif master: tox: Drop envdir https://review.opendev.org/c/openstack/os-vif/+/907604 | |
| 14:09:30 | opendevreview | sean mooney proposed openstack/nova master: Test live migration between hosts with differnet cpu_shared_sets https://review.opendev.org/c/openstack/nova/+/913744 | |
| 14:10:15 | sean-k-mooney | update ^ to make it clear this is testing non numa instances for the vanilla case where the cpu_share_set just happens to be different on each host | |
| 14:16:08 | dansmith | sean-k-mooney: this is modifying our live migration job, but we don't run whitebox there right? so you're thinking this will cause us to run over the code in question and would fail if not on top of the fix? | |
| 14:16:14 | sean-k-mooney | im tempeted to push a second patch to test numa live migration in one of the other jobs but i wont for now. that litrally just need us to modify the flavor to have hw:mem_page_size=small but im not sure if we currently rely on memory over allcation in theyse job. i belvie we dont given the default for initial_ram_allocation_ratio is 1.0 so it should just work perhaps it worth | |
| 14:16:16 | sean-k-mooney | a try as it would be nice to get that coverage effectivly for free | |
| 14:16:53 | sean-k-mooney | dansmith: it does make use run the code in questio. it will not fail unless the code breaks live migratoin | |
| 14:17:00 | sean-k-mooney | but it not asserting that the xml is update | |
| 14:17:11 | sean-k-mooney | which is why i did that by hand by inspecting the logs | |
| 14:17:23 | dansmith | oh right, because it won't fail it will just be wrong | |
| 14:17:27 | dansmith | right, okay sorry | |
| 14:17:33 | sean-k-mooney | it would have caught if the int("of random string") was actully exploding | |
| 14:17:37 | dansmith | the caffeine absorption is slow this morning | |
| 14:18:07 | sean-k-mooney | ya so if we dint have the same number of cpus in both hosts adn we were using one on the source that was not on the dest it would fail | |
| 14:18:11 | sean-k-mooney | but that is not the case here | |
| 14:18:23 | sean-k-mooney | it woudl just be runnign on the wrong core | |
| 14:18:46 | sean-k-mooney | it woudl get fixed on teh next hard reboot of the vm | |
| 14:21:52 | sean-k-mooney | what happens today fi the core does not exist is we get an error for the call to libvirt to start the migration and rollback gracefuly and mark the migration as failed | |
| 14:22:29 | sean-k-mooney | the same thing happens if you have the power managemnt feature enabeld and the core is offline | |
| 14:23:00 | sean-k-mooney | qemu check for that and reports an error to libvirt which we then get and we rollback in the same way as if the cpu were not compatiable | |
| 15:43:28 | opendevreview | Merged openstack/nova stable/2024.1: [stable-only] Update .gitreview for stable/2024.1 https://review.opendev.org/c/openstack/nova/+/913631 | |
| 15:43:36 | opendevreview | Merged openstack/nova stable/2024.1: [stable-only] Update TOX_CONSTRAINTS_FILE for stable/2024.1 https://review.opendev.org/c/openstack/nova/+/913632 | |
| 16:19:55 | zigo | Who's trying to use systemctl in unit tests?!? | |
| 16:19:55 | zigo | https://buildd.debian.org/status/fetch.php?pkg=nova&arch=all&ver=2%3A29.0.0~rc1-1&stamp=1710857860&file=log | |
| 16:20:30 | zigo | Not a good idea, IMO. Or at least, this has to be explicited somewhere. | |
| 16:20:58 | clarkb | the upstream unittest jobs should remove sudo powers before running the tests. Unprivileged systemctl isn't the worst thing? | |
| 16:21:27 | zigo | It's not that... | |
| 16:21:28 | zigo | FileNotFoundError: [Errno 2] No such file or directory: 'systemctl' | |
| 16:21:37 | zigo | There's no systemd in the Debian buildd chroots ... | |
| 16:21:48 | zigo | Plus WTF is it even trying to do? | |
| 16:23:33 | clarkb | its checking if the system is running systemd and assumes if systemd is present then so is systemdctl | |
| 16:23:44 | zigo | sysdout, sysderr = processutils.execute("systemctl", | |
| 16:23:44 | zigo | "is-system-running", | |
| 16:23:44 | zigo | check_exit_code=[0, 1]) | |
| 16:23:49 | zigo | Well, no it's not, thanks ... :) | |
| 16:24:09 | clarkb | does seem like the sort of check that could catch exceptions and then mark no to systemd | |
| 16:24:31 | clarkb | zigo: there must be some systemd due to the checks just above that statement. | |
| 16:24:41 | clarkb | so I don't think it is accurate that the build chroots have no systemd | |
| 16:24:56 | clarkb | if psutil.Process(1).name() == "systemd" or os.path.exists(SYSTEMCTL_CHECK_PATH): | |
| 16:25:05 | zigo | I could add a depends on systemd... | |
| 16:25:11 | zigo | Not sure if that will help though. | |
| 16:25:25 | zigo | It does build fine on my laptop, just not on buildd. | |
| 16:25:32 | zigo | That's kind of the worse situation ! :) | |
| 16:25:52 | zigo | I probably will end up blacklisting yet another bunch of tests ... | |
| 16:27:53 | clarkb | I think changing that or to an and may fix it for you | |
| 16:52:48 | opendevreview | Merged openstack/nova master: Fix tipo https://review.opendev.org/c/openstack/nova/+/907208 | |
| 16:54:44 | opendevreview | ribaudr proposed openstack/nova master: Fix: Live migrating to a host with cpu_shared_set configured will now update the VM's configuration accordingly. https://review.opendev.org/c/openstack/nova/+/903706 | |
| 16:54:45 | opendevreview | ribaudr proposed openstack/nova master: Test live migration between hosts with differnet cpu_shared_sets https://review.opendev.org/c/openstack/nova/+/913744 | |
| 19:34:33 | opendevreview | sean mooney proposed openstack/nova master: enable numa live migration in the ceph job https://review.opendev.org/c/openstack/nova/+/913842 | |
| 19:37:06 | opendevreview | sean mooney proposed openstack/nova master: enable numa live migration in the ceph job https://review.opendev.org/c/openstack/nova/+/913842 | |
| 21:14:38 | opendevreview | sean mooney proposed openstack/nova master: imporve nova object logging https://review.opendev.org/c/openstack/nova/+/898057 | |
| 21:18:42 | opendevreview | sean mooney proposed openstack/nova master: refactor numa claims https://review.opendev.org/c/openstack/nova/+/898056 | |
| 21:24:23 | sean-k-mooney | artom: ^ those are my patches i sstarted when debuging the numa aware vsiwtch issue as an fyi | |
| 21:24:42 | sean-k-mooney | i just inverted the order so the logging patch is first and the refactor patch is second | |
| 21:25:16 | sean-k-mooney | melwitt: ^ i would prefer to use my logging patch instead of https://review.opendev.org/c/openstack/nova/+/907976 by the way just because its more systemtic and general | |
| 21:25:46 | sean-k-mooney | it would be nice to have your review feedback on that when you have time | |
| 21:30:08 | opendevreview | sean mooney proposed openstack/nova master: enable numa live migration in the ceph job https://review.opendev.org/c/openstack/nova/+/913842 | |
| 21:35:56 | artom | sean-k-mooney, ack. I've got a couple of appointment on Friday, but between them, if you're up for it, I'll load context from you | |
| 21:50:56 | sean-k-mooney | sure | |
| 21:51:01 | melwitt | sean-k-mooney: ack, ok | |
| #openstack-nova - 2024-03-21 | |||
| 10:01:34 | bauzas | elodilles: I did a couple of single-core approvals for the reno unmaintenained patches but please ping me if you find that I forgot some patch for other nova repos | |
| 10:06:38 | frickler | bauzas: osc-placement is also nova team, isn't it? https://review.opendev.org/c/openstack/osc-placement/+/911294 etc. | |
| 10:07:00 | bauzas | that's correct, I'll do my duty then | |
| 10:07:56 | frickler | ty | |
| 10:09:11 | bauzas | I wish we could have some flag in gerrit query to say 'flag:nova-related' instead of 'project:<something> OR project:somethingelse> :) | |
| 10:09:35 | bauzas | I just don't know how other services that have like 50 repos do this :) | |
| 10:12:03 | opendevreview | Merged openstack/os-vif master: reno: Update master for unmaintained/xena https://review.opendev.org/c/openstack/os-vif/+/911292 | |
| 10:12:04 | opendevreview | Merged openstack/os-vif master: reno: Update master for unmaintained/wallaby https://review.opendev.org/c/openstack/os-vif/+/911282 | |
| 10:12:05 | opendevreview | Merged openstack/os-vif master: reno: Update master for unmaintained/victoria https://review.opendev.org/c/openstack/os-vif/+/911272 | |
| 10:12:36 | elodilles | bauzas: ACK, thanks (i added review-priority+1 for them) | |
| 10:12:44 | opendevreview | Merged openstack/python-novaclient master: reno: Update master for unmaintained/wallaby https://review.opendev.org/c/openstack/python-novaclient/+/911288 | |
| 10:12:46 | opendevreview | Merged openstack/python-novaclient master: reno: Update master for unmaintained/victoria https://review.opendev.org/c/openstack/python-novaclient/+/911278 | |
| 10:12:47 | opendevreview | Merged openstack/python-novaclient master: reno: Update master for unmaintained/xena https://review.opendev.org/c/openstack/python-novaclient/+/911298 | |
| 10:13:05 | bauzas | we gotta get a pile of them ^ :) | |
| 10:13:52 | elodilles | (well, sorry, i was talking about this ones: 'Update master for stable/2024.1') | |
| 10:14:28 | opendevreview | Merged openstack/osc-placement master: reno: Update master for unmaintained/victoria https://review.opendev.org/c/openstack/osc-placement/+/911274 | |
| 10:16:54 | opendevreview | Merged openstack/osc-placement master: reno: Update master for unmaintained/xena https://review.opendev.org/c/openstack/osc-placement/+/911294 | |
| 10:16:55 | opendevreview | Merged openstack/osc-placement master: reno: Update master for unmaintained/wallaby https://review.opendev.org/c/openstack/osc-placement/+/911284 | |
| 10:18:57 | opendevreview | Merged openstack/nova master: reno: Update master for unmaintained/xena https://review.opendev.org/c/openstack/nova/+/911290 | |
| 10:19:04 | opendevreview | Sylvain Bauza proposed openstack/nova master: Update min support for Dalmatian https://review.opendev.org/c/openstack/nova/+/913890 | |
| 10:22:27 | opendevreview | Merged openstack/nova master: reno: Update master for unmaintained/victoria https://review.opendev.org/c/openstack/nova/+/911270 | |
| 10:24:27 | opendevreview | Merged openstack/nova master: reno: Update master for unmaintained/wallaby https://review.opendev.org/c/openstack/nova/+/911280 | |
| 12:23:42 | sean-k-mooney[m] | bauzas: you can create a dashboard in gerrit | |
| 12:24:15 | bauzas | sure, I already use two of them | |
| 12:24:47 | bauzas | but OK, maybe I should create some dashboard for all the nova repos | |
| 12:25:12 | bauzas | (at least for the release bot ones :) | |