| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-03-18 | |||
| 14:34:21 | bauzas | artom: Uggla: because today is the last day for creating a RC1, I find we will punt the cpu_shared_set changes to Dalmatian :( | |
| 14:34:42 | bauzas | I'm just awaiting for https://zuul.openstack.org/status#902084 + the prelude | |
| 14:34:49 | artom | Err, CPU power management doesn't work properly without it... | |
| 14:35:10 | artom | gibi's going to be very angry at you if we don't fix it entirely | |
| 14:35:17 | artom | ;) | |
| 14:37:34 | artom | I guess we can debate releasing it with a known issue (if you have different cpu_shared_set on source and dest and use libvirt CPU power management, not only does live migration doesn't update the pins, but also you might end up on CPUs that are powered down and the instance just doesn't start)... | |
| 14:37:38 | bauzas | artom: Uggla: so, then tell me about https://review.opendev.org/c/openstack/nova/+/877773 | |
| 14:39:48 | artom | IMO it's fixable with a relatively small and clean-ish (as much as you can be clean when the whole basic principle is a mad genius hack) adjustment | |
| 14:40:46 | dansmith | bauzas: will you +W that patch yourself? | |
| 14:42:03 | dansmith | ... or do you need another review? looks like its 2x+2 already | |
| 14:42:09 | artom | Uggla seems to be AFK at the moment, so I can update it myself since we're in a time squeeze | |
| 14:42:16 | gibi | artom: bauzas: my powermgmt needs are targeting antelope. So if the cpu_share_set fix only lands in D then that will not prevent the backport to antelopej | |
| 14:42:19 | bauzas | dansmith: which change you mean ? | |
| 14:42:21 | dansmith | I'm talking about 902084 | |
| 14:42:51 | bauzas | dansmith: it's already accepted, but it's running on the gate | |
| 14:43:07 | dansmith | 902084 has no +W | |
| 14:43:07 | bauzas | https://zuul.openstack.org/status#902084 | |
| 14:43:13 | bauzas | ?* | |
| 14:43:18 | dansmith | it's in check now | |
| 14:43:31 | dansmith | "WorkflowNo votes" | |
| 14:43:35 | bauzas | oh right | |
| 14:43:35 | artom | gibi, fair... when does master switch to D? Tomorrow after today's RC1? | |
| 14:43:37 | bauzas | shit | |
| 14:43:46 | bauzas | dansmith: no worries, I'll +W it | |
| 14:43:54 | dansmith | bauzas: cool | |
| 14:44:07 | bauzas | thanks btw. | |
| 14:44:47 | bauzas | artom: gibi: so you would want to have https://review.opendev.org/c/openstack/nova/+/877773 to be merged in C ? | |
| 14:45:14 | bauzas | fwiw, we're still missing a second core here https://review.opendev.org/c/openstack/nova/+/903706/2 | |
| 14:45:46 | artom | bauzas, I think gibi's saying that as long as it gets backported to Antelope, he's happy, regardless if it's merged on master in C or D | |
| 14:45:55 | bauzas | my concern is that we couldn't backport https://review.opendev.org/c/openstack/nova/+/903706/2/nova/objects/migrate_data.py#246 | |
| 14:46:09 | gibi | artom: yes, after RC1 we will have master open for D, but I guess bauzas wants to limit the changes on master until final RC to make sure any last minute change to C is easy to backport from masterj | |
| 14:46:25 | artom | bauzas, right, that's why there's a backportable hack below it in https://review.opendev.org/c/openstack/nova/+/877773/9 | |
| 14:46:38 | bauzas | I just +2d both of the changes | |
| 14:47:17 | artom | bauzas, err, want to jump on a call for me to explain stuff? | |
| 14:48:08 | bauzas | guys, that's like 4 days i told about rc1 | |
| 14:48:12 | bauzas | I wonder what you guys want | |
| 14:49:44 | gibi | I want to enable powermgmt in antelope :) | |
| 14:51:18 | gibi | backporting the fix from C or D does not matter for mej | |
| 15:13:55 | dansmith | bauzas: I'm trying to decide if that cpu shared set thing is okay or not | |
| 15:14:12 | dansmith | I don't love deleting a non-versioned property and replacing it with a versioned one like it's doing | |
| 15:14:29 | dansmith | I'm trying to decide if it's actually a problem, or just _very_ confusing (the latter is definitely true, IMHO | |
| 15:16:35 | dansmith | ah, basically what sean-k-mooney said on PS1 | |
| 15:18:06 | bauzas | dansmith: gibi: artom: Uggla: okay, so now I understand more | |
| 15:18:14 | artom | dansmith, heh, bauzas and I were just on a call where I explained the nuances | |
| 15:18:22 | artom | I can do the same for you if you wish :) | |
| 15:18:44 | dansmith | bummer | |
| 15:18:58 | bauzas | so, basically, we have an already bug with live-migration for cpu_shared_set | |
| 15:19:16 | dansmith | yeah I get that | |
| 15:19:51 | dansmith | how far back does it need to be backported? | |
| 15:19:52 | bauzas | now with power management, you can live-migrate an instance that will use a wrong cpu which is a dedicated one, like before, but which will be off | |
| 15:20:14 | bauzas | my point is that I don't think it's a RC1 needed bugfix | |
| 15:20:56 | bauzas | what we can rather do is to merge https://review.opendev.org/c/openstack/nova/+/877773 in Dalmatian and then backport it down to Antelope if we want | |
| 15:21:09 | bauzas | https://review.opendev.org/c/openstack/nova/+/903706/ won't be backported | |
| 15:21:20 | bauzas | (as it's a new object version) | |
| 15:21:58 | bauzas | so I'm just asking Uggla to modify https://review.opendev.org/c/openstack/nova/+/877773 to make sure it fixes the wrong functional test which is https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1899835.py | |
| 15:22:24 | bauzas | (the last assert is wrong in the regression bug) | |
| 15:22:58 | bauzas | (school) | |
| 15:28:46 | gibi | elodilles: could you look at this b | |
| 15:28:57 | gibi | ... this backport series https://review.opendev.org/c/openstack/nova/+/913198 | |
| 16:03:47 | elodilles | gibi: ACK, i'll try to look into it when i get there | |
| 16:03:47 | bauzas | gibi: dansmith: we need approval for the prelude patch https://review.opendev.org/c/openstack/nova/+/912973 | |
| 16:04:10 | dansmith | ack | |
| 16:04:30 | bauzas | thanks | |
| 16:07:17 | gibi | elodilles: thanks | |
| 16:22:47 | dansmith | bauzas: done | |
| 16:22:54 | bauzas | cool thanks ! | |
| 16:26:14 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add a Caracal prelude section https://review.opendev.org/c/openstack/nova/+/912973 | |
| 16:26:21 | bauzas | dansmith: ^ (when you have time) | |
| 16:58:30 | opendevreview | Merged openstack/nova master: vgpu: Allow device_addresses to not be set https://review.opendev.org/c/openstack/nova/+/902084 | |
| 17:18:46 | zigo | bauzas: Typ3 on the last 3 lines: | |
| 17:18:46 | zigo | and yet another one another one (twice "another one") | |
| 17:19:29 | zigo | Live-mig of vGPU is a nice feature, thanks! | |
| 17:20:02 | zigo | Also, good thing for SEV. We were looking at implementing it, now I'll make sure we do that over Caracal! :) | |
| 18:35:42 | opendevreview | Merged openstack/nova stable/2023.2: Add cpuset_reserved helper to instance NUMA topology https://review.opendev.org/c/openstack/nova/+/913193 | |
| 18:35:48 | opendevreview | Merged openstack/nova stable/2023.2: Reproducer for not powering on isolated emulator threads cores https://review.opendev.org/c/openstack/nova/+/913194 | |
| 18:59:52 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add a Caracal prelude section https://review.opendev.org/c/openstack/nova/+/912973 | |
| 19:00:45 | bauzas | dansmith: melwitt: could you please quickky approve now the prelude above $ so I could provide a new RC1 release patch version tonight? | |
| 19:10:29 | dansmith | bauzas: done | |
| 19:17:02 | bauzas | dansmith: melwitt: ta folks, as soon as it merges, I'll update the RC1 patch | |
| 19:46:11 | opendevreview | Merged openstack/nova master: Add a Caracal prelude section https://review.opendev.org/c/openstack/nova/+/912973 | |
| 22:15:44 | opendevreview | Merged openstack/nova stable/zed: Reproducer for bug 2003991 unshelving offloaded instance https://review.opendev.org/c/openstack/nova/+/888093 | |
| #openstack-nova - 2024-03-19 | |||
| 10:20:57 | opendevreview | OpenStack Release Bot proposed openstack/nova stable/2024.1: Update .gitreview for stable/2024.1 https://review.opendev.org/c/openstack/nova/+/913631 | |
| 10:21:00 | opendevreview | OpenStack Release Bot proposed openstack/nova stable/2024.1: Update TOX_CONSTRAINTS_FILE for stable/2024.1 https://review.opendev.org/c/openstack/nova/+/913632 | |
| 10:21:05 | opendevreview | OpenStack Release Bot proposed openstack/nova master: Update master for stable/2024.1 https://review.opendev.org/c/openstack/nova/+/913633 | |
| 10:35:26 | opendevreview | Rocky proposed openstack/nova master: Fix the command to list hw_machine_type unset instances https://review.opendev.org/c/openstack/nova/+/913652 | |
| 10:48:21 | bauzas | guys, please welcome our master branch that's now a Dalmatian :) | |
| 10:48:46 | bauzas | so long Caracal and thanks for the fish | |
| 10:49:14 | bauzas | (RC1 tag is set and caracal branch created) | |
| 10:53:25 | gibi | bauzas: \o/ | |
| 11:15:46 | sean-k-mooney | :) | |
| 12:00:53 | opendevreview | Fabian Wiesel proposed openstack/nova master: Do not close returned image-chunk iterator & get_verifier early https://review.opendev.org/c/openstack/nova/+/909474 | |
| 13:18:57 | fwiesel | bauzas: I've reopened the bug #2055700 as #2058225. In my mind _rebuild_default_impl is implemented libvirt specific. I can implement driver.rebuild for vmwareapi to work around the bug, but I don't think that would be a great way forward. | |
| 13:21:03 | opendevreview | Merged openstack/nova stable/2023.2: Power on cores for isolated emulator threads https://review.opendev.org/c/openstack/nova/+/913195 | |
| 13:40:59 | bauzas | fwiesel: cool | |
| 13:44:52 | fwiesel | But I do not know enough how it is supposed to work in libvirt to make a good suggestion on how to implement it differently. I mean, I assume it makes sense that it is implemented the way it is. | |
| 13:53:08 | bauzas | fwiesel: you're referring to https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4132-L4137 | |
| 14:00:25 | bauzas | fwiesel: _rebuild_default_impl is a virt-agnostic solution for rebuild which does delete the old guest and then create a new one https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L3648-L3731 | |
| 14:02:52 | gibi | elodilles: thanks for the reviews so far. the parent of https://review.opendev.org/c/openstack/nova/+/913196 is merged now. So when you have time please check this backport too | |
| 14:02:56 | bauzas | as you can read, we power off the guest, detach its volumes, (reimage the root disk if volume-backed), destroy the guest, attach the volumes again and spawn the guest | |
| 14:14:52 | sean-k-mooney | fwiesel: the way its currently implemtned shoudl wor for vmware too | |