| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-03-14 | |||
| 18:46:14 | melwitt | yeah.. initially I didn't do that but realized it later. we would need a min version bump to not have to do it I think | |
| 18:46:28 | sean-k-mooney | am that will not strictly be required as we can move to libvirt 8.0.0 next cycle | |
| 18:46:38 | sean-k-mooney | but since you have it working we can keep it | |
| 18:46:45 | melwitt | which we might be doing for dalamation, so I can take that out if so | |
| 18:47:31 | melwitt | it would make the change much prettier if we bumped to 8.0.0 heh | |
| 18:47:55 | sean-k-mooney | ya although its not terrible as is | |
| 18:47:56 | melwitt | persistent mdevs in 7.3.0 and autostart in 7.8.0 | |
| 18:48:46 | sean-k-mooney | autostart in this context being create them automatically on host start right | |
| 18:48:51 | sean-k-mooney | rather then domain start | |
| 18:49:30 | sean-k-mooney | may be worth adding follow up patches that do the min bump | |
| 18:49:55 | sean-k-mooney | and we can then defer that choice until we decied if we bump to 8.0.0 | |
| 18:50:54 | sean-k-mooney | it looks like there would not actully be much clean up to do fo 8.0.0 | |
| 18:51:57 | sean-k-mooney | i mean for other feature | |
| 18:52:11 | sean-k-mooney | all the feature gates seam to be 8.y.z | |
| 18:52:29 | sean-k-mooney | so i dont think you will need to do much cleanup if you decied to creat that patch | |
| 18:55:28 | melwitt | sean-k-mooney: yes autostart is the virNodeDeviceCreate happening automatically at host start | |
| 18:55:32 | melwitt | I also added a thing to do it during init_host if for some reason there are any that are defined but not created | |
| 18:56:08 | melwitt | it's not really related to domain start in that domain start will not start them | |
| 18:56:20 | melwitt | the domain will fail to start until you start the nodedev | |
| 18:57:05 | stblatzheim | anyone here who could review and give a +W for the cherrypick for 2023.1 for https://review.opendev.org/c/openstack/nova/+/911070 ? | |
| 18:58:28 | sean-k-mooney | melwitt: well what i was really thinking about is we currenlty undefien an redefine the domain on start so we woudl recreate those i think if you had not already done it in init_host | |
| 18:59:30 | melwitt | sean-k-mooney: oh so colocating it with the domain define/create, yeah I see what you mean | |
| 18:59:52 | melwitt | I thought about that but forgot. I think that would be a good way too | |
| 19:00:23 | sean-k-mooney | im not sure it required but ill try and reject on that when i get aroudn to reviewing properly | |
| 19:03:27 | melwitt | from testing I know that it won't happen on its own but we could definitely add a check + device start before starting the domain | |
| 19:04:05 | melwitt | *won't happen on its own without autostart on the nodedev | |
| 19:34:49 | sean-k-mooney | ack, i think where reasonable we want to try adn get to the point where restarting a compute node does not requrie any manual intervention to sart the vms via the api provided the smi-manage thing is automated via a systemd service or similar before nova starts | |
| 19:35:19 | sean-k-mooney | that means either creating them at init_host, or autostart or at domain start | |
| 19:36:41 | sean-k-mooney | elodilles: would you mined reviewing https://review.opendev.org/c/openstack/nova/+/911070 for stblatzheim when you have time or other stable cores | |
| 20:03:40 | melwitt | sean-k-mooney: I agree. I tested for example creating a nodedev without autostart on purpose, then rebooting the host, then starting the VM. the code in init_host worked to make it so all I had to do was 'server start' (after sriov-manage -e, which I will test with systemd also) | |
| 23:50:20 | opendevreview | Merged openstack/nova master: Update compute rpc alias for caracal https://review.opendev.org/c/openstack/nova/+/912617 | |
| #openstack-nova - 2024-03-15 | |||
| 08:22:19 | bauzas | Uggla: looks to me we're having some problem with your cpu_shared_set series https://review.opendev.org/c/openstack/nova/+/877773 | |
| 08:22:55 | bauzas | elodilles: I approved a lot of placement changes this morning, so I'll provide a new revision for the placement RC1 release once all of them are merged | |
| 08:23:08 | Uggla | bauzas, looking at it | |
| 08:23:40 | bauzas | elodilles: for nova, we need to await a bit more, at least the prelude change is not yet approved https://review.opendev.org/c/openstack/nova/+/912973 + I'd like https://review.opendev.org/c/openstack/nova/+/899625/ to be merged | |
| 08:23:58 | bauzas | I know we're late :( | |
| 08:24:23 | elodilles | bauzas: ACK, thanks for the heads up | |
| 09:01:25 | elodilles | sean-k-mooney: LGTM, +2+W'd the patch | |
| 09:20:53 | Uggla | bauzas, found the issue this is _disconnect_volume which is called with 2 more parameters than expected destroy_secrets and force. What is funny that it is the case with the [backport] patch and not with the other. | |
| 09:22:33 | bauzas | cool to know | |
| 09:58:58 | opendevreview | Merged openstack/placement master: Add upgrade job from 2023.1 https://review.opendev.org/c/openstack/placement/+/907742 | |
| 09:59:00 | opendevreview | Merged openstack/placement master: reno: Update master for unmaintained/wallaby https://review.opendev.org/c/openstack/placement/+/911286 | |
| 09:59:01 | opendevreview | Merged openstack/placement master: reno: Update master for unmaintained/victoria https://review.opendev.org/c/openstack/placement/+/911276 | |
| 09:59:02 | opendevreview | Merged openstack/placement master: reno: Update master for unmaintained/xena https://review.opendev.org/c/openstack/placement/+/911296 | |
| 09:59:04 | bauzas | \o/ | |
| 10:00:02 | elodilles | ~o~ | |
| 10:00:36 | bauzas | one last to go, and then I'll update the placement RC1 patch | |
| 10:00:59 | elodilles | +1 | |
| 10:01:01 | elodilles | thx | |
| 10:01:17 | opendevreview | Merged openstack/placement master: Update python classifier in setup.cfg https://review.opendev.org/c/openstack/placement/+/904618 | |
| 10:01:29 | opendevreview | Merged openstack/nova master: Update python classifier in setup.cfg https://review.opendev.org/c/openstack/nova/+/901587 | |
| 10:01:57 | bauzas | perfect on time | |
| 10:03:24 | bauzas | https://releases.openstack.org/reference/using.html#using-new-release-command | |
| 10:03:27 | bauzas | cool, found ^ | |
| 10:04:14 | elodilles | well, to tell you the truth, sometimes it's easier to just edit the hash o:) | |
| 10:05:43 | elodilles | though you have to look for the correct hash, so new-release command can be easier :X | |
| 10:08:44 | bauzas | elodilles: I prefer the tooling in order to ensure that the git repo is all good | |
| 10:08:56 | bauzas | for example, github mirror doesn't have yet the last patch | |
| 10:09:10 | bauzas | anyway, updated | |
| 10:16:19 | elodilles | bauzas: true. thanks for the update o/ | |
| 10:32:06 | Uggla | bauzas, progressing it seems the do_cleanup flag is set with the [backport] patch and not with the other patch | |
| 10:54:55 | opendevreview | Merged openstack/nova stable/2023.1: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/911070 | |
| 10:55:41 | Uggla | bauzas, found the issue this is linked with power_management. I need to crosscheck with artom. | |
| 11:03:53 | opendevreview | Steven Blatzheim proposed openstack/nova stable/zed: Fix nova-metadata-api for ovn dhcp native networks https://review.opendev.org/c/openstack/nova/+/912755 | |
| 11:05:11 | stblatzheim | sean-k-mooney, elodilles: thanks for the reviews for the backport of the metadata bug. Here's the last cherrypick for zed: https://review.opendev.org/c/openstack/nova/+/912755 | |
| 11:17:39 | elodilles | stblatzheim: thanks too for the backports! | |
| 14:17:12 | opendevreview | OpenStack Release Bot proposed openstack/placement stable/2024.1: Update .gitreview for stable/2024.1 https://review.opendev.org/c/openstack/placement/+/913348 | |
| 14:17:12 | opendevreview | OpenStack Release Bot proposed openstack/placement stable/2024.1: Update TOX_CONSTRAINTS_FILE for stable/2024.1 https://review.opendev.org/c/openstack/placement/+/913349 | |
| 14:17:14 | opendevreview | OpenStack Release Bot proposed openstack/placement master: Update master for stable/2024.1 https://review.opendev.org/c/openstack/placement/+/913350 | |
| 14:21:36 | bauzas | Uggla: artom: okay, so please tell me if we need to get a new change before we provide the RC1 | |
| 14:21:53 | bauzas | elodilles: f*** the gate failed again for https://review.opendev.org/c/openstack/nova/+/899625 | |
| 14:29:18 | elodilles | :S | |
| 14:30:05 | elodilles | it would be good to have the nova release today, but it's not the end of the world if we can merge the release patch only Monday :/ | |
| 14:30:23 | elodilles | it's good that you signaled on the patch that we should wait | |
| 15:00:21 | dansmith | melwitt: do you know anything about why we're hitting this for BFV? https://zuul.opendev.org/t/openstack/build/05d3e04d9fac460c9e7011e0b40a7089/log/controller/logs/screen-n-cpu.txt#9547 | |
| 15:00:50 | dansmith | I know that's very old code, but it surely seems like we shouldn't be hitting that as a regular event, but it's all over the logs | |
| 15:28:53 | sean-k-mooney | ||
| 15:29:04 | sean-k-mooney | dansmith: is that form the nfs job | |
| 15:29:46 | sean-k-mooney | dansmith: i know melwitt was trying to fix the snapshot code at somepoint for nfs but i dont know what the current state of tha tis | |
| 15:31:29 | sean-k-mooney | it migh be related too https://bugs.launchpad.net/nova/+bug/1989514 | |
| 15:32:13 | sean-k-mooney | whic is adressed by https://review.opendev.org/c/openstack/cinder/+/857528 | |
| 16:33:09 | bauzas | dansmith: sean-k-mooney: please review the prelude patch when you can https://review.opendev.org/c/openstack/nova/+/912973 | |
| 16:33:33 | bauzas | elodilles: yet again it failed :( | |
| 16:58:58 | elodilles | :/ | |
| 17:24:20 | sean-k-mooney | bauzas: did you see my comments on the release highlights patch | |
| 17:44:54 | sean-k-mooney | bauzas: -1 on the prelude https://review.opendev.org/c/openstack/nova/+/912973 i have called out mostly the same issues that were in the highlight | |
| 17:45:22 | sean-k-mooney | i would prefer if we could fix both but i dont want to duplicate them in the prelude so at a minium i would ike to fix them there sicne that is not merged | |
| #openstack-nova - 2024-03-16 | |||
| 08:19:25 | opendevreview | Merged openstack/placement stable/2024.1: Update .gitreview for stable/2024.1 https://review.opendev.org/c/openstack/placement/+/913348 | |
| 08:32:34 | opendevreview | Merged openstack/placement stable/2024.1: Update TOX_CONSTRAINTS_FILE for stable/2024.1 https://review.opendev.org/c/openstack/placement/+/913349 | |
| #openstack-nova - 2024-03-17 | |||
| 14:01:34 | opendevreview | Takashi Natsume proposed openstack/nova master: Update contributor guide for 2024.2 Dalmatian https://review.opendev.org/c/openstack/nova/+/913481 | |
| #openstack-nova - 2024-03-18 | |||
| 10:01:05 | opendevreview | Sylvain Bauza proposed openstack/nova master: Add a Caracal prelude section https://review.opendev.org/c/openstack/nova/+/912973 | |
| 10:03:21 | opendevreview | Sylvain Bauza proposed openstack/nova master: Update contributor guide for 2024.2 Dalmatian https://review.opendev.org/c/openstack/nova/+/913481 | |
| 10:06:23 | bauzas | elodilles: the gate failed again for https://review.opendev.org/c/openstack/nova/+/899625 :( | |
| 10:06:49 | bauzas | elodilles: I rechecked it so I hope it will work now | |
| 10:25:59 | elodilles | ACK | |
| 12:31:31 | opendevreview | Merged openstack/nova master: libvirt: Cap with max_instances GPU types https://review.opendev.org/c/openstack/nova/+/899625 | |
| 13:49:28 | bauzas | sean-k-mooney: gibi: could you please look at https://review.opendev.org/c/openstack/nova/+/912973 ? | |
| 13:49:30 | bauzas | thanks | |
| 14:32:31 | artom | Uggla, I think after the weekend and sleeping on it, the least bad solution I could come up with, at least in the short term, is to add a separate helper that "filters out" that new cpu shared set field from dst_numa_info, and make my code use it | |
| 14:32:53 | artom | But medium term we need to get rid of the conditional do_cleanup RPC call | |